Am 03/08/2023 um 00:30 schrieb Yuri Weinstein:
> 1. bookworm distro build support
> We will not build bookworm until Debian bug
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1030129 is resolved
FYI, there's also a bug in Debian's GCC 12, which is used by default
in Debian Bookworm, that
First thanks for this patch, such polishing are important contributions!
Am 26/07/2023 um 17:36 schrieb Amin Vakil:
please add the cover letter text to the commit message so that the context is
actually conserved in git history.
Also, for a simple single patch a cover letter is rather overhead,
Am 27/07/2023 um 14:47 schrieb Lukas Wagner:
> Before, there was zero space between the the grid border line and the
> button, making it look a bit odd.
>
> The ListField form component is currently used in the
> 'User Tag Access' and 'Registered Tags' dialog windows in datacenter
> option view.
On 13/03/2023 13:56, Friedrich Weber wrote:
> Trying to regenerate a cloudinit drive as a non-root user via the API
> currently throws a Perl error, as reported in the forum [1]. This is
> due to a type mismatch in the permission check, where a string is
> passed but an array is expected.
>
> [1]
On 25/07/2023 13:00, Aaron Lauterer wrote:
> They are underdocumented and finding information is not that easy.
>
> Signed-off-by: Aaron Lauterer
> ---
> changes:
> * added reference anchor for easier linking
> * use link to manpages.debian.org instead of github
>
>
> the corosync-doc package
On 18/07/2023 11:10, Fabian Grünbichler wrote:
> and force upgrade of proxmox-kernel-helper with support for the new package
> names.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> we could rename pve-headers to pmg-headers and Provides/Replaces/Breaks
> pve-headers with a
On 18/07/2023 11:10, Fabian Grünbichler wrote:
> diff --git a/src/PMG/CLI/pmg7to8.pm b/src/PMG/CLI/pmg7to8.pm
> index 85e9f16..8cccde1 100644
> --- a/src/PMG/CLI/pmg7to8.pm
> +++ b/src/PMG/CLI/pmg7to8.pm
> @@ -193,7 +193,7 @@ sub check_pmg_packages {
> }
>
> # FIXME: better
On 25/07/2023 13:52, Friedrich Weber wrote:
> These two patches add some `htmlEncode` calls/renderers that
> had been missing to proxmox-widget-toolkit and pve-manager.
> Each patch can be individually applied.
>
>
>
> widget-toolkit:
>
> Friedrich Weber (1):
> ui: add some missing
On 24/07/2023 14:54, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> pvecm.adoc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied this one for now, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 24/07/2023 13:33, Friedrich Weber wrote:
> The new ciupgrade option was missing in $cloudinitoptions in
> PVE::API2::Qemu, so $check_vm_modify_config_perm defaulted to
> requiring root@pam for modifying the option. To fix this, add
> ciupgrade to $cloudinitoptions. This also fixes an issue
On 24/07/2023 12:14, Christoph Heiss wrote:
> pve-installer:
>
> Christoph Heiss (6):
> tui: simplify duplicate disk checking logic
> tui: deserialize boot type and disk blocksize from runtime env info
> tui: improve bootdisk dialog error handling
> tui: add RAID setup checks for
On 24/07/2023 14:54, Aaron Lauterer wrote:
> They are underdocumented and finding information is not that easy.
>
> Signed-off-by: Aaron Lauterer
> ---
>
> Found some info in the suse documentation [0] and the sourcecode [1].
Yes, like it was mentioned on the chat a bit ago, luckily we use
On 20/07/2023 16:32, Lukas Wagner wrote:
doesn't hurt to have a commit message describing that the underlying
rust code is just wired up and such a few general (or also gotify
specific) details; doesn't have to be multiple paragraphs, but a bit
of context can only help IME.
> Signed-off-by:
On 20/07/2023 16:31, Lukas Wagner wrote:
> # Overview
>
> The purpose of this patch series is to overhaul the existing mail
> notification infrastructure in Proxmox VE.
> The series replaces calls to 'sendmail' with calls to a
> new, configurable notification module. The module was designed to
>
On 19/07/2023 18:31, Christoph Heiss wrote:
> Add checks to ensure that:
> * It is actually has a hostname, not just a domain name
> * Properly check if the hostname is purely numeric, which was
>broken/different to how the GUI installer does it
>
> The custom error type also allows for
On 13/07/2023 11:49, Christoph Heiss wrote:
> This introduces the same checks when creating a RAID setup for ZFS and
> Btrfs as in the GUI installer.
>
> The main benefit is that the user now gets an error before the setup
> dialog can even be closed, instead of during the install process.
>
>
On 20/07/2023 16:48, Christoph Heiss wrote:
> Previously, if one tried to only update e.g. the bind password for an
> LDAP realm, it would fail with an rather unhelpful error message:
>
> # pveum realm modify ldap -password foo
> update auth server failed: no options specified
>
> The root
On 20/07/2023 10:09, Dominik Csapak wrote:
> On 6/26/23 14:41, Noel Ullreich wrote:
>> @@ -75,13 +93,15 @@ to the xref:sysboot_edit_kernel_cmdline[kernel
>> commandline].
>> .Kernel Modules
>> You have to make sure the following modules are loaded. This can be
>> achieved by
>> -adding
On 21/07/2023 11:39, Lukas Wagner wrote:
> This makes the header bar look a bit less cramped and ensures consistency
> if web interfaces are used side-by-side, e.g. on an ultrawide screen.>
> Signed-off-by: Lukas Wagner
> ---
>
> Notes:
> Disadvantage: We loose 8px of vertical space.
unsure about this, need to think a bit and as a few other things
are pending and some vacation too I'd say let's revisit in September
(i.e., ping me then please) if I didn't get around to it.
On 21/07/2023 11:39, Lukas Wagner wrote:
> Also adding a minWidth/maxWidth so that it doesn't become
On 21/07/2023 11:39, Lukas Wagner wrote:
> The shortcut is not really documented anywhere, so I think it make it a
> bit more obvious to the user.
style not: commit message should wrap text at 70 character columns.
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
On 19/07/2023 11:15, Fabian Grünbichler wrote:
> set_min/max_proto_version is recommended upstream nowadays, and it seems to be
> required for some reason if *only* TLS v1.3 is supposed to be enabled.
>
> querying via get_options gives us the union of
> - system-wide openssl defaults
> - our
On 20/07/2023 11:26, Maximiliano Sandoval wrote:
>> On 20.07.2023 10:29 CEST Fiona Ebner wrote:
>> Am 20.07.23 um 10:22 schrieb Lukas Wagner:
>>> Aaaah true, I didn't realize that. These non-obvious editable combo boxes
>>> have bugged me for a while now. Maybe I'll look into it to see if there
On 20/07/2023 11:45, Fiona Ebner wrote:
> Only unit 0 for IDE is supported with machine type q35. Currently,
> QEMU will fail startup with machine type q35 with an error like
>> Can't create IDE unit 1, bus supports only 1 units
> when ide1 or ide3 is configured.
>
> Make sure to keep backwards
On 20/07/2023 11:45, Fiona Ebner wrote:
> None of the configured test storages support the content type iso
> right now, just add it to cifs-store.
>
> Signed-off-by: Fiona Ebner
> ---
> test/cfg2cmd/ide.conf| 14
> test/cfg2cmd/ide.conf.cmd| 39
Am 18/07/2023 um 14:34 schrieb Dominik Csapak:
> * the backup edit window is rather tall at this point, and if we assume a
> minimum
> screen size of 1280x720 there is not quite enough space when you subtract
> the (typical) os bar and browser window decoration, maybe a 'notification'
> tab
Am 29/06/2023 um 13:34 schrieb Maximiliano Sandoval:
> When running `pct status VMID` the variable
> $last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
>
> For consistency with the qt command we do not print the cpu usage.
>
> Signed-off-by: Maximiliano Sandoval
> ---
>
>
Am 18/07/2023 um 14:00 schrieb Philipp Hufnagl:
> Sorry forgott to tag as v2
and also forgot to document the patch changelog like asked yesterday..
>
> On 7/18/23 13:58, Philipp Hufnagl wrote:
>> When called from the command line, it was not possible to calculate
>> cpu load because there
Am 10/07/2023 um 17:10 schrieb Max Carrara:
> Signed-off-by: Max Carrara
> ---
> pveum.adoc | 7 +++
> 1 file changed, 7 insertions(+)
>
>
The grouping is a bit odd for a few points, like SDN.Use and Mapping.Use are
roughly about the same thing, but one is at guest level the other at node
Am 15/06/2023 um 14:11 schrieb Dominik Csapak:
> Looks good from my side now, maybe someone else wants to chime in
> regarding the splitting of the setting in the gui (but IMHO that's good)
>
I'm torn about that, as IMO it would be a slightly better fit there,
but if we'd move it we'd also need
Am 14/07/2023 um 11:18 schrieb Philipp Hufnagl:
> There is an error in this example. The .conf has to be moved in the
> quemu-server folder of the new node for the migration to work.
>
> Signed-off-by: Philipp Hufnagl
> ---
> pmxcfs.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Am 14/07/2023 um 11:29 schrieb Christoph Heiss:
> .. in the same fashion as the GUI installer.
> See also proxinstall:create_intro_view() for reference.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-tui-installer/src/main.rs | 10 ++
> proxmox-tui-installer/src/setup.rs | 17
Am 15/06/2023 um 14:03 schrieb Noel Ullreich:
> When adding or editing a storage device in Datacenter->Storage in the
> web interface, the subdirectory depth can be set in the advanced menu.
>
> Signed-off-by: Noel Ullreich
> ---
> www/manager6/storage/Base.js | 11 +++
> 1 file
Am 17/07/2023 um 10:38 schrieb Fiona Ebner:
> Commit 114e5f2c ("pve7to8: sync over from stable-7 branch")
> accidentally got rid of the correct value 0 here and also the new TODO
> message to improve the situation. But the TODO is actually easy,
> because there already is the $upgraded variable.
Am 17/07/2023 um 14:34 schrieb Dominik Csapak:
> by converting the textfield into a textarea and validate the value
> line wise (if there is more than one line)
>
> also create a 'MultiFileButton' (mostly copied from extjs) that allows
> to select multiple files at once
>
> Signed-off-by:
Am 14/07/2023 um 15:34 schrieb Friedrich Weber:
> The 7->8 upgrade guide [1] mentions that cgroup v1 will be deprecated
> starting from PVE 9.0, so also mention this in the docs.
>
> [1] https://pve.proxmox.com/wiki/Upgrade_from_7_to_8#cgroup_V1_Deprecation
>
> Signed-off-by: Friedrich Weber
>
Am 17/07/2023 um 11:03 schrieb Dominik Csapak:
> On 7/13/23 12:09, Christoph Heiss wrote:
>> also: s/let/const/
>>
>
> hmm... we don't really have a style recommendation which to prefer.
> maybe we should improve our style guideline to have some more hints when to
> use const
> and when to use
where
started before PVE 8 cannot be directly live-migrated to the release
that includes that change; so we should rather only drop it if the
maintenance burden is high.
Signed-off-by: Thomas Lamprecht
---
still need to evaluate if this could be (made) fit for upstream (mainline
and/or ubuntu).
Am 13/07/2023 um 11:38 schrieb Philipp Hufnagl:
> Currently there is a bug that you only can install < 8gb when you NOT
> accept the warning. This is wrong. A user should have to accept the
> warning to install on small systems
>
> Signed-off-by: Philipp Hufnagl
> ---
> Proxmox/Sys/Block.pm | 2
Am 10/07/2023 um 15:26 schrieb Christoph Heiss:
> Pretty much as it says on the tin.
>
> pve-installer:
>
> Christoph Heiss (2):
> tui: fix clippy warnings
> tui: add "Deselect all" button to zfs/btrfs raid disk select
>
> proxmox-tui-installer/src/options.rs| 6 +--
>
Am 10/07/2023 um 11:22 schrieb Noel Ullreich:
> If the minimum requirements are not met, the TUI installer will create a
> popup notifying you that the install might not work and then exits the
> installer.
> While the GUI also creates such a popup, it will not exit the installer.
> This patch
Am 06/07/2023 um 14:27 schrieb Christoph Heiss:
> See the inline comment for what & why.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-tui-installer/src/views/mod.rs | 18 +-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
>
applied, thanks!
Am 03/07/2023 um 09:34 schrieb Christoph Heiss:
> Currently, the logic to check whether hardware-accelerated
> virtualization is supported or not by the host cpu is duplicated.
>
> This adds a `hvm_supported` flag to the runtime environment info,
> indicating whether it is supported or not, which
Am 06/07/2023 um 15:51 schrieb Fiona Ebner:
> which is passed by the backup job window when using selection mode
> 'all', would be converted to [""] and wrongly add an entry with VMID
> 0 because the item "" could not be found in the store.
>
> Reported in the community forum:
>
Am 03/07/2023 um 09:03 schrieb Fabian Grünbichler:
> these are backed up directly with proxmox-backup-client, and the invocation
> was
> lacking the key parameters.
>
> Signed-off-by: Fabian Grünbichler
> ---
> Should possibly be cherry-picked for stable-7 (no changes required)
>
>
Am 05/07/2023 um 20:02 schrieb Max Carrara:
> Displays a confirmation dialogue if the user didn't explicitly
> provide a valid ceph version via the `--version` flag and if
> stdout is connected to a tty.
>
> Signed-off-by: Max Carrara
> ---
>
> v2 of this little patch incorporates the given
Am 03/07/2023 um 14:15 schrieb Noel Ullreich:
> Since some languages translate byte units like 'GiB' or write them in their
> own script, this patch wraps units in the `gettext` function.
>
> While most occurrences of byte strings can be translated within the
> `format_size` function in
Am 04/07/2023 um 15:53 schrieb Dominik Csapak:
> like we do for qemu guest, by multiplying cpu usage by 100
>
> Signed-off-by: Dominik Csapak
> ---
> lib/bloc/pve_lxc_overview_bloc.dart | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
applied, thanks!
> +
> + Future>
Am 04/07/2023 um 15:53 schrieb Dominik Csapak:
> if the user was logged in in the past, but that ticket expired, we still
> gave the expired ticket to the login form which tried to login with
> that, producing a login error the first time the user pressed login.
>
> we already get the correct
Am 04/07/2023 um 16:08 schrieb Philipp Hufnagl:
> Signed-off-by: Philipp Hufnagl
> ---
> pvesm.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
sorry for the delay, a few comments inline.
Am 22/02/2023 um 15:23 schrieb Max Carrara:
> diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
> index afcc67e0..eaf7918e 100755
> --- a/PVE/CLI/pveceph.pm
> +++ b/PVE/CLI/pveceph.pm
> @@ -157,6 +157,19 @@ __PACKAGE__->register_method ({
> }
Am 03/07/2023 um 15:37 schrieb Dominik Csapak:
> by converting the textfield into a textarea and validate the value
> line wise (if there is more than one line)
>
I hit reply to quick and only to you directly, sorry, so here my initial
question and
your quick reply to it:
Am 03/07/2023 um
Am 03/07/2023 um 09:34 schrieb Aaron Lauterer:
> While the '--linkX' paramter works with one dash too, let's use two so
> we are in line with the man page and other uses of named parameters.
>
> Since we are at it, prepend the command with '#' as we do throughout
> this section.
>
>
Am 03/07/2023 um 08:39 schrieb Dominik Csapak:
> when installing AnyEvent::AIO (by the package libanyevent-aio-perl), the
> worker forks of our daemons using AnyEvent would consume 100% cpu cycles
> while trying to do an epoll_wait which no one read from. It was not
> really clear which part of
Am 03/07/2023 um 09:18 schrieb Fabian Grünbichler:
> openssl as packaged in Debian bookworm now ships a compat symlink for the
> "combined" CA certificates file (CAfile) as managed by update-ca-certificates.
> this symlink is in addition to the CApath one that has been around for a file.
> the new
Am 28/06/2023 um 11:39 schrieb Alexandre Derumier:
> stock debian or some hosting company like ovh through cloudinit at each boot,
> add 127.0.1.1 in /etc/hosts.
>
> fix:
> https://forum.proxmox.com/threads/proxmox-7-to-8-upgrade-problem-ovh.129678/
>
Am 29/06/2023 um 16:36 schrieb Fiona Ebner:
> Am 29.06.23 um 16:26 schrieb Thomas Lamprecht:
>> Am 29/06/2023 um 15:59 schrieb Fiona Ebner:
>>> Useful for the updatecerts call triggered via the ExecStartPre hook
>>> for pveproxy.service.
>>>
>>>
Am 29/06/2023 um 15:59 schrieb Fiona Ebner:
> Useful for the updatecerts call triggered via the ExecStartPre hook
> for pveproxy.service.
>
> When starting a node that's part of a cluster, there is a time window
> between the start of pve-cluster.service and when quorum is reached
> (from the
Am 29/06/2023 um 12:30 schrieb Fabian Grünbichler:
> else mirroring bookworm-security will skip *all* components..
>
> Signed-off-by: Fabian Grünbichler
> ---
> Reported on the forum:
> https://forum.proxmox.com/threads/proxmox-offline-mirror-released.115219/page-3#post-568763
>
> and fix
Am 23/06/2023 um 08:13 schrieb Hannes Laimer:
> `proxmox-boot-tool kernel remove --help`, or any version agrument
> that started with a '-', lead to the grep usage message being written
> into /etc/kernel/proxmox-boot-manual-kernels. The problem was `grep`
> interpreted the kernel version agrument
Am 28/06/2023 um 15:23 schrieb Fiona Ebner:
> The call was moved by 84c3ab0 ("pve-cluster.service: move pvecm call
> to pveproxy.service") to pveproxy.service's ExecStartPre.
>
> Signed-off-by: Fiona Ebner
> ---
> src/PVE/CLI/pvecm.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Am 28/06/2023 um 09:47 schrieb DERUMIER, Alexandre:
>> Let's rather improve pmxcfs logic for getting the non-local IP
>> configured on
>> a node via getaddrinfo with the ALL flag and filtering out local
>> IPs..
> oh, I didn't known than getaddrinfo could return multiple ips.
yes, check the
Am 28/06/2023 um 08:06 schrieb Alexandre Derumier:
> stock debian or some hosting company like ovh through cloudinit at each boot,
> add 127.0.1.1 in /etc/hosts.
Yeah, tools just messing with /etc/hosts et al. is irritating..
>
> This is breaking pve-cluster start.
>
> fix:
>
Am 27/06/2023 um 16:15 schrieb Stefan Sterz:
> previously the disk selection was reset if the advanced options
> dialogue was re-opened. this commit adapts the behavior to restore
> the previous selection.
>
> Signed-off-by: Stefan Sterz
> ---
> changes since v2 (thanks @Maximiliano Sandoval):
>
Am 27/06/2023 um 14:40 schrieb Noel Ullreich:
> Commandline/command line/command-line where being used interchangably,
> which is not correct
> (see:
> https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/command-line).
> use command-line when it is an adjective (e.g.
Am 27/06/2023 um 14:40 schrieb Noel Ullreich:
> To be consistent, replaced all synonyms of USB flash drive (e.g. thumb
> drive, drive, stick)
>
> Signed-off-by: Noel Ullreich
> ---
> docs/backup-client.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, albeit spotted the
Am 23/06/2023 um 11:02 schrieb Alexandre Derumier:
> some nic like mellanox connectx or intel i40e don't work well vlan-aware
> bridge
> because they are limited in number of vlan filtering in hardware
>
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/INotify.pm | 2 ++
> 1 file changed, 2
Am 26/06/2023 um 11:42 schrieb Alexandre Derumier:
> upstream: https://github.com/CumulusNetworks/ifupdown2/pull/267
>
> if a script in /etc/network/ifup.d/ is segfaulting,
>
> ifup is crashing with
>
> info: executing2 /etc/network/if-up.d/postfix
> debug: lo: up : running script
Am 23/06/2023 um 11:02 schrieb Alexandre Derumier:
> to fix nic like mellanox && vlan-aware-bridge
>
> upstream pull request:
> https://github.com/CumulusNetworks/ifupdown2/pull/266
>
> Signed-off-by: Alexandre Derumier
> ---
> debian/patches/series | 1 +
>
Am 23/06/2023 um 11:02 schrieb Alexandre Derumier:
> some users need to disable some buggy features for their nic,
> install ethtool by default
>
> Signed-off-by: Alexandre Derumier
> ---
> debian/control | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
Am 26/06/2023 um 12:58 schrieb Fiona Ebner:
> by not having -W eat the next argument when $scfg->{domain} is defined
> but empty.
>
> As reported in the community forum [0], this could lead to issues
> adding a storage in the UI.
>
> [0]: https://forum.proxmox.com/threads/44983/post-566842
>
>
Am 23/06/2023 um 09:08 schrieb Dominik Csapak:
> but fallback to 'eslint' otherwise
>
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Dominik Csapak
> ---
> defines.mk | 1 +
> www/Makefile | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>
Am 23/06/2023 um 09:08 schrieb Dominik Csapak:
> but fallback to 'eslint' otherwise
>
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Dominik Csapak
> ---
> src/Makefile | 6 +++---
> src/defines.mk | 1 +
> 2 files changed, 4 insertions(+), 3 deletions
Am 23/06/2023 um 09:08 schrieb Dominik Csapak:
> but fallback to 'eslint' otherwise
>
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Dominik Csapak
> ---
> defines.mk| 2 ++
> www/manager6/Makefile | 4 ++--
> 2 files changed, 4 insertions(+), 2 de
Am 23/06/2023 um 13:54 schrieb Fiona Ebner:
> IMHO, the average of the CPU usage across the whole uptime is not what
> most people would expect this value to be.
Yeah, this is really not that useful in most cases.
> Maybe we should just remove the line from the output like in qm (technically
> a
Am 23/06/2023 um 19:19 schrieb Stoiko Ivanov:
> The refactoring of the systemd-preset handling inadvertendly changed
> the preset for Fedora >= 37 to disabled
>
> Reported in our community forum:
> https://forum.proxmox.com/threads/.129395/
>
> Tested with a Fedora 38 container on PVE 8.0
>
>
Am 23/06/2023 um 19:01 schrieb Stoiko Ivanov:
> Reported-by: Daniela Häsler
> Signed-off-by: Stoiko Ivanov
> ---
> pve-faq.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
Am 23/06/2023 um 15:28 schrieb Christian Ebner:
> ... and warn if at least one is present.
>
> Signed-off-by: Christian Ebner
> ---
> PVE/CLI/pve7to8.pm | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
> index
Hi,
Am 23/06/2023 um 00:33 schrieb Wolf Noble:
> Im aware of the existing api face, however what exists now requires
> authentication, and seems a little heavy for my intended use:
>
> (hey, you alive? yes? cool! i’ll check again in a couple seconds)
>
> Ideally, there’d be a super
Am 22/06/2023 um 15:57 schrieb Stoiko Ivanov:
> The convoluted calculation logic in case the disks is 8GB leads to
> datasize becoming 16EiB further down:
> * after calculating and removing the rootsize from $rest, $rest becomes
> smaller than $space (which should be the minimal non-used space
Am 22/06/2023 um 16:18 schrieb Fiona Ebner:
> First step towards fixing an issue reported in the community forum [0]
> where using 250.00 hdsize, 250 maxroot and 0 minfree would fail.
>
> Turns out two extents would be missing because of lvcreate implicitly
> rounding up, one of them for the
Am 22/06/2023 um 15:08 schrieb Maximiliano Sandoval:
> Otherwise the user only has 5 seconds to see the error message before
> the machine reboots.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> proxmox-tui-installer/src/main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Am 20/06/2023 um 17:00 schrieb Fiona Ebner:
> which combines the stop+wait logic previously present at the single
> call site of wait_for_unit_removed() in QemuServer.pm. It also does a
> reset-failed call first, to ensure a unit in a failed state is also
> cleaned up properly.
>
> Signed-off-by:
Am 21/06/2023 um 16:48 schrieb Dominik Csapak:
> except the password dialog, since the user must provide input
>
> to do that, we have to set the focus index on all relevant views
>
> Signed-off-by: Dominik Csapak
> ---
>
> not sure if this is the correct approach, also the extra parameter
Am 22/06/2023 um 14:15 schrieb Dominik Csapak:
> under certain circumstances, the migrate button stays disabled, even
> when a valid target node was selected:
> * the first node that gets autoselected (most likely the second)
> is not a valid migration target
> * the user changes to a migration
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> If lots of disks are present and the available screen size is rather
> small, it might be impossible for users to properly set all disks as
> they want.
>
> Fix it by making the view scrollable.
>
what I forgot to write: It's much better than
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> This just causes weird layouts; such that labels and inputs do not line
> up anymore.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-tui-installer/src/views/mod.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied,
Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> If lots of disks are present and the available screen size is rather
> small, it might be impossible for users to properly set all disks as
> they want.
>
> Fix it by making the view scrollable.
>
> Signed-off-by: Christoph Heiss
> ---
>
Am 22/06/2023 um 11:20 schrieb Stefan Sterz:
> previously the tui used `u64` internally to represent the disk size.
> since the perl-based installer expects GiB as floats and that is also
> what is displayed in the tui that meant a lot of converting back and
> forth. it also lead to an error where
Am 22/06/2023 um 08:56 schrieb Stefan Sterz:
> On 21.06.23 16:36, Thomas Lamprecht wrote:
>> Am 21/06/2023 um 16:00 schrieb Stefan Sterz:
>>> previously the installer correctly divided the value when using them
>>> for the `FloatEditView`, but forgot to multiply the valu
Am 21/06/2023 um 19:35 schrieb Stoiko Ivanov:
> since the package won't get installed for systems upgraded from 7 to 8
> we warn users who need systemd-boot - to be able to initialize new
> ESPs - that they need to install it
>
> The check for package installation is based on existance of the
>
Am 21/06/2023 um 18:19 schrieb Fiona Ebner:
> Signed-off-by: Fiona Ebner
> ---
>
> Applies to the master branch. It's enough the have the reminder here,
> stable would even need a different patch because of changed context.
>
> PVE/CLI/pve7to8.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
Am 21/06/2023 um 18:19 schrieb Fiona Ebner:
> Just like 3b776617 ("pve6to7: enable noout before upgrade") last time,
> it should be enabled in the stable branch to ensure users see the
> warning before upgrade.
>
> Signed-off-by: Fiona Ebner
> ---
>
> Intended only for the stable-7 branch.
>
>
Hi,
Am 21/06/2023 um 17:56 schrieb DERUMIER, Alexandre:
> I just see all the patches for the new installer (don't have tested it
> yet).
>
> Any plan to add support for preseed file like debian for automatic
> install ?
>
Yes, for the mid/long term we'd definitively like to provide some
Am 21/06/2023 um 17:02 schrieb Fiona Ebner:
> It's required in the schema for notes-template and protected, but when
> parsing vzdump.conf, it shouldn't matter whether the storage parameter
> is set or not.
>
> The warning is ugly and users might interpret it as something that
> needs to be acted
Am 21/06/2023 um 17:02 schrieb Fiona Ebner:
> It just talks about the default behavior since PVE 7. It's rather
> confusing to mention this, because the behavior doesn't change anymore
> in PVE 8.
>
> Signed-off-by: Fiona Ebner
> ---
>
> Intended for both master and stable-7.
>
>
Am 21/06/2023 um 16:16 schrieb Stefan Hanreich:
> * fix detection of ipv6 addresses
> * change input for CIDR to allow integers up until 128
>
> Signed-off-by: Stefan Hanreich
> ---
> proxmox-tui-installer/src/utils.rs | 2 +-
> proxmox-tui-installer/src/views/mod.rs | 6 +++---
> 2 files
Am 21/06/2023 um 16:32 schrieb Stoiko Ivanov:
> This patchset addresses the change of shipping systemd-boot as separate
> binary packge introduced with Debian Bookworm.
>
> The patches are mostly cosmetic in nature - since they silence warnings,
> which look scary, but don't hurt functionality.
>
Am 21/06/2023 um 16:00 schrieb Stefan Sterz:
> previously the installer correctly divided the value when using them
> for the `FloatEditView`, but forgot to multiply the value again when
> retrieving it after editing. this commit fixes that
>
> Signed-off-by: Stefan Sterz
> ---
> tested this
Am 21/06/2023 um 14:30 schrieb Dominik Csapak:
> regex copied from perl gui installer
>
> Signed-off-by: Dominik Csapak
> ---
> this needs librust-regex-dev as build-dependency
> proxmox-tui-installer/Cargo.toml | 1 +
> proxmox-tui-installer/src/main.rs | 8
> 2 files changed, 9
701 - 800 of 9264 matches
Mail list logo
