Re: svn commit: r1845086 [2/2] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/webapp/accounting/WEB-INF/ content/webapp/content/WEB-INF/ order/webapp/ordermgr/WEB-INF/ party/webapp/partymg

2018-10-29 Thread Gil Portenseigne
Hello Suraj, Is there a reason to keep empty path for service event ? Regards Gil Le lundi 29 oct. 2018 à 08:14:55 (-), sur...@apache.org a écrit : > Modified: > ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml > URL: >

Re: Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler

2018-10-26 Thread Gil Portenseigne
Hello, +1 to follow the 120char guideline for any commit that the purpose it not to refactor line length :). Gil Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit : > Hello Jacques, > > Jacques Le Roux writes: > > > Yes you are right, the whole file should be reformatted.

Re: Groovy DSL runService Exception Management ?

2018-10-23 Thread Gil Portenseigne
the service engine itself. In that way, there won't be needed systematic test against service return in groovy and that is a good thing. Gil Le dimanche 21 oct. 2018 à 08:02:35 (+0200), Jacopo Cappellato a écrit : > On Thu, Oct 18, 2018 at 10:45 AM Gil Portenseigne < > gil.portensei...@nereide.

Groovy DSL runService Exception Management ?

2018-10-18 Thread Gil Portenseigne
Hello ! While we are working on Groovy migration at Nereide, we figured out that using ‘run service’ DSL method instead of returning the errorMap, a ‘ExecutionServiceException’ is thrown : if (ServiceUtil.isError(result)) { throw new

Re: svn commit: r1843780 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src: main/java/org/apache/ofbiz/entity/condition/ test/java/org/apache/ofbiz/entity/

2018-10-15 Thread Gil Portenseigne
Hello, I think that is an incompatibiliy with Windows newline char (\n vs \r\n). Thanks for the feedback, I'll improve that soon. Gil Le lundi 15 oct. 2018 à 18:09:30 (+0200), Jacques Le Roux a écrit : > Hi Gil, > > Not yet sure it's only me (Windows) but I get this locally > >

[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL

2018-10-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649542#comment-16649542 ] Gil Portenseigne commented on OFBIZ-9984: - I just add a reworked patch with a new test

[jira] [Updated] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL

2018-10-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-9984: Attachment: OFBIZ-9984.patch > Convert OrderServices.xml mini-lang to groovy

[jira] [Updated] (OFBIZ-10604) Isolate EntityOperator and EntityConditionValue from EntityConditionBase

2018-10-13 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10604: - Description: While working on OFBIZ-10593 with [~mthl] we discovered a design issue

[jira] [Created] (OFBIZ-10604) Isolate EntityOperator and EntityConditionValue from EntityConditionBase

2018-10-13 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10604: Summary: Isolate EntityOperator and EntityConditionValue from EntityConditionBase Key: OFBIZ-10604 URL: https://issues.apache.org/jira/browse/OFBIZ-10604

[jira] [Closed] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-13 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10593. > ‘EntityConditionVisitor’ is a confused visitor patt

[jira] [Assigned] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-10593: Assignee: Gil Portenseigne (was: Mathieu Lirzin) > ‘EntityConditionVisi

[jira] [Commented] (OFBIZ-10593) ‘EntityConditionVisitor’ is a confused visitor pattern

2018-10-12 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647939#comment-16647939 ] Gil Portenseigne commented on OFBIZ-10593: -- Hello [~mthl], i did review your final patch

Re: Unable to login at demo-stable instance

2018-10-12 Thread Gil Portenseigne
Hello, The admin password was changed in demo by someone, there is nothing to be done to prevent that. A simple trick is to use flexadmin user to get access and fix admin userlogin setup. I just did it. Please rather use user ML for such questions Regards, Gil Le vendredi 12 oct. 2018 à

[jira] [Closed] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-27 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10515. > Impersonation of userLogin feat

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-24 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625535#comment-16625535 ] Gil Portenseigne commented on OFBIZ-10515: -- Thanks Taher, i like working with you too :), doing

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-24 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625488#comment-16625488 ] Gil Portenseigne commented on OFBIZ-10515: -- [~taher] thanks for this basics reminder, My eyes

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-24 Thread Gil Portenseigne
Same tests, same results :) (besides GPG) I tested it a bit although, all fine for me so +1 Thanks Jacopo, Gil Le samedi 22 sept. 2018 à 14:27:54 (+0200), Michael Brohl a écrit : > +1 > > Everything is ok: > > $ ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.05.zip > sha check of

Re: Move SecurityPermission, SecurityGroup and SecurityGroupPermission Data to seed data files

2018-09-21 Thread Gil Portenseigne
+1 Le vendredi 21 sept. 2018 à 11:19:39 (+0530), Arun Patidar a écrit : > Deepak, > > IMO, 'SecurityPermission' data should always be part of seed data. but > SecurityGroup and SecurityGroupPermission like a sample data so should be > part of demo data. > > > > > Kind Regards, > > Arun

[jira] [Commented] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622152#comment-16622152 ] Gil Portenseigne commented on OFBIZ-10575: -- Those two exemple were in my todo list :), i agree

[jira] [Updated] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10576: - Labels: deprecation (was: ) > Deprecate shoppingCart.makeItemShipGroupAndAs

[jira] [Closed] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10576. > Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean > par

[jira] [Created] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10576: Summary: Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter Key: OFBIZ-10576 URL: https://issues.apache.org/jira/browse/OFBIZ-10576

[jira] [Updated] (OFBIZ-10576) Deprecate shoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean parameter

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10576: - Attachment: OFBIZ-10576.patch > Deprecate shoppingCart.makeItemShipGroupAndAs

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621907#comment-16621907 ] Gil Portenseigne commented on OFBIZ-10515: -- Hey Jacques, no it was just a mistake from me

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-20 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621696#comment-16621696 ] Gil Portenseigne commented on OFBIZ-10515: -- Hi Jacques, thanks for the remarks. - "no ext

Re: svn commit: r1840659 - in /ofbiz/ofbiz-framework/trunk/applications: order/template/order/OrderShippingInfo.ftl product/minilang/shipment/shipment/ShipmentServices.xml product/servicedef/services_

2018-09-17 Thread Gil Portenseigne
Hello, There is an old wiki page around entity deprecation (https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-DeprecatedEntities) But I couldn't find any about service or others. I agree with the need of deprecation process for

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-17 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618074#comment-16618074 ] Gil Portenseigne commented on OFBIZ-10515: -- Hello [~taher] i did rework ‘userImpersonate

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-17 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614780#comment-16614780 ] Gil Portenseigne commented on OFBIZ-10566: -- {quote} What about ecommerce, maybe also

[jira] [Closed] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10566. > Update missing entries in GDSL descriptors and cleanup findOne to use > Entit

[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-13 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614090#comment-16614090 ] Gil Portenseigne commented on OFBIZ-10566: -- Here is a patch providing the deprecation

[jira] [Updated] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-13 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10566: - Attachment: OFBIZ-10566.patch > Update missing entries in GDSL descriptors and clea

[jira] [Created] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-13 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10566: Summary: Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead. Key: OFBIZ-10566 URL: https://issues.apache.org/jira/browse/OFBIZ

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-12 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612002#comment-16612002 ] Gil Portenseigne commented on OFBIZ-10515: -- Hello [~taher], Thanks for the review

[jira] [Updated] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-7338: Attachment: (was: tidyUpLabels.sh) > Manufacturing : Arrange UI Labels in alphabe

[jira] [Commented] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610769#comment-16610769 ] Gil Portenseigne commented on OFBIZ-7338: - Ah, glad to see that, ignore my old script though

[jira] [Comment Edited] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610706#comment-16610706 ] Gil Portenseigne edited comment on OFBIZ-7338 at 9/11/18 2:38 PM: -- Hello

[jira] [Comment Edited] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610706#comment-16610706 ] Gil Portenseigne edited comment on OFBIZ-7338 at 9/11/18 2:33 PM: -- Hello

[jira] [Commented] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610706#comment-16610706 ] Gil Portenseigne commented on OFBIZ-7338: - Hello [~suraj.khurana], i can give you a script that i

[jira] [Updated] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-7338: Attachment: tidyUpLabels.sh > Manufacturing : Arrange UI Labels in alphabetic accord

Re: INSTALLING OFBIZ V16.11.04

2018-09-11 Thread Gil Portenseigne
Hello, It seems you miss some data in your database. Be sure to load demo data with : ./gradlew loadDefault Gil > > Hi Michael > > I managed to verify the downloaded file using SHA512, it is ok. Followed > remaining steps in README.md and got to 91% after entering command sudo > ./gradlew

[jira] [Commented] (OFBIZ-10372) Calculate estimated shipment delivery time

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610291#comment-16610291 ] Gil Portenseigne commented on OFBIZ-10372: -- Hello [~soledad], i'm doing a review, i uploaded

[jira] [Updated] (OFBIZ-10372) Calculate estimated shipment delivery time

2018-09-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10372: - Attachment: OFBIZ-10372-plugins.patch > Calculate estimated shipment delivery t

Re: 答复: New Impersonate Feature : OFBIZ-10515

2018-09-10 Thread Gil Portenseigne
r > >> > >> On Mon, Aug 20, 2018 at 12:04 PM, Taher Alkhateeb < > >> slidingfilame...@gmail.com> wrote: > >> > >> I don't have a strong opinion on this, and I am open. My personal > >>> preference is pehaps to just 'login as' instead of i

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: (was: OFBIZ-10515.patch) > Impersonation of userLogin feat

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609727#comment-16609727 ] Gil Portenseigne commented on OFBIZ-10515: -- New patch with documentation integration

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

Re: Impersonation and Documentation

2018-09-10 Thread Gil Portenseigne
), Jacques Le Roux a écrit : > Makes sense, thanks guys, > > Redundancy is indeed not always bad. But you will have to maintain the > consistency between the images, maybe a tool could be built and used? > > Jacques > > > Le 10/09/2018 à 09:39, Gil Portenseigne a

Re: Impersonation and Documentation

2018-09-10 Thread Gil Portenseigne
Yes that was my intention :), i should have said it so ! Le lundi 10 sept. 2018 à 10:28:24 (+0300), Taher Alkhateeb a écrit : > perhaps you can place a copy of whatever you want in > $OFBIZ_HOME/docs/asciidoc/images/ > On Mon, Sep 10, 2018 at 10:22 AM Gil Portenseigne > wrote: &

Re: Impersonation and Documentation

2018-09-10 Thread Gil Portenseigne
:14 (+0200), Jacques Le Roux a écrit : > Le 07/09/2018 à 16:19, Gil Portenseigne a écrit : > > On another hand, i wanted to reference an icon within common-theme, i > > set the property : > > :imagesdir: ../../../../../../themes/common-theme/webapp/images/img/ > > >

Re: Impersonation and Documentation

2018-09-10 Thread Gil Portenseigne
on in the main documentation document > - Create your document in src/docs/asciidoc > - Provide the contents > - Test using ./gradlew generateOfbizDocumentation > On Fri, Sep 7, 2018 at 5:20 PM Gil Portenseigne > wrote: > > > > Hello, > > > > I just published a n

Re: Should we keep the multi-tenants feature in OFBiz?

2018-09-07 Thread Gil Portenseigne
Hello, Very nice analysis, I got the same feeling about multi-tenancy, and prefer using separate instances encapsulated within VM. Gil Le mardi 04 sept. 2018 à 19:12:20 (+0300), Taher Alkhateeb a écrit : > The question is: is it worth keeping it? To answer this question, > perhaps we need to

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607178#comment-16607178 ] Gil Portenseigne commented on OFBIZ-10515: -- This new patch provide more configuration controls

Impersonation and Documentation

2018-09-07 Thread Gil Portenseigne
Hello, I just published a new version of impersonation feature (OFBIZ-10515), and i wrote down some asciidoc documentation. I got some questions to documentation team to get the best practice around it. I write down a documentation within:

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

[jira] [Commented] (OFBIZ-499) Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods

2018-09-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606858#comment-16606858 ] Gil Portenseigne commented on OFBIZ-499: [~pfm.smits] agree that we should close ! > Implem

Re: svn commit: r1839763 - in /ofbiz/ofbiz-framework/trunk/framework/entity: src/main/java/org/apache/ofbiz/entity/test/EntityUtilTestSuite.java src/main/java/org/apache/ofbiz/entity/util/EntityUtil.j

2018-09-03 Thread Gil Portenseigne
Hello Taher ! I'll be a little bit more verbose in commit log next times :), and for the tStream, it was a miss, i'll fix it soon. Thanks as always for your review ! Gil Le samedi 01 sept. 2018 à 21:24:56 (+0300), Taher Alkhateeb a écrit : > Hi Gil, > > Awesome work :) it took me a while to

[jira] [Closed] (OFBIZ-10537) Refactor EntityUtil findBy methods using Stream API

2018-08-31 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10537. > Refactor EntityUtil findBy methods using Stream

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-31 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598785#comment-16598785 ] Gil Portenseigne commented on OFBIZ-10515: -- For information, we currently are implementing

[jira] [Commented] (OFBIZ-10537) Refactor EntityUtil findBy methods using Stream API

2018-08-31 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598746#comment-16598746 ] Gil Portenseigne commented on OFBIZ-10537: -- Hello Jacques, Thanks for your feedback. Yes

[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-28 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594686#comment-16594686 ] Gil Portenseigne commented on OFBIZ-7598: - Hello [~suraj.khurana], There remains a Boolean

[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-28 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-7598: Attachment: OFBIZ-7598-final-proposal.patch > Empty header row should not render if l

[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-24 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591266#comment-16591266 ] Gil Portenseigne commented on OFBIZ-7598: - +1 Jacques, to revert and commit, moreover

[jira] [Commented] (OFBIZ-10537) Refactor EntityUtil findBy methods using Stream API

2018-08-23 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590303#comment-16590303 ] Gil Portenseigne commented on OFBIZ-10537: -- The first patch add integration tests

[jira] [Updated] (OFBIZ-10537) Refactor EntityUtil findBy methods using Stream API

2018-08-23 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10537: - Attachment: OFBIZ-10537-2_refactor_streams.patch OFBIZ-10537

[jira] [Created] (OFBIZ-10537) Refactor EntityUtil findBy methods using Stream API

2018-08-23 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10537: Summary: Refactor EntityUtil findBy methods using Stream API Key: OFBIZ-10537 URL: https://issues.apache.org/jira/browse/OFBIZ-10537 Project: OFBiz

Re: Fwd: OFBiz Sanity Test Automation

2018-08-23 Thread Gil Portenseigne
Hello, I tend to have the same reaction as Nicolas due to a bad personal experience with selenium (unstable, hard to maintain...), but since it may have evolved, Taher's remark make perfect sense. Thanks for the proposal Sanjay ! Gil Le jeudi 23 août 2018 à 15:24:01 (+0300), Taher Alkhateeb a

[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-23 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590157#comment-16590157 ] Gil Portenseigne commented on OFBIZ-7598: - Reading your patch, why using {{Boolean

[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-22 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589145#comment-16589145 ] Gil Portenseigne commented on OFBIZ-7598: - Hello [~suraj.khurana], For the ‘empty-form-data

[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-21 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587380#comment-16587380 ] Gil Portenseigne commented on OFBIZ-7598: - Hello [~suraj.khurana], i will try to explain how i

Re: [PROPOSITION] Demos: replace old by trunk framework only

2018-08-21 Thread Gil Portenseigne
I've not analysed the issue in details, but an in-middle solution should be to remove the problematic links from trunk, and fill a new Jira for implementing it in the better way :). Gil Le mardi 21 août 2018 à 10:10:03 (+0200), Jacques Le Roux a écrit : > OK, that your and Michael's opinions. So

Re: OFBiz Contributors Best Practices was [Re: svn commit: r1838320 ...]

2018-08-20 Thread Gil Portenseigne
Hello Jacques, All, I do not agree about creating a new jira, since the improvement has design flaw (i will add a comment into the Jira introducing it) in my opinion leading to breaking thread safety in ModelForm.java. And Taking into consideration Michael preference for reverting, the best way

Re: 答复: New Impersonate Feature : OFBIZ-10515

2018-08-20 Thread Gil Portenseigne
;, committer > > Apache OFBiz <https://ofbiz.apache.org>, contributor since 2008 > > Apache Steve <https://steve.apache.org>, committer > > > > On Mon, Aug 13, 2018 at 6:19 AM, Zhang Wei wrote: > > > > > +1 > > > ___

Re: 答复: New Impersonate Feature : OFBIZ-10515

2018-08-20 Thread Gil Portenseigne
Hello ! I am back and glad to have so many feedback :) Since Nicolas already answered, i'll add some precisions and opinions inline. Le mardi 14 août 2018 à 18:17:14 (+0200), Nicolas Malin a écrit : > Hello, > On 13/08/2018 10:09, Pierre Smits wrote: > > Impressive... > > [...] > The feature

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-11 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577279#comment-16577279 ] Gil Portenseigne commented on OFBIZ-10515: -- Hello [~mthl], thanks for the review ! I guess

New Impersonate Feature : OFBIZ-10515

2018-08-10 Thread Gil Portenseigne
Hello ! I would like to introduce to you a new feature, i already talked about some time ago (last year?). We needed it for one of our customer, that is using it for some time and is very happy with it (like we are). Indeed this impersonation feature comes to be very useful when we need to

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576774#comment-16576774 ] Gil Portenseigne commented on OFBIZ-10515: -- Here is a patch providing the impersonate feature

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: ImpersonationWidget.png > Impersonation of userLogin feat

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: impersonateButton.png > Impersonation of userLogin feat

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: impersonate-ico.png > Impersonation of userLogin feat

[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feat

[jira] [Created] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-10 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10515: Summary: Impersonation of userLogin feature Key: OFBIZ-10515 URL: https://issues.apache.org/jira/browse/OFBIZ-10515 Project: OFBiz Issue Type

[jira] [Resolved] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10511. -- Resolution: Fixed Fix Version/s: Upcoming Branch 17.12.01

[jira] [Closed] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10511. > Use of layered-modal with parameter does not w

[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: (was: OFBIZ-10511-02-fixProposal.patch) > Use of layered-mo

[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576185#comment-16576185 ] Gil Portenseigne commented on OFBIZ-10511: -- It works, Thanks [~deepak.dixit], that is far more

[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576163#comment-16576163 ] Gil Portenseigne commented on OFBIZ-10511: -- Thanks [~deepak.dixit], i'm on it ! >

[jira] [Commented] (OFBIZ-7482) Deposit price support

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576014#comment-16576014 ] Gil Portenseigne commented on OFBIZ-7482: - Hello [~suraj.khurana], I've no objections

[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575960#comment-16575960 ] Gil Portenseigne commented on OFBIZ-10511: -- This issue has been introduced in OFBIZ-9852,  i

[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575952#comment-16575952 ] Gil Portenseigne commented on OFBIZ-10511: -- To reproduce apply reproduceBug patch onto Example

[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: OFBIZ-10511-02-fixProposal.patch > Use of layered-modal with parameter d

[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: OFBIZ-10511-reproduceBug.patch > Use of layered-modal with parameter d

[jira] [Created] (OFBIZ-10511) Use of layered-modal with parameter does not work

2018-08-10 Thread Gil Portenseigne (JIRA)
Gil Portenseigne created OFBIZ-10511: Summary: Use of layered-modal with parameter does not work Key: OFBIZ-10511 URL: https://issues.apache.org/jira/browse/OFBIZ-10511 Project: OFBiz

[jira] [Closed] (OFBIZ-10506) Initial set of hasLoogedOut flag when logging in

2018-08-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10506. > Initial set of hasLoogedOut flag when logg

[jira] [Assigned] (OFBIZ-10506) Initial set of hasLoogedOut flag when logging in

2018-08-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-10506: Assignee: Gil Portenseigne > Initial set of hasLoogedOut flag when logg

[jira] [Comment Edited] (OFBIZ-10504) Remove all unnecessary boxing and unboxing in Java classes

2018-08-07 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571213#comment-16571213 ] Gil Portenseigne edited comment on OFBIZ-10504 at 8/7/18 7:36 AM

[jira] [Closed] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-05 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10505. > Use the stream API in FormRende

[jira] [Assigned] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-05 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-10505: Assignee: Gil Portenseigne > Use the stream API in FormRende

<    1   2   3   4   5   6   7   8   9   10   >