Re: About building on Apple Silicon M1

[Philipp Weissenbacher]

Hi Alex,

I was wondering about the same thing.

With the patches for the current latest Firebird release from #140332 it
should be usable.

They also cleaned up their code for it to work but haven’t made a release
including those fixes yet. It looks like they’re preparing for a 4.0
release (see their branches on GitHub).

I’m anxious compiling LO will kill my M1 SSD, though.

Philipp

On Wed, 21 Apr 2021 at 11:39, Alexander Thurgood 
wrote:

>
>
> Le 16/04/2021 à 08:42, Stephan Bergmann a écrit :
>
> > Apart from that, things just work (thanks to Tor, mostly).
> >
>
> How about Firebird support ? Does that build / is it functional yet ?
>
>
> Alex
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
-- 
Sent from Gmail Mobile
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [protobuf] Creating ProtoBuf Messages without the generated proxy classes

[Philipp Weissenbacher]

Thanks for your repsonse Feng!

 We've ended up doing exactly that in Scala, actually.

Regards,
Philipp

Op vrijdag 5 augustus 2016 20:23:30 UTC+2 schreef Feng Xiao:
>
>
>
> On Thu, Aug 4, 2016 at 5:47 AM, Philipp Weissenbacher <
> philipp.we...@gmail.com > wrote:
>
>> Hi all,
>>
>> We are currently implementing a testing library. One goal is to allow the 
>> client to test sending and receiving ProtoBuf messages.
>> For this, we need a generic way to create them, without requiring the 
>> client to supply the generated proxy classes.
>> This means MyType.getDefaultInstance() (as suggested here 
>> <https://groups.google.com/forum/#!searchin/protobuf/generic%7Csort:relevance/protobuf/w3enqjfLQ4k/fRtI_WjlwxcJ>)
>>  
>> would not work.
>>
>> So, is there a generic way to create ProtoBuf messages (e.g. from .proto 
>> files) at runtime?
>>
> If you are using C++, you can use the Importer class:
>
> https://github.com/google/protobuf/blob/master/src/google/protobuf/compiler/importer.h#L148
>
> to parse .proto files to FileDescriptor and then use DynamicMessage to 
> create message instances:
>
> https://github.com/google/protobuf/blob/master/src/google/protobuf/dynamic_message.h#L118
>
> After that you can parse/serialize and manipulate the message instances 
> using the reflection API:
>
> https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.message#Reflection
>
>  
>
>>
>> BTW, we're using Scala/Java and protobuf2.
>>
>> Sincerely,
>> Philipp
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Protocol Buffers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to protobuf+u...@googlegroups.com .
>> To post to this group, send email to prot...@googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/protobuf.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.

[protobuf] Creating ProtoBuf Messages without the generated proxy classes

[Philipp Weissenbacher]

Hi all,

We are currently implementing a testing library. One goal is to allow the 
client to test sending and receiving ProtoBuf messages.
For this, we need a generic way to create them, without requiring the 
client to supply the generated proxy classes.
This means MyType.getDefaultInstance() (as suggested here 
)
 
would not work.

So, is there a generic way to create ProtoBuf messages (e.g. from .proto 
files) at runtime?

BTW, we're using Scala/Java and protobuf2.

Sincerely,
Philipp

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.

[Libreoffice-commits] core.git: include/svx

[Philipp Weissenbacher]

 include/svx/svdlayer.hxx  |   80 +++---
 include/svx/svdorect.hxx  |   27 ++
 include/svx/svdotable.hxx |   54 +++-
 include/svx/svdouno.hxx   |   15 ++--
 include/svx/svdovirt.hxx  |   19 ++
 include/svx/svdsnpv.hxx   |   86 ++
 include/svx/sxcllitm.hxx  |   21 ---
 7 files changed, 139 insertions(+), 163 deletions(-)

New commits:
commit da952d821dcc08b017bdef8f7b06f60befd2effa
Author: Philipp Weissenbacher <p.weissenbac...@gmail.com>
Date:   Sun Nov 29 21:11:21 2015 +0100

tdf#39468 Translate German comments - include/svx

Change-Id: I5344af095e52efb1f1569d2b67ee3cc6b449dd22
Signed-off-by: Michael Stahl <mst...@redhat.com>

diff --git a/include/svx/svdlayer.hxx b/include/svx/svdlayer.hxx
index 1150e2e..d412c13 100644
--- a/include/svx/svdlayer.hxx
+++ b/include/svx/svdlayer.hxx
@@ -26,6 +26,33 @@
 #include 
 #include 
 
+/**
+ * Note on the layer mix with symbolic/ID-based interface:
+ * You create a new layer with
+ *pLayerAdmin->NewLayer("A new layer");
+ * This layer is automatically appended to the end of the list.
+ *
+ * The same holds true for layer sets.
+ *
+ * The interface for SdrLayerSet is based on LayerIDs. The app must get
+ * an ID for it at the SdrLayerAdmin, like so:
+ *   SdrLayerID nLayerID=pLayerAdmin->GetLayerID("A new layer");
+ *
+ * If the layer cannot be found, SDRLAYER_NOTFOUND is returned.
+ * The methods with the ID interface usually handle that error in a
+ * meaningful way.
+ * If you not only got a name, but even a SdrLayer*, you can get the ID
+ * much faster via the layer directly.
+ *
+ * @param bInherited:
+ * TRUE If the layer/layer set cannot be found, we examine the parent layer 
admin,
+ *  whether there's a corresponding definition
+ * FALSE We only search this layer admin
+ *
+ * Every page's layer admin has a parent layer admin (the model's). The model
+ * itself does not have a parent.
+ */
+
 class SdrModel;
 
 class SVX_DLLPUBLIC SdrLayer
@@ -35,15 +62,15 @@ class SVX_DLLPUBLIC SdrLayer
 OUString maName;
 OUString maTitle;
 OUString maDescription;
-SdrModel*  pModel; // zum Broadcasten
-sal_uInt16 nType;  // 0=Userdefined,1=Standardlayer
+SdrModel*  pModel; // For broadcasting
+sal_uInt16 nType;  // 0= userdefined, 1= default layer
 SdrLayerID nID;
 
 SdrLayer(SdrLayerID nNewID, const OUString& rNewName);
 
 public:
-bool  operator==(const SdrLayer& rCmpLayer) const;
-bool  operator!=(const SdrLayer& rCmpLayer) const { return 
!operator==(rCmpLayer); }
+bool operator==(const SdrLayer& rCmpLayer) const;
+bool operator!=(const SdrLayer& rCmpLayer) const { return 
!operator==(rCmpLayer); }
 
 void SetName(const OUString& rNewName);
 const OUString& GetName() const { return maName; }
@@ -62,8 +89,7 @@ public:
 void  SetStandardLayer(bool bStd = true);
 };
 
-// When Changing the layer data you currently have to set the Modify-Flag
-// manually
+// When Changing the layer data you currently have to set the Modify flag 
manually
 #define SDRLAYER_MAXCOUNT 255
 class SVX_DLLPUBLIC SdrLayerAdmin {
 friend class SdrView;
@@ -72,14 +98,14 @@ friend class SdrPage;
 
 protected:
 std::vector<SdrLayer*> aLayer;
-SdrLayerAdmin* pParent; // Der Admin der Seite kennt den Admin des Docs
-SdrModel*  pModel; // for broadcasting
-OUString   maControlLayerName;
+SdrLayerAdmin* pParent; // The page's admin knows the doc's admin
+SdrModel* pModel; // For broadcasting
+OUString maControlLayerName;
 protected:
-// Eine noch nicht verwendete LayerID raussuchen. Sind bereits alle
-// verbraucht, so gibt's 'ne 0. Wer sicher gehen will, muss vorher
-// GetLayerCount()(const_cast(this)->GetLayerPerID(nID)); }
+SdrLayer*  GetLayerPerID(sal_uInt16 nID) { return 
const_cast<SdrLayer*>(const_cast(this)->GetLayerPerID(nID)); }
 const SdrLayer*GetLayerPerID(sal_uInt16 nID) const;
 
 void   SetControlLayerName(const OUString& rNewName);
 const OUString&GetControlLayerName() const { return 
maControlLayerName; }
 };
 
-/*
-Anmerkung zu den Layer - Gemischt symbolisch/ID-basierendes Interface
-Einen neuen Layer macht man sich mit:
-  pLayerAdmin->NewLayer("Der neue Layer");
-Der Layer wird dann automatisch an das Ende der Liste angehaengt.
-Entsprechdes gilt fuer Layersets gleichermassen.
-Das Interface am SdrLayerSet basiert auf LayerID's. Die App muss sich
-dafuer am SdrLayerAdmin eine ID abholen:
-SdrLayerID nLayerID=pLayerAdmin->GetLayerID("Der neue Layer");
-Wird der Layer nicht gefunden, so liefert die Methode SDRLAYER_NOTFOUND
-zurueck. Die Methoden mit ID-Interface fangen diesen Wert jedoch i.d.R
- 

[Libreoffice-commits] core.git: include/svx

[Philipp Weissenbacher]

 include/svx/svdmark.hxx  |6 +-
 include/svx/svdobj.hxx   |   79 +++
 include/svx/svdograf.hxx |   20 
 include/svx/svdpagv.hxx  |  106 +++
 include/svx/svdpoev.hxx  |   10 ++--
 5 files changed, 117 insertions(+), 104 deletions(-)

New commits:
commit c0a7b924d020afdcfd61a8fd116b4dd2fbdab778
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Thu Aug 6 23:13:27 2015 +0200

tdf#39468 Translate German comments - include/svx

Also fix some whitespace and Doxygen comments

Change-Id: I0a3440cdff2b1b74b2aa4572fc5c92c1525bfd61
Reviewed-on: https://gerrit.libreoffice.org/17549
Reviewed-by: Phillip Sz phillip.sze...@gmail.com
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com

diff --git a/include/svx/svdmark.hxx b/include/svx/svdmark.hxx
index 391dbbd..cba0a75 100644
--- a/include/svx/svdmark.hxx
+++ b/include/svx/svdmark.hxx
@@ -37,7 +37,9 @@ class SdrPageView;
 typedef std::setsal_uInt16 SdrUShortCont;
 
 
-// Everything a View needs to know about a selected object
+/**
+ * Everything a View needs to know about a selected object
+ */
 class SVX_DLLPUBLIC SdrMark : public sdr::ObjectUser
 {
 protected:
@@ -233,7 +235,7 @@ public:
 bool TakeBoundRect(SdrPageView* pPageView, Rectangle rRect) const;
 bool TakeSnapRect(SdrPageView* pPageView, Rectangle rRect) const;
 
-// Es werden saemtliche Entries kopiert!
+// All Entries are copied!
 void operator=(const SdrMarkList rLst);
 };
 
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 652cd9f..830cfed 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -179,9 +179,11 @@ public:
 SdrObjMacroHitRec();
 };
 
-// User data of a drawing object, e.g. application specific data.
-// Every drawing object can have arbitrarily many such records (SV list).
-// Whoever wants to save data here, must inherit from this and set a 
corresponding link in the factory.
+/**
+ * User data of a drawing object, e.g. application specific data.
+ * Every drawing object can have an arbitrary amount of such records (SV list).
+ * Whoever wants to save data here, must inherit from this and set a 
corresponding link in the factory.
+ */
 class SVX_DLLPUBLIC SdrObjUserData
 {
 protected:
@@ -204,7 +206,9 @@ public:
 sal_uInt16 GetId() const { return nIdentifier;}
 };
 
-// all geometrical data of an arbitrary object for use in undo/redo
+/**
+ * All geometrical data of an arbitrary object for use in undo/redo
+ */
 class SVX_DLLPUBLIC SdrObjGeoData
 {
 public:
@@ -223,7 +227,9 @@ public:
 virtual ~SdrObjGeoData();
 };
 
-// provides information about various ZObject properties
+/**
+ * Provides information about various ZObject properties
+ */
 class SVX_DLLPUBLIC SdrObjTransformInfoRec
 {
 public:
@@ -241,7 +247,7 @@ public:
 bool bShearAllowed : 1;// if false, object cannot be sheared
 bool bEdgeRadiusAllowed : 1;
 bool bNoOrthoDesired : 1;  // is true for Rect; is false for BMP, 
MTF
-bool bNoContortion : 1;// if false, Kein verzerren (bei Crook) 
moeglich (nur true bei PathObj und Gruppierten PathObjs)
+bool bNoContortion : 1;// if false, contortion not possible 
(for crook, only true for PathObj and grouped PathObjs)
 bool bCanConvToPath : 1;   // if false, no conversion into PathObj 
possible
 bool bCanConvToPoly : 1;   // if false, no conversion into PolyObj 
possible
 bool bCanConvToContour : 1;// if false, no conversion down to 
whole contour possible
@@ -251,7 +257,7 @@ public:
 SdrObjTransformInfoRec();
 };
 
-// Abstract DrawObject
+/// Abstract DrawObject
 
 class SvxShape;
 class SVX_DLLPUBLIC SdrObject: public SfxListener, public tools::WeakBase 
SdrObject 
@@ -305,7 +311,7 @@ protected:
 SfxGrabBagItem* pGrabBagItem; // holds the GrabBagItem property
 
 
-// Position in the navigation order.  SAL_MAX_UINT32 when not used.
+// Position in the navigation order. SAL_MAX_UINT32 when not used.
 sal_uInt32  mnNavigationPosition;
 SdrLayerID  mnLayerID;
 
@@ -321,12 +327,13 @@ protected:
 boolbSizProt : 1;   // if true, the size is 
protected
 boolbNoPrint : 1;   // if true, the object is not 
printed.
 boolmbVisible : 1;  // if false, the object is not 
visible on screen (but maybe on printer, depending on bNoprint
+
 // If bEmptyPresObj is true, it is a presentation object that has no 
content yet.
 // The flag's default value is false.
 // The management is done by the application.
 // Neither assign operator nor cloning copies the flag!
 // The flag is persistent.
-boolbEmptyPresObj : 1; // empty presentation 
object (Draw)
+bool

Re: German code comments

[Philipp Weissenbacher]

Hi Johannes, all,

Sorry, but this is not going to work properly and will presumably burden
the reviewers (mostly German-speaking core developers) a lot.
See, even the example on the GitHub page is inaccurate, due to missing
context:

sw/source/filter/ww8/ww8struc.hxx:534: hiermit wird weitergearbeitet
(entspricht weitestgehend dem Ver8-Format
 - with this we continue (largely matches the Ver8-format

 That should be With this we continue (largely corresponds to the version
8 format).

My experience tells me, that the best translations get as much context from
existing comments and surrounding code as possible.
I just can't see that happening out of context in a large text file.

I really like your enthusiasm, so please read up on how to contribute
comment translations like code via Gerrit (
https://wiki.documentfoundation.org/Development/gerrit).

Cheers/Grüße,
Philipp

On 6 August 2015 at 14:41, Bjoern Michaelsen 
bjoern.michael...@canonical.com wrote:

 Hi,

 On Thu, Aug 06, 2015 at 07:36:16AM -0500, Norbert Thiebaud wrote:
  As long as the result is re-injected back in core.git via proper
  gerrit patch, that can work...

  assuming the last 5.000 of 50.000 german comments are not weird,
 strange
 leftovers that require lots and lots of context from the surrounding code
 to be
 sensibly translated at all.

 Lets see, maybe this works, but I am somewhat sceptical.

 Best,

 Bjoern
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 4 commits - include/svx sal/osl toolkit/source unotest/source

[Philipp Weissenbacher]

 include/svx/svdetc.hxx   |  108 ++-
 include/svx/svdpntv.hxx  |  221 ---
 include/svx/svdtrans.hxx |2 
 sal/osl/unx/thread.cxx   |1 
 toolkit/source/awt/vclxtoolkit.cxx   |3 
 unotest/source/python/org/libreoffice/unotest.py |7 
 6 files changed, 186 insertions(+), 156 deletions(-)

New commits:
commit b6a3cdf1b48da74b14d22b8e42343600cfb4dbf5
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Sun Aug 2 23:54:43 2015 +0200

tdf#39468 Translate German comments - include/svx

Also fixed one comment I forgot in the previous patch

Change-Id: I3ee090b03bb3d5b5c0d4095c991f22a894ed912a
Signed-off-by: Michael Stahl mst...@redhat.com

diff --git a/include/svx/svdetc.hxx b/include/svx/svdetc.hxx
index 417ddb0..d026cc1 100644
--- a/include/svx/svdetc.hxx
+++ b/include/svx/svdetc.hxx
@@ -29,12 +29,15 @@
 
 
 
-// ExchangeFormat-Id der DrawingEngine holen. Daten koennen dann per
-//   static bool CopyData(pData,nLen,nFormat);
-// bereitgestellt werden, wobei pData/nLen einen SvMemoryStream beschreiben in
-// dem ein SdrModel gestreamt wird an dem fuer die Zeitdauer des Streamens das
-// Flag SdrModel::SetStreamingSdrModel(sal_True) gesetzt wird.
-// sal_uIntPtr SdrGetExchangeFormat(); -- JP 18.01.99 - dafuer gibt es ein 
define
+/**
+ * Get ExchangeFormatID of the DrawingEngine.
+ * The data can then be made available via
+ *   static bool CopyData(pData,nLen,nFormat);
+ *
+ * However, pData/nLen describe an SvMemoryStream in which an SdrModel is
+ * streamed. For its lifetime, the flag SdrModel::SetStreamingSdrModel(true)
+ * is set.
+ */
 
 class SdrOutliner;
 class SdrModel;
@@ -45,16 +48,20 @@ namespace com { namespace sun { namespace star { namespace 
lang {
 struct Locale;
 
 
-// Einen Outliner mit den engineglobalen
-// Defaulteinstellungen auf dem Heap erzeugen.
-// Ist pModNULL, dann wird der MapMode des uebergebenen
-// Models verwendet. Die resultierende Default-Fonthoehe bleibt
-// jedoch dieselbe (die logische Fonthoehe wird umgerechnet).
+/**
+ * Create an Outliner with the engine-global default settings on the heap.
+ * If pMod != nullptr, the MapMode of the passed model is used.
+ * The resulting default font height, however, stays the same (the logical
+ * font height is converted).
+ */
 SVX_DLLPUBLIC SdrOutliner* SdrMakeOutliner(sal_uInt16 nOutlinerMode, SdrModel 
rMod);
 
-// Globale Defaulteinstellungen fuer die DrawingEngine.
-// Diese Einstellungen sollte man direkt beim Applikationsstart
-// vornehmen, noch bevor andere Methoden der Engine gerufen werden.
+/**
+ * Global default settings for the DrawingEngine.
+ *
+ * One should set these default settings as the first
+ * thing at program start, before any other method is called.
+ */
 class SVX_DLLPUBLIC SdrEngineDefaults
 {
 friend class SdrAttrObj;
@@ -71,66 +78,71 @@ private:
 public:
 SdrEngineDefaults();
 
-// Default FontColor ist COL_BLACK
+// Default FontColor is COL_BLACK
 static Color  GetFontColor()   { return 
GetDefaults().aFontColor; }
 
-// Default FontHeight ist 847. Die Fonthoehe wird in logischen Einheiten
-// (MapUnit/MapFraction (siehe unten)) angegeben. Die Defaulteinstellung
-// 847/100mm entspricht also ca. 24 Point. Verwendet man stattdessen
-// beispielsweise Twips (SetMapUnit(MAP_TWIP)) (20 Twip = 1 Point) muss
-// man als Fonthoehe 480 angeben um 24 Point als default zu erhalten.
+// Default FontHeight is 847. The font height uses logical units 
(MapUnit/MapFraction
+// see below for further details). The default setting 847/100mm 
corresponds to about
+// 24 Point. If e.g. one would use Twips (SetMapUnit(MAP_TWIP)) (20 Twip = 
1 Point)
+// instead, one would need to set the font height to 480, in order to get 
a 24 Point height.
 static sal_uIntPtr  GetFontHeight()  { return 
GetDefaults().nFontHeight; }
 
-// Der MapMode wird fuer den globalen Outliner benoetigt.
-// Gleichzeitig bekommt auch jedes neu instanziierte SdrModel
-// diesen MapMode default zugewiesen.
-// Default MapUnit ist MAP_100TH_MM
+// The MapMode is needed for the global Outliner.
+// Incidentally, every newly instantiated SdrModel is assigned this 
MapMode by default.
+// Default MapUnit is MAP_100TH_MM
 static MapUnitGetMapUnit() { return 
GetDefaults().eMapUnit; }
 
-// Default MapFraction ist 1/1.
+// Default MapFraction is 1/1.
 static Fraction   GetMapFraction() { return 
GetDefaults().aMapFraction; }
 
-// Einen Outliner mit den engineglobalen
-// Defaulteinstellungen auf dem Heap erzeugen.
-// Ist pModNULL, dann wird der MapMode des uebergebenen
-// Models verwendet. Die resultierende Default-Fonthoehe bleibt
-// jedoch dieselbe

[Libreoffice-commits] core.git: include/svx

[Philipp Weissenbacher]

 include/svx/svdtrans.hxx |  169 ++-
 include/svx/svdxcgv.hxx  |   73 ++--
 2 files changed, 133 insertions(+), 109 deletions(-)

New commits:
commit 0f2fb06b9e26077568c18e186894c445fb84285b
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Tue Jul 28 23:30:19 2015 +0200

fdo#39468 Translate German comments - include/svx

Change-Id: If0591f7cb799568cb61bb506c4e1f65e8bc540ac
Reviewed-on: https://gerrit.libreoffice.org/17390
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com

diff --git a/include/svx/svdtrans.hxx b/include/svx/svdtrans.hxx
index 221b7ad..f70bfed 100644
--- a/include/svx/svdtrans.hxx
+++ b/include/svx/svdtrans.hxx
@@ -29,20 +29,22 @@
 #include vcl/field.hxx
 #include vcl/mapmod.hxx
 
-
-
-// Winkelangaben der DrawingEngine sind 1/100 Degree
-// #i19054# nowhere used, removed // const int nAngleDiv=100;
-// Um Winkel der DrawingEngine mit den Trigonometrischen Funktionen
-// verarbeiten zu koennen, muessen sie zunaest ins Bogenmass umgerechnet
-// werden. Dies gestaltet sich recht einfach mit der folgenden Konstanten
-// nPi180. Sei nAngle ein Winkel in 1/100 Deg so schreibt man z.B.:
+// The DrawingEngine's angles are specified in 1/100th degrees
+// We need to convert these angles to radians, in order to be able
+// to process them with trigonometric functions.
+// This is done, using the constant nPi180.
+//
+// Example usage:
+// nAngle ... is an angle in 1/100 Deg
+//
+// Which is converted, by this:
 //   double nSin=sin(nAngle*nPi180);
-// Rueckwandlung entsprechend durch Teilen.
+//
+// To convert it back, we use divison.
 const double nPi=3.14159265358979323846;
-const double nPi180=0.00017453292519943295769; // Bei zuweing Stellen ist 
tan(4500*nPi180)!=1.0
+const double nPi180=0.00017453292519943295769; // If we have too few 
digits, we get tan(4500*nPi180)!=1.0
 
-// Der maximale Shearwinkel
+// That maximum shear angle
 #define SDRMAXSHEAR 8900
 
 class XPolygon;
@@ -74,15 +76,21 @@ inline void ShearPoint(Point rPnt, const Point rRef, 
double tn, bool bVShear =
 SVX_DLLPUBLIC void ShearPoly(Polygon rPoly, const Point rRef, double tn, 
bool bVShear = false);
 void ShearXPoly(XPolygon rPoly, const Point rRef, double tn, bool bVShear = 
false);
 
-// rPnt.X bzw rPnt.Y wird auf rCenter.X bzw. rCenter.Y gesetzt!
-// anschliessend muss rPnt nur noch um rCenter gedreht werden.
-// Der Rueckgabewinkel ist ausnahmsweise in Rad.
+/**
+ * rPnt.X/rPnt.Y is set to rCenter.X or rCenter.Y!
+ * We then only need to rotate rPnt by rCenter.
+ *
+ * @return the returned angle is in rad
+ */
 inline double GetCrookAngle(Point rPnt, const Point rCenter, const Point 
rRad, bool bVertical);
-// Die folgenden Methoden behandeln einen Punkt eines XPolygons, wobei die
-// benachbarten Kontrollpunkte des eigentlichen Punktes ggf. in pC1/pC2
-// uebergeben werden. Ueber rSin/rCos wird gleichzeitig sin(nAngle) und 
cos(nAngle)
-// zurueckgegeben.
-// Der Rueckgabewinkel ist hier ebenfalls in Rad.
+
+/**
+ * The following methods accept a point of an XPolygon, whereas the 
neighbouring
+ * control points of the actual point are passed in pC1/pC2.
+ * Via rSin/rCos, sin(nAngle) and cos(nAngle) are returned.
+ *
+ * @return the returned angle is in rad
+ */
 double CrookRotateXPoint(Point rPnt, Point* pC1, Point* pC2, const Point 
rCenter,
  const Point rRad, double rSin, double rCos, bool 
bVert);
 double CrookSlantXPoint(Point rPnt, Point* pC1, Point* pC2, const Point 
rCenter,
@@ -131,8 +139,8 @@ inline void ShearPoint(Point rPnt, const Point rRef, 
double tn, bool bVShear)
 if (rPnt.Y()!=rRef.Y()) { // sonst nicht noetig
 rPnt.X()-=Round((rPnt.Y()-rRef.Y())*tn);
 }
-} else { // ansonsten vertikal
-if (rPnt.X()!=rRef.X()) { // sonst nicht noetig
+} else { // or else vertical
+if (rPnt.X()!=rRef.X()) { // else not needed
 rPnt.Y()-=Round((rPnt.X()-rRef.X())*tn);
 }
 }
@@ -156,62 +164,75 @@ inline double GetCrookAngle(Point rPnt, const Point 
rCenter, const Point rRad
 
/**/
 
/**/
 
-// Y-Achse zeigt nach unten! Die Funktion negiert bei der
-// Winkelberechnung die Y-Achse, sodass GetAngle(Point(0,-1))=90.00deg.
-// GetAngle(Point(0,0)) liefert 0.
-// Der Rueckgabewert liegt im Bereich -180.00..179.99 Degree und
-// ist in 1/100 Degree angegeben.
+/**
+ * The Y axis points down!
+ * The function negates the Y axis, when calculating the angle, such
+ * that GetAngle(Point(0,-1))=90 deg.
+ * GetAngle(Point(0,0)) returns 0.
+ *
+ * @return the returned value is in the range of -180.00..179.99 deg
+ * and is in 1/100 deg units
+ */
 SVX_DLLPUBLIC long GetAngle(const Point rPnt);
-long

Re: Renaming in sw/

[Philipp Weissenbacher]

Would this change also include comments?

Judging by memory, this should also work for the remaining German comments
as they are neologisms anyway.

Philipp
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/text/porexp.cxx  |   51 +++
 sw/source/core/text/porfld.cxx  |  136 +---
 sw/source/core/text/porfld.hxx  |   27 ---
 sw/source/core/text/porfly.cxx  |   69 ++--
 sw/source/core/text/porfly.hxx  |6 -
 sw/source/core/text/porglue.cxx |   24 ---
 sw/source/core/text/txtdrop.cxx |   10 +-
 sw/source/core/text/txthyph.cxx |   74 +++--
 8 files changed, 212 insertions(+), 185 deletions(-)

New commits:
commit acabab05c1f99f9bd47638b9d3899d2e64aca1de
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Sun Jan 25 17:35:00 2015 +0100

fdo#39468 Translate German comments - sw/source/core/text

Change-Id: Idee941019e87f4e132110adf566e432f99df79ce
Reviewed-on: https://gerrit.libreoffice.org/14174
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/sw/source/core/text/porexp.cxx b/sw/source/core/text/porexp.cxx
index 50f2370..5e9e10a 100644
--- a/sw/source/core/text/porexp.cxx
+++ b/sw/source/core/text/porexp.cxx
@@ -28,8 +28,8 @@ sal_Int32 SwExpandPortion::GetCrsrOfst( const sal_uInt16 
nOfst ) const
 bool SwExpandPortion::GetExpTxt( const SwTxtSizeInfo, OUString rTxt ) const
 {
 rTxt.clear();
-// Nicht etwa: return 0 != rTxt.Len();
-// Weil: leere Felder ersetzen CH_TXTATR gegen einen Leerstring
+// Do not do: return 0 != rTxt.Len();
+// Reason being: empty fields replace CH_TXTATR with an empty string
 return true;
 }
 
@@ -44,19 +44,17 @@ SwPosSize SwExpandPortion::GetTxtSize( const SwTxtSizeInfo 
rInf ) const
 return rInf.GetTxtSize();
 }
 
-// 5010: Exp und Tabs
-
 bool SwExpandPortion::Format( SwTxtFormatInfo rInf )
 {
 SwTxtSlot aDiffTxt( rInf, this, true, false );
 const sal_Int32 nFullLen = rInf.GetLen();
 
-// So komisch es aussieht, die Abfrage auf GetLen() muss wegen der
-// ExpandPortions _hinter_ aDiffTxt (vgl. SoftHyphs)
-// false returnen wegen SetFull ...
+// As odd as it may seem: the query for GetLen() must return
+// false due to the ExpandPortions _after_ the aDiffTxt (see SoftHyphs)
+// caused by the SetFull ...
 if( !nFullLen )
 {
-// nicht Init(), weil wir Hoehe und Ascent brauchen
+// Do not Init(), because we need height and ascent
 Width(0);
 return false;
 }
@@ -75,7 +73,7 @@ void SwExpandPortion::Paint( const SwTxtPaintInfo rInf ) 
const
 rInf.DrawBackBrush( *this );
 rInf.DrawBorder( *this );
 
-// do we have to repaint a post it portion?
+// Do we have to repaint a post it portion?
 if( rInf.OnWin()  pPortion  !pPortion-Width() )
 pPortion-PrePaint( rInf, this );
 
@@ -98,11 +96,11 @@ void SwExpandPortion::Paint( const SwTxtPaintInfo rInf ) 
const
 
 SwLinePortion *SwBlankPortion::Compress() { return this; }
 
-// 5497: Es gibt schon Gemeinheiten auf der Welt...
-// Wenn eine Zeile voll mit HardBlanks ist und diese ueberlaeuft,
-// dann duerfen keine Underflows generiert werden!
-// Komplikationen bei Flys...
-
+/**
+ * If a Line is full of HardBlanks and overflows, we must not generate
+ * underflows!
+ * Causes problems with Fly
+ */
 sal_uInt16 SwBlankPortion::MayUnderflow( const SwTxtFormatInfo rInf,
 sal_Int32 nIdx, bool bUnderflow ) const
 {
@@ -114,9 +112,10 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 while( pPos  pPos-IsBlankPortion() )
 pPos = pPos-GetPortion();
 if( !pPos || !rInf.GetIdx() || ( !pPos-GetLen()  pPos == rInf.GetRoot() 
) )
-return 0; // Nur noch BlankPortions unterwegs
-// Wenn vor uns ein Blank ist, brauchen wir kein Underflow ausloesen,
-// wenn hinter uns ein Blank ist, brauchen wir kein Underflow weiterreichen
+return 0; // There are just BlankPortions left
+
+// If a Blank is preceding us, we do not need to trigger underflow
+// If a Blank is succeeding us, we do not need to pass on the underflow
 if (bUnderflow  nIdx + 1  rInf.GetTxt().getLength()  CH_BLANK == 
rInf.GetTxt()[nIdx + 1])
 return 0;
 if( nIdx  !const_castSwTxtFormatInfo(rInf).GetFly() )
@@ -125,9 +124,9 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 pPos = pPos-GetPortion();
 if( !pPos )
 {
-//Hier wird ueberprueft, ob es in dieser Zeile noch sinnvolle Umbrueche
-//gibt, Blanks oder Felder etc., wenn nicht, kein Underflow.
-//Wenn Flys im Spiel sind, lassen wir das Underflow trotzdem zu.
+// We check to see if there are useful line breaks, blanks or fields 
etc. left
+// In case there still are some, no underflow
+// If there are Flys, we still allow the underflow
 sal_Int32 nBlank = nIdx;
 while( --nBlank  rInf.GetLineStart() )
 {
@@ -149,7 +148,9 @@ sal_uInt16 SwBlankPortion::MayUnderflow( const 
SwTxtFormatInfo rInf,
 return

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/text/txtftn.cxx |  298 +
 1 file changed, 158 insertions(+), 140 deletions(-)

New commits:
commit 453b9c98550b76bab3c3d5119300175243b403b6
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Sun Jan 18 21:45:06 2015 +0100

fdo#39468 Translate German comments - sw/source/core/text

Change-Id: I187cb3f6beb14c43def5d76396bf49bd9540a222
Reviewed-on: https://gerrit.libreoffice.org/13981
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/sw/source/core/text/txtftn.cxx b/sw/source/core/text/txtftn.cxx
index 62810bb..bb0ba76 100644
--- a/sw/source/core/text/txtftn.cxx
+++ b/sw/source/core/text/txtftn.cxx
@@ -63,7 +63,9 @@ bool SwTxtFrm::_IsFtnNumFrm() const
 return !pFtn;
 }
 
-// Sucht innerhalb einer Master-Follow-Kette den richtigen TxtFrm zum SwTxtFtn
+/**
+ * Looks for the TxtFrm matching the SwTxtFtn within a master-follow chain
+ */
 SwTxtFrm *SwTxtFrm::FindFtnRef( const SwTxtFtn *pFtn )
 {
 SwTxtFrm *pFrm = this;
@@ -118,7 +120,7 @@ void SwTxtFrm::CalcFtnFlag()
 
 bool SwTxtFrm::CalcPrepFtnAdjust()
 {
-OSL_ENSURE( HasFtn(), Wer ruft mich da? );
+OSL_ENSURE( HasFtn(), Who´s calling me? );
 SwFtnBossFrm *pBoss = FindFtnBossFrm( true );
 const SwFtnFrm *pFtn = pBoss-FindFirstFtn( this );
 if( pFtn  FTNPOS_CHAPTER != GetNode()-GetDoc()-GetFtnInfo().ePos 
@@ -145,7 +147,7 @@ bool SwTxtFrm::CalcPrepFtnAdjust()
 SwTxtFormatInfo aInf( this );
 SwTxtFormatter aLine( this, aInf );
 aLine.TruncLines();
-SetPara( 0 );   //Wird ggf. geloescht!
+SetPara( 0 ); // May be deleted!
 ResetPreps();
 return false;
 }
@@ -153,8 +155,10 @@ bool SwTxtFrm::CalcPrepFtnAdjust()
 return true;
 }
 
-// Local helper function. Checks if nLower should be taken as the boundary
-// for the footnote.
+/**
+ * Local helper function. Checks if nLower should be taken as the boundary
+ * for the footnote.
+ */
 static SwTwips lcl_GetFtnLower( const SwTxtFrm* pFrm, SwTwips nLower )
 {
 // nLower is an absolute value. It denotes the bottom of the line
@@ -283,9 +287,10 @@ SwTwips SwTxtFrm::GetFtnLine( const SwTxtFtn *pFtn ) const
 return nRet;
 }
 
-// Ermittelt die max. erreichbare Hoehe des TxtFrm im Ftn-Bereich.
-// Sie wird eingeschraenkt durch den unteren Rand der Zeile mit
-// der Ftn-Referenz.
+/**
+ * Calculates the maximum reachable height for the TxtFrm in the Ftn Area.
+ * The cell's bottom margin with the Ftn Reference limit's this height.
+ */
 SwTwips SwTxtFrm::_GetFtnFrmHeight() const
 {
 OSL_ENSURE( !IsFollow()  IsInFtn(), SwTxtFrm::SetFtnLine: moon walk );
@@ -303,11 +308,11 @@ SwTwips SwTxtFrm::_GetFtnFrmHeight() const
 1 : pRef-GetFtnLine( pFtnFrm-GetAttr() );
 if( nHeight )
 {
-// So komisch es aussehen mag: Die erste Ftn auf der Seite darf sich
-// nicht mit der Ftn-Referenz beruehren, wenn wir im Ftn-Bereich Text
-// eingeben.
+// As odd as it may seem: the first Ftn on the page may not touch the
+// Ftn Reference, when entering text in the Ftn Area.
 const SwFrm *pCont = pFtnFrm-GetUpper();
-//Hoehe innerhalb des Cont, die ich mir 'eh noch genehmigen darf.
+
+// Height within the Container which we're allowed to consume anyways
 SWRECTFN( pCont )
 SwTwips nTmp = (*fnRect-fnYDiff)( (pCont-*fnRect-fnGetPrtBottom)(),
(Frm().*fnRect-fnGetTop)() );
@@ -331,7 +336,7 @@ SwTwips SwTxtFrm::_GetFtnFrmHeight() const
 
 if ( (*fnRect-fnYDiff)( (pCont-Frm().*fnRect-fnGetTop)(), nHeight) 
 0 )
 {
-//Wachstumspotential den Containers.
+// Growth potential of the container
 if ( !pRef-IsInFtnConnect() )
 {
 SwSaveFtnHeight aSave( (SwFtnBossFrm*)pBoss, nHeight  );
@@ -361,16 +366,16 @@ SwTwips SwTxtFrm::_GetFtnFrmHeight() const
 
 SwTxtFrm *SwTxtFrm::FindQuoVadisFrm()
 {
-// Erstmal feststellen, ob wir in einem FtnFrm stehen:
+// Check whether we're in a FtnFrm
 if( GetIndPrev() || !IsInFtn() )
 return 0;
 
-// Zum Vorgaenger-FtnFrm
+// To the preceding FtnFrm
 SwFtnFrm *pFtnFrm = FindFtnFrm()-GetMaster();
 if( !pFtnFrm )
 return 0;
 
-// Nun den letzten Cntnt:
+// Now the last Cntnt
 SwCntntFrm *pCnt = pFtnFrm-ContainsCntnt();
 if( !pCnt )
 return NULL;
@@ -451,16 +456,18 @@ void SwTxtFrm::RemoveFtn( const sal_Int32 nStart, const 
sal_Int32 nLen )
 }
 }
 
-// Wir loeschen nicht, sondern wollen die Ftn verschieben.
-// Drei Faelle koennen auftreten:
-// 1) Es gibt weder Follow noch PrevFollow

Re: [nl-discuss] favoriete functies/verbeteringen in komende 4.4.0 ??

[Philipp Weissenbacher]

Hoi Cor,

Mooie insteek!
Mijn favoriete zijn

   - de nieuwe default toolbars (sub- en superscript, yay!)
   - de ondersteuning voor OpenGL (!!!)
   - het PDF signing
   - de overstap naar layout managers is eindelijk af - bye bye 90's UI
   - de nieuwe kleurkiezer ziet er mooi uit
  - helaas was er niemand die mijn bounty voor de ondersteuning van
  Adobe palette's
  
https://freedomsponsors.org/issue/570/add-adobe-ase-colour-palette-support
voor
  4.4 wou implementeren
   - en bug 86627 https://bugs.freedesktop.org/show_bug.cgi?id=86627: het
   bijsnijden van grafieken/foto's in Impress

Heb helaas geen tijd heb om het te vertalen.

Groet,
Philipp

2015-01-14 16:48 GMT+01:00 Cor Nouws oo...@nouenoff.nl:

 Beste lezer,

 Wat vindt jij het beste/fijnste van deze pagina?
   https://wiki.documentfoundation.org/ReleaseNotes/4.4

 En is er misschien een deel dat je zou willen vertalen om de
 Nederlandstalige gebruikers te dienen?

 dank  groet,
 Cor

 --
 Cor Nouws
 GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
 - vrijwilliger http://nl.libreoffice.org
 - volunteer http://www.libreoffice.org
 - The Document Foundation Membership Committee Member

 --
 Unsubscribe instructions: E-mail to discuss+unsubscr...@nl.libreoffice.org
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://listarchives.libreoffice.org/nl/discuss/
 All messages sent to this list will be publicly archived and cannot be
 deleted


-- 
Unsubscribe instructions: E-mail to discuss+unsubscr...@nl.libreoffice.org
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/nl/discuss/
All messages sent to this list will be publicly archived and cannot be deleted

Re: Request for LO development design documents

[Philipp Weissenbacher]

Hi Sand,

If you want to start from the architecture, I'd recommend reading
https://wiki.documentfoundation.org/Development/Code_Overview.

Because that can be quite daunting, LO developers usually recommend to
start with one of
the https://wiki.documentfoundation.org/Development/Easy_Hacks
https://wiki.documentfoundation.org/Development/Easy_Hacks and get a feel
for the code and the project.

Of course you can ask here too, but such questions are usually asnwered
more quickly in the IRC channel: irc://chat.freenode.net/libreoffice-dev

Cheers and happy hacking!

Philipp

On 12 January 2015 at 07:16, Sand sand.fj@qq.com wrote:

 Hi Maarten Hoes,
  thanks for you replying. Unfortunately, I have read the articles
 of the link. And more, I have followed this link:
 https://wiki.openoffice.org/wiki/Writer , these articles have guided me
 some how. But I still don't understand some designs in the code,  could you
 give me some tips, i.e. why the message loop in module VCL is designed with
 several level of while loop and some invocations are send to the message
 queue with Link class?

 Any help will be great!

 Sand Wen

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: Who knows of a free UML tool to work with libreoffice?

[Philipp Weissenbacher]

Take a look at this answer for some tools:
http://stackoverflow.com/questions/405953/generating-uml-from-c-code

As we're using doxygen already, we could prolly use that to generate some
graphs. (cf. http://www.stack.nl/~dimitri/doxygen/manual/diagrams.html).

Cheers,
Philipp
Op 22 nov. 2014 07:41 schreef nicholas ferguson 
nicholasfergu...@wingarch.com:

 At times it can help track down the 'has a and is a relationships.
 Anyone used a free UML with libreoffice….that proved a good tool?



 *From:* nicholas ferguson [mailto:nicholasfergu...@wingarch.com]
 *Sent:* Friday, November 21, 2014 8:13 AM
 *To:* 'libreoffice@lists.freedesktop.org'
 *Subject:* Who knows of a free UML tool to work with libreoffice?





 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/text/txtdrop.cxx |   42 ++--
 sw/source/core/text/txtfld.cxx  |   47 ++---
 sw/source/core/text/txtfly.cxx  |   12 -
 sw/source/core/text/txtfrm.cxx  |  357 +---
 sw/source/core/text/txttab.cxx  |   52 +++--
 5 files changed, 275 insertions(+), 235 deletions(-)

New commits:
commit 7ed6b9a3c31cd79f88c0d6b29fa76366d7fe8992
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Sat Nov 8 15:20:57 2014 +0100

fdo#39468 Translate German comments - sw/source/core/text

Change-Id: I8f94931ab8e55e8e330350c92251fa8737bfe730
Reviewed-on: https://gerrit.libreoffice.org/12308
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/sw/source/core/text/txtdrop.cxx b/sw/source/core/text/txtdrop.cxx
index 7d1271f..eeb8e66 100644
--- a/sw/source/core/text/txtdrop.cxx
+++ b/sw/source/core/text/txtdrop.cxx
@@ -41,9 +41,11 @@
 using namespace ::com::sun::star::i18n;
 using namespace ::com::sun::star;
 
-//  Calculates if a drop caps portion intersects with a fly
-//  The width and height of the drop caps portion are passed as arguments,
-//  the position is calculated from the values in rInf
+/**
+ * Calculates if a drop caps portion intersects with a fly
+ * The width and height of the drop caps portion are passed as arguments,
+ * the position is calculated from the values in rInf
+ */
 static bool lcl_IsDropFlyInter( const SwTxtFormatInfo rInf,
  sal_uInt16 nWidth, sal_uInt16 nHeight )
 {
@@ -88,14 +90,14 @@ SwDropSave::~SwDropSave()
 pInf-Y( nY );
 }
 
-// SwDropPortionPart DTor
+/// SwDropPortionPart DTor
 SwDropPortionPart::~SwDropPortionPart()
 {
 delete pFollow;
 delete pFnt;
 }
 
-// SwDropPortion CTor, DTor
+/// SwDropPortion CTor, DTor
 SwDropPortion::SwDropPortion( const sal_uInt16 nLineCnt,
   const sal_uInt16 nDrpHeight,
   const sal_uInt16 nDrpDescent,
@@ -119,7 +121,7 @@ SwDropPortion::~SwDropPortion()
 pBlink-Delete( this );
 }
 
-// nWishLen = 0 indicates that we want a whole word
+/// nWishLen = 0 indicates that we want a whole word
 sal_Int32 SwTxtNode::GetDropLen( sal_Int32 nWishLen ) const
 {
 sal_Int32 nEnd = GetTxt().getLength();
@@ -166,9 +168,11 @@ sal_Int32 SwTxtNode::GetDropLen( sal_Int32 nWishLen ) const
 return i;
 }
 
-//  If a dropcap is found the return value is true otherwise false. The
-//  drop cap sizes passed back by reference are font height, drop height
-//  and drop descent.
+/**
+ * If a dropcap is found the return value is true otherwise false. The
+ * drop cap sizes passed back by reference are font height, drop height
+ * and drop descent.
+ */
 bool SwTxtNode::GetDropSize(int rFontHeight, int rDropHeight, int 
rDropDescent) const
 {
 rFontHeight = 0;
@@ -237,7 +241,7 @@ bool SwTxtNode::GetDropSize(int rFontHeight, int 
rDropHeight, int rDropDescen
 return true;
 }
 
-// Manipulate the width, otherwise the chars are being stretched
+/// Manipulate the width, otherwise the chars are being stretched
 void SwDropPortion::PaintTxt( const SwTxtPaintInfo rInf ) const
 {
 OSL_ENSURE( nDropHeight  pPart  nLines != 1, Drop Portion painted 
twice );
@@ -456,12 +460,12 @@ void SwTxtFormatter::CalcDropHeight( const sal_uInt16 
nLines )
 }
 if ( !Next() )
 {
-nDropLns++; // Fix: 11356
+nDropLns++;
 break;
 }
 }
 
-// In der letzten Zeile plumpsen wir auf den Zeilenascent!
+// We hit the line ascent when reaching the last line!
 nDropHght = nDropHght - nHeight;
 nDropHght = nDropHght + nAscent;
 Top();
@@ -481,8 +485,10 @@ void SwTxtFormatter::CalcDropHeight( const sal_uInt16 
nLines )
 }
 }
 
-//  We assume hat the font height doesn't change and that at first there
-//  are at least as many lines, as the DropCap-setting claims
+/**
+ * We assume hat the font height doesn't change and that at first there
+ * are at least as many lines, as the DropCap-setting claims
+ */
 void SwTxtFormatter::GuessDropHeight( const sal_uInt16 nLines )
 {
 OSL_ENSURE( nLines, GuessDropHeight: Give me more Lines! );
@@ -984,22 +990,22 @@ bool SwDropPortion::Format( SwTxtFormatInfo rInf )
 // reset my length
 SetLen( rInf.GetLen() );
 
-// 7631, 7633: bei Ueberlappungen mit Flys ist Schluss.
+// Quit when Flys are overlapping
 if( ! bFull )
 bFull = lcl_IsDropFlyInter( rInf, Width(), nDropHeight );
 
 if( bFull )
 {
-// Durch FormatTxt kann nHeight auf 0 gesetzt worden sein
+// FormatTxt could have caused nHeight to be 0
 if ( !Height() )
 Height( rInf.GetTxtHeight() );
 
-// Jetzt noch einmal der ganze Spass
+// And now for another round
 nDropHeight

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/text/atrhndl.hxx|   10 +++--
 sw/source/core/text/atrstck.cxx|   34 ++
 sw/source/core/text/blink.cxx  |9 ++--
 sw/source/core/text/guess.hxx  |4 +-
 sw/source/core/text/inftxt.cxx |   47 ++---
 sw/source/core/text/inftxt.hxx |   34 +-
 sw/source/core/text/itratr.cxx |   69 -
 sw/source/core/text/txthyph.cxx|   52 +++
 sw/source/core/text/widorp.cxx |   58 +++
 sw/source/core/unocore/unodraw.cxx |   10 +++--
 sw/source/core/unocore/unomap.cxx  |   10 ++---
 sw/source/core/unocore/unosett.cxx |3 +
 sw/source/core/unocore/unotbl.cxx  |   24 ++--
 13 files changed, 197 insertions(+), 167 deletions(-)

New commits:
commit c58c28d19b3afaa53ef1895609e9e21db04d8abb
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Tue Oct 21 15:08:26 2014 +0200

fdo#39468 Translate German comments - sw/source/core/{unocore|text}

Change-Id: Ib68eb94b296b002a8cd4e73dd6fd72a4f9d2f7d3
Reviewed-on: https://gerrit.libreoffice.org/12058
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

diff --git a/sw/source/core/text/atrhndl.hxx b/sw/source/core/text/atrhndl.hxx
index ed41f2a..c1ecd6a 100644
--- a/sw/source/core/text/atrhndl.hxx
+++ b/sw/source/core/text/atrhndl.hxx
@@ -32,20 +32,22 @@ class SwViewShell;
 class SfxPoolItem;
 extern const sal_uInt8 StackPos[];
 
-// Used by Attribute Iterators to organize attributes on stacks to
-// find the valid attribute in each category
+/**
+ * Used by Attribute Iterators to organize attributes on stacks to
+ * find the valid attribute in each category
+ */
 class SwAttrHandler
 {
 private:
 
-// Container for SwTxtAttr Objects
+/// Container for SwTxtAttr Objects
 class SwAttrStack
 {
 private:
 SwTxtAttr* pInitialArray[ INITIAL_NUM_ATTR ];
 SwTxtAttr** pArray;
 sal_uInt16 nCount; // number of elements on stack
-sal_uInt16 nSize;// number of positions in Array
+sal_uInt16 nSize;  // number of positions in Array
 
 public:
 // Ctor, Dtor
diff --git a/sw/source/core/text/atrstck.cxx b/sw/source/core/text/atrstck.cxx
index 8590ecf..365cca4 100644
--- a/sw/source/core/text/atrstck.cxx
+++ b/sw/source/core/text/atrstck.cxx
@@ -56,8 +56,8 @@
 
 #define STACK_INCREMENT 4
 
-/*
- *  Attribute to Stack Mapping
+/**
+ * Attribute to Stack Mapping
  *
  * Attributes applied to a text are pushed on different stacks. For each
  * stack, the top most attribute on the stack is valid. Because some
@@ -131,7 +131,7 @@ const sal_uInt8 StackPos[ RES_TXTATR_WITHEND_END - 
RES_CHRATR_BEGIN + 1 ] =
 namespace CharFmt
 {
 
-// Returns the item set associated with an character/inet/auto style
+/// Returns the item set associated with an character/inet/auto style
 const SfxItemSet* GetItemSet( const SfxPoolItem rAttr )
 {
 const SfxItemSet* pSet = 0;
@@ -155,7 +155,7 @@ const SfxItemSet* GetItemSet( const SfxPoolItem rAttr )
 return pSet;
 }
 
-// Extracts pool item of type nWhich from rAttr
+/// Extracts pool item of type nWhich from rAttr
 const SfxPoolItem* GetItem( const SwTxtAttr rAttr, sal_uInt16 nWhich )
 {
 if ( RES_TXTATR_INETFMT == rAttr.Which() ||
@@ -175,7 +175,7 @@ const SfxPoolItem* GetItem( const SwTxtAttr rAttr, 
sal_uInt16 nWhich )
 return ( nWhich == rAttr.Which() ) ? rAttr.GetAttr() : 0;
 }
 
-// checks if item is included in character/inet/auto style
+/// Checks if item is included in character/inet/auto style
 bool IsItemIncluded( const sal_uInt16 nWhich, const SwTxtAttr *pAttr )
 {
 bool bRet = false;
@@ -188,11 +188,13 @@ bool IsItemIncluded( const sal_uInt16 nWhich, const 
SwTxtAttr *pAttr )
 }
 }
 
-// The color of hyperlinks is taken from the associated character attribute,
-// depending on its 'visited' state. There are actually two cases, which
-// should override the colors from the character attribute:
-// 1. We never take the 'visited' color during printing/pdf export/preview
-// 2. The user has chosen to override these colors in the view options
+/**
+ * The color of hyperlinks is taken from the associated character attribute,
+ * depending on its 'visited' state. There are actually two cases, which
+ * should override the colors from the character attribute:
+ * 1. We never take the 'visited' color during printing/pdf export/preview
+ * 2. The user has chosen to override these colors in the view options
+ */
 static bool lcl_ChgHyperLinkColor( const SwTxtAttr rAttr,
 const SfxPoolItem rItem,
 const SwViewShell* pShell,
@@ -526,7 +528,7 @@ void SwAttrHandler::PopAndChg( const SwTxtAttr rAttr, 
SwFont rFnt )
 }
 }
 
-// only used during redlining
+/// Only used during redlining
 void SwAttrHandler::Pop( const

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/sw3io/sw3convert.cxx |  174 +++-
 sw/source/core/sw3io/swacorr.cxx|   17 ++-
 sw/source/core/swg/SwXMLTextBlocks.cxx  |   12 +-
 sw/source/core/swg/SwXMLTextBlocks1.cxx |   12 --
 sw/source/core/swg/swblocks.cxx |   45 
 sw/source/core/unocore/unochart.cxx |  126 +++
 6 files changed, 197 insertions(+), 189 deletions(-)

New commits:
commit b6c32f3fd330d4297fc448a090d8c95bed11b02d
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Fri Oct 17 20:59:54 2014 +0200

fdo#39468 Translate German comments - sw/source/core/{sw3io|swg|unocore}

- Convert Deutsche Mark (DM) to Euro (EUR)
- Fix some whitespace

Change-Id: I94e0c9cbf5f5defca2e0d0f59f08592a914a381b
Reviewed-on: https://gerrit.libreoffice.org/12011
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/sw/source/core/sw3io/sw3convert.cxx 
b/sw/source/core/sw3io/sw3convert.cxx
index 9056381..3ab1589 100644
--- a/sw/source/core/sw3io/sw3convert.cxx
+++ b/sw/source/core/sw3io/sw3convert.cxx
@@ -46,8 +46,8 @@
 #include ndtxt.hxx
 
 //really used ids from old sw3ids.hxx
-#define SWG_INETBROWSER 0x000e  // URL-Grf-Nodes, Browse-Flag, Format-Ums.
-#define SWG_NEWFIELDS   0x0200  // Felder mit Numberformatter-Zahlenformat
+#define SWG_INETBROWSER 0x000e  // URL graph nodes, browse flag, formatter
+#define SWG_NEWFIELDS   0x0200  // Fields with Numberformatter numberformat
 
 using namespace nsSwDocInfoSubType;
 
@@ -59,118 +59,114 @@ struct OldFormats
 
 static const OldFormats aOldDateFmt40[] =
 {
-// Datumsfelder:
-{ NF_DATE_SYSTEM_SHORT, DFF_SSYS }, // Kurzes Systemdatum
-{ NF_DATE_SYSTEM_LONG,  DFF_LSYS }, // Langes Systemdatum
-{ NF_DATE_SYS_DDMMYY,   DFF_DMY },// 06.10.64
+// Date fields
+{ NF_DATE_SYSTEM_SHORT, DFF_SSYS }, // Short system date
+{ NF_DATE_SYSTEM_LONG,  DFF_LSYS }, // Long system date
+{ NF_DATE_SYS_DDMMYY,   DFF_DMY },  // 06.10.64
 { NF_DATE_SYS_DDMM, DFF_DMYY }, // 06.10.1964
-{ NF_DATE_SYS_DMMMYY,   DFF_DMMY }, // 06. Okt 64
-{ NF_DATE_SYS_DMMM, DFF_DMMYY },// 06. Okt 1964
-{ NF_DATE_DIN_D,DFF_DMMMYY },   // 06. Oktober 1964
-{ NF_DATE_DIN_D,DFF_DMMMY },// 06. Oktober 64
-{ NF_DATE_SYS_NNDMMMYY, DFF_DDMMY },// Di, 06. Okt 64
-{ NF_DATE_SYS_NND,  DFF_DDMMMY },   // Di, 06. Oktober 64
-{ NF_DATE_SYS_NND,  DFF_DDMMMYY },  // Di, 06. Oktober 1964
-{ NF_DATE_SYS_D,DFF_DDDMMMYY }, // Dienstag, 06. 
Oktober 1964
-{ NF_DATE_SYS_D,DFF_DDDMMMY },  // Dienstag, 06. 
Oktober 64
-{ NF_DATE_SYS_MMYY, DFF_MY },   // 10.64
-{ NF_DATE_DIN_MMDD, DFF_MD },   // 10-06
-{ NF_DATE_DIN_YYMMDD,   DFF_YMD },  // 64-10-06
+{ NF_DATE_SYS_DMMMYY,   DFF_DMMY }, // 06. Oct 64
+{ NF_DATE_SYS_DMMM, DFF_DMMYY },// 06. Oct 1964
+{ NF_DATE_DIN_D,DFF_DMMMYY },   // 06. October 1964
+{ NF_DATE_DIN_D,DFF_DMMMY },// 06. October 64
+{ NF_DATE_SYS_NNDMMMYY, DFF_DDMMY },// Tue, 06. Oct 64
+{ NF_DATE_SYS_NND,  DFF_DDMMMY },   // Tue, 06. October 64
+{ NF_DATE_SYS_NND,  DFF_DDMMMYY },  // Tue, 06. October 1964
+{ NF_DATE_SYS_D,DFF_DDDMMMYY }, // Tuesday, 06. October 
1964
+{ NF_DATE_SYS_D,DFF_DDDMMMY },  // Tuesday, 06. October 64
+{ NF_DATE_SYS_MMYY, DFF_MY },   // 10.64
+{ NF_DATE_DIN_MMDD, DFF_MD },   // 10-06
+{ NF_DATE_DIN_YYMMDD,   DFF_YMD },  // 64-10-06
 { NF_DATE_DIN_MMDD, DFF_YYMD }, // 1964-10-06
 
-{ NF_NUMERIC_START, 0  }// Tabellenende
+{ NF_NUMERIC_START, 0  }// End of table
 };
 
 static const OldFormats aOldDateFmt30[] =
 {
-// Datumsfelder:
-{ NF_DATE_SYSTEM_SHORT, DFF_SSYS }, // Kurzes Systemdatum
-{ NF_DATE_SYSTEM_LONG,  DFF_LSYS }, // Langes Systemdatum
-{ NF_DATE_SYS_DDMMYY,   DFF_DMY },// 06.10.64
+// Date fields
+{ NF_DATE_SYSTEM_SHORT, DFF_SSYS }, // Short system date
+{ NF_DATE_SYSTEM_LONG,  DFF_LSYS }, // Long system date
+{ NF_DATE_SYS_DDMMYY,   DFF_DMY },  // 06.10.64
 { NF_DATE_SYS_DDMM, DFF_DMYY }, // 06.10.1964
-{ NF_DATE_SYS_DMMMYY,   DFF_DMMY }, // 06. Okt 64
-{ NF_DATE_SYS_DMMM, 4 /*DFF_DMMYY*/ },  // 06. Okt 1964
-{ NF_DATE_DIN_D,5 /*DFF_DMMMYY

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/layout/paintfrm.cxx |  621 +++--
 1 file changed, 335 insertions(+), 286 deletions(-)

New commits:
commit 68da0456a783afe65d9ff114477a36487450ca46
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Mon Oct 6 09:53:04 2014 +0200

Improve Denglish and reformat comments

Change-Id: Ieb0d47240209f35a0558cb788a21ab45b405eb47
Reviewed-on: https://gerrit.libreoffice.org/11820
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 91583a6..cf04cf9 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -144,7 +144,7 @@ class SwLineRect : public SwRect
 SvxBorderStyle  nStyle;
 const SwTabFrm *pTab;
   sal_uInt8 nSubColor;  //colorize subsidiary lines
-  bool  bPainted;   //already painted?
+  bool  bPainted;   //already painted?
   sal_uInt8 nLock;  //To distinguish the line and the hell 
layer.
 public:
 SwLineRect( const SwRect rRect, const Color *pCol, const SvxBorderStyle 
nStyle,
@@ -300,10 +300,12 @@ bool isTableBoundariesEnabled()
 
 }
 
-// Set borders alignment statics.
-// adjustment for 'small' twip-to-pixel relations:
-// For 'small' twip-to-pixel relations (less then 2:1)
-// values of nHalfPixelSzW and nHalfPixelSzH are set to ZERO.
+/**
+ * Set borders alignment statics
+ * Adjustment for 'small' twip-to-pixel relations:
+ * For 'small' twip-to-pixel relations (less then 2:1)
+ * values of nHalfPixelSzW and nHalfPixelSzH are set to ZERO
+ */
 void SwCalcPixStatics( OutputDevice *pOut )
 {
 // determine 'small' twip-to-pixel relation
@@ -357,7 +359,9 @@ void SwCalcPixStatics( OutputDevice *pOut )
 aScaleY = rMap.GetScaleY();
 }
 
-//To be able to save the statics so the paint is more or lees reentrant.
+/**
+ * To be able to save the statics so the paint is more or lees reentrant
+ */
 class SwSavePaintStatics
 {
 boolbSFlyMetafile;
@@ -652,9 +656,8 @@ bool SwLineRect::MakeUnion( const SwRect rRect )
 void SwLineRects::AddLineRect( const SwRect rRect, const Color *pCol, const 
SvxBorderStyle nStyle,
const SwTabFrm *pTab, const sal_uInt8 nSCol )
 {
-//Loop backwards because lines which can be combined, can usually be 
painted
-//in the same context.
-
+// Loop backwards because lines which can be combined, can usually be 
painted
+// in the same context
 for (reverse_iterator it = aLineRects.rbegin(); it != aLineRects.rend();
  ++it)
 {
@@ -786,9 +789,9 @@ void SwLineRects::ConnectEdges( OutputDevice *pOut )
 }
 
 if ( rL1.Bottom()  pLB-Bottom() )
-rL1.Top( pLB-Top() );  // extend i1 on the top
+rL1.Top( pLB-Top() ); // extend i1 on the top
 else
-bRemove = true; //stopping, remove i1
+bRemove = true; //stopping, remove i1
 }
 }
 else
@@ -844,7 +847,6 @@ void SwLineRects::ConnectEdges( OutputDevice *pOut )
 void SwSubsRects::RemoveSuperfluousSubsidiaryLines( const SwLineRects rRects )
 {
 // All help lines that are covered by any border will be removed or split
-
 for (size_t i = 0; i  aLineRects.size(); ++i)
 {
 // get a copy instead of a reference, because an insert may destroy
@@ -909,7 +911,7 @@ void SwSubsRects::RemoveSuperfluousSubsidiaryLines( const 
SwLineRects rRects )
 break;
 }
 }
-else//horizontal
+else // Horizontal
 {
 if ( aSubsRect.Top() = rLine.Bottom() 
  aSubsRect.Bottom() = rLine.Top() )
@@ -1211,18 +1213,21 @@ void SwSubsRects::PaintSubsidiary( OutputDevice *pOut,
 
 // Various functions that are use in this file.
 
-// Note: function SwAlignRect(..) also used outside this file.
-// Correction: adjust rectangle on pixel level in order
-//  to assure, that the border 'leaves its original pixel', if it has 
to.
-//  No prior adjustments for odd relation between pixel and twip.
+/**
+ * Function SwAlignRect(..) is also used outside this file
+ *
+ * Correction: adjust rectangle on pixel level in order to make sure,
+ * that the border leaves its original pixel, if it has to
+ * No prior adjustments for odd relation between pixel and twip
+ */
 void SwAlignRect( SwRect rRect, const SwViewShell *pSh )
 {
 if( !rRect.HasArea() )
 return;
 
-// Assure that view shell (parameter pSh) exists, if the output device
-// is taken from this view shell -- no output device, no alignment.
-// Output

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx |   16 +--
 sw/source/core/ole/ndole.cxx   |   49 
+-
 2 files changed, 35 insertions(+), 30 deletions(-)

New commits:
commit 8a8fa926c1fe843c5c79f7b300b7365855460e62
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Mon Oct 6 10:12:46 2014 +0200

fdo#39468 Translate German comments - sw/source/core/

Change-Id: I64743b4f6b7bfd44b410d63ab13298a000a47221
Reviewed-on: https://gerrit.libreoffice.org/11821
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com

diff --git a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
index be59ead..6e73a79 100644
--- a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
@@ -714,9 +714,9 @@ void SwToCntntAnchoredObjectPosition::CalcPosition()
 } // end of else nRelPosY = 0
 } // end of aVert.GetVertOrient() == text::VertOrientation::NONE
 
-//Damit das Teil ggf. auf die richtige Seite gestellt und in die
-//PrtArea des LayLeaf gezogen werden kann, muss hier seine
-//absolute Position berechnet werden.
+// We need to calculate the part's absolute position, in order for
+// it to be put onto the right page and to be pulled into the
+// LayLeaf's PrtArea
 const SwTwips nTopOfAnch = _GetTopForObjPos( *pAnchorFrmForVertPos, 
fnRect, bVert );
 if( bVert )
 {
@@ -884,7 +884,7 @@ void SwToCntntAnchoredObjectPosition::CalcPosition()
 if ( !bInSct 
  (GetAnchoredObj().GetObjRect().*fnRect-fnGetTop)() ==
  (pUpperOfOrientFrm-*fnRect-fnGetPrtTop)() )
-//Das teil passt nimmer, da hilft auch kein moven.
+// It doesn't fit, moving it would not help either 
anymore
 break;
 
 const SwLayoutFrm* pNextLay = pUpperOfOrientFrm-GetLeaf(
@@ -951,8 +951,8 @@ void SwToCntntAnchoredObjectPosition::CalcPosition()
 }
 else if ( bInSct )
 {
-// Wenn wir innerhalb des Bereich nicht genug Platz 
haben, gucken
-// wir uns mal die Seite an.
+// If we don't have enough room within the Area, we 
take a look at
+// the Page
 const SwLayoutFrm* pTmp = 
pUpperOfOrientFrm-FindSctFrm()-GetUpper();
 nDist = 
(GetAnchoredObj().GetObjRect().*fnRect-fnBottomDist)(
   (pTmp-*fnRect-fnGetPrtBottom)() );
@@ -1066,7 +1066,9 @@ void SwToCntntAnchoredObjectPosition::CalcPosition()
 GetAnchoredObj().SetCurrRelPos( aRelPos );
 }
 
-/** determine frame for horizontal position */
+/**
+ * Determine frame for horizontal position
+ */
 const SwFrm SwToCntntAnchoredObjectPosition::_GetHoriVirtualAnchor(
 const SwLayoutFrm _rProposedFrm ) 
const
 {
diff --git a/sw/source/core/ole/ndole.cxx b/sw/source/core/ole/ndole.cxx
index 8b2fc0f..35df868 100644
--- a/sw/source/core/ole/ndole.cxx
+++ b/sw/source/core/ole/ndole.cxx
@@ -247,25 +247,26 @@ const Graphic* SwOLENode::GetGraphic()
 
 SwCntntNode *SwOLENode::SplitCntntNode( const SwPosition  )
 {
-// OLE-Objecte vervielfaeltigen ??
+// Multiply OLE objects?
 OSL_FAIL( OleNode: can't split. );
 return this;
 }
 
-// Laden eines in den Undo-Bereich verschobenen OLE-Objekts
-
+/**
+ * Loading a OLE object that has been moved to the Undo Area
+ */
 bool SwOLENode::RestorePersistentData()
 {
 OSL_ENSURE( aOLEObj.GetOleRef().is(), No object to restore! );
 if ( aOLEObj.xOLERef.is() )
 {
-// Falls bereits eine SvPersist-Instanz existiert, nehmen wir diese
+// If a SvPersist instance already exists, we use it
 SfxObjectShell* p = GetDoc()-GetPersist();
 if( !p )
 {
-// TODO/LATER: reicht hier nicht ein EmbeddedObjectContainer? Was 
passiert mit
-// diesem Dokument?
-OSL_ENSURE( false, warum wird hier eine DocShell angelegt? );
+// TODO/LATER: Isn't a EmbeddedObjectContainer sufficient here?
+// What happens to this document?
+OSL_ENSURE( false, Why are we creating a DocShell here? );
 p = new SwDocShell( GetDoc(), SFX_CREATE_MODE_INTERNAL );
 p-DoInitNew( NULL );
 }
@@ -293,7 +294,9 @@ bool SwOLENode::RestorePersistentData()
 return true;
 }
 
-// OLE object is transported into UNDO area
+/**
+ * OLE object is transported into UNDO area
+ */
 bool SwOLENode::SavePersistentData()
 {
 if( aOLEObj.xOLERef.is

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/inc/ptqueue.hxx  |   35 +--
 sw/source/core/inc/rootfrm.hxx  |  214 +++-
 sw/source/core/inc/rowfrm.hxx   |   18 +
 sw/source/core/inc/sectfrm.hxx  |   42 ++--
 sw/source/core/inc/swblocks.hxx |   70 +++---
 sw/source/core/inc/swcache.hxx  |  103 -
 sw/source/core/inc/tabfrm.hxx   |   80 +++
 sw/source/core/inc/tblrwcl.hxx  |   28 +-
 sw/source/core/inc/txmsrt.hxx   |   12 -
 sw/source/core/inc/txtfrm.hxx   |  418 +++-
 sw/source/core/inc/viewimp.hxx  |  114 +-
 11 files changed, 622 insertions(+), 512 deletions(-)

New commits:
commit aa053bb16f34ce4d216848abd32845f7369e236b
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Fri Oct 3 15:56:16 2014 +0200

fdo#39468 Finish translating German comments in sw/source/core/inc

Change-Id: I9a07a46582eafe70dcc26161e39856e9cf72de0c
Reviewed-on: https://gerrit.libreoffice.org/11792
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com

diff --git a/sw/source/core/inc/ptqueue.hxx b/sw/source/core/inc/ptqueue.hxx
index 155776d..817f2f9 100644
--- a/sw/source/core/inc/ptqueue.hxx
+++ b/sw/source/core/inc/ptqueue.hxx
@@ -19,23 +19,24 @@
 #ifndef INCLUDED_SW_SOURCE_CORE_INC_PTQUEUE_HXX
 #define INCLUDED_SW_SOURCE_CORE_INC_PTQUEUE_HXX
 
-//Leider vertragen wir es nicht so gut, wenn wir mehr als ein Paint
-//gleichzeitig verarbeiten sollen. Insbesondere beim Drucken kommt dies
-//leider haeufig vor.
-//SwRootFrm::Paint() stellt fest, dass es zum zweitenmal gerufen wird, und
-//traegt das Rechteck sowie die dazugehoerige Shell in den PaintCollector ein.
-//Diejenigen stellen, die moeglicherweise das doppelte Paint Verursachen
-//brauchen nur noch zum richtigen Zeitpunkt die gesammelten Paints verarbeiten.
-//Derzeit bietet sich der Druckvorgang an, und zwar nach dem Druck von jeweils
-//einer Seite.
-
-//Das Invalidieren der Windows direkt aus dem RootFrm::Paint hat sich als nicht
-//erfolgreich erwiesen, weil die Paints dann in den allermeisten Faellen
-//wiederum zu einem sehr unguenstigen Zeitpunkt ankommen.
-//Nach dem Druck jeder Seite ein Update auf alle Fenster auszuloesen scheint
-//auch nicht angeraten, weil einerseits die edit-Windows nicht im direkten
-//Zugriff sind und anderseits das notwendige Update je nach Plattform extrem
-//teuer werden kann.
+/**
+ * Unfortunately we have some problems with processing more than one Paint()
+ * at a time. This happens especially often during printing.
+ *
+ * SwRootFrm::Paint() determines that it's called a second time and adds the
+ * rectangle and the corresponding Shell to the PaintCollector.
+ * The call sites that are causing the double Paint() only need to process the
+ * collected Paint()s at the right point in time.
+ * Doing this during printing (after having printed one page) is very suitable
+ * for doing that.
+ *
+ * Invalidating windows directly from the RootFrm::Paint was not a succesful
+ * approach, because the Paint()s arrive at a very unfavourable point in time.
+ * Triggering an update for all windows after printing each page does not seem
+ * appropriate either: on the one hand we don't have direct acces to the edit
+ * windows and on the other hand the updates can become very costly on some
+ * platforms.
+ */
 
 class SwQueuedPaint;
 class SwViewShell;
diff --git a/sw/source/core/inc/rootfrm.hxx b/sw/source/core/inc/rootfrm.hxx
index fa4acdb..d8761d2 100644
--- a/sw/source/core/inc/rootfrm.hxx
+++ b/sw/source/core/inc/rootfrm.hxx
@@ -53,74 +53,77 @@ struct SwCrsrMoveState;
 /// The root element of a Writer document layout.
 class SwRootFrm: public SwLayoutFrm
 {
-//Muss das Superfluous temporaer abschalten.
+// Needs to disable the Superfluous temporarily
 friend void AdjustSizeChgNotify( SwRootFrm *pRoot );
 
-//Pflegt pLastPage (Cut() und Paste() vom SwPageFrm
+// Maintains the pLastPage (Cut() and Paste() of SwPageFrm
 friend inline void SetLastPage( SwPageFrm* );
 
-// Fuer das Anlegen und Zerstoeren des virtuellen Outputdevice-Managers
-friend void _FrmInit(); //erzeugt pVout
-friend void _FrmFinit();//loescht pVout
+// For creating and destroying of the virtual output device manager
+friend void _FrmInit(); // Creates pVout
+friend void _FrmFinit(); // Destroys pVout
 
 std::vectorSwRect maPageRects;// returns the current rectangle for each 
page frame
 // the rectangle is extended to the 
top/bottom/left/right
-// for pages located at the outer borders
+// for pages located at the outer margins
 SwRect  maPagesArea;// the area covered by the pages
 longmnViewWidth;// the current page layout bases on this 
view width
-sal_uInt16  mnColumns;  // the current page layout bases on 
this number of columns

[Libreoffice-commits] core.git: forms/source

[Philipp Weissenbacher]

 forms/source/misc/InterfaceContainer.cxx |   24 
 forms/source/misc/services.cxx   |   12 ++--
 2 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 0658889bcdc54e63aa5966aa9936bd043d3a8b35
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Thu Oct 2 11:54:57 2014 +0200

fdo#39468 Make forms/ German comments clean

Change-Id: Iec24928324bec1caee65ca37cbf0fb5b66e6975e
Reviewed-on: https://gerrit.libreoffice.org/11760
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/forms/source/misc/InterfaceContainer.cxx 
b/forms/source/misc/InterfaceContainer.cxx
index ea989e3..5b0efaf 100644
--- a/forms/source/misc/InterfaceContainer.cxx
+++ b/forms/source/misc/InterfaceContainer.cxx
@@ -334,7 +334,7 @@ void SAL_CALL OInterfaceContainer::writeEvents(const 
ReferenceXObjectOutputStre
 if (xScripts.is())
 xScripts-write(_rxOutStream);
 
-// feststellen der Laenge
+// Determine length
 nObjLen = xMark-offsetToMark(nMark) - 4;
 xMark-jumpToMark(nMark);
 _rxOutStream-writeLong(nObjLen);
@@ -441,7 +441,7 @@ void SAL_CALL OInterfaceContainer::readEvents(const 
ReferenceXObjectInputStream
 {
 ::osl::MutexGuard aGuard( m_rMutex );
 
-// Scripting Info lesen
+// Read scripting info
 ReferenceXMarkableStream  xMark(_rxInStream, UNO_QUERY);
 sal_Int32 nObjLen = _rxInStream-readLong();
 if (nObjLen)
@@ -455,7 +455,7 @@ void SAL_CALL OInterfaceContainer::readEvents(const 
ReferenceXObjectInputStream
 xMark-deleteMark(nMark);
 }
 
-// Attachement lesen
+// Read Attachement
 if ( m_xEventAttacher.is() )
 {
 OInterfaceArray::const_iterator aAttach = m_aItems.begin();
@@ -475,7 +475,7 @@ void SAL_CALL OInterfaceContainer::write( const Reference 
XObjectOutputStream 
 ::osl::MutexGuard aGuard( m_rMutex );
 sal_Int32 nLen = m_aItems.size();
 
-// schreiben der laenge
+// Write length
 _rxOutStream-writeLong(nLen);
 
 if (nLen)
@@ -483,7 +483,7 @@ void SAL_CALL OInterfaceContainer::write( const Reference 
XObjectOutputStream 
 // 1. Version
 _rxOutStream-writeShort(0x0001);
 
-// 2. Objekte
+// 2. Objects
 for (sal_Int32 i = 0; i  nLen; i++)
 {
 ReferenceXPersistObject  xObj(m_aItems[i], UNO_QUERY);
@@ -537,7 +537,7 @@ void SAL_CALL OInterfaceContainer::read( const Reference 
XObjectInputStream 
 while (getCount())
 removeByIndex(0);
 
-// Schreibt nur in Abhaengigkeit der Laenge
+// Only writes depending on the length
 sal_Int32 nLen = _rxInStream-readLong();
 
 if (nLen)
@@ -545,7 +545,7 @@ void SAL_CALL OInterfaceContainer::read( const Reference 
XObjectInputStream 
 // 1. Version
 sal_uInt16 nVersion = _rxInStream-readShort(); (void)nVersion;
 
-// 2. Objekte
+// 2. Objects
 for (sal_Int32 i = 0; i  nLen; i++)
 {
 ReferenceXPersistObject  xObj;
@@ -564,11 +564,11 @@ void SAL_CALL OInterfaceContainer::read( const Reference 
XObjectInputStream 
 }
 catch(const Exception)
 {
-// unsere Map leeren
+// Clear the map
 while (!m_aItems.empty())
 removeElementsNoEvents(0);
 
-// und die Exception nach aussen
+// Rethrow the exception
 throw;
 }
 
@@ -580,9 +580,9 @@ void SAL_CALL OInterfaceContainer::read( const Reference 
XObjectInputStream 
 implInsert(
 m_aItems.size(),// position
 xElement,   // element to insert
-false,  // no event attacher manager handling
+false,  // no event attacher manager 
handling
 NULL,   // not yet approved - let 
implInsert do it
-true// fire the event
+true// fire the event
 );
 }
 catch( const Exception )
@@ -829,7 +829,7 @@ void OInterfaceContainer::implInsert(sal_Int32 _nIndex, 
const Reference XProper
 _rxElement-addPropertyChangeListener(PROPERTY_NAME, this);
 
 // insert the object into our internal structures
-if (_nIndex  (sal_Int32)m_aItems.size()) // ermitteln des tatsaechlichen 
Indexs
+if (_nIndex  (sal_Int32)m_aItems.size()) // Calculate the actual index
 {
 _nIndex = m_aItems.size();
 m_aItems.push_back( pElementMetaData-xInterface );
diff --git a/forms/source/misc/services.cxx b/forms/source/misc/services.cxx
index 189cf35..b275b1e 100644
--- a/forms/source/misc/services.cxx
+++ b/forms/source/misc/services.cxx
@@ -29,17 +29,17 @@ using namespace ::com

[Libreoffice-commits] core.git: sw/source

[Philipp Weissenbacher]

 sw/source/core/inc/layact.hxx   |  100 +++-
 sw/source/core/inc/layfrm.hxx   |   63 -
 sw/source/core/inc/mvsave.hxx   |   23 -
 sw/source/core/inc/node2lay.hxx |   47 +-
 sw/source/core/inc/pagefrm.hxx  |   74 ++---
 5 files changed, 161 insertions(+), 146 deletions(-)

New commits:
commit 7c3f7016f1bcbc6b7c46de3420c4410700dae5cd
Author: Philipp Weissenbacher p.weissenbac...@gmail.com
Date:   Thu Oct 2 13:05:37 2014 +0200

fdo#39468 Start translating German comments in sw/source/core/inc

Change-Id: I77e61fb268188d7c26132b10d1308daf1bebc741
Reviewed-on: https://gerrit.libreoffice.org/11761
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com

diff --git a/sw/source/core/inc/layact.hxx b/sw/source/core/inc/layact.hxx
index 0c83a38..3d8d42c 100644
--- a/sw/source/core/inc/layact.hxx
+++ b/sw/source/core/inc/layact.hxx
@@ -31,63 +31,59 @@ class SwViewImp;
 class SwCntntNode;
 class SwWait;
 
-// The usage of LayAction is always the same:
-
-// 1. Generation of the LayAction object.
-// 2. Specifying the wanted bahaviour via the Set-methods
-// 3. Calling Action()
-// 4. Soon after that the destruction of the object
-
-// Das Objekt meldet sich im CTor beim SwViewImp an und erst im DTor
-// wieder ab! Es handelt sich mithin um ein typisches Stackobjekt.
-
+/**
+ * The usage of LayAction is always the same:
+ *
+ * 1. Generation of the LayAction object.
+ * 2. Specifying the wanted behaviour via the Set-methods
+ * 3. Calling Action()
+ * 4. Soon after that the destruction of the object
+ *
+ * The object registers at the SwViewImp in the ctor and deregisters not until
+ * the dtor!
+ * It's a typical stack object.
+ */
 class SwLayAction
 {
 SwRootFrm  *pRoot;
-SwViewImp  *pImp;   // here the action logs in and off
+SwViewImp  *pImp; // here the action logs in and off
 
-// for the sake of optimization, so that the tables stick a bit better to 
the Crsr
-// when hitting return/backspace in front of one
-// Wenn der erste TabFrm, der sich Paintet (pro Seite) traegt sich im
-// Pointer ein. Die CntntFrms unterhalb der Seite brauchen sich
-// dann nicht mehr bei der Shell zum Painten anmelden.
+// For the sake of optimization, so that the tables stick a bit better to
+// the Crsr when hitting return/backspace in front of one.
+// The first TabFrm that paints itself (per page) adds itself to the 
pointer.
+// The CntntFrms beneath the page do not need to deregister at the Shell 
for
+// painting.
 const SwTabFrm *pOptTab;
 
 SwWait *pWait;
 
-//Wenn ein Absatz - oder was auch immer - bei der Formatierung mehr
-//als eine Seite rueckwaerts floss traegt er seine neue Seitennummer
-//hier ein. Die Steuerung der InternalAction kann dann geeignet reagieren.
+// If a paragraph (or anything else) moved more than one page when
+// formatting, it adds its new page number here.
+// The InternalAction can then take the appropriate steps.
 sal_uInt16 nPreInvaPage;
 
-sal_uLong nStartTicks;  //Startzeitpunkt der Aktion, vergeht zu viel Zeit 
kann
-//der WaitCrsr per CheckWaitCrsr() eingeschaltet 
werden.
-
-sal_uInt16 nInputType;  //Bei welchem Input soll die Verarbeitung 
abgebrochen
-//werden?
-sal_uInt16 nEndPage;//StatBar control
-sal_uInt16 nCheckPageNum; //CheckPageDesc() was delayed if != USHRT_MAX
-  // check from this page on
-
-bool bPaint;// painting or only formatting?
-bool bComplete; //Alles bis zum sichtbaren Bereich Formatieren oder
-// or only the visible area?
-bool bCalcLayout;   //Vollstaendige Reformatierung?
-bool bAgain;//Zur automatisch wiederholten Action wenn Seiten
-//geloscht werden.
-bool bNextCycle;//Wiederaufsetzen bei der ersten Ungueltigen Seite.
-bool bInput;//Zum Abbrechen der Verarbeitung wenn ein Input 
anliegt.
-bool bIdle; //True wenn die Layaction vom Idler ausgeloest wurde.
-bool bReschedule;   //Soll das Reschedule - abhaengig vom Progress -
-//gerufen werden?
-bool bCheckPages;   //CheckPageDescs() ausfuehren oder verzoegern.
-bool bUpdateExpFlds;//Wird gesetzt wenn nach dem Formatierien noch eine
-//Runde fuer den ExpFld laufen muss.
-bool bBrowseActionStop; //Action fruehzeitig beenden (per bInput) und den
-//Rest dem Idler ueberlassen.
-bool bWaitAllowed;  //Wartecursor erlaubt?
-bool bPaintExtraData;   //Anzeige von Zeilennumerierung o. ae. 
eingeschaltet?
-bool bActionInProgress; // wird in Action() anfangs gesetzt und zum 
Schluss geloescht
+sal_uLong nStartTicks;  // The Action's starting time; if too

[Libreoffice-commits] core.git: Changes to 'refs/changes/57/4657/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/24/5224/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/80/880/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/52/5752/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/80/880/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/61/4361/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/75/10475/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/85/7885/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/2796/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/23/5223/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/16/2916/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/57/3057/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/65/4365/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/61/4361/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/16/2916/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/39/2539/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/49/11649/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/23/5223/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/07/7/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/74/7574/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/9831/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/75/10475/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/49/11649/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/11622/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/57/3057/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/65/4365/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/39/2539/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/6631/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/2796/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/39/2539/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/6631/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/85/7885/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/91/2691/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/6631/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/11622/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/02/2/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/02/2/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/68/1568/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/74/7574/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/11622/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/07/7/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/40/2540/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/63/9263/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/68/1568/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/63/9263/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/24/11524/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/41/2541/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/47/4747/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/02/902/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/06/6/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/91/2691/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/79/879/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/19/4319/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/36/6136/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/53/7753/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/40/2540/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/04/9304/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/47/4747/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/04/9304/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/99/899/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/19/4319/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/41/2541/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/11522/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/03/11103/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/10/10/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/04/5304/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/54/954/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/94/3294/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/4322/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/4331/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/74/10474/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/20/4320/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/71/6671/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/4331/3'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/03/11103/1'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/71/6671/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/51/10151/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/53/7753/2'

[Philipp Weissenbacher]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits