++
target/s390x/helper.c | 3 +--
target/s390x/kvm/kvm.c | 6 ++
target/s390x/tcg/excp_helper.c | 11 +++
target/s390x/tcg/translate.c | 3 +--
6 files changed, 10 insertions(+), 22 deletions(-)
Reviewed-by: Thomas Huth
| 6 ++
target/m68k/helper.c| 3 +--
target/m68k/m68k-semi.c | 6 ++
target/m68k/op_helper.c | 11 +++
target/m68k/translate.c | 3 +--
6 files changed, 19 insertions(+), 40 deletions(-)
Reviewed-by: Thomas Huth
vel--;
return;
}
insn = read_dword(s, s->dsp);
Reviewed-by: Thomas Huth
On 25/01/2024 17.56, Philippe Mathieu-Daudé wrote:
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hvf/vmx.h | 9 +++
hw/i386/vmmouse.c
On 25/01/2024 17.56, Philippe Mathieu-Daudé wrote:
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hvf/vmx.h | 9 +++
hw/i386/vmmouse.c
On 26/01/2024 11.44, Philippe Mathieu-Daudé wrote:
Hi Thomas,
On 26/1/24 09:39, Thomas Huth wrote:
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 292
On 25/01/2024 01.38, Jason Wang wrote:
On Wed, Jan 24, 2024 at 9:14 PM David Woodhouse wrote:
Hi Jason,
I think this series probably lives or dies with you. I think it's a
worthwhile cleanup, but I no longer have an immediate need for it; I
shipped a slightly ugly workaround in QEMU 8.2.
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
These old functions can be removed now too. Let net_param_nic() print
the full set of network devices directly, and also make it note that a
list more specific to this platform/config will be available by using
'-nic model=help'
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
These old functions can be removed now too. Let net_param_nic() print
the full set of network devices directly, and also make it note that a
list more specific to this platform/config will be available by using
'-nic model=help'
IVE_ENDIAN);
Reviewed-by: Thomas Huth
qdev_set_nic_properties(DEVICE(>gem), nd);
-}
+qemu_configure_nic_device(DEVICE(>gem), true, NULL);
object_property_set_int(OBJECT(>gem), "revision", GEM_REVISION,
_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(>gem), errp)) {
Reviewed-by: Thomas Huth
im_memmap[OR1KSIM_ETHOC].size,
+ smp_cpus, cpus,
+ OR1KSIM_ETHOC_IRQ);
if (smp_cpus > 1) {
openrisc_sim_ompic_init(state, or1ksim_memmap[OR1KSIM_OMPIC].base,
Reviewed-by: Thomas Huth
prefix */
Reviewed-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Extract the MAC address from the NICInfo, or generate one explicitly if
there was no corresponding NIC configuration, to put it in the PROM.
Uh, I don't see any MAC handling in the patch below? Is this the right
comment for
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1225187
Title:
qemu hangs in windows 7 host with -serial pipe:windbg
Status in QEMU:
Invalid
Bug
uot;qapi/error.h"
-DeviceState *etraxfs_eth_init(NICInfo *nd, hwaddr base, int phyaddr,
+DeviceState *etraxfs_eth_init(hwaddr base, int phyaddr,
struct etraxfs_dma_client *dma_out,
struct etraxfs_dma_client *dma_in);
Reviewed-by: Thomas Huth
MIPS CPU INT0, which is interrupt 2. */
-mipsnet_init(0x4200, env->irq[2], _table[0]);
+/* MIPSnet uses the MIPS CPU INT0, which is interrupt 2. */
+mipsnet_init(0x4200, env->irq[2]);
}
static void mips_mipssim_machine_init(MachineClass *mc)
Reviewed-by: Thomas Huth
MIPS CPU INT0, which is interrupt 2. */
-mipsnet_init(0x4200, env->irq[2], _table[0]);
+/* MIPSnet uses the MIPS CPU INT0, which is interrupt 2. */
+mipsnet_init(0x4200, env->irq[2]);
}
static void mips_mipssim_machine_init(MachineClass *mc)
Reviewed-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add: "Also remove the leftover definition of host_net_devices which
has been forgotten to be removed in commit 7cc28cb061040cb089." (or so)
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add: "Also remove the leftover definition of host_net_devices which
has been forgotten to be removed in commit 7cc28cb061040cb089." (or so)
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David
-by: Thomas Huth
-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add a short patch description à la "All callers have been converted
in the previous patches, so this is not required anymore".
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
i
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add a short patch description à la "All callers have been converted
in the previous patches, so this is not required anymore".
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
i
qdev_prop_set_uint32(dev, "tx-ping-pong", 0);
qdev_prop_set_uint32(dev, "rx-ping-pong", 0);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), _fatal);
Reviewed-by: Thomas Huth
qdev_prop_set_uint32(dev, "tx-ping-pong", 0);
qdev_prop_set_uint32(dev, "rx-ping-pong", 0);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), _fatal);
Reviewed-by: Thomas Huth
ort("Too many NICs");
-exit(1);
-}
I wonder whether we'd need a different mechanism to specify the maximum
amount of on-board NICs now... Anyway, we can also think of that later, so:
Reviewed-by: Thomas Huth
ort("Too many NICs");
-exit(1);
-}
I wonder whether we'd need a different mechanism to specify the maximum
amount of on-board NICs now... Anyway, we can also think of that later, so:
Reviewed-by: Thomas Huth
;);
-qdev_set_nic_properties(dev, _table[1]);
+dev = qemu_create_nic_device("xgmac", true, NULL);
+if (dev) {
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), _fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xfff51000);
sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic[80]);
Reviewed-by: Thomas Huth
LUE_H
#define HW_Q800_GLUE_H
-#include "qemu/osdep.h"
#include "hw/sysbus.h"
#define TYPE_GLUE "q800-glue"
Reviewed-by: Thomas Huth
ics; i++) {
-if (!enable_lasi_lan()) {
-pci_nic_init_nofail(_table[i], pci_bus, mc->default_nic, NULL);
-}
+if (!enable_lasi_lan()) {
+pci_init_nic_devices(pci_bus, mc->default_nic);
}
/* BMC board: HP Powerbar SP2 Diva (with console only) */
Reviewed-by: Thomas Huth
mc->default_nic, NULL);
-}
+pci_init_nic_devices(pci->bus, mc->default_nic);
}
nodename = vms->pciehb_nodename = g_strdup_printf("/pcie@%" PRIx64, base);
Reviewed-by: Thomas Huth
, NULL);
-}
+pci_init_nic_devices(pci_bus, mc->default_nic);
/* Super I/O */
isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO);
Reviewed-by: Thomas Huth
es(dev, nd);
+qemu_configure_nic_device(dev, true, NULL);
Wouldn't it be possible to use qemu_create_nic_device() here, too?
Anyway:
Reviewed-by: Thomas Huth
s = SYS_BUS_DEVICE(dev);
sysbus_realize_and_unref(s, _fatal);
sysbus_mmio_map(s, 0, base);
eth[i]), "tx-ring-num",
FSL_IMX7_ETH_NUM_TX_RINGS, _abort);
-qdev_set_nic_properties(DEVICE(>eth[i]), _table[i]);
+qemu_configure_nic_device(DEVICE(>eth[i]), true, NULL);
sysbus_realize(SYS_BUS_DEVICE(>eth[i]), _abort);
_and_unref(s, _fatal);
Reviewed-by: Thomas Huth
0_GIC_SPI_GMAC));
/* EMAC */
+qemu_configure_nic_device(DEVICE(>emac), true, "emac");
sysbus_realize(SYS_BUS_DEVICE(>emac), _fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(>emac), 0, s->memmap[AW_R40_DEV_EMAC]);
sysbus_connect_irq(SYS_BUS_DEVICE(>emac), 0,
Reviewed-by: Thomas Huth
lt_nic, NULL);
-}
+pci_init_nic_devices(pci->bus, mc->default_nic);
}
}
Reviewed-by: Thomas Huth
want more).
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
include/net/net.h | 3 +++
net/net.c | 53 +++
2 files changed, 56 insertions(+)
Reviewed-by: Thomas Huth
want more).
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
include/net/net.h | 3 +++
net/net.c | 53 +++
2 files changed, 56 insertions(+)
Reviewed-by: Thomas Huth
On 26/01/2024 15.34, David Woodhouse wrote:
On Fri, 2024-01-26 at 15:24 +0100, Thomas Huth wrote:
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+D
On 26/01/2024 15.34, David Woodhouse wrote:
On Fri, 2024-01-26 at 15:24 +0100, Thomas Huth wrote:
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+D
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
By noting the models for which a configuration was requested, we can give
the user an accurate list of which NIC models were actually available on
the platform/configuration that was otherwise chosen.
Signed-off-by: David
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
By noting the models for which a configuration was requested, we can give
the user an accurate list of which NIC models were actually available on
the platform/configuration that was otherwise chosen.
Signed-off-by: David
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+DeviceState *qemu_create_nic_device(const char *typename, bool match_default,
+
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+DeviceState *qemu_create_nic_device(const char *typename, bool match_default,
+
CAddr));
+onboard_nic = true;
}
+pci_init_nic_devices(pci_busB, mc->default_nic);
/* If we don't have an onboard NIC, grab a default MAC address so that
* we have a valid machine id */
Reviewed-by: Thomas Huth
ault_nic);
}
/* Load kernel. */
Reviewed-by: Thomas Huth
", true, "ibmveth"))) {
+spapr_vlan_create(spapr->vio_bus, nd);
}
+pci_init_nic_devices(phb->bus, NULL);
+
for (i = 0; i <= drive_get_max_bus(IF_SCSI); i++) {
spapr_vscsi_create(spapr->vio_bus);
}
Reviewed-by: Thomas Huth
ices(pci_bus, mc->default_nic);
}
/* Prepare firmware configuration for OpenBIOS */
Fine for me ... Hervé, could you maybe comment from a 40p point of view, too?
Reviewed-by: Thomas Huth
fail(_table[i], pci_bus, mc->default_nic, NULL);
-}
+pci_init_nic_devices(pci_bus, mc->default_nic);
}
static void mips_loongson3_virt_init(MachineState *machine)
Reviewed-by: Thomas Huth
fail(_table[i], pci_bus, mc->default_nic, NULL);
-}
+pci_init_nic_devices(pci_bus, mc->default_nic);
}
static void mips_loongson3_virt_init(MachineState *machine)
Reviewed-by: Thomas Huth
nd, pci_bus, "pcnet", default_devaddr);
-}
+/* The malta board has a PCNet card using PCI SLOT 11 */
+pci_init_nic_in_slot(pci_bus, "pcnet", NULL, "0b");
+ pci_init_nic_devices(pci_bus, "pcnet");
}
Reviewed-by: Thomas Huth
Philippe, could you maybe have a look at this, too?
nd, pci_bus, "pcnet", default_devaddr);
-}
+/* The malta board has a PCNet card using PCI SLOT 11 */
+pci_init_nic_in_slot(pci_bus, "pcnet", NULL, "0b");
+ pci_init_nic_devices(pci_bus, "pcnet");
}
Reviewed-by: Thomas Huth
Philippe, could you maybe have a look at this, too?
and the rest
will be dynamically assigned.
Sounds fine for me ... Philippe, what do you think?
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
hw/mips/fuloong2e.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips
and the rest
will be dynamically assigned.
Sounds fine for me ... Philippe, what do you think?
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
hw/mips/fuloong2e.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips
On 26/01/2024 12.25, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:20 +0100, Thomas Huth wrote:
On 26/01/2024 12.13, David Woodhouse wrote:
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote:
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access
On 26/01/2024 12.25, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:20 +0100, Thomas Huth wrote:
On 26/01/2024 12.13, David Woodhouse wrote:
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote:
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access
On 26/01/2024 12.13, David Woodhouse wrote:
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote:
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access to nd_table[] and nb_nics by processing the the
Xen and ISA NICs first and then calling
On 26/01/2024 12.13, David Woodhouse wrote:
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote:
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access to nd_table[] and nb_nics by processing the the
Xen and ISA NICs first and then calling
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Most code which directly accesses nd_table[] and nb_nics uses them for
one of two things. Either "I have created a NIC device and I'd like a
configuration for it", or "I will create a NIC device *if* there is a
configuration for
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Most code which directly accesses nd_table[] and nb_nics uses them for
one of two things. Either "I have created a NIC device and I'd like a
configuration for it", or "I will create a NIC device *if* there is a
configuration for
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access to nd_table[] and nb_nics by processing the the
Xen and ISA NICs first and then calling pci_init_nic_devices() for the
rest.
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
hw/i386/pc.c
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access to nd_table[] and nb_nics by processing the the
Xen and ISA NICs first and then calling pci_init_nic_devices() for the
rest.
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
hw/i386/pc.c
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 292 +
target/arm/tcg/cpu32.c | 261 -
target/arm/tcg
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require additional functions for linking. The
reduced set of the linux-user functions works fine as stubs in this
case, so change the #ifdef statement accordingly.
Signed-off-by: Thomas Huth
---
target
Now that we made sure that ARM_V7M code only gets compiled if really
needed, we can drop the hard requirement for CONFIG_ARM_V7M in the
Kconfig file.
Signed-off-by: Thomas Huth
---
target/arm/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git a/target/arm/Kconfig b/target/arm/Kconfig
onfig file.
Thomas Huth (3):
target/arm: Move v7m-related code from cpu32.c into a separate file
target/arm/tcg/m_helper.c: Include the full helpers only with
CONFIG_ARM_V7M
target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M
target/arm/tcg/cpu-v7m
--git a/meson.build b/meson.build
index d0329966f1b..385b8247073 100644
--- a/meson.build
+++ b/meson.build
@@ -601,6 +601,7 @@ warn_flags = [
'-Wno-psabi',
'-Wno-gnu-variable-sized-type-not-at-end',
'-Wshadow=local',
+ '-Wvla',
]
if host_os != 'darwin'
Reviewed-by: Thomas Huth
...)
Remove the VLA usage.
Signed-off-by: Peter Maydell
---
tests/qtest/xlnx-versal-trng-test.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth
even bump it to 60 seconds, just to be on the safe side.
Anyway:
Reviewed-by: Thomas Huth
even bump it to 60 seconds, just to be on the safe side.
Anyway:
Reviewed-by: Thomas Huth
On 25/01/2024 13.47, Ilya Leoshkevich wrote:
On Thu, 2024-01-18 at 18:28 +0100, Thomas Huth wrote:
On 15/01/2024 21.21, Ilya Leoshkevich wrote:
Hi,
Ido reported that we are missing the CVDG emulation (which is very
similar to the existing CVD emulation). This series adds it along
with a test
On 25/01/2024 12.04, Peter Maydell wrote:
On Thu, 25 Jan 2024 at 07:54, Paolo Bonzini wrote:
Right now configure contains a couple hacks to preserve some of the semantics
of the pre-meson build system:
1) emulation of ./configure by creating a build directory and a forwarding
GNUmakefile
and dc390 controllers, and everything still
works fine with your patches. Thus feel free to add:
Tested-by: Thomas Huth
com>
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Weil
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c | 97 ++
2 files changed, 11 insertions(+), 87 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu
ear what is going
on here.
Suggested-by: "Daniel P. Berrangé"
Message-ID: <20240122153347.71654-1-th...@redhat.com>
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
tests/unit/test-iov.c | 20 +++-
1 file changed, 11 insertions(+), 9 del
Thomas Huth (7):
tests/qtest: Bump timeout of the boot-serial-test to 360 seconds
tests/unit/test-iov: Fix timeout problem on NetBSD and OpenBSD
tests/qtest: Bump timeouts of boot_sector_test()-based tests to 610
seconds
182247.432642-4-th...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c | 70 --
2 files changed, 71 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index 899ce8
bump them
on the meson side to 610 seconds so that the tests themselves can
run with their internal 600 seconds timeout and have some additional
seconds on top for reporting the outcome.
Message-ID: <20240124084412.465638-1-th...@redhat.com>
Reviewed-by: "Daniel P. Berrangé"
Signe
Reviewed-by: "Daniel P. Berrangé"
Message-ID: <20240123182247.432642-3-th...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 2 -
util/uri.c | 689 -
2 files changed, 691 deletion
which should hopefully really be
high enough now.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2097
Message-ID: <20240123110353.30658-1-th...@redhat.com>
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 2 +-
1 file changed, 1
They are not used anywhere, so there's no need to keep them around.
Reviewed-by: Stefan Weil
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: "Daniel P. Berrangé"
Message-ID: <20240123182247.432642-5-th...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
bump them
on the meson side to 610 seconds so that the tests themselves can
run with their internal 600 seconds timeout and have some additional
seconds on top for reporting the outcome.
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 6 --
1 file changed, 4 insertions(+), 2
They are not used anywhere, so there's no need to keep them around.
Message-ID: <20240122191753.103118-6-th...@redhat.com>
Reviewed-by: Stefan Weil
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
util/uri.c | 13 -
They are not used anywhere, so there's no need to keep them around.
Message-ID: <20240122191753.103118-6-th...@redhat.com>
Reviewed-by: Stefan Weil
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
util/uri.c | 13 -
Now that uri_resolve_relative() has been removed, this function is not
used in QEMU anymore - and if somebody needs this functionality, they
can simply use g_uri_escape_string() from the glib instead.
Reviewed-by: Stefan Weil
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: T
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 2 -
util/uri.c | 689 -
2 files changed, 691 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index f0722b75da..899ce85
Now that uri_resolve_relative() has been removed, this function is not
used in QEMU anymore - and if somebody needs this functionality, they
can simply use g_uri_escape_string() from the glib instead.
Reviewed-by: Stefan Weil
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: T
()]
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c | 97 ++
2 files changed, 11 insertions(+), 87 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index 1855b764f2..f0722b75da 100644
--- a/include/qemu/uri.h
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 2 -
util/uri.c | 689 -
2 files changed, 691 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index f0722b75da..899ce85
()]
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c | 97 ++
2 files changed, 11 insertions(+), 87 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index 1855b764f2..f0722b75da 100644
--- a/include/qemu/uri.h
uri_string_unescape() with g_uri_unescape_segment(), so
we can remove uri_string_unescape() completely now
Thomas Huth (4):
util/uri: Remove uri_string_unescape()
util/uri: Remove unused functions uri_resolve() and
uri_resolve_relative()
util/uri: Remove the uri_string_escape() function
util
uri_string_unescape() with g_uri_unescape_segment(), so
we can remove uri_string_unescape() completely now
Thomas Huth (4):
util/uri: Remove uri_string_unescape()
util/uri: Remove unused functions uri_resolve() and
uri_resolve_relative()
util/uri: Remove the uri_string_escape() function
util
On 23/01/2024 17.50, Michael Tokarev wrote:
15.12.2023 10:03, Thomas Huth wrote:
This is a respin of Daniel's series that re-enables the meson test
runner timeouts. To make sure that we do not get into trouble on
older systems, I ran all the tests with "make check SPEED=slow -j32"
on
On 23/01/2024 11.25, Paolo Bonzini wrote:
Il lun 22 gen 2024, 20:18 Thomas Huth <mailto:th...@redhat.com>> ha scritto:
uri_string_unescape() basically does the same as the glib function
g_uri_unescape_string(), with just an additional length parameter.
You can replace it a
which should hopefully really be
high enough now.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2097
Signed-off-by: Thomas Huth
---
tests/qtest/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index d22434b14e
On 22/01/2024 21.59, Stefan Weil wrote:
Am 22.01.24 um 20:17 schrieb Thomas Huth:
It is not used in QEMU - and if somebody needs this functionality,
they can simply use g_uri_escape_string() from the glib instead.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c
On 22/01/2024 22.22, Stefan Weil wrote:
Am 22.01.24 um 20:17 schrieb Thomas Huth:
uri_string_unescape() basically does the same as the glib function
g_uri_unescape_string(), with just an additional length parameter.
So we can simplify this function a lot by limiting the length with
g_strndup
These rather complex functions have never been used since they've been
introduced in 2012, so looks like they are not really useful for QEMU.
And since the static normalize_uri_path() function is also only used by
uri_resolve(), we can remove that function now, too.
Signed-off-by: Thomas Huth
901 - 1000 of 20501 matches
Mail list logo
