[pve-devel] applied: [PATCH pve-flutter-frontend] node overview: power menu: reorder/reword confirm buttons

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 10:53 schrieb Dominik Csapak: > move the confirm action to the right as mentioned in the material spec[0] > also rewords the buttons to 'cancel' and 'shutdown/reboot' > for that to work properly slightly rename the confirm message > > 0: >

[pve-devel] applied: [PATCH v3 storage] fix insecure migration failing if waiting on lock

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 11:48 schrieb Mira Limbeck: > both STDOUT and STDERR are written into `$info` which is then parsed for > IP and port of the target socket listening. > when the ports file can't be locked immediately `trying to acquire > lock...` is printed on STDERR and in turn written into

[pve-devel] applied: [PATCH v5 manager 0/2] add edit window for device passthrough

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 10:44 schrieb Filip Schauer: > Changes since v4: > * Simplify cbind > * Fix selection of custom devid not being applied on creation in > onGetValues > > Changes since v3: > * Pass confid in via cbind instead of manually setting it in the view > model > * Check me.isCreate

Re: [pve-devel] [PATCH storage 1/9] copy OVF.pm from qemu-server

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 11:19 schrieb Fiona Ebner: > Am 16.04.24 um 17:02 schrieb Thomas Lamprecht: >> high-level nit: this, and most of the ESXi one, should go into another module >> name space, e.g. PVE::GuestImport:: (or if that's to long, or we really are >> sure >> that

[pve-devel] applied: [PATCH pve-flutter-frontend v2] node overview: add power settings menu

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 08:45 schrieb Dominik Csapak: > similar to how it works for qemu, but add a confirmation dialog > so one does not accidentally shutdown or reboot a node. > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * add an AlertDialog as confirmation before executing the action

Re: [pve-devel] [PATCH pve-flutter-frontend] update flutter_inappwebview to 6.0.0

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 10:41 schrieb Dominik Csapak: > only 2 changes for the URI necessary > as mentioned off-list I tried this already locally, so pushed that similar change out instead replacing this:

Re: [pve-devel] [PATCH installer v5 00/36] add automated/unattended installation

2024-04-16 Thread Thomas Lamprecht
Am 16/04/2024 um 17:32 schrieb Aaron Lauterer: > patches until 31 got a [0,1] > > Tested-by: Christoph Heiss > Reviewed-by: Christoph Heiss why don't these patches include above trailers then? ___ pve-devel mailing list

[pve-devel] applied: [PATCH flutter-repositories] some improvements/fixes for the app

2024-04-16 Thread Thomas Lamprecht
Am 15/04/2024 um 12:30 schrieb Dominik Csapak: > some improvements: > * better error handling for saving the password > * adding node power actions (shutdown/restart) > * change webview so we can show it without a trusted certificate > * improve back button behavior > > flutter-frontend patch 1

Re: [pve-devel] [PATCH pve-flutter-frontend 4/5] nove overview: add power settings menu

2024-04-16 Thread Thomas Lamprecht
Am 15/04/2024 um 12:30 schrieb Dominik Csapak: > similar to how it works for qemu the one for virtual guests is already borderline dangerous without having a confirmation prompt, but this one here is far from being borderline here IMO, as for guests one can at least start them for sure again

[pve-devel] applied: [PATCH proxmox-login-manager 1/2] login: show custom alert dialog for password saving errors

2024-04-16 Thread Thomas Lamprecht
Am 15/04/2024 um 12:30 schrieb Dominik Csapak: > in those cases, we sometimes get ugly stack traces/exceptions, so > instead of just showing that and aborting, show a custom dialog with > the basic info that we could not save the password (+details box with > the original error) and continue

[pve-devel] applied: [PATCH proxmox-dart-api-client 1/1] client: correctly set parameter for node actions

2024-04-16 Thread Thomas Lamprecht
Am 15/04/2024 um 12:30 schrieb Dominik Csapak: > using '?' in the url will be escaped and not used for the get > parameters. Instead add the command to the parameters map. > > Signed-off-by: Dominik Csapak > --- > lib/src/client.dart | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

[pve-devel] applied: [PATCH v2 proxmox-ve] apt hook: disable on remove

2024-04-16 Thread Thomas Lamprecht
Am 16/04/2024 um 14:32 schrieb Fabian Grünbichler: > and (re-)enable on install. adapted from apt-listbugs/apt-listchanges, which > solve the issue of removing (instead of purging) the conffile and hook binary > providing package in the same fashion. > > Suggested-by: Fiona Ebner >

Re: [pve-devel] [PATCH storage 1/9] copy OVF.pm from qemu-server

2024-04-16 Thread Thomas Lamprecht
Am 16/04/2024 um 15:18 schrieb Dominik Csapak: > copies the OVF.pm and relevant ovf tests from qemu-server. > We need it here, and it uses PVE::Storage already, and since there is no > intermediary package/repository we could put it, it seems fitting in > here. > > Signed-off-by: Dominik Csapak

[pve-devel] applied: [PATCH pve-flutter-frontend 0/9] small improvements

2024-04-16 Thread Thomas Lamprecht
Am 12/04/2024 um 10:04 schrieb Dominik Csapak: > a series of smaller improvements, noticed by rechecking the app > after updating to new dart/flutter version. > > not all of them have to be applied, most are rather independent. > e.g. use of the NavigationBar, and the icon of the warning task

Re: [pve-devel] [PATCH http-server] http: support Content-Encoding=deflate

2024-04-16 Thread Thomas Lamprecht
Am 16/04/2024 um 13:44 schrieb Maximiliano Sandoval: > Add support for compressing the body of responses with > `Content-Encoding=deflate` as per [RFC9110]. Note that in this context > `deflate` is actually a "zlib" data format as defined in [RFC1950]. > > [RFC9110]

Re: [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs

2024-04-16 Thread Thomas Lamprecht
Am 25/03/2024 um 15:09 schrieb Fiona Ebner: > Am 07.11.23 um 14:49 schrieb Fiona Ebner: >> Improve fallback for the 'performance' sub-properties by using a >> per-property fallback and honor schema defaults. >> >> Expose commonly used performance-related properties in the backup job >> UI under a

[pve-devel] applied: [PATCH pve-kernel] fix #5373: cherry-pick USB ethernet naming fix

2024-04-15 Thread Thomas Lamprecht
Am 12/04/2024 um 15:25 schrieb Fabian Grünbichler: > Signed-off-by: Fabian Grünbichler > --- > test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly > there (build hasn't finished yet ;)) > > I also assume this will be picked up fairly fast by stable point releases, but

[pve-devel] applied: [PATCH v2 pve-zsync] parse disks: improve error messages

2024-04-11 Thread Thomas Lamprecht
On 12/09/2023 14:29, Fiona Ebner wrote: > The one with the backup flag was reported in the community forum: > https://forum.proxmox.com/threads/77254/ > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * Further improve message as suggested by Sterzy. > > pve-zsync | 5 +++-- > 1

[pve-devel] partially-applied: [PATCH qemu v3 06/22] backup: add minimum cluster size to performance options

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > Useful to make discard-source work in the context of backup fleecing > when the fleecing image has a larger granularity than the backup > target. > > Backup/block-copy will use at least this granularity for copy operations > and in particular, discard

[pve-devel] applied: [PATCH guest-common v3 10/22] vzdump: schema: make storage for fleecing semi-optional

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > so it doesn't need to be set when explicitly disabling fleecing. Needs > a custom verifier to enforce it being set when enabled. > > Suggested-by: Fabian Grünbichler > Signed-off-by: Fiona Ebner > --- > src/PVE/VZDump/Common.pm | 14 +- > 1

Re: [pve-devel] [PATCH guest-common v3 10/22] vzdump: schema: make storage for fleecing semi-optional

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > so it doesn't need to be set when explicitly disabling fleecing. Needs > a custom verifier to enforce it being set when enabled. > > Suggested-by: Fabian Grünbichler > Signed-off-by: Fiona Ebner > --- > src/PVE/VZDump/Common.pm | 14 +- > 1

[pve-devel] applied: Re: [PATCH guest-common v3 09/22] vzdump: schema: add fleecing property string

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > It's a property string, because that avoids having an implicit > "enabled" as part of a 'fleecing-storage' property. And there likely > will be more options in the future, e.g. threshold/limit for the > fleecing image size. > > Storage is non-optional, so

[pve-devel] applied: [PATCH common v3 08/22] json schema: add format description for pve-storage-id standard option

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > so that the option can be used as part of a property string. > > Signed-off-by: Fiona Ebner > --- > src/PVE/JSONSchema.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing

Re: [pve-devel] [RFC qemu-server v3 17/22] parse config: allow config keys with minus sign

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 11:29, Fiona Ebner wrote: > In preparation for the upcoming 'fleecing-images' key. To avoid mixing > of options with - and options with _, which is not very user-friendly, > it would be nice to add aliases for existing options with _. And > long-term, backup restore handlers could

Re: [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 19:07, Alexander Zeidler wrote: > On Mon, 2024-03-25 at 08:52 +0100, Thomas Lamprecht wrote: >> journalctl --list-boots > > On slow servers / storage drives this execution can easily take 10 seconds > or longer. But there is an alternative that is quite f

Re: [pve-devel] [PATCH guest-common v2 2/5] mapping: pci: rework properties check

2024-04-11 Thread Thomas Lamprecht
On 10/04/2024 13:03, Dominik Csapak wrote: > refactors the actual checking out to its own sub, so we can reuse it > later > > Signed-off-by: Dominik Csapak > --- > src/PVE/Mapping/PCI.pm | 43 +- > 1 file changed, 26 insertions(+), 17 deletions(-) > >

[pve-devel] applied: Re: [PATCH guest-common v2 1/5] mapping: pci: fix missing description/default for mdev

2024-04-11 Thread Thomas Lamprecht
On 10/04/2024 13:03, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > src/PVE/Mapping/PCI.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied-series: [PATCH-SERIES v2 guest-common] replication improvements

2024-04-11 Thread Thomas Lamprecht
On 13/12/2023 15:17, Fiona Ebner wrote: > Improve error when finding a common base snapshot and fix the check if > a snapshot is needed by replication when there are volumes with > replicate setting turned off. > > First version: >

Re: [pve-devel] [PATCH manager v9 3/3] ui: machine: add viommu ComboBox

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 12:48, Markus Frank wrote: > Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a > VM. If i440fx is selected, a hint tells that q35 is required for Intel vIOMMU. > > The UI also needs to parse the new machine parameter as PropertyString. > > Signed-off-by: Markus

[pve-devel] applied: Re: [PATCH docs v9 2/3] add vIOMMU documentation

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 12:48, Markus Frank wrote: > Signed-off-by: Markus Frank > --- > qm-pci-passthrough.adoc | 50 + > qm.adoc | 1 + > 2 files changed, 51 insertions(+) > > applied, thanks! ___

[pve-devel] applied: Re: [PATCH qemu-server v9 1/3] fix #3784: config: Parameter for guest vIOMMU + test-cases

2024-04-11 Thread Thomas Lamprecht
On 11/04/2024 12:48, Markus Frank wrote: > vIOMMU enables the option to passthrough pci devices to L2 VMs > in L1 VMs via Nested Virtualisation and adds an extra isolation. > > Uses the new property-string from the "config: define machine schema > as property-string"-commit to add the viommu

Re: [pve-devel] [PATCH qemu-server v8 2/4] fix #3784: Parameter for guest vIOMMU + test-cases

2024-04-11 Thread Thomas Lamprecht
Am 24/01/2024 um 10:49 schrieb Markus Frank: > vIOMMU is the emulation of a hardware IOMMU within a virtual machine, > providing improved memory access control and security for virtualized I/O > devices. > vIOMMU also enables the option to passthrough pci devices to L2 VMs > in L1 VMs via Nested

[pve-devel] applied: [PATCH qemu-server v8 1/4] machine as property-string

2024-04-11 Thread Thomas Lamprecht
Am 24/01/2024 um 10:49 schrieb Markus Frank: > Convert the machine parameter to a property-string and use the > machine type as the default key for backward compatibility. > > Signed-off-by: Markus Frank > --- > PVE/API2/Qemu.pm | 9 +++-- > PVE/QemuConfig.pm | 3 ++- >

Re: [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

2024-04-11 Thread Thomas Lamprecht
Am 14/12/2023 um 11:26 schrieb Maximiliano Sandoval: > > Lukas Wagner writes: > >> - Switch order of 'mailto' and 'mailnotification' field >> - When mode is 'auto', disable 'mailtnotification' field >> - When mode is 'auto' and 'mailto' is empty, show >> hint that the notification

Re: [pve-devel] [RFC container/firewall/manager/proxmox-firewall/qemu-server 00/37] proxmox firewall nftables implementation

2024-04-11 Thread Thomas Lamprecht
Am 11/04/2024 um 07:21 schrieb Stefan Hanreich: >> Since `Command` is serializable anyway, we could have a nice test suite of >> firewall/VM config files and expected commands as JSON dumps. >> This will be tedious to setup at first, but will help to detect any unwanted >> regressions in the

[pve-devel] applied-series: [PATCH stable-7 qemu 1/2] update patches and submodule to QEMU stable 7.2.10

2024-04-10 Thread Thomas Lamprecht
Am 10/04/2024 um 15:13 schrieb Fiona Ebner: > Many stable fixes came in since the last bump, a few of which were > actually already present. Notable ones not yet present include a few > guest-triggerable assert fixes, some AHCI/IDE fixes (including the fix > for bug #2784), TGC fixes for i386 and

[pve-devel] applied: [PATCH qemu-server v2 1/2] fix #5363: cloudinit: make creation of scsi cloudinit discs possible again

2024-04-10 Thread Thomas Lamprecht
Am 10/04/2024 um 13:17 schrieb Hannes Duerr: > Upon obtaining the device type, a check is performed to determine if it > is a CD drive. It is important to note that Cloudinit drives are always > assigned as CD drives. If the drive has not yet been allocated, the test > will fail due to the unset

[pve-devel] applied: [PATCH kernel] add apparmor patch to fix recvmsg returning EINVAL

2024-04-10 Thread Thomas Lamprecht
Am 10/04/2024 um 14:17 schrieb Wolfgang Bumiller: > With apparmor 4, when recvmsg() calls are checked by the apparmor LSM > they will always return EINVAL. > This causes very weird issues when apparmor profiles are in use, and a > lot of networking issues in containers (which are always using >

[pve-devel] applied-series: [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins

2024-04-10 Thread Thomas Lamprecht
Am 14/12/2023 um 10:48 schrieb Lukas Wagner: > Deleting a built-in target/matcher does not remove it, but resets it > to its default settings. This was not really obvious from the UI. > This patch changes the 'Remove' button text based on the > selected target/matcher. If it is a built-in, the

[pve-devel] applied: [PATCH widget-toolkit v2] i18n: mark strings as translatable

2024-04-10 Thread Thomas Lamprecht
Am 07/12/2023 um 09:18 schrieb Maximiliano Sandoval: > Note that N/A is already translatable in other places. > > Signed-off-by: Maximiliano Sandoval > --- > Differences from v2: > - Translate the invalid subscription key message, this string is also in > two more places in pve-manager. This

Re: [pve-devel] [PATCH qemu-server 1/1] fix #5365: drive: add drive_is_cloudinit check to get_scsi_devicetype

2024-04-10 Thread Thomas Lamprecht
This is not bug #5365 [0] (which is about a ceph device class UX improvement) but #5363 [0]. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5365 [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5363 I mostly noticed because I had too loo what this is actually about, IMO the subject could be

[pve-devel] applied: [PATCH widget-toolkit v4] window: edit: avoid sharing custom config objects between subclasses

2024-04-10 Thread Thomas Lamprecht
constructor > that makes copies of `extraRequestParams` and `submitOptions`. This > ensures that any subclass instance modifies only its own copies, and > modifications do not leak to other subclass instances. > > Suggested-by: Stefan Sterz > Suggested-by: Thomas Lamprecht >

[pve-devel] applied: [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

2024-04-10 Thread Thomas Lamprecht
Am 16/10/2023 um 18:28 schrieb Stefan Sterz: > some icons intentionally use black as their color in the light theme. > this includes the little pencil and check mark icon in the acme > overview. change their color to the regular dark-mode icon-color. for > this to work the filter inversion needed

Re: [pve-devel] [PATCH pve-storage] esxi: add mapping for windows server 2016/2019

2024-04-10 Thread Thomas Lamprecht
Am 09/04/2024 um 12:56 schrieb Stefan Sterz: > previously these were mapped to the linux 2.6 default > > Signed-off-by: Stefan Sterz > --- > src/PVE/Storage/ESXiPlugin.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm >

Re: [pve-devel] [PATCH manager] Revert "ui: dc: remove notify key from datacenter option view"

2024-04-09 Thread Thomas Lamprecht
Am 09/02/2024 um 11:16 schrieb Lukas Wagner: > This reverts commit c81bca2d28744616098448b81fa58e133d3ac5ed. > > In the first iteration of the notification system, notification > routing and enabling/disabling notifications was configured via > the (extended) `notify` parameter in

[pve-devel] applied: [PATCH installer] run env: use default error message if country detection failed with empty string

2024-04-08 Thread Thomas Lamprecht
Am 26/03/2024 um 14:29 schrieb Christoph Heiss: > Bit of perl fun again. > $err from detect_country_tracing_to() can be empty string under certain > circumstances (according to a forum post [0]). The // operator > evaluates an empty as true, thus `warn` receives an empty string to and > just

[pve-devel] applied: [PATCH common] docs: add missing prefix

2024-04-08 Thread Thomas Lamprecht
Am 27/03/2024 um 14:09 schrieb Folke Gleumes: > include 'PVEAPIToken=' prefix in the example for target-endpoint which > is mainly used for remote migrations. > > Signed-off-by: Folke Gleumes > --- > src/PVE/JSONSchema.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied,

[pve-devel] applied: [PATCH pve-manager v2] sdn: evpn: allow empty primary exit node in zone form

2024-04-08 Thread Thomas Lamprecht
Am 22/02/2024 um 17:40 schrieb Stefan Hanreich: > its broken since the change in semantics of the PUT endpoint [1] > > [1] > https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852 > > Signed-off-by: Stefan Hanreich > Originally-by: Alexandre Derumier >

[pve-devel] applied: [PATCH v3 pve-network 00/12] SDN: Testing VNets as a blackbox and fixing found bugs

2024-04-08 Thread Thomas Lamprecht
Am 05/04/2024 um 15:17 schrieb Stefan Lendl: > This add several tests for SDN VNets. > State setup as well as testing results is done only via the API to test on the > API boundaries and not against the internal state. Internal state and config > files are mocked to avoid requiring access to

[pve-devel] applied: [PATCH] fix #4835: order zfs-import@ before -cache/-scan

2024-04-08 Thread Thomas Lamprecht
Am 28/03/2024 um 10:41 schrieb Fabian Grünbichler: > this should fix failures of the template instances because either of the two > other import services picked up the pool in question first. > > Signed-off-by: Fabian Grünbichler > --- > ...dd-systemd-unit-for-importing-specific-pools.patch |

[pve-devel] applied: [PATCH ksm-control-daemon] ksmtuned: use PSS instead of RSZ for caluculating memory usage

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 15:25 schrieb Stefan Lendl: > PSS properly accounts for memory usage of shared libraries and is > therefore better suited when summing up memory usage of multiple > processes. > > Signed-off-by: Stefan Lendl > --- > debian/patches/series | 1 + >

Re: [pve-devel] [PATCH qemu-server v3] QEMU AMD SEV enable

2024-04-08 Thread Thomas Lamprecht
Am 09/12/2022 um 15:25 schrieb Markus Frank: > This Patch is for enabling AMD SEV (Secure Encrypted > Virtualization) support in QEMU > > VM-Config-Examples: > amd_sev: type=std,nodbg=1,noks=1 > amd_sev: es,nodbg=1,kernel-hashes=1 > > Node-Config-Example (gets generated automatically): >

[pve-devel] applied: [PATCH v2 ksm-control-daemon 1/2] ksmtuned: revert to use rsz instead of vsz to compute memory usage

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 14:17 schrieb Stefan Lendl: > For summing up actual memory usage of precesses rsz is more suitable > then vsz. > > This reverts commit cd5cf20cc8af53427dcb9b08486c68f376ce8743. > > Signed-off-by: Stefan Lendl > --- > debian/patches/series | 1 - >

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 12:36 schrieb Stefan Sterz: > On Mon Apr 8, 2024 at 11:30 AM CEST, Friedrich Weber wrote: >> +constructor: function(conf) { >> +let me = this; >> +// make copies in order to prevent subclasses from accidentally writing >> +// to objects that are shared with other

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 14:04 schrieb Stefan Lendl: > I agree summing up processes it would make sense to use PSS. > Unfortunately, ps does not report the PSS. The `ps` from the Debian Bookworm version of the `procps` package does report it here if I use something like `ps -C kvm -o pss` though, FWICT

Re: [pve-devel] [PATCH container v2 3/6] fix #4474: lxc api: add overrule-shutdown parameter to stop endpoint

2024-04-06 Thread Thomas Lamprecht
Am 30/01/2024 um 18:10 schrieb Friedrich Weber: > The new `overrule-shutdown` parameter is boolean and defaults to 0. If > it is 1, all active `vzshutdown` tasks by the current user for the same > CT are aborted before attempting to stop the CT. > > Passing `overrule-shutdown=1` is forbidden for

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-06 Thread Thomas Lamprecht
Am 05/04/2024 um 15:13 schrieb Friedrich Weber: > On 04/04/2024 17:20, Thomas Lamprecht wrote: >> Or does it even make sense to check this at all? >> As long as the user has the rights to execute a stop they probably >> should also be able to force it at any time,

[pve-devel] applied: [PATCH pve-kernel] revert 2 changes in thermal driver causing an early kernel Oops.

2024-04-05 Thread Thomas Lamprecht
Am 05/04/2024 um 11:27 schrieb Stoiko Ivanov: > The second patch, that is reverted (first): > `thermal: trip: Drop lockdep assertion from thermal_zone_trip_id()` > only touches code introduced by the first patch. > The first patch causes the following Oops (reproduced on an old > HP DL380 G8): >

[pve-devel] applied: [PATCH container v2 2/6] api: status: move config locking from API handler into worker

2024-04-04 Thread Thomas Lamprecht
Am 30/01/2024 um 18:10 schrieb Friedrich Weber: > Previously, container start/stop/shutdown/suspend would try to acquire > the config lock in the API handler prior to forking a worker. If the > lock was currently held elsewhere, this would block the API handler > and thus the pvedaemon worker

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-04 Thread Thomas Lamprecht
Am 30/01/2024 um 18:10 schrieb Friedrich Weber: Maybe start of with "Add a helper to abort all tasks from a specific (type, user, vmid) tuple. It will be used ... > This helper is used to abort any active qmshutdown/vzshutdown tasks > before attempting to stop a VM/CT (if requested). > >

[pve-devel] applied: [PATCH proxmox] notify: fix #5274: also set 'X-Gotify-Key' header for authentication

2024-04-04 Thread Thomas Lamprecht
Am 03/04/2024 um 10:08 schrieb Lukas Wagner: > Versions of Gotify < 2.2.0 only supported the 'X-Gotify-Key' header > for passing the API token. This comment sets this header in addition > to the regular 'Authorization' header in order to be compatible with > older Gotify servers. > >

[pve-devel] applied-series: [PATCH v3 pve-network 0/5] SDN: Add mocking to run tests in sbuild

2024-04-04 Thread Thomas Lamprecht
Am 02/04/2024 um 13:07 schrieb Stefan Lendl: > Extract and mock functions that otherwise access system files which is not > possible in a clean sbuild environment. > Namely /etc/network/interfaces as well as /etc/frr/frr.config.local > Added .gitignore for sbuild artifacts > > Changes v2 -> v3: >

[pve-devel] applied: [PATCH installer] html: pbs: fix missing in template after feature list

2024-04-04 Thread Thomas Lamprecht
Am 03/04/2024 um 12:45 schrieb Christoph Heiss: > This adds an empty line between the feature list and the "more > information" paragraph, which looks a lot better. > > The exact same is already present in the HTML template for both other > products, probably a simple oversight. > >

[pve-devel] applied: [PATCH pve-kernel] revert cifs backport to 6.1 added between 6.5.13-1 and 6.5.13-2

2024-04-04 Thread Thomas Lamprecht
Am 03/04/2024 um 13:46 schrieb Stoiko Ivanov: > copying files within a cifs-share currently result in the following > trace: > ``` > [ 495.388739] BUG: unable to handle page fault for address: fffe > [ 495.388744] #PF: supervisor read access in kernel mode > [ 495.388746] #PF:

Re: [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params

2024-04-04 Thread Thomas Lamprecht
Am 04/04/2024 um 12:10 schrieb Friedrich Weber: > Maybe we could do: > > ```js > extraRequestParams: {}, > > constructor: function(conf) { > let me = this; > me.extraRequestParams = Ext.clone(me.extraRequestParams); > me.initConfig(conf); > me.callParent();

Re: [pve-devel] [PATCH manager v15 1/2] add clipboard comboBox to VM Options

2024-04-04 Thread Thomas Lamprecht
subject should be more in the style of: ui: qemu: add clipboard selector to options Am 21/11/2023 um 13:39 schrieb Markus Frank: > For SPICE and VNC, a different message is displayed. > possibly reference the backend work here, > Save config in DisplayEdit so that the clipboard setting

[pve-devel] applied: [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-29 Thread Thomas Lamprecht
Am 20/03/2024 um 09:56 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pve-system-requirements.adoc | 2 ++ > 1 file changed, 2 insertions(+) > > applied this one, thanks! It's correct and avoids duplicate use of "recommend" ___

[pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-28 Thread Thomas Lamprecht
Am 26/03/2024 um 10:16 schrieb Christian Ebner: > For certain network setups the default values currently used to send > a wake on lan magic packet are not correct, e.g. it will get send via > the interface for which the default gateway is configured. > > This patches add optional configuration

[pve-devel] applied: [PATCH docs] installation: add serial console grub entry

2024-03-27 Thread Thomas Lamprecht
Am 23/02/2024 um 13:06 schrieb Christoph Heiss: > This was added with the 8.1 release ISO, so mention it in the > documentation too. > > Signed-off-by: Christoph Heiss > --- > pve-installation.adoc | 7 +++ > 1 file changed, 7 insertions(+) > > applied, thanks!

[pve-devel] applied: [PATCH docs v2] installation: reword `nomodeset` section a bit, add link to it

2024-03-27 Thread Thomas Lamprecht
Am 26/02/2024 um 18:59 schrieb Christoph Heiss: > The `nomodeset` section needs some massaging due to the text flow being > broken a bit. While at it, link to it above at the 'Terminal UI' > bootloader tip such that readers can find it more easily. > > Suggested-by: Alexander Zeidler >

Re: [pve-devel] [PATCH docs v2] installation: reword `nomodeset` section a bit, add link to it

2024-03-27 Thread Thomas Lamprecht
Am 26/02/2024 um 18:59 schrieb Christoph Heiss: > The `nomodeset` section needs some massaging due to the text flow being > broken a bit. While at it, link to it above at the 'Terminal UI' > bootloader tip such that readers can find it more easily. > > Suggested-by: Alexander Zeidler >

[pve-devel] applied-series: [PATCH docs] local-zfs: mention `zfs_arc_max` clamping by the installer

2024-03-27 Thread Thomas Lamprecht
Am 05/03/2024 um 13:13 schrieb Christoph Heiss: > This was forgotten to be updated when it changed it the installer and > now reported in the forum [0] that the docs are a bit outdated in this > regard. > > [0] > https://forum.proxmox.com/threads/hat-proxmox-8-neue-zfs_arc_max-settings.142754/ >

Re: [pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique

2024-03-27 Thread Thomas Lamprecht
Am 27/03/2024 um 11:32 schrieb Aaron Lauterer: > I did choose the 'labelWidth' and 'fieldLabel' to match the look and > feel of the 'Prepare for Virtio-SCSI" checkbox further up for > consistency though. > > Maybe we want to change that back? No, those are separate grids, it's fine to not have

[pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique

2024-03-27 Thread Thomas Lamprecht
Am 26/03/2024 um 14:25 schrieb Aaron Lauterer: > by adding a new checkbox and render the grid accordingly. > > If unique MAC addresses are enabled, set them to undefined when getting > the values from the grid. > > Signed-off-by: Aaron Lauterer > --- > not sure if setting `uniqueMac` directly

[pve-devel] applied: [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-27 Thread Thomas Lamprecht
Am 26/03/2024 um 13:04 schrieb Aaron Lauterer: > static -> defined manually > generated -> by ESXi > vpx -> generated by vCenter > > Signed-off-by: Aaron Lauterer > --- > src/PVE/Storage/ESXiPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

Re: [pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Thomas Lamprecht
Am 26/03/2024 um 12:03 schrieb Aaron Lauterer: > static -> defined manually > generated -> by ESXi > vpx -> generated by vCenter nice! > Signed-off-by: Aaron Lauterer > --- > src/PVE/Storage/ESXiPlugin.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[pve-devel] applied: [PATCH cluster] datacenter config: mark notification settings as deprecated/unused

2024-03-25 Thread Thomas Lamprecht
Am 19/01/2024 um 11:30 schrieb Lukas Wagner: > These were part of the first version of the notification overhaul > which was already rolled out in pvetest. To avoid breakage for users > who may have used the version from pvetest, we do not remove them yet > and only mark them as unused or

[pve-devel] applied: [PATCH docs] installation: update link to installing on top of Debian to bookworm version

2024-03-25 Thread Thomas Lamprecht
Am 22/03/2024 um 12:11 schrieb Christoph Heiss: > Seems this just was forgotten, Buster is quite old at this point. > > Signed-off-by: Christoph Heiss > --- > pve-installation.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

Re: [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > * list availability and installation status of `*microcode` packages > * grep for applied "Early OS Microcode Updates" > * grep for (un)patched CPU vulnerability messages > > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 2 ++ > 1 file

Re: [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > like on this system: > > # dmidecode -t bios > # dmidecode 3.4 > Getting SMBIOS data from sysfs. > SMBIOS 3.0.0 present. > > Handle 0x, DMI type 0, 24 bytes > > Handle 0x005C, DMI type 13, 22 bytes The manual page here states that this

Re: [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections

2024-03-25 Thread Thomas Lamprecht
And why are those more appropriate? Both fit's the general "always important" section, so even though they fit the section you moved them too, they also fit the general one, so some actual reasoning here would be good.. On 22/03/2024 14:59, Alexander Zeidler wrote: > Signed-off-by: Alexander

Re: [pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug related network/load/backup/etc issues

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > Suggested-by: Friedrich Weber > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index d4191769..6014f13e 100644 > --- a/PVE/Report.pm > +++

Re: [pve-devel] [PATCH manager 3/9] report: add list of upgradable packages

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > * to easily see if APT already knows about old packages in use and > their exact version > * to reconsider asking for applying updates as a first recommendation > if the list is empty and no updates have been released very recently > > # apt

Re: [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > While using `/proc/cmdline` would already provide an initial info for > debugging passthrough and similar, the use of `dmesg` is an easy way > to get the boot date as an absolute value for free (additional to the > relative value in `uptime` from

[pve-devel] applied: Re: [PATCH cluster] ssh: default to 4096 bit keys when generating

2024-03-25 Thread Thomas Lamprecht
On 21/12/2023 10:46, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > src/PVE/Cluster/Setup.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, (but was a bit to quick with the push before adding Fiona's R-b & T-b, they are still much appreciated)

[pve-devel] applied: [PATCH storage] zfs: fix duplicate word typo in error message

2024-03-22 Thread Thomas Lamprecht
On 30/01/2024 10:11, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > src/PVE/Storage/ZFSPoolPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied (since a while already), thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH installer] build: run shellcheck as part of `test` step

2024-03-22 Thread Thomas Lamprecht
On 15/03/2024 11:23, Christoph Heiss wrote: > Especially unconfigured.sh is worth checking consistently. > > Running shellcheck also does not really have any notable impact on build > time, so no downside there either. > > Signed-off-by: Christoph Heiss > --- > Makefile| 14

[pve-devel] applied: [PATCH installer] unconfigured: move terminal size setting before starting debug shell

2024-03-22 Thread Thomas Lamprecht
On 12/03/2024 12:59, Christoph Heiss wrote: > Otherwise, when using the serial debug shell, the console size will be > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > properly. > > It also adjust the size to the proper 80x24 instead of 80x25, as > advertised in the log

[pve-devel] applied-series: [PATCH docs v3 0/5] improve & unify installation(-related) documentation

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 16:29, Christoph Heiss wrote: > This series in short tries to bring the documentation for the > ISO installation flow and anything related to it in line the with > respective documentation for PMG. As both products use the same > installer (minus small differences such as LVM options

[pve-devel] applied: [PATCH storage v2] esxi: detect correct os type in 'other' family

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 10:07, Gabriel Goller wrote: > This patch introduces the conversion table for all possible OS Types > that are in the VMWare 'other' family and sets the pve counterpart. > Our default OS Type is 'linux', so including mappings to 'other' makes > sense. > > Signed-off-by: Gabriel

[pve-devel] applied: [PATCH stable-7 qemu] fix #2258: select correct device when removing drive snapshot via QEMU

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 13:29, Maximiliano Sandoval wrote: > The QMP command needs to be issued for the device where the disk is > currently attached, not for the device where the disk was attached at > the time the snapshot was taken. > > Fixes the following scenario with a disk image for which >

Re: [pve-devel] release a new pve-network package ? (evpn fix)

2024-03-22 Thread Thomas Lamprecht
Hi! On 21/03/2024 09:13, DERUMIER, Alexandre wrote: > a critical bug in evpn with multiple nodes is fixed in git, > https://git.proxmox.com/?p=pve-network.git;a=commit;h=e614da43f13e3c61f9b78ee9984364495eff91b6 > but package is still not released > > I see a lot of user bug report since 4

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-22 Thread Thomas Lamprecht
On 22/03/2024 08:29, Dominik Csapak wrote: > On 3/21/24 18:07, Thomas Lamprecht wrote: >> On 20/03/2024 16:39, Dominik Csapak wrote: >>> needing one less step when adding the storage, assuming most esxi >>> certificates are self-signed. >> >> Well this mak

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-21 Thread Thomas Lamprecht
On 05/03/2024 13:54, Christian Ebner wrote: > Allows to optionally configure a local interface name to which to > bind to when sending a wake on lan packet to wake a remote node. > > Default behaviour remains to send the packet via the interface for > the default gateway. > > Signed-off-by:

[pve-devel] applied: [PATCH v2 pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-21 Thread Thomas Lamprecht
Am 14/03/2024 um 11:19 schrieb Max Carrara: > The Ceph monitor removal assertion contains a condition that checks > whether the given mon ID actually exists and thus may be removed. > > The first part of the condition checks whether the hash returned by > `get_services_info` [0] contains the key

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-21 Thread Thomas Lamprecht
On 20/03/2024 16:39, Dominik Csapak wrote: > needing one less step when adding the storage, assuming most esxi > certificates are self-signed. Well this makes it insecure by default though? Which is not something I'd just not mention in such a commit message... As that was the original reason I

[pve-devel] applied: [PATCH manager] ui: agentipview: make text in grid selectable

2024-03-21 Thread Thomas Lamprecht
On 21/03/2024 10:25, Aaron Lauterer wrote: > This makes it possible to select any of the IP addresses listed in the > full view window to copy & paste it. > > Signed-off-by: Aaron Lauterer > --- > Becaue @Folke made a remark that this was a nuisance ;) > > www/manager6/qemu/AgentIPView.js | 3

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-21 Thread Thomas Lamprecht
(missed reply-all, so resending) On 20/03/2024 10:30, Fiona Ebner wrote: > Am 20.03.24 um 09:56 schrieb Aaron Lauterer: >> Signed-off-by: Aaron Lauterer >> --- >> pve-system-requirements.adoc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/pve-system-requirements.adoc

[pve-devel] applied: [PATCH storage/manager] guest import improvements

2024-03-19 Thread Thomas Lamprecht
On 19/03/2024 14:00, Dominik Csapak wrote: > some sensible improvements for the guest import > > pve-storage: > > Dominik Csapak (2): > esxi: add warning for losing efi state > esxi: only add scsihw if it's defined > > src/PVE/Storage/ESXiPlugin.pm | 3 ++- > 1 file changed, 2

[pve-devel] applied: [PATCH manager] fix #5293: ceph status: fix division-by-zero when calculating usage

2024-03-19 Thread Thomas Lamprecht
On 12/03/2024 10:13, Christoph Heiss wrote: > Fixes #5293 [0]. This happens when no OSDs are created yet and thus the > total space is 0, which leads to a division-by-zero. > > Add a simple check if the total space is greater than 0. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5293 > >

<    1   2   3   4   5   6   7   8   9   10   >