Re: [pve-devel] [PATCH container v2 2/2] pct: add keep-env option

2024-02-02 Thread Thomas Lamprecht
Am 29/01/2024 um 16:43 schrieb Folke Gleumes: > The keep-env option allows the user to define if the current environment > should be kept when running 'pct enter/exec'. pct will now always set > '--keep-env' or '--discard-env' when calling lxc-attach to anticipate > the upcoming change in default

[pve-devel] applied: [PATCH container v2 1/2] fix #5194: pct: delete environment variables set by pve

2024-02-02 Thread Thomas Lamprecht
Am 29/01/2024 um 16:43 schrieb Folke Gleumes: > proxmox-perl-rs set's SSL_CERT_{DIR,FILE}, which can break ssl in > containers if their certificate store can't be found in the same spot. > This patch explicitly unsets those variables before starting the > container. > > Signed-off-by: Folke

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-02-02 Thread Thomas Lamprecht
Am 01/02/2024 um 10:20 schrieb Fiona Ebner: > Am 31.01.24 um 12:55 schrieb Friedrich Weber: >> >> After changing `warn` to `log_warn` I noticed that pvestatd does not >> write the warning to the syslog every 10s anymore. Turns out `warn` >> triggers a custom __WARN__ handler we install for our

[pve-devel] applied: [PATCH proxmox-i18n] es: Add new translations

2024-02-02 Thread Thomas Lamprecht
Am 01/02/2024 um 11:42 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 48 +++- > 1 file changed, 19 insertions(+), 29 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH v2 manager] ui: lvm: expose saferemove setting

2024-02-02 Thread Thomas Lamprecht
Am 01/02/2024 um 16:12 schrieb Fiona Ebner: > It can be security-relevant in some environments. The LVM storage > documentation can be reached via the "Help" button and contains a few > more details. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * Improve label text (thanks to

[pve-devel] applied: [PATCH pve-network 0/4] evpn controller fix && cleanup

2024-01-22 Thread Thomas Lamprecht
Am 03/12/2023 um 16:46 schrieb Alexandre Derumier: > This patch serie is fixing 1 critical bug with multiple exit-nodes > and other minor ipv6 bug with prefix-list && null routes. > > Also cleaning the re-ordering of some values in frr.conf to match > the output of frr running config. > >

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Thomas Lamprecht
Am 16/01/2024 um 11:40 schrieb Fabian Grünbichler: > >> Thomas Lamprecht hat am 16.01.2024 11:34 CET >> geschrieben: >> >> >> Am 15/01/2024 um 16:53 schrieb Hannes Dürr: >>> Tested cluster creation with three new nodes on 8.1 and the patches >>

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Thomas Lamprecht
Am 15/01/2024 um 16:53 schrieb Hannes Dürr: > Tested cluster creation with three new nodes on 8.1 and the patches > Cluster creation and further ssh communication (eq. migration) worked > flawless > > Tested-by: Hannes Duerr What about the reinstallation of an existing node, or replacing one,

[pve-devel] applied: [PATCH proxmox-i18n] es: update translations

2024-01-15 Thread Thomas Lamprecht
Am 03/01/2024 um 16:18 schrieb Maximiliano Sandoval: > This patch follows the the discussion at > https://lists.proxmox.com/pipermail/pve-devel/2023-December/061192.html. > > The use of exclamation and question marks is improved, one or two typos > are fixed, and we use lowercase rather than

[pve-devel] applied: [PATCH docs] pvecm: remove node: explain how to deal with the node's pmxcfs directory

2024-01-15 Thread Thomas Lamprecht
Am 05/01/2024 um 10:26 schrieb Fiona Ebner: > Reported in the community forum: > https://forum.proxmox.com/threads/139006/post-621739 > > Signed-off-by: Fiona Ebner > --- > pvecm.adoc | 4 > 1 file changed, 4 insertions(+) > > applied, thanks!

[pve-devel] applied-series: [PATCH v3 ceph 0/2] Complete Workaround For Ceph Dashboard

2024-01-15 Thread Thomas Lamprecht
Am 05/01/2024 um 15:07 schrieb Max Carrara: > These two patches allow the Ceph Dashboard to work again as intended. > > The first patch provides a backport of a pull request [0] which removes > the dependency on PyJWT. [1] > > The second patch removes two usages of functions that use PyOpenSSL,

[pve-devel] applied: [PATCH pve-manager 1/1] add missing library packages

2024-01-12 Thread Thomas Lamprecht
no biggie, but for the subject something like: apt: package versions: track cluster & notify library packages might have been a slightly better fit and tell one more info if skimming the git log (--oneline), as otherwise that could also be interpreted as missing dependency or the like. But I

Re: [pve-devel] Status Ceph 18.2.1 for enterprise

2024-01-12 Thread Thomas Lamprecht
Hi! Am 12/01/2024 um 13:10 schrieb Mark Schouten via pve-devel: > What’s the ETA on that? I would like to keep the cluster as ‘enterprise’ > as possible and refrain from mixing repo’s. No hard ETA, but if nothing comes up we'll move that version over to enterprise between the middle of next

[pve-devel] applied: [PATCH v2 pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Thomas Lamprecht
Am 10/01/2024 um 14:50 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > changes since v1: > - fix an additional typo spotted Lukas > > notifications.adoc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > applied, thanks!

Re: [pve-devel] qemu + tcmalloc for rbd

2024-01-10 Thread Thomas Lamprecht
Am 10/01/2024 um 10:38 schrieb DERUMIER, Alexandre: >>> Unfortunately, the QEMU patch seems rather hacky and I'd prefer to >>> not >>> include and maintain it. If tcmalloc would just provide malloc_trim() >>> (e.g. as a no-op), there would be no need for the ugly >>> at-runtime-detection at all. >

Re: [pve-devel] qemu + tcmalloc for rbd

2024-01-10 Thread Thomas Lamprecht
Am 10/01/2024 um 10:12 schrieb Fiona Ebner: > Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre: >> Another way (maybe safer), is to build 2 binary in same package >> (/usr/bin/kvm-tcmalloc && /usr/bin/kvm), and give option to user to >> choose it. >> > > If we go for this route, I'd rather have

[pve-devel] applied: [PATCH manager 2/3] pvesubscription: update set-offline-key description

2024-01-10 Thread Thomas Lamprecht
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler: > and point users to proxmox-offline-mirror-helper > > Signed-off-by: Alexander Zeidler > --- > PVE/CLI/pvesubscription.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager 3/3] report: format iptables output for readability

2024-01-10 Thread Thomas Lamprecht
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied this one, thanks! It could have been a standalone patch though, as it's not really related to the other ones.

Re: [pve-devel] [PATCH manager 2/3] pvesubscription: update set-offline-key description

2024-01-10 Thread Thomas Lamprecht
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler: > and point users to proxmox-offline-mirror-helper the change is fine, but having any background/reason/why here could be still nice, I never saw a commit with to much references or reasons state for why a change was done, and having those can

Re: [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement

2024-01-10 Thread Thomas Lamprecht
any reason this is relevant you might want to add to the commit message here? Am 09/01/2024 um 15:23 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > PVE/CLI/pvesubscription.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/CLI/pvesubscription.pm

Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread Thomas Lamprecht
Am 09/01/2024 um 16:46 schrieb DERUMIER, Alexandre: > oh, I have tested with 17.2.7-pve1 > > > I'll look for 18.2 I managed to port it over, and in the second patch I squashed both changes into one diff hunk, those two hunks touching the same file confused me slightly initially ^^

Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread Thomas Lamprecht
Am 09/01/2024 um 15:50 schrieb Alexandre Derumier: > They are a bug in current debian packaging, > where rocksdb is build in debug mode (not inheriting from cmake flags) > > patch 1 already exist in ubuntu > patch 2 is a newer patch commited in ceph recently > > (patch 2 should be enough, but

[pve-devel] applied: [PATCH ifupdown2] fix #5009: avoid waiting for stdout eof of /etc/network/ scripts

2023-12-20 Thread Thomas Lamprecht
On 19/12/2023 10:22, Friedrich Weber wrote: > Previously, PVE (7 and 8) hosts would hang at boot if both ntpsec and > ntpsec-ntpdate are installed. The root cause for the hang is an > unfortunate interaction between ntpsec, ntpsec-ntpdate and the PVE > ifupdown2 package. The hang happens because

Re: [pve-devel] [PATCH v2 qemu-server] fix #4501: TCP migration: start vm: move port reservation and usage closer together

2023-12-20 Thread Thomas Lamprecht
ting a reserved port for a few seconds. But IMO it's not highly likely to run out of such ports, most actions that can spawn multiple migrations (like HA) are capped by default. So once tested a few general migration situations, consider this: Acked-by: Thomas Lamprecht

Re: [pve-devel] [PATCH manager] ui: ceph installer: Run ceph/init if joining a cluster

2023-12-20 Thread Thomas Lamprecht
On 20/12/2023 10:53, Mira Limbeck wrote: > On 12/19/23 18:09, Aaron Lauterer wrote: >> The commit message doesn't explain the actual issue that it is trying to >> solve. >> AFAICT we do not need the ceph.conf symlinked right away for normal PVE >> operations. If it is not present in

[pve-devel] applied: [PATCH manager] fix #5121: ui: node status: avoid invalid array access for certain foreign kernels

2023-12-14 Thread Thomas Lamprecht
Am 14/12/2023 um 11:34 schrieb Fiona Ebner: > with custom build date format, which would prevent the panel from loading. > > Signed-off-by: Fiona Ebner > --- > www/manager6/node/StatusView.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH proxmox-i18n] es: Improve translations

2023-12-13 Thread Thomas Lamprecht
Am 13/12/2023 um 15:49 schrieb Maximiliano Sandoval: > Tweak some string, improve others. > > Signed-off-by: Maximiliano Sandoval > --- > es.po | 52 +--- > 1 file changed, 25 insertions(+), 27 deletions(-) > > applied, thanks!

Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit

2023-12-12 Thread Thomas Lamprecht
Am 12/12/2023 um 10:21 schrieb Fiona Ebner: > Am 11.12.23 um 17:29 schrieb DERUMIER, Alexandre: So not sure if that's really nicer. This suggests QEMU should raise the limit itself. >> >> Yes, but it don't raise the limit :/ But it's really working with more >> than 1024 file

[pve-devel] applied-series: [PATCH qemu 1/2] add patch to work around stuck guest IO with iothread and VirtIO block/SCSI

2023-12-11 Thread Thomas Lamprecht
Am 11/12/2023 um 14:28 schrieb Fiona Ebner: > When using iothread, after commits > 1665d9326f ("virtio-blk: implement BlockDevOps->drained_begin()") > 766aa2de0f ("virtio-scsi: implement BlockDevOps->drained_begin()") > it can happen that polling gets stuck when draining. This would cause > IO in

[pve-devel] applied: [PATCH] fix #5063: load webgl addon in try block

2023-12-11 Thread Thomas Lamprecht
Am 11/12/2023 um 11:19 schrieb Dominik Csapak: > since under certain circumstances (e.g. using safari < 16) the addon > constructor already throws an exception, not only the loading later. > > To allow falling back to the canvas renderer, move it into the try block > after webgl detection. > >

Re: [pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

2023-12-07 Thread Thomas Lamprecht
Am 07/12/2023 um 12:01 schrieb Dominik Csapak: > this has the advantage that the title is now completely visible when the > column is too narrow when expanded, although it is duplicated (since > it's already contained in the non expanded row) even if the original > value may be cutoff. > >

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Thomas Lamprecht
Am 06/12/2023 um 15:26 schrieb Dominik Csapak: > honestly i don't want to argue/bikeshed about such a small detail, > but i don't see a good reason to translate names and established > (technical) words. > > I'm ready to change my mind, but i did not see a good example > of when it would be good

[pve-devel] applied: [RFC manager] api: replication: allow users to enumerate accessible replication jobs

2023-12-04 Thread Thomas Lamprecht
Am 01/12/2023 um 14:24 schrieb Lukas Wagner: > Previously, the /cluster/replication API handler would fail completely > with a HTTP 403 if a user does have VM.Audit permissions for > a single VM/CT. That was due to the 'noerr' parameter not set for > $rpcenv->check() > > Signed-off-by: Lukas

[pve-devel] applied: [PATCH manager] ui: iso selector: fix disabling

2023-12-04 Thread Thomas Lamprecht
Am 04/12/2023 um 10:29 schrieb Fiona Ebner: > Otherwise, it's impossible to add no or a physical CD to an existing > VM. > > Reported in the communiy forum: > https://forum.proxmox.com/threads/136960/post-611704 > > Fixes: fc7b556d ("ui: refactor iso-selector out of the cd input panel") >

[pve-devel] applied: [PATCH proxmox-i18n] es: Improve translations

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 14:31 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > Improvements made after going through the three web UIs. > > es.po | 62 +-- > sl.po | 2 +- > 2 files changed, 32 insertions(+), 32

[pve-devel] applied: [PATCH docs] fix #5089: pvesdn: replace quest(s) -> guest(s)

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 16:08 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > pvesdn.adoc | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH pve-network] tests: mocking cfs_lock_file to pass subnet tests

2023-11-29 Thread Thomas Lamprecht
Am 24/11/2023 um 14:16 schrieb Stefan Lendl: > IPAM tries to lock file in clusterfs which it can't when testing as > non-root. > > Mocking cfs_lock_file to emulate locking behavior. > > Signed-off-by: Stefan Lendl > --- > src/test/run_test_subnets.pl | 20 +++- > 1 file

[pve-devel] applied: [PATCH proxmox-i18n] es: update Spanish translations

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 12:13 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 3934 +++-- > 1 file changed, 1608 insertions(+), 2326 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH pve-network] dhcp: dnsmasq: Use dir_glob_foreach for deleting configuration files

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 09:58 schrieb Stefan Hanreich: > The current invocation is quite unsafe and triggers the taint mode of > Perl. Replacing it with dir_glob_foreach solves those issues. > > Reported-By: Friedrich Weber > Signed-off-by: Stefan Hanreich > --- > I wasn't sure whether directly

[pve-devel] applied: [PATCH] update kernel to 6.5.11 and ZFS to 2.2.1, refresh patches

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 16:07 schrieb Stoiko Ivanov: > * for the kernel-patch this includes a rename from 0003+0004 to > 0001+0002 > * for ZFS there was a change in upstream's autotools-setup - I > referenced the commit in the actual patch-file > > minimally tested with a VM with a zfs-pool and an

[pve-devel] applied: [PATCH pve-network] api: vnet: fix warning in vnet API

2023-11-29 Thread Thomas Lamprecht
Am 27/11/2023 um 11:23 schrieb Stefan Hanreich: > If zone is not set, we also check the pending changes for a zone key, > since it is set as pending when the Vnet settings have not yet been > applied. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/API2/Network/SDN/Vnets.pm | 2 +- > 1 file

[pve-devel] applied-series: [PATCH i18n 1/3] german: unify different words of the same meaning

2023-11-29 Thread Thomas Lamprecht
Am 24/11/2023 um 19:28 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > de.po | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH pve-network] validation: add support for arrays to change tracking

2023-11-29 Thread Thomas Lamprecht
Am 22/11/2023 um 13:28 schrieb Stefan Hanreich: > This is needed so dhcp-ranges are properly displayed as changed in the > web UI. > > Also took the chance to properly indent the encode_value function with > our indentation scheme. > > Signed-off-by: Stefan Hanreich > --- >

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 09:08 schrieb Maximiliano Sandoval: >>> If its only right-to-left languages, we could just add another helper >>> to assemble lists in the correct order? > > The GNOME l10n guidelines at least have an entry about not splitting > strings. > > While it does not apply to this

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 16:29 schrieb Dietmar Maurer: >> I'm taking on a lot of contributions to translations and the common complaint >> I hear is that not all can be translated correctly due to such tricks (or >> just >> missing gettext), most translators care much more about a correct translation >>

[pve-devel] applied: [PATCH docs 1/2] secure boot: fix typos, add inline code formatting

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 14:56 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > system-booting.adoc | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > applied series, thanks! ___ pve-devel mailing list

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 15:39 schrieb Dietmar Maurer: > Well, this also duplicates the number of things to translate! I'm taking on a lot of contributions to translations and the common complaint I hear is that not all can be translated correctly due to such tricks (or just missing gettext), most

[pve-devel] applied: [PATCH manager] node: add guard for missing secure-boot efi var

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 07:58 schrieb Fabian Grünbichler: > some (old) systems might have efivars, but don't have the SecureBoot one. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > reported on the forum for a Dell server from 2009(!): > >

[pve-devel] applied: [PATCH kernel] cherry-pick fix for RCU stall issue after VM live migration

2023-11-27 Thread Thomas Lamprecht
On 27.11.23 18:39, Fiona Ebner wrote: > caused by a lapic timer interrupt getting lost. > > Already queued for 6.5.13: > https://lore.kernel.org/stable/20231124172031.920738...@linuxfoundation.org/ > > Reported in the community forum: > https://forum.proxmox.com/threads/136992/ > >

Re: [pve-devel] Synology NAS container O_TMPFILE fallback support

2023-11-25 Thread Thomas Lamprecht
Hello, Am 24/11/2023 um 19:15 schrieb Arunas: > as somebody noticed or not, but PBS starting 2.1x stopped working on > Synology NAS machines earlier that 2020 or even newer models which use > 3.1.1 kernel. That kernel went EOL quite exactly 10 years ago, oof...

Re: [pve-devel] seem than ifupdown2 is installed by default on upgrade (a friend reported me an ipv6 slaac bug)

2023-11-24 Thread Thomas Lamprecht
Am 24/11/2023 um 11:12 schrieb DERUMIER, Alexandre: > After investigate a litte bit, > > I think this is because ifupdown1 is setting accept_ra=2 by default. > > > and with ifupdown2, by security, we setup accept_ra=0 until it's > really setup in /etc/network/interfaces > > > iface vmbr0

Re: [pve-devel] seem than ifupdown2 is installed by default on upgrade (a friend reported me an ipv6 slaac bug)

2023-11-24 Thread Thomas Lamprecht
Am 23/11/2023 um 18:50 schrieb DERUMIER, Alexandre: > Hi, > > I have a friend who's reported my than ifupdown2 had been installed by > default on pve 8.1 upgrade. > > I think it's because pve-network have "Recommends: ifupdown2". > Well, that was the case since almost forever, but since we

[pve-devel] applied: [PATCH manager] ui: pool view: fix editing nested pools

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 11:07 schrieb Dominik Csapak: > for nested pools we have to provide the pool id via a get parameter > instead of in the path, and also we have to extract the data from the > returned array. > > To do this, changet the cbind url handler, remove the autoLoad one, > and handle the

[pve-devel] applied: [PATCH docs] secure boot: add subsection for DKMS/MOK

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:45 schrieb Fabian Grünbichler: > similar, but a bit more beginner friendly compared to the wiki article. > > Signed-off-by: Fabian Grünbichler > --- > system-booting.adoc | 43 +++ > 1 file changed, 43 insertions(+) > > applied,

[pve-devel] applied: [PATCH manager] ui: perm paths: change /mapping/notification to /mapping/notifications

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:54 schrieb Lukas Wagner: > The ACL path was changed during the notification system rework. > This change adapts the list of predefined ACL paths in the > 'Add {User,Group,API Token} Permission' dialog window to reflect > this change. > > Signed-off-by: Lukas Wagner > --- >

Re: [pve-devel] [PATCH manager] pveceph: install: set default to reef

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:33 schrieb Aaron Lauterer: > to align it with the default in the web UI the default in the web UI is actually dynamic and depends if anything is already installed on the cluster. This is still lacking here, IIRC there is an open enhancement request about that (did not find it

[pve-devel] applied: [PATCH manager 3/3] ui: resource tree: remove wrong comment

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:25 schrieb Dominik Csapak: > that function is not only there for the storage indicators, but > generally for adding additional information, such as tags, and for > wrapping in a span for making tooltip selection easier. > > Signed-off-by: Dominik Csapak > --- >

[pve-devel] applied: [PATCH manager 1/3] ui: resource tree: fix nodes text moving in tree on update

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:25 schrieb Dominik Csapak: > when a node element was updated, it was put through the 'setText' method > which accidentally added a space before it's name. > > Fix this by putting the space into the status variable > > This could be observed when one node had guests on it but

[pve-devel] applied: [PATCH docs] system-booting: fix typo

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:38 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > system-booting.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH pve-manager] sdn: adapt edit panels for new API endpoints

2023-11-22 Thread Thomas Lamprecht
For the record, two things inline Am 22/11/2023 um 18:41 schrieb Stefan Hanreich: > diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js > index db9b47b18..2eecb101a 100644 > --- a/www/manager6/sdn/zones/Base.js > +++ b/www/manager6/sdn/zones/Base.js > @@ -34,9 +34,9 @@

[pve-devel] applied: [PATCH] ui: iso selector: fix layout, stretch items again to full space

2023-11-22 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- fixes the recent refactoring into its own component www/manager6/form/IsoSelector.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js index 632ee7f0..0bc6346c 100644 --- a/www

[pve-devel] applied: [PATCH pve-network] dnsmasq: check for existence of dnsmasq binary

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 19:33 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 8 > 1 file changed, 8 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH pve-network] Fix #4917: evpn: forbid vlan-aware bridge

2023-11-22 Thread Thomas Lamprecht
Am 27/10/2023 um 13:53 schrieb Alexandre Derumier: > Do it on vnet update instead throwing a warning at config generation. > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH pve-manager] sdn: zone: fix edit for dns zone

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 19:05 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > www/manager6/sdn/zones/Base.js | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH pve-manager] sdn: adapt edit panels for new API endpoints

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 18:41 schrieb Stefan Hanreich: > PUT endpoints have changed so they work like the other SectionConfig > endpoints. Reflect those changes in the UI. > > Signed-off-by: Stefan Hanreich > --- > www/manager6/sdn/SubnetEdit.js | 23 ++--- >

[pve-devel] applied: [PATCH docs] system-booting: add note about weird uefi behaviour

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 18:45 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > This is essentially what Fabian and Aaron discovered earlier today. Just > let users know that if that happens, it's not something we can do much > about on our end. > > system-booting.adoc | 6 ++ > 1

[pve-devel] applied: [PATCH docs] system-booting: add instructions to switch install to secure boot

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 18:07 schrieb Christoph Heiss: > As this procedure could *potentially* lead to data loss (however > unlikely if followed correctly), put a big warning on top, for safety. > > Signed-off-by: Christoph Heiss > --- > Tested both (GRUB on ext4, system-boot with ZFS-on-root)

[pve-devel] applied: [PATCH i18n] update German translation

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 16:27 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > de.po | 183 ++ > 1 file changed, 81 insertions(+), 102 deletions(-) > > applied, with s/Datenträger/Laufwerk/ for the virtio-driver convenience

[pve-devel] applied: [PATCH pve-docs] pvesdn: Fix heading for NetBox IPAM plugin section

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 15:09 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > pvesdn.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH pve-manager] ui: sdn: use all upper case for acronyms

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 15:22 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > www/manager6/sdn/ZoneView.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH pve-docs] pvesdn: remove double occurrence of 'external'

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 14:52 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > pvesdn.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH v2 container 0/4] Bugfixes for DHCP

2023-11-22 Thread Thomas Lamprecht
Am 20/11/2023 um 20:19 schrieb Stefan Hanreich: > When editing a NIC there was a possibility of duplicate IPAM entries being > generated. This should be fixed with this patch series. > > Additionally when creating vNICs for a container there were multiple warnings > in the log due to the LXC

[pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 14:00 schrieb Stefan Lendl: > * start- and end-addresses must be valid IPs > * must both be in the subnet's CIDR > * and start needs to smaller (or equal) to end > > Signed-off-by: Stefan Lendl > --- > src/PVE/Network/SDN/SubnetPlugin.pm | 28 > 1

[pve-devel] applied: [PATCH pve-manager] ipam: send ip to delete endpoint

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 13:29 schrieb Stefan Hanreich: > The ip parameter has been added to the delete endpoint, so only a > specific mapping gets deleted instead of all mappings for that mac > address. Reflect this change in the UI. > > Signed-off-by: Stefan Hanreich > --- >

[pve-devel] applied: [PATCH pve-network] ipam: improve update / delete behavior

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 14:22 schrieb Stefan Hanreich: >> is this really related? > > somewhat. add_ip never added a cache entry in macs.db which didn't cause > any issues when we added gateways via add_ip. But now that we use it in > update as well we need to create the entries in this function as well

[pve-devel] applied: [PATCH v2 qemu] add fix for vnc clipboard

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 13:41 schrieb Fiona Ebner: > This fixes the host->guest direction with noNVC as a client (and > likely others). > > Reported-by: Friedrich Weber > Signed-off-by: Fiona Ebner > --- > ...-ui-vnc-clipboard-fix-inflate_buffer.patch | 34 +++ > debian/patches/series

Re: [pve-devel] [PATCH pve-network] ipam: improve update / delete behavior

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 13:29 schrieb Stefan Hanreich: > Currently when updating or deleting a mapping in the IPAM we would > delete all existing entries in the IPAM with that mac address. Now we > only delete the specific entry we are updating / deleting. > > Signed-off-by: Stefan Hanreich > --- >

Re: [pve-devel] [PATCH v2 qemu] add fix for vnc clipboard

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 13:45 schrieb Friedrich Weber: > Would be great if we could get this in, as the VNC clipboard is > half-broken without it. not configurable via the UI though, hmm.. ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH installer] grub: install all efi binaries in fallback/default dir

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 13:19 schrieb Fabian Grünbichler: > else this fails with secureboot, where the entry point must be shim and not > grub. > > Signed-off-by: Fabian Grünbichler > --- > tested by using the "Hard Disk" boot option, instead of the (higher priority) > 'proxmox' one when booting a

[pve-devel] applied: [PATCH docs] boot: add Secure Boot information

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 09:54 schrieb Fabian Grünbichler: > and refer to the (updated) wiki article for more in-depth explanations. > > Signed-off-by: Fabian Grünbichler > --- > local-zfs.adoc | 6 +- > system-booting.adoc | 42 +- > 2 files changed,

[pve-devel] applied: [PATCH pve-network] fix dhcpv6 router advertisement

2023-11-22 Thread Thomas Lamprecht
Am 22/11/2023 um 08:58 schrieb Alexandre Derumier: > - don't listen to ip address, but use interface= instead > - generate 1 config file by vnet instead 1 by subnet > - enable-ra is global to server, enable it in default conf > > Signed-off-by: Alexandre Derumier > --- >

Re: [pve-devel] [TurnKey Linux] Looking to update our signing key... Advice?

2023-11-22 Thread Thomas Lamprecht
Hello! Am 22/11/2023 um 05:50 schrieb Jeremy Davis: > Apologies in advance if this is not the right place to post this. Please > redirect me to the appropriate forum if not. I'm also happy to discuss > off list if that is deemed more appropriate. It's fine here, thanks for reaching out. > My

[pve-devel] applied: [PATCH v4 pve-manager 17/33] sdn: regenerate DHCP config on reload

2023-11-21 Thread Thomas Lamprecht
Am 17/11/2023 um 12:39 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > PVE/API2/Network.pm | 1 + > 1 file changed, 1 insertion(+) > > applied the manager ones, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH pve-manager] sdn: subnet: proper change detect for dhcp range panel

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 20:46 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > www/manager6/sdn/SubnetEdit.js | 51 +- > 1 file changed, 38 insertions(+), 13 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH pve-manager 2/2] sdn: Update IPAM API endpoints

2023-11-21 Thread Thomas Lamprecht
Am 20/11/2023 um 17:28 schrieb Stefan Hanreich: > The IPAM-related API endpoints were moved, reflect those changes in > the UI as well. > > Signed-off-by: Stefan Hanreich > --- > www/manager6/sdn/IpamEdit.js | 4 +++- > www/manager6/tree/DhcpTree.js | 15 +++ > 2 files changed, 14

[pve-devel] applied: [PATCH kernel-helper] add dedicated removable installation

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 21:19 schrieb Stoiko Ivanov: > seems adding `--removable` makes grub install ignore most other > information - e.g. the bootloader-id (guessed based on [0]). > add dedicated call with out `--removable` in addition > > Seems that's the reason why our installer also 'rolls its own

[pve-devel] applied-series: [PATCH network/container/qemu-server 0/3] sdn: register a new IP at VM start if missing

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 15:55 schrieb Stefan Lendl: > > If a VM or LXC starts and no IP was found in the IPAM, register a new one. > > This is very seful as a fallback if for some reason an IP mapping was deleted > or there is a bug somewhere that does not register an IP. > > This acts more like DHCP

[pve-devel] applied: [PATCH pve-container] sdn: fix wrong vmid parameter in prestart-hook

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 18:50 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/lxc-pve-prestart-hook | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH proxmox-widget-toolkit 4/4] notification ui: add appropriate onlineHelp anchors

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 15:47 schrieb Lukas Wagner: > This links the dialog windows to the correct help section (different > target types, matchers). > > Signed-off-by: Lukas Wagner > --- > src/panel/GotifyEditPanel.js | 1 + > src/panel/NotificationConfigView.js | 1 + >

[pve-devel] applied-series: [PATCH docs/proxmox-widget-toolkit 0/2] notifications: document 'unknown' severity and add to GUI

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 17:01 schrieb Lukas Wagner: > This is the severity used for forwarded mails, since we cannot > reasonably infer a priority here. > > > > pve-docs: > > Lukas Wagner (1): > notification: document 'unknown' severity > > notifications.adoc | 2 +- > 1 file changed, 1

[pve-devel] applied: [PATCH v4 pve-docs 33/33] sdn: dhcp: Add documentation for DHCP

2023-11-21 Thread Thomas Lamprecht
Am 17/11/2023 um 12:40 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > pvesdn.adoc | 122 > 1 file changed, 122 insertions(+) > > applied, with some merge conflicts resolved, maybe you could also recheck to ensure nothing

[pve-devel] applied: [PATCH kernel-helper] grub-install: provide --removable to grub-install

2023-11-21 Thread Thomas Lamprecht
le. > > minimally tested on a VM during install. > > Reported-by: Thomas Lamprecht > Signed-off-by: Stoiko Ivanov > --- > ftr: In Mira's tests a RAID1 install on ZFS booted fine as long as both > disks were added to the boot-options (which I cannot explain) > >

Re: [pve-devel] [PATCH pve-manager 2/4] ui: sdn: fix onlineHelp anchors

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 15:47 schrieb Lukas Wagner: > These have been renamed in: > bcb72b 'sdn: overall language and consistency rework' in pve-docs I reverted that part in the docs before I saw you patch and will keep it that way, IMO one should have good reasons to break links than just vnet vs

[pve-devel] applied: [PATCH pve-manager 3/4] ui: dc: config: remove onlineHelp for notification config view

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 15:47 schrieb Lukas Wagner: > The 'onlineHelp' is now set in the component definition in > 'proxmox-widget-toolkit'. > > Signed-off-by: Lukas Wagner > --- > www/manager6/dc/Config.js | 1 - > 1 file changed, 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH pve-docs 1/4] notification: add anchors for target types/matchers

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 15:47 schrieb Lukas Wagner: > This enables us to directly link to the appropriate section from the > UI. > > Signed-off-by: Lukas Wagner > --- > notifications.adoc | 6 ++ > 1 file changed, 6 insertions(+) > > applied this one, needing a bump for the other ones, thanks!

[pve-devel] applied-series: [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 13:52 schrieb Lukas Wagner: > This patch series adds the 'notification-mode' setting for backup jobs. > It allows users to choose between the 'old-style' notifications > (mail to configured address, directly via a call to sendmail) or > the 'new-style' notification system. > >

[pve-devel] applied: [PATCH proxmox-mail-forward] do not forward on PBS systems if co-installed with PVE

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 16:53 schrieb Lukas Wagner: > With the newly built-in targets/matchers, we should not add > a target/matcher manually any more. In fact, this broke mail > forwarding on PBS because 'default-matcher' already existed as a > built-in and could thus not be created. > We now simply do

[pve-devel] applied: [PATCH manager v4 0/3] fix 2515 use size defaults

2023-11-21 Thread Thomas Lamprecht
Am 29/09/2023 um 15:02 schrieb Aaron Lauterer: > The main goal of this series is to improve the handling of configured > default size & min_size values when creating a new Ceph Pool in the GUI. > > A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch > values for config keys that

[pve-devel] applied: [PATCH manager] ui: qemu wizard: use better boot order for second cd drive

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 09:35 schrieb Dominik Csapak: > in the case we add a second cd drive (for windows), we don't want the > backend logic to only include the first one, since we cannot know > which is bootable and which is (probably) the virtio iso. > > so instead, emulate the backend logic for the

[pve-devel] applied: [PATCH docs v15 2/2] add VNC clipboard documentation

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 13:39 schrieb Markus Frank: > Signed-off-by: Markus Frank > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak > --- > qm.adoc | 18 ++ > 1 file changed, 18 insertions(+) > > applied, thanks! ___ pve-devel

<    1   2   3   4   5   6   7   8   9   10   >