Re: New Framework Review: KDAV

2020-06-19 Thread Volker Krause
On Friday, 19 June 2020 01:16:20 CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 4. April 2020, 16:20:21 CEST schrieb Kevin Ottens: > > Overall apidox would likely need a big pass of cleanups as well. > > I locally prepared the addition of ECMAddQch usage for KDAV tonight, and > while testing

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

2020-06-17 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #36 from Volker Krause --- Git commit bc8b78d47829da0bec4facdff3bf1a740751e5ae by Volker Krause. Committed on 17/06/2020 at 15:06. Pushed by vkrause into branch 'release/20.04'. Extract seat reservation information from Ouigo confirmations

Re: New Framework Review: KDAV

2020-06-14 Thread Volker Krause
move this in Gitlab? Thanks, Volker On Sunday, 24 May 2020 08:52:17 CEST Volker Krause wrote: > The remaining issues that didn't change ABI anymore (movable value types, > hide private methods/slots inside the private classes, etc) have long since > been addressed. > > I th

Re: New Framework Review: KDAV

2020-06-14 Thread Volker Krause
move this in Gitlab? Thanks, Volker On Sunday, 24 May 2020 08:52:17 CEST Volker Krause wrote: > The remaining issues that didn't change ABI anymore (movable value types, > hide private methods/slots inside the private classes, etc) have long since > been addressed. > > I th

Re: The KDEPIM / Akonadi situation

2020-06-13 Thread Volker Krause
On Saturday, 13 June 2020 17:35:08 CEST Adriaan de Groot wrote: > On Saturday, 13 June 2020 09:29:36 CEST Volker Krause wrote: > > I have finite time and prioritized what seemed to have most wide-spread > > impact (all of Android and all of Flatpak vs. Akonadi/FreeBSD), &g

Re: The KDEPIM / Akonadi situation

2020-06-13 Thread Volker Krause
On Friday, 12 June 2020 23:54:19 CEST Ben Cooksley wrote: > On Sat, Jun 13, 2020 at 7:49 AM Andras Mantia wrote: > > Hey, > > Hi all, > > > don't want to add much as I'm not active anymore and have my share of > > fault > > > for not fixing certain bugs, but I'd like to reply to only one

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-06 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 --- Comment #8 from Volker Krause --- Git commit 1021bb61cd28b0b18594cfc1995a3ad10e9174ea by Volker Krause. Committed on 06/06/2020 at 08:48. Pushed by vkrause into branch 'master'. Add support for displaying generic Apple Wallet passes Found

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-06 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 --- Comment #8 from Volker Krause --- Git commit 1021bb61cd28b0b18594cfc1995a3ad10e9174ea by Volker Krause. Committed on 06/06/2020 at 08:48. Pushed by vkrause into branch 'master'. Add support for displaying generic Apple Wallet passes Found

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-06 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-06 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-05 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 --- Comment #6 from Volker Krause --- The backtrace doesn't have line numbers, so having the email causing this (or at least its pkpass attachment) would help a lot for reproducing this. Doesn't need to be shared publicly, you can sent it to me

[kmail2] [Bug 422325] Newer KMail crashes with HTML Mail from DHL

2020-06-05 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422325 --- Comment #6 from Volker Krause --- The backtrace doesn't have line numbers, so having the email causing this (or at least its pkpass attachment) would help a lot for reproducing this. Doesn't need to be shared publicly, you can sent it to me

[frameworks-kuserfeedback] [Bug 422227] org.kde.plasmashell Internal Server Error

2020-06-02 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=47 --- Comment #3 from Volker Krause --- Ben checked the logs, the problem seems to be that the server hits the PHP memory limit for those two products (as they have accumulated 10+M of data by now), and right now the full JSON response with that data

[frameworks-kuserfeedback] [Bug 422227] org.kde.plasmashell Internal Server Error

2020-06-02 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=47 --- Comment #2 from Volker Krause --- Plasma and Discover show this problem, all other products seems to work fine. Asking sysadmins for the server logs. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-kuserfeedback] [Bug 422227] org.kde.plasmashell Internal Server Error

2020-06-02 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=47 Volker Krause changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #1 from

[frameworks-kuserfeedback] [Bug 422348] server replied: Internal Server Error

2020-06-02 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=422348 Volker Krause changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[frameworks-kuserfeedback] [Bug 418981] Violation of KDE Software Privacy Policy

2020-05-29 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=418981 --- Comment #9 from Volker Krause --- The policy is meant to be about data shared with KDE, ie. data actually sent to the telemetry server, not about what applications do locally. If that is unclear anywhere in the wording we can certainly improve

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-26 Thread Volker Krause
vkrause added a comment. PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: New Framework Review: KDAV

2020-05-24 Thread Volker Krause
. * For the July release, just in time for the 20.08 dependency freeze. Opinions? Thanks, Volker On Saturday, 4 April 2020 17:32:19 CEST Volker Krause wrote: > Thanks for the review! We are cutting it close again with the 20.04 > deadline, but fortunately most of these findings aren't ABI-br

Re: New Framework Review: KDAV

2020-05-24 Thread Volker Krause
. * For the July release, just in time for the 20.08 dependency freeze. Opinions? Thanks, Volker On Saturday, 4 April 2020 17:32:19 CEST Volker Krause wrote: > Thanks for the review! We are cutting it close again with the 20.04 > deadline, but fortunately most of these findings aren't ABI-br

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of

D29358: Implement lock-screen visibility control on Android

2020-05-23 Thread Volker Krause
vkrause closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Volker Krause
vkrause updated this revision to Diff 83104. vkrause added a comment. Rename visibility hint. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29358?vs=81734=83104 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 AFFECTED FILES

D29358: Implement lock-screen visibility control on Android

2020-05-19 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:942bddded289: Implement notification grouping on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29335?vs=81731=83063#toc REPOSITORY R289 KNotifications

D29357: Display rich text notification messages on Android

2020-05-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c14be41192d2: Display rich text notification messages on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29357?vs=82566=83046#toc REPOSITORY R289

D27989: Add a new set of barcode size functions

2020-05-14 Thread Volker Krause
vkrause added a comment. In D27989#670416 , @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start,

D29357: Display rich text notification messages on Android

2020-05-11 Thread Volker Krause
vkrause retitled this revision from "Display rich text notification messages on Android (API level 24+)" to "Display rich text notification messages on Android". REPOSITORY R289 KNotifications BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause, tfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-11 Thread Volker Krause
vkrause updated this revision to Diff 82566. vkrause added a comment. Support API level < 24 as well. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29357?vs=81729=82566 BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-11 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-05-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol, vkrause Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem,

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-05-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol, vkrause Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem,

D29342: Implement support for notification urgency on Android

2020-05-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9a13dd26d1de: Implement support for notification urgency on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29342?vs=81695=82227#toc REPOSITORY R289

[frameworks-kuserfeedback] [Bug 420955] KUserFeedback components are hard (not optional) runtime dependency once compiled in

2020-05-07 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=420955 Volker Krause changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-06 Thread Volker Krause
vkrause added a comment. Technically this looks fine from the Prison POV. Whether the barcode type selection makes sense beyond "because we can" I'm not sure about though (in particular the 1D codes seem to be of questionable use here), but then again that's not something introduced by this

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-05 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R175:c39d1eb12217: Add holiday file for DE-BE (Germany/Berlin) (authored by vkrause). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29415?vs=81905=81999 REVISION

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The generic DE file doesn't really work anymore since Berlin got creative in adding non-standard public holidays.

D29358: Implement lock-screen visibility control on Android

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is only the backend part, lacking a proper frontend API this is using a custom hint for now. Android knows three

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81731. vkrause added a comment. Replace the simple ref count with a full child id tracking. The ref count got out of sync when an existing notification is updated, using a set fixes that. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. Still not good enough, updating existing notfication messes up the refcounter, resulting still in leftover group elements. REPOSITORY R289 KNotifications BRANCH grouping REVISION DETAIL https://phabricator.kde.org/D29335 To: vkrause, nicolasfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29357 AFFECTED FILES

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause added a comment. Example: F8278136: Screenshot_20200502_112835.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81725. vkrause added a comment. Explicitly track if notification groups are still in use. This fixes group summaries staying active when we explicitly close a notification, rather then having the user or system dismiss it. REPOSITORY R289

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. This isn't good to go yet, there are corner cases where the group summary item stays around after closing the last notification, working on fixing this. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29335 To:

D29339: Implement updating of notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c5688295e45f: Implement updating of notifications on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29339?vs=81686=81722#toc REPOSITORY R289 KNotifications

D29323: Handle multi-line and rich-text notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text notifications on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29342: Implement support for notification urgency on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY While the notification levels map nicely, the behavior on Android with API level 26 or higher is slightly different

D29339: Implement updating of notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 AFFECTED FILES

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > nicolasfella wrote in NotifyByAndroid.java:171 > Please use > https://developer.android.com/reference/android/os/Build.VERSION_CODES > instead of hardcoding numbers That seems counter-productive to me, as the Android API documentation always

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. Collapsed: F8276057: Screenshot_20200501_161952.PNG Expanded: F8276059: Screenshot_20200501_162043.PNG REPOSITORY R289 KNotifications REVISION DETAIL

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is available starting at API level 20, which is below our minimal requirement. Grouping can be disabled by the

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. F8275264: Screenshot_20200501_124105.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY By default only a single line of the notification message is shown, for making longer messages readable we need to

D29268: [WIP] Add Date/Time dialog

2020-04-29 Thread Volker Krause
vkrause added a comment. There might be ways around the native function registration issue from the QML thread, e.g. by using the alternative approach of exported (mangled) symbols instead: https://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/design.html -> "Loading and Linking Native

D29079: android: include the architecture on the apk name

2020-04-22 Thread Volker Krause
vkrause added a comment. +1, I can't judge the impact on the subsequent pipeline though, such as the fdroid repo handling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks Cc: vkrause, kde-frameworks-devel,

D29079: android: include the architecture on the apk name

2020-04-22 Thread Volker Krause
vkrause added a comment. +1, I can't judge the impact on the subsequent pipeline though, such as the fdroid repo handling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks Cc: vkrause, kde-frameworks-devel,

D28834: Add metadata properties to calendar

2020-04-14 Thread Volker Krause
vkrause added a comment. In D28834#648405 , @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled

[frameworks-kio] [Bug 279664] [KRun] Use EFF's rule set from HTTPS Everywhere

2020-04-14 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=279664 --- Comment #6 from Volker Krause --- Certainly interesting, it could complement HSTS for hosts not supporting that yet. And yes, this is something you'd want to apply to all user-entered URLs, not limited to a specific application. I'm not so sure

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

2020-04-07 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

[kmail2] [Bug 409001] when opened message (incapsulated by outlook) kmail crashes

2020-04-07 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=409001 --- Comment #17 from Volker Krause --- wow, nice find, that's a nasty one -- You are receiving this mail because: You are the assignee for the bug.

[kmail2] [Bug 409001] when opened message (incapsulated by outlook) kmail crashes

2020-04-07 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=409001 --- Comment #17 from Volker Krause --- wow, nice find, that's a nasty one -- You are receiving this mail because: You are watching all bug changes.

[Akonadi] [Bug 416813] Crash on startup

2020-04-05 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416813 Volker Krause changed: What|Removed |Added CC||vkra...@kde.org Resolution

[Akonadi] [Bug 416813] Crash on startup

2020-04-05 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416813 Volker Krause changed: What|Removed |Added CC||vkra...@kde.org Resolution

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-05 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: New Framework Review: KDAV

2020-04-04 Thread Volker Krause
wrote: > Hello, > > On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav prot

Re: New Framework Review: KDAV

2020-04-04 Thread Volker Krause
wrote: > Hello, > > On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav prot

D27595: Watch for language change events, and forward those to the QML engine

2020-03-28 Thread Volker Krause
vkrause added subscribers: broulik, davidedmundson. vkrause added a comment. In D27595#636543 , @rikmills wrote: > git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 I haven't seen a

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D28030: Also expose the true minimum size to QML

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28030?vs=77578=77650 REVISION DETAIL

D27989: Add a new set of barcode size functions

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441=77647 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611=77612 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158=77610

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D27730

D28030: Also expose the true minimum size to QML

2020-03-13 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27989: Add a new set of barcode size functions

2020-03-11 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking

D27916: Add Overpass QL highlighting

2020-03-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27916?vs=77179=77372#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause added a comment. The deprecation version is off by one, but that will be fixed when rebasing the entire patch set on 5.69 once 5.68 is released. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n,

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We don't need to track the minimum size separately anymore, so avoid this getting

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause updated this revision to Diff 77179. vkrause added a comment. Highlight the {{bbox}} Overpass Turbo placeholder. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27916?vs=77177=77179 BRANCH master REVISION DETAIL

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D27916 AFFECTED

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-07 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes any kind of scaling from the specific implementations, they now

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Volker Krause
vkrause updated this revision to Diff 77128. vkrause added a comment. Alternative implementation for the barcode dimension API. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=76661=77128 BRANCH pending REVISION DETAIL

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:10054afd8243: Remove empty/unused private classes on internal types (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27727?vs=76657=76965

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27595: Watch for language change events, and forward those to the QML engine

2020-03-04 Thread Volker Krause
vkrause added a comment. I can reproduce only if I set a valid translation catalog. Even more surprising since the affected dialog does not seem to contain any qsTr() translations. I don't think this patch is wrong as such, the layouting glitch is a bug elsewhere that we trigger by the

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

[frameworks-kuserfeedback] [Bug 418330] kuserfeedback build looks for qt4 version of qmllint

2020-03-03 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=418330 --- Comment #1 from Volker Krause --- The Qt4 path isn't coming from kuserfeedback, all that's done there is `find_program(QMLLINT_EXECUTABLE qmllint)` (ie. find qmllint in $PATH). What does "which qmllint" report in the shell you trie

D26749: Support NDK r20 and Qt 5.14

2020-03-02 Thread Volker Krause
vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D26749: Support NDK r20 and Qt 5.14

2020-03-02 Thread Volker Krause
vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause
vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause
vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters for user code doing some more advanced layouting or size computations, especially once we remove the

D27727: Remove empty/unused private classes on internal types

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids unnecessary allocations. This also un-exports QRCodeBarcode, which is declared in a non-installed header

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by vkrause). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76316=76652 REVISION DETAIL

<    2   3   4   5   6   7   8   9   10   11   >