[Okular-devel] [okular] [Bug 346149] Konqui crash when closing tab with okular kpart

2015-04-15 Thread Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=346149 Dawit Alemayehu ada...@kde.org changed: What|Removed |Added Component|general |general Assignee

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-18 Thread Dawit Alemayehu
- src/core/ktcpsocket.h d59b180 src/core/ktcpsocket.cpp f223986 src/core/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-15 Thread Dawit Alemayehu
/ktcpsocket.h d59b180 src/core/ktcpsocket.cpp f223986 src/core/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-11 Thread Dawit Alemayehu
/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[kmail2] [Bug 342567] TLSv1.2 is not used on imap/smtp/managesieve

2015-01-07 Thread Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=342567 --- Comment #7 from Dawit Alemayehu ada...@kde.org --- I dunno this particular code base but what that patch does is bascially change the protocol to be used during SSL handshake from only TLSv1 to SSLv3/TLSv1. I am not entirely certain that QSslSocket

Re: Review Request 121092: Use QSslCertificate::fromDevice to load certs in KDE SSL Certificates dialog

2014-11-16 Thread Dawit Alemayehu
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/10/797589bb-56fd-4ee0-a45a-4a9694db1e88__test_qsslcertificate_import.cpp Thanks, Dawit Alemayehu

Review Request 121092: Use QSslCertificate::fromDevice to load certs in KDE SSL Certificates dialog

2014-11-10 Thread Dawit Alemayehu
-4a9694db1e88__test_qsslcertificate_import.cpp Thanks, Dawit Alemayehu

Re: Review Request 120975: Allow user to cancel out of the SSL certificate accept duration dialog

2014-11-05 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/120975/diff/ Testing --- File Attachments Accept dialog with cancel button https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png Thanks, Dawit Alemayehu

Review Request 120975: Allow user to cancel out of the SSL certificate accept duration dialog

2014-11-04 Thread Dawit Alemayehu
with cancel button https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png Thanks, Dawit Alemayehu

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-10-02 Thread Dawit Alemayehu
, Dawit Alemayehu

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-30 Thread Dawit Alemayehu
server. Thanks, Dawit Alemayehu

Re: Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-30 Thread Dawit Alemayehu
/r/120418/diff/ Testing --- Copy file from local directory to a webdav server. Thanks, Dawit Alemayehu

Review Request 120439: kio_webdav: Fix folder creation on apache + mod_dav webdav server

2014-09-30 Thread Dawit Alemayehu
apache to refuse any further requests. Diffs - kioslave/http/http.cpp 7e2bca7 Diff: https://git.reviewboard.kde.org/r/120439/diff/ Testing --- Tested on own local apache + mod_dav server. Thanks, Dawit Alemayehu

Re: Review Request 120439: kio_webdav: Fix folder creation on apache + mod_dav webdav server

2014-09-30 Thread Dawit Alemayehu
. Thanks, Dawit Alemayehu

Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-28 Thread Dawit Alemayehu
kioslave/http/http.cpp 7e2bca7 kioslave/http/webdav.protocol c0fbd11 Diff: https://git.reviewboard.kde.org/r/120418/diff/ Testing --- Copy file from local directory to a webdav server. Thanks, Dawit Alemayehu

Re: Review Request 120178: Set the kio_http responsecode metadata on error

2014-09-19 Thread Dawit Alemayehu
1068eb0e7780dd02f3af284e5d1ba932c06f4e1f Diff: https://git.reviewboard.kde.org/r/120178/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/#review66976 --- On Sept. 19, 2014, 11:25 a.m., Dawit Alemayehu wrote

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-17 Thread Dawit Alemayehu
. To reply, visit: https://git.reviewboard.kde.org/r/120182/#review66682 --- On Sept. 13, 2014, 12:38 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-17 Thread Dawit Alemayehu
) - kio/kio/copyjob.cpp 713255b Diff: https://git.reviewboard.kde.org/r/120182/diff/ Testing --- Mounted Andriod filesystem through sshfs and attempted to copy files through sftp. Thanks, Dawit Alemayehu

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-17 Thread Dawit Alemayehu
--- On Sept. 17, 2014, 12:55 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/ --- (Updated Sept

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-17 Thread Dawit Alemayehu
) - kio/kio/copyjob.cpp 713255b Diff: https://git.reviewboard.kde.org/r/120182/diff/ Testing --- Mounted Andriod filesystem through sshfs and attempted to copy files through sftp. Thanks, Dawit Alemayehu

Review Request 120178: Set the kio_http responsecode metadata on error

2014-09-13 Thread Dawit Alemayehu
/show_bug.cgi?id=337198 Repository: kdelibs Description --- The attached patch sets the HTTP responsecode metadata on error. Diffs - kioslave/http/http.cpp 1068eb0e7780dd02f3af284e5d1ba932c06f4e1f Diff: https://git.reviewboard.kde.org/r/120178/diff/ Testing --- Thanks, Dawit

Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-13 Thread Dawit Alemayehu
/120182/diff/ Testing --- Mounted Andriod filesystem through sshfs and attempted to copy files through sftp. Thanks, Dawit Alemayehu

Re: Review Request 119211: Queue CMD_REPARSECONFIGRATION requests for suspended ioslaves

2014-08-30 Thread Dawit Alemayehu
command if it is ever reused again. Diffs - kio/kio/connection.cpp 99aea0b Diff: https://git.reviewboard.kde.org/r/119211/diff/ Testing --- Run the steps given in the bug report before and after the fix. Thanks, Dawit Alemayehu

Re: Review Request 116570: Ask user for confirmation before doing POST - POST redirection in KIO

2014-08-30 Thread Dawit Alemayehu
, Dawit Alemayehu

Review Request 119211: Queue CMD_REPARSECONFIGRATION requests for suspended ioslaves

2014-07-10 Thread Dawit Alemayehu
Diff: https://git.reviewboard.kde.org/r/119211/diff/ Testing --- Run the steps given in the bug report before and after the fix. Thanks, Dawit Alemayehu

Re: Review Request 119211: Queue CMD_REPARSECONFIGRATION requests for suspended ioslaves

2014-07-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119211/#review62085 --- On July 10, 2014, 12:04 p.m., Dawit Alemayehu wrote

Re: Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-07-04 Thread Dawit Alemayehu
I cannot compile and test the fix myself yet. Diffs - src/klauncher/klauncher.cpp 31498e0 Diff: https://git.reviewboard.kde.org/r/119021/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-07-01 Thread Dawit Alemayehu
the fix myself yet. Diffs - src/klauncher/klauncher.cpp 31498e0 Diff: https://git.reviewboard.kde.org/r/119021/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 119020: Forward port fix for 142957 to kio in frameworks

2014-07-01 Thread Dawit Alemayehu
cannot compile and test the fix myself yet. Diffs (updated) - src/widgets/krun.cpp 77708a0 Diff: https://git.reviewboard.kde.org/r/119020/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-07-01 Thread Dawit Alemayehu
this because I cannot compile and test the fix myself yet. Diffs (updated) - src/klauncher/klauncher.cpp 31498e0 Diff: https://git.reviewboard.kde.org/r/119021/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 118954: Set directory to current working directory when executing Open With... dialog

2014-06-29 Thread Dawit Alemayehu
--- Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME. Thanks, Dawit Alemayehu

Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-06-29 Thread Dawit Alemayehu
/ Testing --- Thanks, Dawit Alemayehu

Review Request 119020: Forward port fix for 142957 to kio in frameworks

2014-06-29 Thread Dawit Alemayehu
: https://git.reviewboard.kde.org/r/119020/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 118954: Set directory to current working directory when executing Open With... dialog

2014-06-28 Thread Dawit Alemayehu
/118954/#review61122 --- On June 28, 2014, 2:09 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954

Re: Review Request 118954: Set directory to current working directory when executing Open With... dialog

2014-06-28 Thread Dawit Alemayehu
/ Testing --- Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME. Thanks, Dawit Alemayehu

Re: Review Request 118954: Set directory to current working directory when executing Open With... dialog

2014-06-27 Thread Dawit Alemayehu
--- Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME. Thanks, Dawit Alemayehu

Review Request 118954: Set directory to current working directory when executing Open With... dialog

2014-06-26 Thread Dawit Alemayehu
directory instead of $HOME. Thanks, Dawit Alemayehu

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

2014-06-18 Thread Dawit Alemayehu
compile KDE on rolling release based distros like ArchLinux without this patch. - Dawit Alemayehu On June 18, 2014, 11:40 a.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread Dawit Alemayehu
combobox. Diffs (updated) - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread Dawit Alemayehu
in Konqueror's URL combobox. Diffs - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu

[Okular-devel] [okular] [Bug 306417] opened new tab becomes active though not visible

2014-06-14 Thread Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=306417 Dawit Alemayehu ada...@kde.org changed: What|Removed |Added Component|tabbing |general Version

Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-14 Thread Dawit Alemayehu
/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

2014-05-24 Thread Dawit Alemayehu
On May 19, 2014, 12:05 p.m., Frank Reininghaus wrote: We are seeing quite a few bug reports about a severe regression between KDE SC 4.13.0 and KDE SC 4.13.1: https://bugs.kde.org/show_bug.cgi?id=334776 According to the reporter of https://bugs.kde.org/show_bug.cgi?id=334988

Re: Review Request 116602: fix setting ssl_was_in_use metadata

2014-03-26 Thread Dawit Alemayehu
suggested? - Dawit Alemayehu On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116602

Re: Review Request 116602: fix setting ssl_was_in_use metadata

2014-03-26 Thread Dawit Alemayehu
about the other suggestion I made. - Dawit Alemayehu On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116602

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-20 Thread Dawit Alemayehu
variables to 64 bits so they can accomodates dates beyond Feb 7, 2106. Diffs - kioslave/http/http.h dd85622 kioslave/http/http.cpp e4f1eba Diff: https://git.reviewboard.kde.org/r/116784/diff/ Testing --- Thanks, Dawit Alemayehu

Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
ftp server listed in the bug report. Diffs - kioslave/ftp/ftp.h cbcd096 kioslave/ftp/ftp.cpp b9d90e6 Diff: https://git.reviewboard.kde.org/r/116783/diff/ Testing --- Rerun all the tests run for 116524. Thanks, Dawit Alemayehu

Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread Dawit Alemayehu
/http.h dd85622 kioslave/http/http.cpp e4f1eba Diff: https://git.reviewboard.kde.org/r/116784/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52887 --- On March 13, 2014, 12:33 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
for 116524. Thanks, Dawit Alemayehu

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
for 116524. Thanks, Dawit Alemayehu

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/116783/#review52891 --- On March 13, 2014, 10:15 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116784/#review52897 --- On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
the tests run for 116524. Thanks, Dawit Alemayehu

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
on an Android device and run tests. Thanks, Dawit Alemayehu

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
, Dawit Alemayehu

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
to a remote destination, e.g. sftp server. Thanks, Dawit Alemayehu

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
message that states the file could not be opened. Diffs (updated) - kioslave/ftp/ftp.cpp ddc6eaf Diff: https://git.reviewboard.kde.org/r/116523/diff/ Testing --- Attempt to copy an empty file from any ftp server to a remote destination, e.g. sftp server. Thanks, Dawit Alemayehu

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52761 --- On March 12, 2014, 1:26 p.m., Dawit Alemayehu wrote

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
on an Android device and run tests. Thanks, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-11 Thread Dawit Alemayehu
it might work better on android (if it doesn't support absolute paths, maybe it doesn't support ../../foo/bar.txt either?). Dawit Alemayehu wrote: I have not been able to test whether it supported ../../foo/bar.txt yet. However, making the code relative to m_currentPath seems to work just

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-11 Thread Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52381 --- On March 7, 2014, 6:05 a.m., Dawit Alemayehu wrote

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
/http/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
/http.cpp b4d64d4 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Dawit Alemayehu
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: I tested your patch, no trailing slash is added whether the request refers to a collection or resource (as it was before commit 58294ac). Dawit Alemayehu wrote: Right, but now the webdav server should redirect to the right

Review Request 116570: Ask user for confirmation before doing POST - POST redirection in KIO

2014-03-06 Thread Dawit Alemayehu
File Attachments POST redirection confirm dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png Thanks, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-06 Thread Dawit Alemayehu
--- On March 3, 2014, 12:16 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 3

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-05 Thread Dawit Alemayehu
. - Dawit --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review51922 --- On March 2, 2014, 2:20 p.m., Dawit Alemayehu wrote

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-05 Thread Dawit Alemayehu
://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/116122/#review51879 --- On March 3, 2014, 3:50 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Dawit Alemayehu
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote: Still broken for webdav protocol (tested using konq/dolphin), can't delete file. isFile is always false whether you try to delete a file or folder so a trailing slash is always added. Dawit Alemayehu wrote: Well it works

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-03 Thread Dawit Alemayehu
/http/http.cpp 9eba5d1 Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing (updated) --- For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets Thanks, Dawit Alemayehu

Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-02 Thread Dawit Alemayehu
, e.g. sftp server. Thanks, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-02 Thread Dawit Alemayehu
On March 2, 2014, 12:14 a.m., Dawit Alemayehu wrote: I am curious if stripping the leading / and sending a relative path with the SIZE command would work for every FTP server? David Faure wrote: It's worth a try. I took at look at the very old svn history, and it has just always

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-02 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/116524/diff/ Testing --- Installed Ftp server from bug report on an Android device and run tests. Thanks, Dawit Alemayehu

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-01 Thread Dawit Alemayehu
a relative path with the SIZE command would work for every FTP server? - Dawit Alemayehu On March 2, 2014, 12:12 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
/httpredirects/t308methods.html http://www.w3.org/People/Bos/Test/redirect307.html Thanks, Dawit Alemayehu

Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Dawit Alemayehu
. It ensures that the fix is only applicable to webdav and the addition of the trailing slash is communicated to the client application. Diffs - Diff: https://git.reviewboard.kde.org/r/116122/diff/ Testing --- Thanks, Dawit Alemayehu

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
://www.w3.org/People/Bos/Test/redirect307.html Thanks, Dawit Alemayehu

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
/t308methods.html http://www.w3.org/People/Bos/Test/redirect307.html Thanks, Dawit Alemayehu

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
/t307methods.html http://greenbytes.de/tech/tc/httpredirects/t308methods.html Thanks, Dawit Alemayehu

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
/#review50957 --- On Feb. 26, 2014, 8:34 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
kio/kio/job.h aeaffa2 kio/kio/job.cpp edc5fed Diff: https://git.reviewboard.kde.org/r/116017/diff/ Testing --- http://greenbytes.de/tech/tc/httpredirects/t307methods.html http://greenbytes.de/tech/tc/httpredirects/t308methods.html Thanks, Dawit Alemayehu

Re: Review Request 116048: Remove Content-Type header when redirecting to GET

2014-02-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116048/#review50896 --- Ship it! Ship It! - Dawit Alemayehu On Feb. 25, 2014, 4

Review Request 116073: Do not use encoded URL when creating relative symlinks

2014-02-25 Thread Dawit Alemayehu
in the bug report to create a symlink to a file whose path or name contains characters that are not allowed in a URL. Thanks, Dawit Alemayehu

Re: Review Request 116073: Do not use encoded URL when creating relative symlinks

2014-02-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116073/#review50899 --- On Feb. 26, 2014, 6:31 a.m., Dawit Alemayehu wrote

Re: Review Request 116073: Do not use encoded URL when creating relative symlinks

2014-02-25 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/116073/diff/ Testing --- Follow the steps outlined in the bug report to create a symlink to a file whose path or name contains characters that are not allowed in a URL. Thanks, Dawit Alemayehu

Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
--- http://greenbytes.de/tech/tc/httpredirects/t307methods.html http://greenbytes.de/tech/tc/httpredirects/t308methods.html Thanks, Dawit Alemayehu

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
://git.reviewboard.kde.org/r/116017/#review50761 --- On Feb. 24, 2014, 2:07 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115864: kio_http: fixes for 30X response code redirection handling

2014-02-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115864/#review50296 --- Ship it! - Dawit Alemayehu On Feb. 19, 2014, 9:50 p.m

Re: Review Request 115864: kio_http: fixes for 30X response code redirection handling

2014-02-18 Thread Dawit Alemayehu
/115864/#comment35291 I think 301 can simply do the setMetaData call and pass on through 302 instead of duplicating the same exact code. - Dawit Alemayehu On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote

Re: Review Request 115864: kio_http: fixes for 30X response code redirection handling

2014-02-18 Thread Dawit Alemayehu
? - Dawit Alemayehu On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115864

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

2014-02-17 Thread Dawit Alemayehu
--- Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/ Thanks, Dawit Alemayehu

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

2014-02-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115689/#review49889 --- On Feb. 14, 2014, 4 p.m., Dawit Alemayehu wrote

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

2014-02-16 Thread Dawit Alemayehu
--- Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/ Thanks, Dawit Alemayehu

  1   2   3   4   5   6   7   >