Re: [PATCH v8 0/5] Support message-based DMA in vfio-user server

Stefan, to the best of my knowledge this is fully reviewed and ready to go in - can you kindly pick it up or advise in case there's something I missed? Thanks! On Mon, Mar 4, 2024 at 11:25 AM Peter Xu wrote: > > On Mon, Mar 04, 2024 at 02:05:49AM -0800, Mattias Nissler wrote: > >

[PATCH v8 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Reviewed-by: Peter Xu Tested-by: Jonathan Cameron Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - system/dma-helpers.c | 4 +- system/memory.c | 7 +++ system/physmem.c

[PATCH v8 2/5] softmmu: Support concurrent bounce buffers

-by: Peter Xu Tested-by: Jonathan Cameron Signed-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 +++ include/hw/pci/pci_device.h | 3 ++ system/memory.c | 5 ++- system/physmem.c| 80

[PATCH v8 4/5] vfio-user: Message-based DMA support

-by: Jagannathan Raman Signed-off-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 100 -- 2 files changed, 87 insertions(+), 15 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34

[PATCH v8 3/5] Update subprojects/libvfio-user

ocket pair" Adds support for separate sockets for either command direction, addressing a bug where libvfio-user gets confused if both client and server send commands concurrently. Reviewed-by: Jagannathan Raman Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 fi

[PATCH v8 5/5] vfio-user: Fix config space access byte order

-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c index a15e291c9a..0e93d7a7b4 100644 --- a/hw/remote/vfio-user-obj.c +++ b/hw/remote/vfio-user-obj.c @@ -281,7 +281,7

[PATCH v8 0/5] Support message-based DMA in vfio-user server

conflict in system/dma-helpers.c Changes from v7: * Rebase (applied cleanly) * Restore various Reviewed-by and Tested-by tags that I failed to carry forward (I double-checked that the patches haven't changed since the reviewed version) Mattias Nissler (5): softmmu: Per-AddressSpace bounce

Re: [PATCH, v2] physmem: avoid bounce buffer too small

On Thu, Feb 29, 2024 at 1:35 PM Peter Maydell wrote: > > On Thu, 29 Feb 2024 at 11:17, Heinrich Schuchardt > wrote: > > > But yes, I'm not surprised that CXL runs into this. Heinrich, > > > are you doing CXL testing, or is this some other workload? > > > > I am running the UEFI

Re: [PATCH, v2] physmem: avoid bounce buffer too small

On Thu, Feb 29, 2024 at 12:12 PM Peter Maydell wrote: > > On Thu, 29 Feb 2024 at 10:59, Jonathan Cameron > wrote: > > > > On Thu, 29 Feb 2024 09:38:29 + > > Peter Maydell wrote: > > > > > On Wed, 28 Feb 2024 at 19:07, Heinrich Schuchardt > > > wrote: > > > > > > > > On 28.02.24 19:39,

Re: [PATCH v7 0/5] Support message-based DMA in vfio-user server

up if you disagree. Thanks, Mattias On Tue, Feb 20, 2024 at 6:06 AM Peter Xu wrote: > > On Mon, Feb 12, 2024 at 12:06:12AM -0800, Mattias Nissler wrote: > > Changes from v6: > > > > * Rebase, resolve straightforward merge conflict in system/dma-helpers.c > >

Re: [PATCH, v2] physmem: avoid bounce buffer too small

On Thu, Feb 29, 2024 at 11:22 AM Heinrich Schuchardt wrote: > > On 29.02.24 02:11, Peter Xu wrote: > > On Wed, Feb 28, 2024 at 08:07:47PM +0100, Heinrich Schuchardt wrote: > >> On 28.02.24 19:39, Peter Maydell wrote: > >>> On Wed, 28 Feb 2024 at 18:28, Heinrich Schuchardt > >>> wrote: > >

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

On Thu, Feb 15, 2024 at 4:29 PM Jonathan Cameron < jonathan.came...@huawei.com> wrote: > On Thu, 8 Feb 2024 14:50:59 + > Jonathan Cameron wrote: > > > On Wed, 7 Feb 2024 17:34:15 + > > Jonathan Cameron wrote: > > > > > On Fri, 2 Feb 2024 16:56:18 + > > > Peter Maydell wrote: > > >

[PATCH v7 5/5] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v7 3/5] Update subprojects/libvfio-user

ocket pair" Adds support for separate sockets for either command direction, addressing a bug where libvfio-user gets confused if both client and server send commands concurrently. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 0/5] Support message-based DMA in vfio-user server

to master due to a minor merge conflict. I've just sent a rebased version to address that. Stefan, are you OK to pick this up for merging at your next convenience? Thanks, Mattias On Fri, Feb 9, 2024 at 6:39 PM Jonathan Cameron wrote: > On Wed, 1 Nov 2023 06:16:06 -0700 > Mattias N

[PATCH v7 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - system/dma-helpers.c | 4 +- system/memory.c | 7 +++ system/physmem.c | 101 -- 5

[PATCH v7 2/5] softmmu: Support concurrent bounce buffers

-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 +++ include/hw/pci/pci_device.h | 3 ++ system/memory.c | 5 ++- system/physmem.c| 80 + 5 files changed, 74 insertions(+), 36

[PATCH v7 4/5] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 100 -- 2 files changed, 87 insertions(+), 15 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace

[PATCH v7 0/5] Support message-based DMA in vfio-user server

conflict in system/dma-helpers.c Mattias Nissler (5): softmmu: Per-AddressSpace bounce buffering softmmu: Support concurrent bounce buffers Update subprojects/libvfio-user vfio-user: Message-based DMA support vfio-user: Fix config space access byte order hw/pci/pci.c |

[PATCH v6 5/5] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v6 3/5] Update subprojects/libvfio-user

ocket pair" Adds support for separate sockets for either command direction, addressing a bug where libvfio-user gets confused if both client and server send commands concurrently. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v6 2/5] softmmu: Support concurrent bounce buffers

-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 +++ include/hw/pci/pci_device.h | 3 ++ system/memory.c | 5 ++- system/physmem.c| 80 + 5 files changed, 74 insertions(+), 36

[PATCH v6 4/5] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 100 -- 2 files changed, 87 insertions(+), 15 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace

[PATCH v6 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - system/dma-helpers.c | 4 +- system/memory.c | 7 +++ system/physmem.c | 101 -- 5

[PATCH v6 0/5] Support message-based DMA in vfio-user server

opriately, so my hope is that this will be the final iteration. Stefan, Peter, Jag, thanks for your feedback, let me know if there's anything else needed from my side before this can get merged. Mattias Nissler (5): softmmu: Per-AddressSpace bounce buffering softmmu: Support concurrent bounc

Re: [RFC] Proposal of QEMU PCI Endpoint test environment

On Fri, Oct 6, 2023 at 1:51 PM Shunsuke Mie wrote: > > > On 2023/10/05 16:02, Mattias Nissler wrote: > > On Thu, Oct 5, 2023 at 3:31 AM Shunsuke Mie wrote: > >> Hi Jiri, Mattias and all. > >> > >> 2023年10月4日(水) 16:36 Mattias Nissler : > >>>

Re: [PATCH v5 4/5] vfio-user: Message-based DMA support

On Wed, Oct 4, 2023 at 4:54 PM Jag Raman wrote: > > > > On Sep 20, 2023, at 4:06 AM, Mattias Nissler > wrote: > > > > Wire up support for DMA for the case where the vfio-user client does not > > provide mmap()-able file descriptors, but DMA requests must b

Re: [PATCH v5 5/5] vfio-user: Fix config space access byte order

On Thu, Oct 5, 2023 at 6:30 PM Jag Raman wrote: > > > > On Sep 20, 2023, at 4:06 AM, Mattias Nissler > wrote: > > > > PCI config space is little-endian, so on a big-endian host we need to > > perform byte swaps for values as they are passed to and received from

Re: [RFC] Proposal of QEMU PCI Endpoint test environment

On Thu, Oct 5, 2023 at 3:31 AM Shunsuke Mie wrote: > > Hi Jiri, Mattias and all. > > 2023年10月4日(水) 16:36 Mattias Nissler : >>> >>> hi shunsuke, all, >>> what about vfio-user + qemu? > > Thank you for the suggestion. > >> FWIW, I have ha

Re: [RFC] Proposal of QEMU PCI Endpoint test environment

> > hi shunsuke, all, > what about vfio-user + qemu? > FWIW, I have had some good success using VFIO-user to bridge software components to hardware designs. For the most part, I have been hooking up software endpoint models to hardware design components speaking the PCIe transaction layer

[PATCH v5 2/5] softmmu: Support concurrent bounce buffers

-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 +++ include/hw/pci/pci_device.h | 3 ++ softmmu/memory.c| 5 ++- softmmu/physmem.c | 80 + 5 files changed, 74 insertions(+), 36

[PATCH v5 5/5] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v5 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - softmmu/dma-helpers.c | 4 +- softmmu/memory.c | 7 +++ softmmu/physmem.c | 101 -- 5

[PATCH v5 3/5] Update subprojects/libvfio-user

ocket pair" Adds support for separate sockets for either command direction, addressing a bug where libvfio-user gets confused if both client and server send commands concurrently. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v5 0/5] Support message-based DMA in vfio-user server

4: * Fix accidentally dropped memory_region_unref, control flow restored to match previous code to simplify review. * Some cosmetic fixes. Mattias Nissler (5): softmmu: Per-AddressSpace bounce buffering softmmu: Support concurrent bounce buffers Update subprojects/libvfio-user vfio-user

[PATCH v5 4/5] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 84 +++ 2 files changed, 79 insertions(+), 7 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace-events

Re: [PATCH v4 2/5] softmmu: Support concurrent bounce buffers

On Tue, Sep 19, 2023 at 7:14 PM Peter Xu wrote: > > On Tue, Sep 19, 2023 at 09:08:10AM -0700, Mattias Nissler wrote: > > @@ -3119,31 +3143,35 @@ void *address_space_map(AddressSpace *as, > > void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, > >

[PATCH v4 2/5] softmmu: Support concurrent bounce buffers

-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 +++--- include/hw/pci/pci_device.h | 3 ++ softmmu/memory.c| 5 ++- softmmu/physmem.c | 88 - 5 files changed, 77 insertions(+), 41

[PATCH v4 3/5] Update subprojects/libvfio-user

ocket pair" Adds support for separate sockets for either command direction, addressing a bug where libvfio-user gets confused if both client and server send commands concurrently. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 5/5] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 4/5] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 84 +++ 2 files changed, 79 insertions(+), 7 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace-events

[PATCH v4 0/5] Support message-based DMA in vfio-user server

MA access commands. See https://github.com/nutanix/libvfio-user/issues/279 for details. * Add missing teardown code in do_address_space_destroy. * Fix bounce buffer size bookkeeping race condition. * Generate unmap notification callbacks unconditionally. * Some cosmetic fixes. Mattias N

[PATCH v4 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - softmmu/dma-helpers.c | 4 +- softmmu/memory.c | 7 +++ softmmu/physmem.c | 103 -- 5

Re: [PATCH v3 1/5] softmmu: Per-AddressSpace bounce buffering

On Fri, Sep 15, 2023 at 10:37 AM Mattias Nissler wrote: > > On Wed, Sep 13, 2023 at 8:30 PM Peter Xu wrote: > > > > On Thu, Sep 07, 2023 at 06:04:06AM -0700, Mattias Nissler wrote: > > > @@ -3105,6 +3105,9 @@ void address_space_init(AddressSpace *as, > > >

Re: [PATCH v3 5/5] vfio-user: Fix config space access byte order

On Thu, Sep 14, 2023 at 10:32 PM Stefan Hajnoczi wrote: > > On Thu, Sep 07, 2023 at 06:04:10AM -0700, Mattias Nissler wrote: > > PCI config space is little-endian, so on a big-endian host we need to > > perform byte swaps for values as they are passed to and received from &

Re: [PATCH v3 4/5] vfio-user: Message-based DMA support

On Thu, Sep 14, 2023 at 9:04 PM Stefan Hajnoczi wrote: > > On Thu, Sep 07, 2023 at 06:04:09AM -0700, Mattias Nissler wrote: > > Wire up support for DMA for the case where the vfio-user client does not > > provide mmap()-able file descriptors, but DMA requests must be performe

Re: [PATCH v3 2/5] softmmu: Support concurrent bounce buffers

On Thu, Sep 14, 2023 at 8:49 PM Stefan Hajnoczi wrote: > > On Thu, Sep 07, 2023 at 06:04:07AM -0700, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > >

Re: [PATCH v3 2/5] softmmu: Support concurrent bounce buffers

On Wed, Sep 13, 2023 at 9:11 PM Peter Xu wrote: > > On Thu, Sep 07, 2023 at 06:04:07AM -0700, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > > file descr

Re: [PATCH v3 1/5] softmmu: Per-AddressSpace bounce buffering

On Wed, Sep 13, 2023 at 8:30 PM Peter Xu wrote: > > On Thu, Sep 07, 2023 at 06:04:06AM -0700, Mattias Nissler wrote: > > @@ -3105,6 +3105,9 @@ void address_space_init(AddressSpace *as, > > MemoryRegion *root, const char *name) > > as->ioeventfds = NULL; >

Re: [PATCH v3 0/5] Support message-based DMA in vfio-user server

On Thu, Sep 14, 2023 at 4:39 PM Stefan Hajnoczi wrote: > > On Thu, Sep 07, 2023 at 06:04:05AM -0700, Mattias Nissler wrote: > > This series adds basic support for message-based DMA in qemu's vfio-user > > server. This is useful for cases where the client does not provide fi

[PATCH v3 4/5] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 84 +++ 2 files changed, 79 insertions(+), 7 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace-events

[PATCH v3 3/5] Update subprojects/libvfio-user

Brings in assorted bug fixes. In particular, "Fix address calculation for message-based DMA" corrects a bug in DMA address calculation which is necessary to get DMA across VFIO-user messages working. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file

[PATCH v3 2/5] softmmu: Support concurrent bounce buffers

-off-by: Mattias Nissler --- hw/pci/pci.c| 8 include/exec/memory.h | 14 ++ include/hw/pci/pci_device.h | 3 ++ softmmu/memory.c| 3 +- softmmu/physmem.c | 94 + 5 files changed, 80 insertions(+), 42

[PATCH v3 0/5] Support message-based DMA in vfio-user server

buffer struct as a best effort measure to detect invalid pointers in address_space_unmap. Mattias Nissler (5): softmmu: Per-AddressSpace bounce buffering softmmu: Support concurrent bounce buffers Update subprojects/libvfio-user vfio-user: Message-based DMA support vfio-user: Fix config

[PATCH v3 5/5] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 1/5] softmmu: Per-AddressSpace bounce buffering

configured per AddressSpace. Signed-off-by: Mattias Nissler --- include/exec/cpu-common.h | 2 - include/exec/memory.h | 45 - softmmu/dma-helpers.c | 4 +- softmmu/memory.c | 3 ++ softmmu/physmem.c | 103 -- 5

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

On Tue, Sep 5, 2023 at 3:45 PM Peter Xu wrote: > > On Tue, Sep 05, 2023 at 09:38:39AM +0200, Mattias Nissler wrote: > > It would be nice to use a property on the device that originates the > > DMA operation to configure this. However, I don't see how to do this > > in

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

On Fri, Sep 1, 2023 at 3:41 PM Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > On Wed, Aug 23, 2023 at 04:54:06PM -0400, Peter Xu wrote: > >> On Wed, Aug 23, 2023 at 10:08:08PM +0200, Mattias Nissler wrote: > >> > On Wed, Aug 23, 2023 at 7:35 PM P

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

On Wed, Aug 23, 2023 at 10:54 PM Peter Xu wrote: > > On Wed, Aug 23, 2023 at 10:08:08PM +0200, Mattias Nissler wrote: > > Peter, thanks for taking a look and providing feedback! > > > > On Wed, Aug 23, 2023 at 7:35 PM Peter Xu wrote: > > > > > > On Wed,

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

Peter, thanks for taking a look and providing feedback! On Wed, Aug 23, 2023 at 7:35 PM Peter Xu wrote: > > On Wed, Aug 23, 2023 at 02:29:02AM -0700, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in

[PATCH v2 4/4] vfio-user: Fix config space access byte order

PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 2/4] Update subprojects/libvfio-user

Brings in assorted bug fixes. In particular, "Fix address calculation for message-based DMA" corrects a bug in DMA address calculation which is necessary to get DMA across VFIO-user messages working. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file

[PATCH v2 0/4] Support message-based DMA in vfio-user server

that I've included a fix for. Mattias Nissler (4): softmmu: Support concurrent bounce buffers Update subprojects/libvfio-user vfio-user: Message-based DMA support vfio-user: Fix config space access byte order hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 88

[PATCH v2 3/4] vfio-user: Message-based DMA support

-by: Mattias Nissler --- hw/remote/trace-events| 2 + hw/remote/vfio-user-obj.c | 84 +++ 2 files changed, 79 insertions(+), 7 deletions(-) diff --git a/hw/remote/trace-events b/hw/remote/trace-events index 0d1b7d56a5..358a68fb34 100644 --- a/hw/remote/trace-events

[PATCH v2 1/4] softmmu: Support concurrent bounce buffers

-by: Mattias Nissler --- include/sysemu/sysemu.h | 2 + qemu-options.hx | 27 + softmmu/globals.c | 1 + softmmu/physmem.c | 84 +++-- softmmu/vl.c| 6 +++ 5 files changed, 83 insertions(+), 37 deletions(-) diff --git

Re: [PATCH 3/3] vfio-user: Message-based DMA support

On Thu, Jul 20, 2023 at 8:32 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:27AM -0700, Mattias Nissler wrote: > > Wire up support for DMA for the case where the vfio-user client does not > > provide mmap()-able file descriptors, but DMA requests must be performe

Re: [PATCH 1/3] softmmu: Support concurrent bounce buffers

On Thu, Jul 20, 2023 at 8:10 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:25AM -0700, Mattias Nissler wrote: > > It is not uncommon for device models to request mapping of several DMA > > regions at the same time. An example is igb (and probably other net > &g

Re: [PATCH 2/3] softmmu: Remove DMA unmap notification callback

On Thu, Jul 20, 2023 at 8:14 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:26AM -0700, Mattias Nissler wrote: > > According to old commit messages, this was introduced to retry a DMA > > operation at a later point in case the single bounce buffer is fo

Re: [PATCH 0/3] Support message-based DMA in vfio-user server

. Thanks, Mattias On Thu, Jul 20, 2023 at 8:41 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:24AM -0700, Mattias Nissler wrote: > > This series adds basic support for message-based DMA in qemu's vfio-user > > server. This is useful for cases where the client doe

[PATCH 2/3] softmmu: Remove DMA unmap notification callback

(concurrently) and just failed. After the improvement to support multiple concurrent bounce buffers, the condition the notification callback allowed to work around no longer exists, so we can just remove the logic and simplify the code. Signed-off-by: Mattias Nissler --- softmmu/dma-helpers.c | 28

[PATCH 0/3] Support message-based DMA in vfio-user server

this to be addressed in a separate patch. Mattias Nissler (3): softmmu: Support concurrent bounce buffers softmmu: Remove DMA unmap notification callback vfio-user: Message-based DMA support hw/remote/vfio-user-obj.c | 62 -- softmmu/dma-helpers.c | 28 softmmu/physmem.c

[PATCH 3/3] vfio-user: Message-based DMA support

on the github issue for more details. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 62 ++- 1 file changed, 55 insertions(+), 7 deletions(-) diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c index 8b10c32a3c..9799580c77 100644

[PATCH 1/3] softmmu: Support concurrent bounce buffers

the device model in a vfio-server process without mmap()-ed DMA, this change allocates DMA bounce buffers dynamically instead of supporting only a single buffer. Signed-off-by: Mattias Nissler --- softmmu/physmem.c | 74 ++- 1 file changed, 35 insertions(+), 39

[PATCH] hw/remote: Fix vfu_cfg trace offset format

The printed offset value is prefixed with 0x, but was actually printed in decimal. To spare others the confusion, adjust the format specifier to hexadecimal. Signed-off-by: Mattias Nissler --- hw/remote/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

On Fri, Jan 15, 2021 at 6:46 AM Sai Prakash Ranjan wrote: > > Hello Mathieu, Suzuki > > On 2020-10-15 21:32, Mathieu Poirier wrote: > > On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > >> On production systems with ETMs enabled, it is preferred to > >> exclude kernel mode(NS

Re: [PATCH 4.9 30/47] ANDROID: binder: remove waitqueue when thread exits.

> > > > > > Prevent this by using POLLFREE when the thread exits. > > > > > > Signed-off-by: Martijn Coenen > > > Reported-by: syzbot > > > Cc: stable # 4.14 > > > [backport BINDER_LOOPER_STATE_POLL logic as well] > > &

Re: [PATCH 3/3] brcmfmac: Add check for short event packets

f additional event > data. Ensure that the received packet actually contains at least > DATALEN bytes of additional data, to avoid copying uninitialized memory > into event->data. > > Suggested-by: Mattias Nissler <mniss...@chromium.org> > Signed-off-by: Kevin Cernekee

Re: [PATCH v2] Add a "nosymlinks" mount option.

On Mon, Nov 21, 2016 at 6:10 PM, James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On Wed, 2016-11-16 at 13:18 -0800, Mattias Nissler wrote: >> I understand that silence suggests there's little interest, but >> here's some new information I discovered t

Re: [PATCH v2] Add a "nosymlinks" mount option.

On Mon, Nov 21, 2016 at 6:10 PM, James Bottomley wrote: > On Wed, 2016-11-16 at 13:18 -0800, Mattias Nissler wrote: >> I understand that silence suggests there's little interest, but >> here's some new information I discovered today that may justify to >> reconsider the

Re: [PATCH v2] Add a "nosymlinks" mount option.

On Thu, Nov 17, 2016 at 1:43 PM, Austin S. Hemmelgarn <ahferro...@gmail.com> wrote: > On 2016-11-16 16:18, Mattias Nissler wrote: >> >> I understand that silence suggests there's little interest, but here's >> some new information I discovered today that may justify

Re: [PATCH v2] Add a "nosymlinks" mount option.

On Thu, Nov 17, 2016 at 1:43 PM, Austin S. Hemmelgarn wrote: > On 2016-11-16 16:18, Mattias Nissler wrote: >> >> I understand that silence suggests there's little interest, but here's >> some new information I discovered today that may justify to reconsider >> the pa

[PATCH v3] Add a "nosymfollow" mount option.

ting the "nosymfollow" mount option helps prevent privileged writers from modifying files unintentionally in case there is an unexpected link along the accessed path. The "nosymfollow" option is thus useful as a defensive measure for systems that need to deal with untru

[PATCH v3] Add a "nosymfollow" mount option.

ting the "nosymfollow" mount option helps prevent privileged writers from modifying files unintentionally in case there is an unexpected link along the accessed path. The "nosymfollow" option is thus useful as a defensive measure for systems that need to deal with untrusted f

Re: [PATCH v2] Add a "nosymlinks" mount option.

eebsd/blob/a41f4cc9a57cd74604ae7b051eec2f48865f18d6/sys/kern/vfs_lookup.c#L939 There's also some evidence on the net that people have been using said nosymfollow mount option to mitigate symlink attacks. On Mon, Oct 24, 2016 at 7:09 AM, Mattias Nissler <mniss...@chromium.org> wrote: > Friendly ping

Re: [PATCH v2] Add a "nosymlinks" mount option.

eebsd/blob/a41f4cc9a57cd74604ae7b051eec2f48865f18d6/sys/kern/vfs_lookup.c#L939 There's also some evidence on the net that people have been using said nosymfollow mount option to mitigate symlink attacks. On Mon, Oct 24, 2016 at 7:09 AM, Mattias Nissler wrote: > Friendly ping - does this version of the p

Re: [PATCH v2] Add a "nosymlinks" mount option.

Friendly ping - does this version of the patch have any chance on getting included in mainline? On Wed, Oct 19, 2016 at 2:31 PM, Mattias Nissler <mniss...@chromium.org> wrote: > For mounts that have the new "nosymlinks" option, don't follow > symlinks when resolving

Re: [PATCH v2] Add a "nosymlinks" mount option.

Friendly ping - does this version of the patch have any chance on getting included in mainline? On Wed, Oct 19, 2016 at 2:31 PM, Mattias Nissler wrote: > For mounts that have the new "nosymlinks" option, don't follow > symlinks when resolving paths. The new option is s

[PATCH v2] Add a "nosymlinks" mount option.

pected link along the accessed path. The "nosymlinks" option is thus useful as a defensive measure for systems that need to deal with untrusted file systems in privileged contexts. Signed-off-by: Mattias Nissler <mniss...@chromium.org> --- fs/namei.c | 3 +++ fs/na

[PATCH v2] Add a "nosymlinks" mount option.

pected link along the accessed path. The "nosymlinks" option is thus useful as a defensive measure for systems that need to deal with untrusted file systems in privileged contexts. Signed-off-by: Mattias Nissler --- fs/namei.c | 3 +++ fs/namespace.c | 9 ++---

Re: [RFC] [PATCH] Add a "nolinks" mount option.

On Tue, Oct 18, 2016 at 5:14 PM, Colin Walters <walt...@verbum.org> wrote: > > On Mon, Oct 17, 2016, at 09:02 AM, Mattias Nissler wrote: > > OK, no more feedback thus far. Is there generally any interest in a > > mount option to avoid path name aliasing resulting in t

Re: [RFC] [PATCH] Add a "nolinks" mount option.

On Tue, Oct 18, 2016 at 5:14 PM, Colin Walters wrote: > > On Mon, Oct 17, 2016, at 09:02 AM, Mattias Nissler wrote: > > OK, no more feedback thus far. Is there generally any interest in a > > mount option to avoid path name aliasing resulting in target file > > conf

Re: [RFC] [PATCH] Add a "nolinks" mount option.

ptable. > > On Fri, Oct 14, 2016 at 5:50 PM, Mattias Nissler <mniss...@chromium.org> > wrote: >> On Fri, Oct 14, 2016 at 5:00 PM, Al Viro <v...@zeniv.linux.org.uk> wrote: >>> >>> On Fri, Oct 14, 2016 at 03:55:15PM +0100, Al Viro wrote: >>>

Re: [RFC] [PATCH] Add a "nolinks" mount option.

t 14, 2016 at 5:50 PM, Mattias Nissler > wrote: >> On Fri, Oct 14, 2016 at 5:00 PM, Al Viro wrote: >>> >>> On Fri, Oct 14, 2016 at 03:55:15PM +0100, Al Viro wrote: >>> > > Setting the "nolinks" mount option helps prevent privileged writers >&

Re: [RFC] [PATCH] Add a "nolinks" mount option.

Forgot to mention: I realize my motivation is very specific to Chrome OS, however the nolinks option seemed useful also as a mitigation to generic privilege escalation symlink attacks, for cases where disabling symlinks/hardlinks is acceptable. On Fri, Oct 14, 2016 at 5:50 PM, Mattias Nissler

Re: [RFC] [PATCH] Add a "nolinks" mount option.

Forgot to mention: I realize my motivation is very specific to Chrome OS, however the nolinks option seemed useful also as a mitigation to generic privilege escalation symlink attacks, for cases where disabling symlinks/hardlinks is acceptable. On Fri, Oct 14, 2016 at 5:50 PM, Mattias Nissler

Re: [RFC] [PATCH] Add a "nolinks" mount option.

On Fri, Oct 14, 2016 at 5:00 PM, Al Viro wrote: > > On Fri, Oct 14, 2016 at 03:55:15PM +0100, Al Viro wrote: > > > Setting the "nolinks" mount option helps prevent privileged writers > > > from modifying files unintentionally in case there is an unexpected > > > link

Re: [RFC] [PATCH] Add a "nolinks" mount option.

On Fri, Oct 14, 2016 at 5:00 PM, Al Viro wrote: > > On Fri, Oct 14, 2016 at 03:55:15PM +0100, Al Viro wrote: > > > Setting the "nolinks" mount option helps prevent privileged writers > > > from modifying files unintentionally in case there is an unexpected > > > link along the accessed path. The

[RFC] [PATCH] Add a "nolinks" mount option.

ontrol of the attacker, who can place symlinks to trick file writes after reboot to target a file of their choice. "nolinks" fundamentally prevents this. Signed-off-by: Mattias Nissler <mniss...@chromium.org> --- fs/namei.c | 9 - fs/namespace.c | 8 +

[RFC] [PATCH] Add a "nolinks" mount option.

ontrol of the attacker, who can place symlinks to trick file writes after reboot to target a file of their choice. "nolinks" fundamentally prevents this. Signed-off-by: Mattias Nissler --- fs/namei.c | 9 - fs/namespace.c | 8 +--- fs/proc_namespace.c

Re: debugfs_create_{u,x,s}{8,16,32,64}

On Wed, Aug 13, 2014 at 11:57 PM, Greg KH wrote: > > On Wed, Aug 13, 2014 at 02:57:05PM -0700, Matt Longnecker wrote: > > Greg, > > > > Back in December 2007 Mattias Nissler proposed a patch defining > > debugfs_create_s32 and friends. In it he reworked the already

  1   2   >