[FFmpeg-cvslog] avformat/mov: Fix MSAN issue with stsd_id

2024-04-14 Thread Thomas Guilbert
ffmpeg | branch: release/6.0 | Thomas Guilbert | Wed Nov 15 20:28:49 2023 +| [9258cc72cb8ed5a20285eb39a11547fb50b5432b] | committer: Michael Niedermayer avformat/mov: Fix MSAN issue with stsd_id Fixes: use of uninitialized value Fixes: bbb-320x240-2video-2audio.mp4 Signed-off-by: Michael

Re: [blink-dev] Re: Intent to Implement and Ship: OpusEncoderConfig `signal` and `application` parameters

2024-04-04 Thread 'Thomas Guilbert' via blink-dev
The last launch gate approval came in today. Thanks! On Wed, Apr 3, 2024 at 11:49 AM Thomas Guilbert wrote: > I agree that this would have been a viable solution, and this was > considered and discussed with the spec editors too [1]. These Opus flags > were originally

Re: [blink-dev] Re: Intent to Implement and Ship: OpusEncoderConfig `signal` and `application` parameters

2024-04-03 Thread 'Thomas Guilbert' via blink-dev
chromium.org/d/msgid/blink-dev/CADxkKiLH6ViLccGxHZzbCG_ChtSxiG59XoeYMPRqeW1Wk410rg%40mail.gmail.com > > [2] ContentHint: > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9K9_YmJRFn%3DQBKb0GsETsSFex0DPprMRRpWUWgcvAtbA%40mail.gmail.com > > > On 2024-03-28 08:43, Yoav Weiss (@Shopify) wrote: > > Thanks

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-04-02 Thread 'Thomas Guilbert' via blink-dev
gt; > LGTM2. Please be sure to update Chrome Status with the deprecation trial > timelines and removal milestones so that data gets fed into the feature > dashboard, beta blog posts, etc. > > On Fri, Feb 2, 2024 at 7:35 AM Thomas Guilbert > wrote: > >> Thank you! >> &

[blink-dev] Re: Intent to Implement and Ship: OpusEncoderConfig `signal` and `application` parameters

2024-03-27 Thread Thomas Guilbert
t; > On Tuesday, March 26, 2024 at 11:29:53 PM UTC+1 Thomas Guilbert wrote: > >> Contact emailstguilb...@chromium.org >> >> ExplainerNone >> >> Specification >> https://w3c.github.io/webcodecs/opus_codec_registration.html#dom-opusencoderco

[blink-dev] Intent to Implement and Ship: OpusEncoderConfig `signal` and `application` parameters

2024-03-26 Thread Thomas Guilbert
Contact emailstguilb...@chromium.org ExplainerNone Specification https://w3c.github.io/webcodecs/opus_codec_registration.html#dom-opusencoderconfig-signal Summary `OpusEncoderConfig.signal` and `OpusEncoderConfig.application` were recently added to the WebCodecs spec [1]. Both parameters are

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-02-01 Thread Thomas Guilbert
al to re-enable them for 6 months. If you hear feedback requesting an > extension towards the end of those 6 months, please request an extension > for another 6 months. > > On Thu, Feb 1, 2024 at 12:43 AM Thomas Guilbert > wrote: > >> Thanks for marking it for review

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-31 Thread 'Thomas Guilbert' via blink-dev
eature/5259513871466496 is linked from the > bottom, so our review tooling is presenting that to us. But I've just > flagged the new one so it will show up as well. > > thanks! > On 1/31/24 2:41 PM, Thomas Guilbert wrote: > > I requested privacy/security/debuggability on the vid

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-31 Thread Thomas Guilbert
ly blocking LGTMs). >> >> On Wednesday, January 24, 2024 at 7:23:28 AM UTC-5 Mike Taylor wrote: >> >>> Would you mind requesting reviews for the various gates (privacy, >>> security, debuggability) for an OT/DT in your chromestatus entry? >>> On 1/19/24 10

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-29 Thread 'Thomas Guilbert' via blink-dev
ow about we > start with 6 months, and if we see that there are sites using the trial to > re-enable the feature, then we extend it by another 6 months. Would that > work? > > On Thu, Jan 25, 2024 at 9:22 PM Thomas Guilbert > wrote: > >> Thank you Wesley for the useful information!

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-25 Thread Thomas Guilbert
ver supported the generic >>> fullscreen API until very recent >>> https://twitter.com/jensimmons/status/1717937227190460797 >>> It always required the webkit prefixed API on the video element (not any >>> other element like a div etc ) >>> Y'all are

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-24 Thread Thomas Guilbert
I opened a support ticket with Mux, and opened an issue for Clappr <https://github.com/clappr/clappr/issues/2136>. On Wed, Jan 24, 2024 at 3:40 PM Thomas Guilbert wrote: > I've created a new ChromeStatus entry > <https://chromestatus.com/feature/5111638103687168>, and reque

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-24 Thread Thomas Guilbert
gt; > On Tue, Jan 23, 2024 at 7:55 AM Thomas Guilbert > wrote: > >> Good point about the most used APIs being the boolean properties! The >> APIs are now only aliases for the standard non-prefixed fullscreen APIs (see >> this code for the current implementation >> <h

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-22 Thread Thomas Guilbert
or would this sampling be enough? Thank you, Thomas On Sun, Jan 21, 2024 at 7:56 PM Domenic Denicola wrote: > It would be very exciting to clean this up! I have some questions that > might help clarify the cost-benefit analysis. > > On Sat, Jan 20, 2024 at 6:43 AM Thomas Guil

[blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-19 Thread Thomas Guilbert
Contact emails tguilb...@chromium.org Explainer None Specification https://fullscreen.spec.whatwg.org/#dom-document-fullscreenenabled Summary There was an attempt in 2014 to deprecate and remove the

[FFmpeg-cvslog] avformat/mov: Fix MSAN issue with stsd_id

2023-12-29 Thread Thomas Guilbert
ffmpeg | branch: release/6.1 | Thomas Guilbert | Wed Nov 15 20:28:49 2023 +| [2bd36ef4c7709a4beaef358a75408c0d6f9e3ea7] | committer: Michael Niedermayer avformat/mov: Fix MSAN issue with stsd_id Fixes: use of uninitialized value Fixes: bbb-320x240-2video-2audio.mp4 Signed-off-by: Michael

[FFmpeg-cvslog] avformat/mov: Fix MSAN issue with stsd_id

2023-12-29 Thread Thomas Guilbert
ffmpeg | branch: master | Thomas Guilbert | Wed Nov 15 20:28:49 2023 +| [ff451df9479810d75851f92babd0b4290da03dd6] | committer: Michael Niedermayer avformat/mov: Fix MSAN issue with stsd_id Fixes: use of uninitialized value Fixes: bbb-320x240-2video-2audio.mp4 Signed-off-by: Michael

[blink-dev] Intent to Implement & Ship: AudioEncoderConfig.bitrateMode

2023-08-17 Thread 'Thomas Guilbert' via blink-dev
Contact emails tguilb...@google.com Explainer None Specification https://w3c.github.io/webcodecs/#dom-audioencoderconfig-bitratemode Summary Some audio codecs support specifying the audio encoder bitrate modes. This feature adds a "bitrateMode" flag with a default value of “variable” to

Re: [webkit-dev] Position on emerging standard: video.requestAnimationFrame()

2020-01-21 Thread Thomas Guilbert
other task. So, going off the spec you linked, I think this would be "5) Perform oldestTask's step" and not "10) Rendering: [...] 11. Foreach document run animation frame callbacks for that Document". On Tue, Jan 21, 2020 at 1:01 PM Simon Fraser wrote: > On Jan 21, 2020,

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-07 Thread Thomas Guilbert
ing patch. I also understand if our use case is unusual and that one may assume that s->metadata is always NULL. On Thu, Apr 6, 2017 at 11:32 PM, wm4 <nfx...@googlemail.com> wrote: > On Thu, 6 Apr 2017 14:07:53 -0700 > Thomas Guilbert <tguilb...@chromium.org> wrote: > &

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-06 Thread Thomas Guilbert
Fri, Mar 31, 2017 at 12:39 PM, Thomas Guilbert <tguilb...@chromium.org> wrote: > Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada > with s->internal->id3v2_meta, which leaks an AVDictionary* if > s->metada was not null. > > Please excuse an

[FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-03-31 Thread Thomas Guilbert
Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada with s->internal->id3v2_meta, which leaks an AVDictionary* if s->metada was not null. Please excuse any formatting problems in this email, this is my first time uploading a patch :) Thank you, Thomas

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix hang with slice threads

2017-03-10 Thread Thomas Guilbert
Thank you! On Thu, Mar 9, 2017 at 5:20 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Mar 09, 2017 at 08:17:37PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Mar 9, 2017 at 8:12 PM, Michael Niedermayer > <mich...@niedermayer.cc&g

[FFmpeg-cvslog] avcodec/vp8: Fix hang with slice threads

2017-03-09 Thread Thomas Guilbert
ffmpeg | branch: master | Thomas Guilbert <tguilb...@google.com> | Fri Mar 10 00:15:39 2017 +0100| [9bbc73ae9fdedc8789b2b6be65279e9a0ecd7090] | committer: Michael Niedermayer avcodec/vp8: Fix hang with slice threads Fixes: 447860.webm Reviewed-by: "Ronald S. Bultje" <

[FFmpeg-cvslog] avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c

2016-08-26 Thread Thomas Guilbert
ffmpeg | branch: release/2.8 | Thomas Guilbert <tguilb...@google.com> | Fri May 27 15:50:25 2016 -0700| [669fc1338f258d27426f5b36b9f924082080f22a] | committer: Michael Niedermayer avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c

[FFmpeg-cvslog] avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c

2016-06-04 Thread Thomas Guilbert
ffmpeg | branch: release/3.0 | Thomas Guilbert <tguilb...@google.com> | Fri May 27 15:50:25 2016 -0700| [dab82a2a7c907f0ff842f9a1ce05670cfe6715ab] | committer: Michael Niedermayer avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c

[FFmpeg-cvslog] avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c

2016-05-28 Thread Thomas Guilbert
ffmpeg | branch: master | Thomas Guilbert <tguilb...@google.com> | Fri May 27 15:50:25 2016 -0700| [1a82d2cf8fb6a7e854e7548dfcf73c3d046b34ac] | committer: Michael Niedermayer avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c Fixes: usan_granule_ov