[PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-26 Thread Thomas Huth
According to the comment in qga/meson.build, the test got disabled since there were problems with the fuzzing job. But instead of disabling this test completely, we should still be fine running it when fuzzing is disabled. Signed-off-by: Thomas Huth --- qga/meson.build | 5 ++--- 1 file changed

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
On 26/04/2024 15.46, Eldon Stegall wrote: On Fri, Apr 26, 2024 at 02:47:20PM +0200, Thomas Huth wrote: With regards to NetBSD and OpenBSD, this is not a step backward since these gitlab jobs were never run anyway (they could only be triggered manually, but hardly anybody did that AFAIK). If we

Re: [PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-26 Thread Thomas Huth
| 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04

2024-04-26 Thread Thomas Huth
ons(+), 15 deletions(-) rename .gitlab-ci.d/custom-runners/{ubuntu-20.04-s390x.yml => ubuntu-22.04-s390x.yml} (88%) Reviewed-by: Thomas Huth

Re: [PATCH 1/3] build-environment: make some packages optional

2024-04-26 Thread Thomas Huth
' or ansible_facts['architecture'] == 'x86_64' + - name: Install armhf cross-compile packages to build QEMU on AArch64 Ubuntu 22.04 package: name: Reviewed-by: Thomas Huth

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
On 26/04/2024 14.30, Peter Maydell wrote: On Fri, 26 Apr 2024 at 12:38, Thomas Huth wrote: During the past months, the netbsd and openbsd jobs in the Cirrus-CI were broken most of the time - the setup to run a BSD in KVM on Cirrus-CI from gitlab via the cirrus-run script was very fragile

[PATCH v2] KVM: selftests: Use TAP interface in the set_memory_region test

2024-04-26 Thread Thomas Huth
, not with vm_create_with_one_vcpu()) Reviewed-by: Andrew Jones Signed-off-by: Thomas Huth --- v2: - Rebase to linux-next branch - Make "loops" variable static - Added Andrew's Reviewed-by .../selftests/kvm/set_memory_region_test.c| 86 +-- 1 file changed, 42 insertions(+), 44

[PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
introduce a limit on the amount of free CI minutes that you get there, so it is not appealing at all anymore to run these BSDs in this setup - it's better to run the checks locally via "make vm-build-openbsd" and "make vm-build-netbsd" instead. Thus let's remove these CI jobs now. S

Re: [PATCH] KVM: selftests: Use TAP interface in the set_memory_region test

2024-04-26 Thread Thomas Huth
On 26/04/2024 12.07, Muhammad Usama Anjum wrote: On 4/26/24 1:55 PM, Thomas Huth wrote: Use the kselftest_harness.h interface in this test to get TAP output, so that it is easier for the user to see what the test is doing. (Note: We are not using the KVM_ONE_VCPU_TEST_SUITE() macro here since

[PATCH] KVM: selftests: Use TAP interface in the set_memory_region test

2024-04-26 Thread Thomas Huth
, not with vm_create_with_one_vcpu()) Signed-off-by: Thomas Huth --- .../selftests/kvm/set_memory_region_test.c| 86 +-- 1 file changed, 42 insertions(+), 44 deletions(-) diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
On 25/04/2024 22.56, Philippe Mathieu-Daudé wrote: Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation

[PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
it is not available in the binary, so I hope this patch is fine, too. Thomas Huth (3): hw/i386/pc: Allow to compile without CONFIG_FDC_ISA hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA hw/i386: Add the possibility to use i440fx and isapc without FDC hw/i386/pc.c | 13 + hw/i386

[PATCH 2/3] hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA

2024-04-25 Thread Thomas Huth
d the isa-pc machine currently always instantiate the FDC, so we have to add the select statements now there instead. Signed-off-by: Thomas Huth --- hw/i386/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index a6ee052f9a..0b08580862

[PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA

2024-04-25 Thread Thomas Huth
The q35 machine can work without FDC. But to be able to also link a QEMU binary that does not include the FDC code, we have to make it possible to disable the spots that call into the FDC code. Signed-off-by: Thomas Huth --- hw/i386/pc.c | 13 + 1 file changed, 9 insertions(+), 4

[RFC PATCH 3/3] hw/i386: Add the possibility to use i440fx and isapc without FDC

2024-04-25 Thread Thomas Huth
The i440fx and the isapc machines can be used in binaries without FDC, too. We just have to make sure that they don't try to instantiate the FDC when it is not available. Signed-off-by: Thomas Huth --- hw/i386/pc_piix.c | 6 -- hw/i386/Kconfig | 2 -- 2 files changed, 4 insertions(+), 4

Re: [PATCH v2 4/7] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-25 Thread Thomas Huth
-by: Zhao Liu --- target/s390x/cpu_models.c | 9 - target/s390x/cpu_models.h | 2 +- target/s390x/kvm/kvm.c| 13 +++-- 3 files changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
On 25/04/2024 17.04, Richard Henderson wrote: On 4/24/24 22:11, Thomas Huth wrote: On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of https

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-25 Thread Thomas Huth
On 12/04/2024 12.37, Paolo Bonzini wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major

[PULL v2 00/16] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
(3): hw/s390x: Include missing 'cpu.h' header tests/unit: Remove debug statements in test-nested-aio-poll.c target/s390x: Remove KVM stubs in cpu_models.h Thomas Huth (8): Revert ".travis.yml: Cache Avocado cache" .travis.yml: Remove the unused UNRELIABLE e

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-24 Thread Thomas Huth
On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-04-23 17:35:57 -0700) are available in the Git

Re: [PULL 12/17] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-24 Thread Thomas Huth
On 24/04/2024 18.19, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: RHEL 9 (and thus also the derivatives) have been available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Another reason

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Thomas Huth
On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to

Re: [PATCH] vfio/ccw: Use g_autofree variable

2024-04-24 Thread Thomas Huth
changed, 11 insertions(+), 14 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Thomas Huth
On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to

Re: [PATCH 2/2] checkpatch.pl: forbid strerrorname_np()

2024-04-24 Thread Thomas Huth
=~ /\bffs\(/) { ERROR("use ctz32() instead of ffs()\n" . $herecurr); Reviewed-by: Thomas Huth

Re: [PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-24 Thread Thomas Huth
code: %s", - strerrorname_np(errno)); +error_report("Unable to read vlenb register, error code: %d", + errno); exit(EXIT_FAILURE); } Reviewed-by: Thomas Huth

[PULL 12/17] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-24 Thread Thomas Huth
6.302103-5-th...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml| 16 - .gitlab-ci.d/container-core.yml | 4 +-- .../{centos8.docker => centos9.docker}| 34 +++ tests/lcitool/mappings.yml

[PULL 06/17] .travis.yml: Remove the unused UNRELIABLE environment variable

2024-04-24 Thread Thomas Huth
l had the x86 jobs here around that were our main CI jobs. Thus let's simply remove this useless variable now. Message-ID: <20240320104144.823425-6-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.travis.yml b/.travis.yml

[PULL 15/17] docs/devel: fix minor typo in submitting-a-patch.rst

2024-04-24 Thread Thomas Huth
From: Manos Pitsidianakis s/Resolved:/Resolves:/ Signed-off-by: Manos Pitsidianakis Message-ID: <20240422124128.4034482-1-manos.pitsidiana...@linaro.org> Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- docs/devel/submitting-a-patch.rst | 2 +- 1 file changed, 1 insertion

[PULL 02/17] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`

2024-04-24 Thread Thomas Huth
Ninad Palsule Message-ID: <20240414173349.31194-1-ines.var...@telecom-paris.fr> Signed-off-by: Thomas Huth --- tests/qtest/aspeed_fsi-test.c | 20 ++-- tests/qtest/cmsdk-apb-dualtimer-test.c | 2 +- tests/qtest/cmsdk-apb-watchdog-test.c | 2 +- tests/qtest/erst-test.c|

[PULL 03/17] docs: i386: pc: Update maximum CPU numbers for PC Q35

2024-04-24 Thread Thomas Huth
From: Zhao Liu Commit e4e98c7eebfa ("pc: q35: Bump max_cpus to 4096 vcpus") increases the supported CPUs for PC Q35 machine. Update maximum CPU numbers for PC Q35 in the document. Signed-off-by: Zhao Liu Message-ID: <20240412085358.731560-1-zhao1@linux.intel.com> Signe

[PULL 13/17] ci: move external build environment setups to CentOS Stream 9

2024-04-24 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-7-th...@redhat.com> Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environme

[PULL 16/17] tests/unit: Remove debug statements in test-nested-aio-poll.c

2024-04-24 Thread Thomas Huth
246.83812-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- tests/unit/test-nested-aio-poll.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/unit/test-nested-aio-poll.c b/tests/unit/test-nested-aio-poll.c index db33742af3..d8fd92c43b 100644 --- a/tests/unit/test-nested-aio-

[PULL 11/17] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-24 Thread Thomas Huth
Message-ID: <20240418101056.302103-4-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 3 ++- tests/docker/dockerfiles/centos8.docker | 1 + tests/docker/dockerfiles/debian-amd64-cross.docker| 3 ++- tests/docker/dockerfi

[PULL 14/17] hw/s390x: Include missing 'cpu.h' header

2024-04-24 Thread Thomas Huth
h:22:27: error: unknown type name 'CPUS390XState' int s390_virtio_hypercall(CPUS390XState *env); ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Eric Farman Message-ID: <20240322162822.7391-1-phi...@linaro.org> Signed-off-by: Thomas Hu

[PULL 05/17] Revert ".travis.yml: Cache Avocado cache"

2024-04-24 Thread Thomas Huth
4144.823425-4-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..8da88c4360 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,8 +12,6 @@ cache: timeout: 1200 ccache: true pip: tru

[PULL 17/17] target/s390x: Remove KVM stubs in cpu_models.h

2024-04-24 Thread Thomas Huth
From: Philippe Mathieu-Daudé Since the calls are elided when KVM is not available, we can remove the stubs (which are never compiled). Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240419090631.48055-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.

[PULL 01/17] MAINTAINERS: update email of Peter Lieven

2024-04-24 Thread Thomas Huth
From: Peter Lieven I will leave KAMP in the next days. Update email to stay reachable. Signed-off-by: Peter Lieven Message-ID: <20230105095039.182718-1...@kamp.de> Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINT

[PULL 08/17] .travis.yml: Do some more testing with Clang

2024-04-24 Thread Thomas Huth
ed-off-by: Thomas Huth --- .travis.yml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7527f71c05..cef0308952 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,8 +113,9 @@ jobs: - CONFIG="--disable-containers --enable

[PULL 10/17] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-24 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-3-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 ins

[PULL 04/17] tests/vm: update openbsd image to 7.5

2024-04-24 Thread Thomas Huth
From: Brad Smith tests/vm: update openbsd to release 7.5 Signed-off-by: Brad Smith Message-ID: Signed-off-by: Thomas Huth --- tests/vm/openbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 85c9863633..5e646f7c51 100755

[PULL 07/17] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-24 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-6-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a

[PULL 09/17] tests: Remove Ubuntu 20.04 container

2024-04-24 Thread Thomas Huth
Since Ubuntu 22.04 has now been available for more than two years, we can stop actively supporting the previous LTS version of Ubuntu now. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240418101056.302103-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/docke

[PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-24 Thread Thomas Huth
-Daudé (3): hw/s390x: Include missing 'cpu.h' header tests/unit: Remove debug statements in test-nested-aio-poll.c target/s390x: Remove KVM stubs in cpu_models.h Thomas Huth (8): Revert ".travis.yml: Cache Avocado cache" .travis.yml: Remove the unused

[PATCH] .gitlab-ci.d/cirrus.yml: Fix the NetBSD and OpenBSD Cirrus-CI KVM jobs

2024-04-24 Thread Thomas Huth
e dormant for a year as the old ':master' tags were not removed until some weeks ago. The other Cirrus-CI jobs were already fixed in commit 1d2f2b35bc86b7a1 ("gitlab-ci/cirrus: switch from 'master' to 'latest'"), but apparently nobody noticed the KVM jobs so far that need to be triggered ma

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-22 Thread Thomas Huth
On 22/04/2024 10.03, Daniel P. Berrangé wrote: On Sat, Apr 20, 2024 at 07:46:03AM +0200, Thomas Huth wrote: Printing an architecture prefix in front of each CPU name is not helpful at all: It is confusing for the users since they don't know whether they have to specify these letters

[PATCH 3/3] target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list

2024-04-19 Thread Thomas Huth
Let's simply remove this now and use two spaces at the beginning of the lines for the indentation of the entries instead, and add a "Available CPUs" in the very first line, like most other target architectures are doing it for their CPU help output already. Signed-off-by: Thomas Huth

[PATCH 1/3] target/i386/cpu: Remove "x86" prefix from the CPU list

2024-04-19 Thread Thomas Huth
Let's simply remove this now and use two spaces at the beginning of the lines for the indentation of the entries instead, like most other target architectures are doing it for their CPU help output already. Signed-off-by: Thomas Huth --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-19 Thread Thomas Huth
t's simply remove those now. Thomas Huth (3): target/i386/cpu: Remove "x86" prefix from the CPU list target/s390x/cpu_models: Rework the output of "-cpu help" target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list target/i386/cpu.c

[PATCH 2/3] target/s390x/cpu_models: Rework the output of "-cpu help"

2024-04-19 Thread Thomas Huth
Let's simply remove this now! While we're at it, use two spaces at the beginning of the lines for the indentation of the entries, and add a "Available CPUs" in the very first line, like most other target architectures are doing it for their "-cpu help" output already. Signe

[PATCH v2 2/4] target/sparc/cpu: Avoid spaces by default in the CPU names

2024-04-19 Thread Thomas Huth
d Henderson Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- target/sparc/cpu.c | 56 +++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 774e234e09..593c8d6867 100644 --- a/target/

[PATCH v2 0/4] Sparc CPU naming and help text improvements

2024-04-19 Thread Thomas Huth
BSD and OpenBSD in the docs since these problems are likely fixed since a long time already - Added Reviewed-bys from earlier series and updated the patch descriptions a little bit Thomas Huth (4): target/sparc/cpu: Rename the CPU models with a "+" in their names target/sparc/cpu: A

[PATCH v2 4/4] docs/about: Deprecate the old "UltraSparc" CPU names that contain a "+"

2024-04-19 Thread Thomas Huth
For consistency we should drop the names with a "+" in it in the long run. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index

[PATCH v2 3/4] docs/system/target-sparc: Improve the Sparc documentation

2024-04-19 Thread Thomas Huth
://gitlab.com/qemu-project/qemu/-/issues/2141 Signed-off-by: Thomas Huth --- docs/system/target-sparc.rst | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/system/target-sparc.rst b/docs/system/target-sparc.rst index 9ec8c90c14..54bd8b6ead 100644 --- a/docs/system/target

[PATCH v2 1/4] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-04-19 Thread Thomas Huth
ward compatibility for the old names via some simple checks in the sparc_cpu_class_by_name() function. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- qom/object.c | 8 target/sparc/cpu.c | 14 -- 2 files changed, 12 insertions(+), 10 deletions(-) d

Re: [PATCH 6/6] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local virable @err. With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 5/6] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
-off-by: Zhao Liu --- target/s390x/cpu_models.h| 5 +++-- target/s390x/cpu_models_sysemu.c | 3 +-- target/s390x/kvm/kvm.c | 15 --- 3 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 4/6] target/s390x/cpu_models: Drop local @err in get_max_cpu_model()

2024-04-19 Thread Thomas Huth
(errp, err); +if (!kvm_s390_get_host_cpu_model(_model, errp)) { return NULL; } } else { With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 3/6] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. So make kvm_s390_get_host_cpu_model() return boolean and check the returned boolean in get_max_cpu_model() instead of accessing @err.

Re: [PATCH 2/6] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local s/fetech/fetch/ virable @err. s/virable/variable/ Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x/cpu_models.c | 4 +--- 1 file changed, 1

Re: [PATCH 1/6] target/s390x/cpu_model: Make check_compatibility() return boolean

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. With returned boolean, there's no need to check @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x

Re: [PATCH 4/5] docs/system/target-sparc: Improve the Sparc documentation

2024-04-18 Thread Thomas Huth
On 18/04/2024 22.27, Mark Cave-Ayland wrote: On 07/03/2024 17:43, Thomas Huth wrote: Add some words about how to enable or disable boolean features, and remove the note about a Linux kernel being available on the QEMU website (they have been removed long ago already). Signed-off-by: Thomas

Re: [PATCH] vhost-user-test: no set non-blocking for cal fd less than 0.

2024-04-18 Thread Thomas Huth
On 11/04/2024 09.35, Yuxue Liu yuxue@jaguarmicro.com wrote: From: Yuxue Liu In the scenario where vhost-user sets eventfd to -1, qemu_chr_fe_get_msgfds retrieves fd as -1. When vhost_user_read receives, it does not perform blocking operations on the descriptor with fd=-1, so non-blocking

[PATCH v3 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-18 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environment.yml | 31 ++--- .../stream/{8 => 9}/x86_64/configure

[PATCH v3 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-18 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environment.yml | 31 ++--- .../stream/{8 => 9}/x86_64/configure

[PATCH v3 08/13] Remove glib compatibility code that is not required anymore

2024-04-18 Thread Thomas Huth
Now that we bumped the minumum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-report.c | 10 -- 2 files changed, 18 deletions(-) diff

[PATCH v3 12/13] block/ssh: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
or other mistakes. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 2748253d4a..a88171d4b5 100644 --- a/block/ssh.c

[PATCH v3 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-18 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..56a2a01e14 1006

[PATCH v3 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
-are-coming-for-centos-stream-8-and-centos-linux-7/ "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." Thus upgrade our CentOS Stream container to major version 9 now. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .g

[PATCH v3 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-18 Thread Thomas Huth
ation environment. Our containers are disposable though, so a venv has no benefit. Removing the 'EXTERNALLY-MANAGED' allows the historical arbitrary use of 'pip' outside a venv. lcitool just does this unconditionally given the containers are not precious." Reviewed-by: Daniel P. Berrangé Signed-off-

[PATCH v3 11/13] block/nfs: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
ce the latter rather sounds like the users were breaking a law here. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 56 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index f7

[PATCH v3 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
of g_uri_get_path() as input). Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- block/gluster.c | 71 - 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index cc74af06dc

[PATCH v3 08/13] Remove glib compatibility code that is not required anymore

2024-04-18 Thread Thomas Huth
Now that we bumped the minumum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-report.c | 10 -- 2 files changed, 18 deletions(-) diff

[PATCH v3 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-18 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci

[PATCH v3 12/13] block/ssh: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
or other mistakes. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 2748253d4a..a88171d4b5 100644 --- a/block/ssh.c

[PATCH v3 10/13] block/nbd: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
. Reviewed-by: Richard W.M. Jones Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nbd.c | 76 ++--- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index ef05f7cdfd..589d28af83 100644 --- a/block

[PATCH v3 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-18 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci

[PATCH v3 11/13] block/nfs: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
ce the latter rather sounds like the users were breaking a law here. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 56 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index f7

[PATCH v3 13/13] util/uri: Remove the old URI parsing code

2024-04-18 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH v3 13/13] util/uri: Remove the old URI parsing code

2024-04-18 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH v3 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
-are-coming-for-centos-stream-8-and-centos-linux-7/ "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." Thus upgrade our CentOS Stream container to major version 9 now. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .g

[PATCH v3 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-18 Thread Thomas Huth
ation environment. Our containers are disposable though, so a venv has no benefit. Removing the 'EXTERNALLY-MANAGED' allows the historical arbitrary use of 'pip' outside a venv. lcitool just does this unconditionally given the containers are not precious." Reviewed-by: Daniel P. Berrangé Signed-off-

[PATCH v3 10/13] block/nbd: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
. Reviewed-by: Richard W.M. Jones Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nbd.c | 76 ++--- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index ef05f7cdfd..589d28af83 100644 --- a/block

[PATCH v3 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-18 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..56a2a01e14 1006

[PATCH v3 00/13] Drop old distros, bump glib and switch to glib URI parsing code

2024-04-18 Thread Thomas Huth
r simplification - Don't allow port 0 in the URIs Paolo Bonzini (1): ci: move external build environment setups to CentOS Stream 9 Thomas Huth (12): tests: Remove Ubuntu 20.04 container tests/lcitool/libvirt-ci: Update to the latest master branch tests/docker/dockerfiles: Run lcitool-re

[PATCH v3 07/13] Bump minimum glib version to v2.66

2024-04-18 Thread Thomas Huth
which will allow further clean-ups in the following patches. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/commands-posix-ssh.c | 4 ++-- 3 files changed, 5 insertions

[PATCH v3 01/13] tests: Remove Ubuntu 20.04 container

2024-04-18 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh

[PATCH v3 07/13] Bump minimum glib version to v2.66

2024-04-18 Thread Thomas Huth
which will allow further clean-ups in the following patches. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/commands-posix-ssh.c | 4 ++-- 3 files changed, 5 insertions

[PATCH v3 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
of g_uri_get_path() as input). Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- block/gluster.c | 71 - 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index cc74af06dc

[PATCH v3 01/13] tests: Remove Ubuntu 20.04 container

2024-04-18 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh

[PATCH v3 00/13] Drop old distros, bump glib and switch to glib URI parsing code

2024-04-18 Thread Thomas Huth
r simplification - Don't allow port 0 in the URIs Paolo Bonzini (1): ci: move external build environment setups to CentOS Stream 9 Thomas Huth (12): tests: Remove Ubuntu 20.04 container tests/lcitool/libvirt-ci: Update to the latest master branch tests/docker/dockerfiles: Run lcitool-re

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
On 17/04/2024 18.15, Daniel P. Berrangé wrote: On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
On 17/04/2024 18.15, Daniel P. Berrangé wrote: On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
On 12/04/2024 16.40, Eric Blake wrote: On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
On 12/04/2024 16.40, Eric Blake wrote: On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block

Re: Deprecation/removal of nios2 target support

2024-04-17 Thread Thomas Huth via Gcc
On 18/04/2024 05.27, Sandra Loosemore wrote: Tomorrow I plan to push patches to mark the nios2 target as obsolete in GCC 14. Background: Intel has EOL'ed the Nios II processor IP and is now directing their FPGA customers to a RISC-V platform instead.

Re: Deprecation/removal of nios2 target support

2024-04-17 Thread Thomas Huth
On 18/04/2024 05.27, Sandra Loosemore wrote: Tomorrow I plan to push patches to mark the nios2 target as obsolete in GCC 14. Background: Intel has EOL'ed the Nios II processor IP and is now directing their FPGA customers to a RISC-V platform instead.

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote: On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote: On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/depr

  1   2   3   4   5   6   7   8   9   10   >