[jira] [Closed] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-15 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-11067. Resolution: Fixed Thanks Gaëtan for your catch and contribution ! > Migrate integrat

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-15 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837261#comment-17837261 ] Gil Portenseigne commented on OFBIZ-11067: -- Hi [~jleroux] , if you don't mind, i will take care

[jira] [Assigned] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-15 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-11067: Assignee: Gil Portenseigne (was: Jacques Le Roux) > Migrate integration te

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-15 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837094#comment-17837094 ] Gil Portenseigne commented on OFBIZ-11067: -- i do it this day :D > Migrate integration te

[jira] [Commented] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836265#comment-17836265 ] Gil Portenseigne commented on OFBIZ-13009: -- oops, i failed codenarc rules, that is now fixed

[jira] [Closed] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-13009. Resolution: Fixed > Fix Ecommerce Groovy te

[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Fix Version/s: Upcoming Branch > Fix Ecommerce Groovy te

[jira] [Closed] (OFBIZ-13003) Fix Assetmain Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-13003. Resolution: Fixed > Fix Assetmain Groovy te

[jira] [Commented] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836246#comment-17836246 ] Gil Portenseigne commented on OFBIZ-13009: -- yes, seems fix, a last check before i push

[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Affects Version/s: Upcoming Branch > Fix Ecommerce Groovy te

[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836247#comment-17836247 ] Gil Portenseigne commented on OFBIZ-13003: -- [https://ci2.apache.org/#/builders/46/builds/805

[jira] [Created] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-13009: Summary: Fix Ecommerce Groovy tests Key: OFBIZ-13009 URL: https://issues.apache.org/jira/browse/OFBIZ-13009 Project: OFBiz Issue Type: Sub-task

[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Description: Unable to load test suite class

[jira] [Commented] (OFBIZ-13006) Reject wrong URLs

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836193#comment-17836193 ] Gil Portenseigne commented on OFBIZ-13006: -- Hello [~jleroux] , there might be an issue

[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests

2024-04-11 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836189#comment-17836189 ] Gil Portenseigne commented on OFBIZ-13003: -- Strange, the test was a success on my local

[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests

2024-04-10 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835799#comment-17835799 ] Gil Portenseigne commented on OFBIZ-13003: -- I am not sure about if others test already comply

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-09 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835187#comment-17835187 ] Gil Portenseigne commented on OFBIZ-11067: -- Sure, i will when i got some time :) > Migr

[jira] [Commented] (OFBIZ-12998) Fix Partymgr Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834430#comment-17834430 ] Gil Portenseigne commented on OFBIZ-12998: -- Thanks Jacques for the review, i checked in my

[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834380#comment-17834380 ] Gil Portenseigne commented on OFBIZ-12985: -- i'll stop for now it remains

[jira] [Closed] (OFBIZ-12999) Fix Product Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12999. Resolution: Fixed [https://ci2.apache.org/#/builders/49/builds/851] OK ! > Fix Prod

[jira] [Created] (OFBIZ-13000) Fix Order Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-13000: Summary: Fix Order Groovy tests Key: OFBIZ-13000 URL: https://issues.apache.org/jira/browse/OFBIZ-13000 Project: OFBiz Issue Type: Sub-task

[jira] [Closed] (OFBIZ-12998) Fix Partymgr Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12998. Resolution: Fixed [https://ci2.apache.org/#/builders/46/builds/785] OK > Fix Party

[jira] [Created] (OFBIZ-12999) Fix Product Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12999: Summary: Fix Product Groovy tests Key: OFBIZ-12999 URL: https://issues.apache.org/jira/browse/OFBIZ-12999 Project: OFBiz Issue Type: Sub-task

[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834313#comment-17834313 ] Gil Portenseigne commented on OFBIZ-12985: -- One thing is bothering me, we are putting

[jira] [Assigned] (OFBIZ-12998) Fix Partymgr Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-12998: Assignee: Gil Portenseigne > Fix Partymgr Groovy te

[jira] [Updated] (OFBIZ-12998) Fix Partymgr Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12998: - Priority: Major (was: Blocker) > Fix Partymgr Groovy te

[jira] [Created] (OFBIZ-12998) Fix Partymgr Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12998: Summary: Fix Partymgr Groovy tests Key: OFBIZ-12998 URL: https://issues.apache.org/jira/browse/OFBIZ-12998 Project: OFBiz Issue Type: Sub-task

[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834249#comment-17834249 ] Gil Portenseigne commented on OFBIZ-12985: -- ow, sorry, i look that this afternoon

[jira] [Closed] (OFBIZ-12985) Integration Groovy tests fail

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12985. Resolution: Fixed Closing since last buildbot is ok. Thanks Jacques ! > Integrat

[jira] [Commented] (OFBIZ-12995) Fix Accounting Groovy tests

2024-04-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834219#comment-17834219 ] Gil Portenseigne commented on OFBIZ-12995: -- Hi Jacques, do you need some help ? I'll have

[jira] [Commented] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.

2024-03-26 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830919#comment-17830919 ] Gil Portenseigne commented on OFBIZ-12963: -- Thanks Jacques, idea licence trolled me, so i

[jira] [Updated] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.

2024-03-26 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12963: - Attachment: OFBIZ-12963.patch > Fix problems with Eclipse about multi mod

[jira] [Created] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.

2024-03-26 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12963: Summary: Fix problems with Eclipse about multi module dependencies. Key: OFBIZ-12963 URL: https://issues.apache.org/jira/browse/OFBIZ-12963 Project: OFBiz

[jira] [Commented] (OFBIZ-12940) Modal title not supported on hyperlink in form fields

2024-03-20 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828921#comment-17828921 ] Gil Portenseigne commented on OFBIZ-12940: -- Hi Jacques, i got interrupted while doing it, i

[jira] [Closed] (OFBIZ-12940) Modal title not supported on hyperlink in form fields

2024-03-20 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12940. Resolution: Fixed > Modal title not supported on hyperlink in form fie

[jira] [Updated] (OFBIZ-12940) Modal title not supported on hyperlink in form fields

2024-03-19 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12940: - Fix Version/s: Upcoming Branch > Modal title not supported on hyperlink in form fie

[jira] [Assigned] (OFBIZ-12940) Modal title not supported on hyperlink in form fields

2024-03-19 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-12940: Assignee: Gil Portenseigne > Modal title not supported on hyperlink in f

[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2024-01-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803598#comment-17803598 ] Gil Portenseigne commented on OFBIZ-12726: -- Thanks and nice catch, I agree we can close

[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-12 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795857#comment-17795857 ] Gil Portenseigne commented on OFBIZ-12726: -- Hello Eugen, Jacques, I just join the effort

[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-12 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12726: - Attachment: image-2023-12-12-18-10-16-016.png > Running integration tests under Gra

Re: [VOTE] Apache OFBiz 18.12.10

2023-11-30 Thread Gil Portenseigne
+1 Thanks, Gil On 27/11/2023 11:48, Jacopo Cappellato wrote: This is the vote thread to publish "Apache OFBiz 18.12.10", tenth release from the release18.12 branch. The release files can be downloaded from here: https://dist.apache.org/repos/dist/dev/ofbiz/ and are: *

[jira] [Commented] (OFBIZ-10213) Update build.gradle to the latest dependencies

2023-08-18 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755986#comment-17755986 ] Gil Portenseigne commented on OFBIZ-10213: -- Hello [~jleroux] , i just made some manual updates

[jira] [Closed] (OFBIZ-12844) Update zip4j to 2.11.5

2023-08-18 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12844. Fix Version/s: 22.01.01 Upcoming Branch Resolution: Fixed

[jira] [Created] (OFBIZ-12845) Update commons-net to 3.9.0

2023-08-18 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12845: Summary: Update commons-net to 3.9.0 Key: OFBIZ-12845 URL: https://issues.apache.org/jira/browse/OFBIZ-12845 Project: OFBiz Issue Type: Improvement

[jira] [Closed] (NET-724) Update commons-net to

2023-08-18 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/NET-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed NET-724. > Update commons-net to > -- > > Key: NET-724 >

[jira] [Resolved] (NET-724) Update commons-net to

2023-08-18 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/NET-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved NET-724. -- Resolution: Abandoned Sorry, ticket was created by mistake. > Update commons-

[jira] [Created] (NET-724) Update commons-net to

2023-08-18 Thread Gil Portenseigne (Jira)
Gil Portenseigne created NET-724: Summary: Update commons-net to Key: NET-724 URL: https://issues.apache.org/jira/browse/NET-724 Project: Commons Net Issue Type: Improvement

[jira] [Created] (OFBIZ-12844) Update zip4j to 2.11.5

2023-08-18 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12844: Summary: Update zip4j to 2.11.5 Key: OFBIZ-12844 URL: https://issues.apache.org/jira/browse/OFBIZ-12844 Project: OFBiz Issue Type: Improvement

IDEA plugin contribution

2023-06-30 Thread Gil Portenseigne
Hello, I'm starting a new thread to get your opinion about contributing the OFBiz idea plugin. This intention was already done in the past in https://lists.apache.org/thread/03fr40tvhkv97pqrgt4nl78w4m6ml33w , but no conclusion was made. Gaëtan continued working on the plugin to provide

Re: OFBiz 22.01 - Eclipse - Issues on setting up a debugging environment.

2023-05-05 Thread Gil Portenseigne
Hello, Reading this i discussed with Gaëtan about somthing that could help control that every groovyScript reference in Screens/Forms/Services are effectively referencing an existing file. As you might know, Gaëtan is contributing an IDEA plugin dedicated to OFBiz [1]. The plugin already

[jira] [Closed] (OFBIZ-12816) Fix exception for createFuturePeriod Service

2023-05-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12816. Resolution: Fixed > Fix exception for createFuturePeriod Serv

[jira] [Created] (OFBIZ-12816) Fix exception for createFuturePeriod Service

2023-05-05 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12816: Summary: Fix exception for createFuturePeriod Service Key: OFBIZ-12816 URL: https://issues.apache.org/jira/browse/OFBIZ-12816 Project: OFBiz Issue

[jira] [Closed] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-05-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12801. Resolution: Fixed > Error at CommunicationEventServices.groovy:489 due to OFBIZ-11

Re: OFBiz 22.01 - Eclipse - Issues on setting up a debugging environment.

2023-05-05 Thread Gil Portenseigne
+1 Thanks, Gil Le 03/05/2023 à 16:39, Michael Brohl a écrit : +1 from my side. Best regards, Michael Am 03.05.23 um 09:45 schrieb Jacopo Cappellato: On Tue, May 2, 2023 at 9:17 AM Daniel Watford wrote: [...] I'll ask one more question (and then run for cover!): Rather than carry out

[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-05-05 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719844#comment-17719844 ] Gil Portenseigne commented on OFBIZ-12801: -- Hello Jacques, Daniel, While the discussion

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-28 Thread Gil Portenseigne
::success ? Gil Le 26/04/2023 à 09:49, Gil Portenseigne a écrit : Hello, I like the idea that the developer do not have to sync about which method to use. If I understand well what Michael envision, i.e. to use for event a new GroovyBaseEvent class, and for services/scripts a GroovyBaseScript

Re: [jira] [Commented] (OFBIZ-12808) Eclipse build problems and proper dependency setup

2023-04-26 Thread Gil Portenseigne
+1 Gil Le 26/04/2023 à 16:36, Jacques Le Roux a écrit : +1 Jacques Le 26/04/2023 à 16:01, Jacopo Cappellato a écrit : +1 Jacopo On Wed, Apr 26, 2023 at 3:11 PM Michael Brohl wrote: Hi everyone, any objections against merging those pr's for framework/plugins in trunk/release22.01? I

Re: [OFBIZ-12801] "Error at CommunicationEventServices.groovy:489"

2023-04-26 Thread Gil Portenseigne
Hello, I like the idea that the developer do not have to sync about which method to use. If I understand well what Michael envision, i.e. to use for event a new GroovyBaseEvent class, and for services/scripts a GroovyBaseScript class, that both extends a common class for the common code,

[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-04-19 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713934#comment-17713934 ] Gil Portenseigne commented on OFBIZ-12801: -- For this case I agree that the fix should

[jira] [Closed] (OFBIZ-11167) Use Codenarc to test Groovy code

2023-04-12 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-11167. Fix Version/s: 22.01.01 Upcoming Branch Resolution: Implemented

Re: Codenarc integration process

2023-04-12 Thread Gil Portenseigne
me to fix that, i wanted to ask if it is allowed ? Gil Le 27/03/2023 à 16:46, Jacques Le Roux a écrit : Hi Guys, For those who have used a non "PASSED" lozenge in wiki and resolved a related conversation in GH please update the status in wiki TIA Jacques Le 28/01/2023 à 11:51, Gil

Re: how to add multiple .ftl files in screen.xml based on user permissions using if else conditions

2023-04-11 Thread Gil Portenseigne
One way of doing that is to have a structure like                 One                                  permission="XERUS_ASSETMAINTENANCE" action="_VIEW"/>            two                

Re: how to add multiple .ftl files in screen.xml based on user permissions using if else conditions

2023-04-11 Thread Gil Portenseigne
Hello Mahi, You can find multiple examples in the code base looking for : `` One of :         service-name="workEffortGenericPermission" main-action="VIEW"/>             location="component://workeffort/template/task/MyTasks.ftl"/>            

Re: [VOTE] Apache OFBiz 18.12.07

2023-04-04 Thread Gil Portenseigne
+1 Everything is fine from my side ! Thanks Gil Le 03/04/2023 à 09:47, Jacopo Cappellato a écrit : This is the vote thread to publish "Apache OFBiz 18.12.07", seventh and probably final release from the release18.12 branch. The release files can be downloaded from here:

[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL

2023-02-13 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687808#comment-17687808 ] Gil Portenseigne commented on OFBIZ-9984: - Hello Jacques, IIRW it was not complete, only partly

Re: Codenarc integration process

2023-01-28 Thread Gil Portenseigne
Oh sorry indeed i overview the review approach section. The table is nice, thanks Dan ! 28 janv. 2023 09:37:50 Daniel Watford : > Hi Gil, > > I don't think a checklist is quite enough, assuming we want to track the > status of each file reviewed. > > From the review approach section: > > >  

Re: Codenarc integration process

2023-01-21 Thread Gil Portenseigne
he 455(!) files and > will rather call our CTR mode as I'm much confident in your (big) work :) > > +1 from my side > > Jacques > > > Le 21/01/2023 à 09:57, Gil Portenseigne a écrit : >> Yes, it is considered best practice to avoid gstring usage when not needed. >&

Re: Codenarc integration process

2023-01-21 Thread Gil Portenseigne
Yes, it is considered best practice to avoid gstring usage when not needed. Like for others, we can decide to not apply this rule. The detailed rule from codenarc documentation : *UnnecessaryGString** Rule* /Since //CodeNarc// 0.13/ String objects should be created with single quotes, and

[jira] [Closed] (OFBIZ-12732) Error in BlackList to DenyList migration service

2023-01-02 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12732. Resolution: Fixed > Error in BlackList to DenyList migration serv

[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service

2023-01-02 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Fix Version/s: 22.01.01 > Error in BlackList to DenyList migration serv

[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service

2023-01-02 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Affects Version/s: (was: 18.12.06) > Error in BlackList to DenyList migrat

[jira] [Created] (OFBIZ-12732) Error in BlackList to DenyList migration service

2023-01-02 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12732: Summary: Error in BlackList to DenyList migration service Key: OFBIZ-12732 URL: https://issues.apache.org/jira/browse/OFBIZ-12732 Project: OFBiz

[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme

2022-12-27 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652186#comment-17652186 ] Gil Portenseigne commented on OFBIZ-12725: -- Hello [~jleroux] , [~marine] is the person you

[jira] [Updated] (OFBIZ-11167) Use Codenarc to test Groovy code

2022-12-16 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-11167: - Description: Thread of community discussion about the rules to implement : https

[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code

2022-12-16 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648644#comment-17648644 ] Gil Portenseigne commented on OFBIZ-11167: -- Work still ongoing, i propose to remove rule

Re: Welcome to Leila Mekika as new committer

2022-10-05 Thread Gil Portenseigne
Congratulations Leila ! Bravo ! Gil On 04/10/2022 09:30, MLeila wrote: Hello all, Thanks for your welcome! I am glad to join the team and be able to contribute more actively on the project Regards, Leila Le 04/10/2022 à 07:38, Devanshu Vyas a écrit : Many congratulations and welcome

Re: Ofbiz using itext-2.1.7

2022-08-12 Thread Gil Portenseigne
Hello Rishin, This Itext version was the last version that could be included in OFBiz regarding the Licence (MPL). Nothing to worry about this. Regards, Gil Details : https://www.apache.org/legal/resolved On Fri, Aug 12, 2022 at 08:15:37AM +0200, Rishi Agr wrote: > Hi, There is a usage of

Re: Codenarc integration, rules to use.

2022-08-01 Thread Gil Portenseigne
Hello Jacques, Thanks for your feedback, I'll go with that. Gil On Mon, Jul 25, 2022 at 10:08:20AM +0200, Jacques Le Roux wrote: > Hi Gil, > > Here are my preferences inline... > > Le 20/07/2022 à 23:49, Gil Portenseigne a écrit : > > Thanks All for the feedback. >

Re: Codenarc integration, rules to use.

2022-07-20 Thread Gil Portenseigne
as UnnecessaryGetter Thanks, Gil On 2022/07/04 15:24:43 Gil Portenseigne wrote: > Hello Devs, > > I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). > > For those who are not aware, Codenarc is an analysis tools for Groovy > for defects, bad practices, inconsisten

Re: Codenarc integration, rules to use.

2022-07-12 Thread gil . portenseigne
. Thanks for the initiative, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.07.22 um 17:24 schrieb Gil Portenseigne: > Hello Devs, > > I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). > > For those who are not aware, Codenarc is an analysis tools for Groov

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
Forgot the ref https://github.com/CodeNarc/CodeNarc/issues/331 Le 12 juillet 2022 21:11:13 GMT+02:00, Gil Portenseigne a écrit : >Hello, > >I agree with you, i find out here [1] that it is customisable. > >So we can agree upon this variation of the rule ! > >I have not

Re: Codenarc integration, rules to use.

2022-07-12 Thread Gil Portenseigne
out, my preference for >legibility has always been [someKey: someValue]. I find >[someKey:someValue] a bit too condensed and harder to differentiate key >from value. > >Regards >Scott > >On Mon, 4 Jul 2022 at 16:25, Gil Portenseigne >wrote: > >> Hello Devs, >> >

Codenarc integration, rules to use.

2022-07-04 Thread Gil Portenseigne
Hello Devs, I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). For those who are not aware, Codenarc is an analysis tools for Groovy for defects, bad practices, inconsistencies, style issues and more. For this purpose we need to agree about the ruleset to put in place. I

[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code

2022-07-03 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561935#comment-17561935 ] Gil Portenseigne commented on OFBIZ-11167: -- I wrote a little script to extract the rules

[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code

2022-07-01 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561468#comment-17561468 ] Gil Portenseigne commented on OFBIZ-11167: -- Hello Folks, i dig up this subject and started

[jira] [Closed] (OFBIZ-10692) Groovy DSL runService Exception Management

2022-05-27 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10692. Resolution: Fixed Thanks [~mleila] , this is commited in trunk. Regards, Gil > Gro

[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management

2022-05-27 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542922#comment-17542922 ] Gil Portenseigne commented on OFBIZ-10692: -- This ticket was in stand-by, we added some

Re: "New commiter first steps" wiki page proposal

2022-05-16 Thread Gil Portenseigne
Hello Giulio, I just went through the page, it's nice and clear ! Thanks Gil Le samedi 14 mai 2022 à 16:32 +0200, Giulio Speri - MpStyle Srl a écrit : > Hello Devs, > > I hope you are all doing well! > I finally had some time to write a little guide regarding the steps > to > perform as a

[jira] [Closed] (OFBIZ-12183) Groovy script Product.groovy: java.util.NoSuchElementException

2022-05-06 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12183. Resolution: Cannot Reproduce Closing since not reproducible. Thanks > Groovy scr

[jira] [Closed] (OFBIZ-12612) Update sshd dependency and implementation

2022-05-06 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12612. Fix Version/s: 22.01.01 Resolution: Fixed This was commited in release22 since

[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation

2022-05-06 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Fix Version/s: Upcoming Branch > Update sshd dependency and implementat

[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation

2022-05-06 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Affects Version/s: Upcoming Branch > Update sshd dependency and implementat

[jira] [Created] (OFBIZ-12612) Update sshd dependency and implementation

2022-05-06 Thread Gil Portenseigne (Jira)
Gil Portenseigne created OFBIZ-12612: Summary: Update sshd dependency and implementation Key: OFBIZ-12612 URL: https://issues.apache.org/jira/browse/OFBIZ-12612 Project: OFBiz Issue

Re: [INFRA-22722] Restart the ofbiz-vm3 demos server

2022-03-24 Thread Gil Portenseigne
I do not remember doing such :) Gil On Wed, Mar 23, 2022 at 07:13:02PM +0100, Jacques Le Roux wrote: > Ah forgot, did you fix the warnings? > > Le 23/03/2022 à 19:09, Jacques Le Roux a écrit : > > Great, thanks Gil! > > > > Le 23/03/2022 à 18:15, Gil Portenseigne a

Re: [INFRA-22722] Restart the ofbiz-vm3 demos server

2022-03-23 Thread Gil Portenseigne
Hello Jacques, We have some production server based on 18.12, with java 11. It is working fine. Gil On Wed, Mar 23, 2022 at 05:58:25PM +0100, Jacques Le Roux wrote: > BTW, > > Is there someone who is already using Java 11 with 18.12? > > TIA > > Jacques > > Le 23/03/2022 à 16:24, Jacques

Re: Welcome to Nicola Mazzoni and Giulio Speri as new committers

2022-03-22 Thread Gil Portenseigne
Congratulations, Welcome ! Gil On Mon, Mar 21, 2022 at 09:26:16PM +0100, Jacopo Cappellato wrote: > The OFBiz PMC has invited Nicola Mazzoni and Giulio Speri as new > committers and we are glad to announce that they have accepted the > nomination. > > On behalf of the OFBiz PMC, welcome on

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Gil Portenseigne
+1, Verifying files... sha check of file: apache-ofbiz-18.12.05.zip Using sha file: apache-ofbiz-18.12.05.zip.sha512 apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 334583ED 606F5516 6D653B2C

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2021-12-30 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466789#comment-17466789 ] Gil Portenseigne commented on OFBIZ-9498: - Hello [~ieugen] , Thanks for your review, I work

Re: [Conclusion] PartyRole usage in OFBiz

2021-11-19 Thread Gil Portenseigne
Hello Pierre, Inline, On Fri, Nov 19, 2021 at 06:48:40PM +0100, Pierre Smits wrote: > Hi Gil, All, > > My apologies, but I have to object to this and for the following reasoning: > Objections to pursuing improvements to the entity definition (for > PartyRole) and subsequent addressing front-end

[Conclusion] PartyRole usage in OFBiz

2021-11-19 Thread Gil Portenseigne
Hello, I will try to summarize the ongoing thread, to produce a conclusion or potential plan. Sorry in advance, if I forgot some points. About the improvement of adding lifespan in PartyRole entity, the "Won't do" seems to get the consensus, since this improvement do not follow logical purpose

  1   2   3   4   5   6   7   8   9   10   >