Re: [PATCH v2] drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds

2024-05-31 Thread Alex Deucher
Applied. Thanks! On Fri, May 31, 2024 at 12:31 PM Tasos Sahanidis wrote: > > Flexible arrays used [1] instead of []. Replace the former with the latter > to resolve multiple UBSAN warnings observed on boot with a BONAIRE card. > > In addition, use the __counted_by attribute where possible to

Re: [PATCH][next] drm/amd/display: Fix a handful of spelling mistakes

2024-05-31 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 31, 2024 at 11:37 AM Randy Dunlap wrote: > > > > On 5/31/24 2:32 AM, Colin Ian King wrote: > > There are a few spelling mistakes in dml2_printf messages. Fix them. > > > > Signed-off-by: Colin Ian King > > > Reviewed-by: Randy Dunlap > > Thanks. > > > --- >

[PATCH] Revert "drm/amdgpu/gfx11: enable gfx pipe1 hardware support"

2024-05-31 Thread Alex Deucher
This reverts commit 269226a8fdf2cac0e03920f9ba0d670a056af3d6. Pierre-Eric reported problems with this on his navi33. Revert for now until we understand what is going wrong. Signed-off-by: Alex Deucher Cc: pierre-eric.pelloux-pra...@amd.com --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 6

[PATCH 5/5] drm/amdgpu: add sdma 7.0 support for copy dcc buffer

2024-05-31 Thread Alex Deucher
From: Frank Min 1. Add dcc buffer flag for copy buffer 2. Add sdma 7.0 support copy dcc buffer Signed-off-by: Likun Gao Signed-off-by: Frank Min Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8

[PATCH 4/5] drm/amdgpu: support for DCC feature

2024-05-31 Thread Alex Deucher
From: Likun Gao Deal with AMDGPU_GEM_CREATE_GFX12_DCC to set DCC bit when needed. Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 ++ drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 3 +++ 2 files changed, 9

[PATCH 1/5] drm/amdgpu: define new gfx12 uapi flags

2024-05-31 Thread Alex Deucher
From: Marek Olšák define new gfx12 uapi flags Signed-off-by: Marek Olšák Acked-by: Hawking Zhang Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index

[PATCH 2/5] drm/amdgpu: update gc_12_0_0 headers

2024-05-31 Thread Alex Deucher
Add some additional registers. Signed-off-by: Alex Deucher --- .../include/asic_reg/gc/gc_12_0_0_offset.h| 8 ++ .../include/asic_reg/gc/gc_12_0_0_sh_mask.h | 98 +++ 2 files changed, 106 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/gc

[PATCH 3/5] drm/amdgpu: add additional VM bits

2024-05-31 Thread Alex Deucher
Add additional VM PTE bits. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h index acd1b55b8b0e..a14cf93417c7 100644 --- a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: fix failure mapping legacy queue when FLR

2024-05-31 Thread Alex Deucher
t; init be skipped during FLR, which will leads to mapping legacy queue > fail. Set this flag as false when post reset will fix this issue. > > Signed-off-by: Lin.Cao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ > 1 file changed, 2 inserti

Re: [PATCH v1 3/3] drm/amdgpu: add cp queue registers for gfx9 ipdump

2024-05-30 Thread Alex Deucher
ptr = kcalloc(reg_count * inst, sizeof(uint32_t), GFP_KERNEL); > + if (ptr == NULL) { > + DRM_ERROR("Failed to allocate memory for GFX CP IP Dump\n"); > + adev->gfx.ip_dump_cp_queues = NULL; > + } else { > + adev->gfx

[pull] amdgpu, amdkfd drm-fixes-6.10

2024-05-30 Thread Alex Deucher
- Simplify APU VRAM handling Alex Deucher (4): drm/amdgpu: Adjust logic in amdgpu_device_partner_bandwidth() drm/amdgpu: silence UBSAN warning Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 de

Re: [PATCH] drm/amdgpu: Fix type mismatch in amdgpu_gfx_kiq_init_ring

2024-05-30 Thread Alex Deucher
uot;drm/amdgpu: Fix snprintf usage in > amdgpu_gfx_kiq_init_ring") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202405250446.xeawe66u-...@intel.com/ > Cc: Lijo Lazar > Cc: Alex Deucher > Cc: Christian König > Signed-off-by: Sri

Re: [PATCH] drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds

2024-05-30 Thread Alex Deucher
On Thu, May 30, 2024 at 6:31 AM Tasos Sahanidis wrote: > > On Mon, May 27, 2024 at 10:47:39AM -0400, Alex Deucher wrote: > > On Mon, May 27, 2024 at 5:42 AM Tasos Sahanidis wrote: > > > > > > On 2024-05-23 17:52, Alex Deucher wrote: > > > > On Th

Re: [PATCH] drm/radeon: Remove __counted_by from StateArray.states[]

2024-05-30 Thread Alex Deucher
Applied. Thanks! On Wed, May 29, 2024 at 5:54 PM Nathan Chancellor wrote: > > From: Bill Wendling > > Work for __counted_by on generic pointers in structures (not just > flexible array members) has started landing in Clang 19 (current tip of > tree). During the development of this feature, a

Re: [PATCH] MAINTAINERS: update email for Evan Quan

2024-05-30 Thread Alex Deucher
I'll send out an update. Thanks! Alex On Thu, May 30, 2024 at 9:12 AM Wolfram Sang wrote: > > > > Evan no longer maintains the SWSMU code, it should be changed to Kenneth > > and Jun (CCed). > > Thanks for the heads up! Kenneth, Jun, will you send a patch or shall I? > If you send one, please

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 2:47 AM Wolfram Sang wrote: > > Hi Alex, > > On Thu, May 09, 2024 at 01:15:32PM -0400, Alex Deucher wrote: > > On Thu, May 9, 2024 at 8:02 AM Heiner Kallweit wrote: > > > > > > Support for I2C_CLASS_SPD is currently being removed f

Re: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

2024-05-29 Thread Alex Deucher
Ping? On Wed, May 8, 2024 at 3:42 PM Alex Deucher wrote: > > This fixes HDP flushes on systems with non-4K pages. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a

Re: [PATCH 1/4] [RESEND] drm/amd/display: dynamically allocate dml2_configuration_options structures

2024-05-29 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, May 28, 2024 at 7:52 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > This structure is too large to fit on a stack, as shown by the > newly introduced warnings from a recent code change: > >

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: > > On Wed, 29 May 2024, Alex Deucher wrote: > > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > > wrote: > >> > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it

Re: [bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-05-29 Thread Alex Deucher
DId you also update mesa? There could be a UMD change that causes the page faults. Alex On Wed, May 29, 2024 at 3:37 AM Christian König wrote: > > Hi, > > when the issue is easy to reproduce I suggest to bisect the changes > between 6.9 and 6.10-rc1. > > On the other hand it's not unlikely

Re: [PATCH v1 1/3] drm/amdgpu: add gfx9 register support in ipdump

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 5:50 AM Sunil Khatri wrote: > > Add general registers of gfx9 in ipdump for > devcoredump support. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 124 +- > 1 file changed, 123 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
ACPI > lid status and if it's closed disable any eDP connectors. > > Reported-by: Chris Bainbridge > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 > Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher Do you have drm-misc access or do you need someone to appl

Re: [PATCH 2/2] drivers/gpu: Fix misalignment in comment block

2024-05-28 Thread Alex Deucher
Applied. Thanks! Alex On Tue, May 28, 2024 at 10:47 AM Bruno Rocha Levi wrote: > > This patch fixes a warning from checkpatch by ensuring the trailing */ is > aligned with the rest of the *, improving readability. > > Co-developed-by: Lucas Antonio > Signed-off-by: Lucas Antonio >

Re: [PATCH] drm/amdkfd: simplify APU VRAM handling

2024-05-27 Thread Alex Deucher
On Mon, May 27, 2024 at 3:22 PM Felix Kuehling wrote: > > On 2024-05-24 10:08, Alex Deucher wrote: > > With commit 89773b85599a > > ("drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs") > > big and small APU "VRAM" handling in KFD was un

Re: [PATCH] drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds

2024-05-27 Thread Alex Deucher
On Mon, May 27, 2024 at 5:42 AM Tasos Sahanidis wrote: > > On 2024-05-23 17:52, Alex Deucher wrote: > > On Thu, May 23, 2024 at 9:05 AM Tasos Sahanidis wrote: > >> > >> Dyanmically sized arrays used [1] instead of []. Replacing the former > >> with the lat

Re: [PATCH] drm/client: Detect when ACPI lid is closed during initialization

2024-05-27 Thread Alex Deucher
ACPI > lid status and if it's closed disable any eDP connectors. > > Suggested-by: Alex Deucher > Reported-by: Chris Bainbridge > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 > Signed-off-by: Mario Limonciello > --- > drivers/gpu/drm/drm_client_modese

[PATCH] drm/amdkfd: simplify APU VRAM handling

2024-05-24 Thread Alex Deucher
s (Lang) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 16 drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 6 ++ drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 1 - 4 files ch

Re: [PATCH] drm/amd/display: clean up some inconsistent indenting

2024-05-24 Thread Alex Deucher
Applied. Thanks! On Thu, May 23, 2024 at 10:37 PM Jiapeng Chong wrote: > > No functional modification involved. > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:5200 > dc_power_down_on_boot() warn: inconsistent indenting. > > Reported-by: Abaci Robot > Closes:

Re: [PATCH] drm/amdgpu: drop MES 10.1 support v3

2024-05-24 Thread Alex Deucher
can be removed since it is > no longer used. It's still used by gfx10_kiq_invalidate_tlbs(). Alex > > Best Regards, > Harish > > > -Original Message----- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, May 23, 2024 3:48 PM > To: amd-gfx@lis

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-24 Thread Alex Deucher
On Fri, May 24, 2024 at 9:17 AM Alex Deucher wrote: > > On Fri, May 24, 2024 at 5:16 AM Guenter Roeck wrote: > > > > Hi, > > > > On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: > > > Now that all previously-supported architectures s

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-24 Thread Alex Deucher
> > of the existing list of architectures. It can also take advantage of the > > common kernel-mode FPU API and method of adjusting CFLAGS. > > > > Acked-by: Alex Deucher > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Samuel Holland > > With this patch in

[PATCH] drm/amdgpu: drop MES 10.1 support v3

2024-05-23 Thread Alex Deucher
It was an enablement vehicle for MES 11 and was never productized. Remove it. v2: drop additional checks in the GFX10 code. v3: drop mes_api_def.h Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |1 - drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 20

Re: [PATCH] drm/amdgpu: drop MES 10.1 support v2

2024-05-23 Thread Alex Deucher
amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, May 23, 2024 2:46 PM > To: Deucher, Alexander > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: drop MES 10.1 support v2 > > Ping? > > On Fri, May 10, 2024 at 7:37 PM Alex Deucher > wrote: >

Re: [PATCH] drm/amdgpu: drop MES 10.1 support v2

2024-05-23 Thread Alex Deucher
Ping? On Fri, May 10, 2024 at 7:37 PM Alex Deucher wrote: > > It was an enablement vehicle for MES 11 and was never > productized. Remove it. > > v2: drop additional checks in the GFX10 code. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgp

Re: [PATCH 1/3] drm/amdgpu/gfx11: select HDP ref/mask according to gfx ring pipe

2024-05-23 Thread Alex Deucher
Ping on this series? Alex On Mon, May 13, 2024 at 4:32 PM Alex Deucher wrote: > > Use correct ref/mask for differnent gfx ring pipe. Ported from > ZhenGuo's patch for gfx10. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- > 1 f

Re: [PATCH] drm/amdgpu: silence UBSAN warning

2024-05-23 Thread Alex Deucher
Ping? On Thu, May 16, 2024 at 10:32 AM Alex Deucher wrote: > > Convert a variable sized array from [1] to []. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH] drm/amdgpu: Adjust logic in amdgpu_device_partner_bandwidth()

2024-05-23 Thread Alex Deucher
Ping? On Thu, May 16, 2024 at 11:42 AM Alex Deucher wrote: > > Use current speed/width on devices which don't support > dynamic PCIe switching. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3289 > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amd

Re: [PATCH] Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"

2024-05-23 Thread Alex Deucher
Ping? On Mon, May 20, 2024 at 2:52 PM Alex Deucher wrote: > > This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8. > > Revert this commit as apparently the LLVM code to take advantage of > this never landed. > > Signed-off-by: Alex Deucher > Cc: Feifei Xu >

[PATCH] drm/amdkfd: simplify APU VRAM handling

2024-05-23 Thread Alex Deucher
With commit 89773b85599a ("drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs") big and small APU "VRAM" handling in KFD was unified. Since AMD_IS_APU is set for both big and small APUs, we can simplify the checks in the code. Signed-off-by: Alex Deucher ---

Re: [PATCH 1/3] drm/amdkfd: Sync trap handler binary with source

2024-05-23 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Thu, May 23, 2024 at 10:27 AM Jay Cornwall wrote: > > Source and binary have become mismatched during branch activity. > > Signed-off-by: Jay Cornwall > Cc: Lancelot Six > --- > .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h| 57 +++

Re: [PATCH 4/4] drm/amdgpu: prevent gpu access during reset recovery

2024-05-23 Thread Alex Deucher
On Thu, May 23, 2024 at 11:32 AM Christian König wrote: > > Am 23.05.24 um 13:36 schrieb Li, Yunxiang (Teddy): > > [AMD Official Use Only - AMD Internal Distribution Only] > > > >>> +void amdgpu_lock_hw_access(struct amdgpu_device *adev); void > >>> +amdgpu_unlock_hw_access(struct amdgpu_device

Re: [PATCH 1/4] drm/amdgpu: fix -Wformat-truncation warning in amdgpu_gfx_kiq_init_ring()

2024-05-23 Thread Alex Deucher
~ > 333 | xcc_id, ring->me, ring->pipe, ring->queue); > | ~~ > > Silence the warning by checking the snprintf() return value. > Already fixed with this patch: https://patchw

Re: [PATCH] drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds

2024-05-23 Thread Alex Deucher
On Thu, May 23, 2024 at 9:05 AM Tasos Sahanidis wrote: > > Dyanmically sized arrays used [1] instead of []. Replacing the former > with the latter resolves multiple warnings observed on boot with a > BONAIRE card. > > Signed-off-by: Tasos Sahanidis > --- > drivers/gpu/drm/amd/include/pptable.h

[pull] amdgpu, amdkfd drm-fixes-6.10

2024-05-22 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.10. The following changes since commit 5a5a10d9db77939a22e1d65fc0a4ba6b5d8f4fce: drm/buddy: Fix the warn on's during force merge (2024-05-20 06:42:12 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH 3/3] drm/amdgpu: Update the impelmentation of AMDGPU_PTE_MTYPE_VG10

2024-05-22 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Wed, May 22, 2024 at 1:47 AM Shane Xiao wrote: > > This patch changes the implementation of AMDGPU_PTE_MTYPE_VG10, > clear the bits before setting the new one. > > Suggested-by: Alex Deucher > Signed-off-by: longlyao > Sign

Re: [PATCH v1 00/10] ipdump support for gfx10 and gfx11

2024-05-22 Thread Alex Deucher
On Wed, May 22, 2024 at 3:30 AM Sunil Khatri wrote: > > With this support for gfx10 and gfx11 ipdump is complete. > Also added dev_info needed fields for devcoredump. A few comments on patch 4. The rest are: Reviewed-by: Alex Deucher > > Sunil Khatri (10): > drm/amdgpu:

Re: [PATCH v1 04/10] drm/amdgpu: add prints while ip register dump

2024-05-22 Thread Alex Deucher
um_ip_blocks; i++) > if > (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state) > tmp_adev->ip_blocks[i].version->funcs > ->dump_ip_state((void *)tmp_adev); > +

Re: [PATCH] drm/amdgpu: Update the impelmentation of AMDGPU_PTE_MTYPE_GFX12

2024-05-21 Thread Alex Deucher
On Mon, May 20, 2024 at 5:37 AM Xiao, Shane wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alex, > > I have changed the macro AMDGPU_PTE_MTYPE_GFX12 to clear mtype bit before > setting. > Add one parameter for this macro, and some related code needs to be changed. > >

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
Applied and pushed out: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8a0a7b98d4b6eeeab337ec25daa4bc0a5e710a15 Alex On Tue, May 21, 2024 at 12:12 PM Alex Deucher wrote: > > I've got it teed up. Is drm-misc-fixes the right branch since we are > in the merge window? > >

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
I've got it teed up. Is drm-misc-fixes the right branch since we are in the merge window? Alex On Tue, May 21, 2024 at 7:20 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily

[PATCH] Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"

2024-05-20 Thread Alex Deucher
This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8. Revert this commit as apparently the LLVM code to take advantage of this never landed. Signed-off-by: Alex Deucher Cc: Feifei Xu --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 ++- 1 file changed, 2 insertions(+), 9

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-20 Thread Alex Deucher
TALL_MOD_PATH=/boot2 modules_install > >> # cp arch/x86/boot/bzImage /boot2/vmlinuz > >> # sync > >> ...QV on Acer laptop, black screen! > >> > >> # git bisect bad > >> 56b522f4668167096a50c39446d6263c96219f5f is the first bad commit

Re: [PATCH] drm/amdgpu: Fix amdgpu_vm_is_bo_always_valid kerneldoc

2024-05-20 Thread Alex Deucher
Add amdgpu_bo_is_vm_bo helper") > Cc: Christian König > Cc: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > b/drivers/gpu/drm/amd/am

Re: [PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-20 Thread Alex Deucher
On Fri, May 17, 2024 at 4:42 AM Yang Li wrote: > > This patch updates the function documentation comment for > optc35_set_odm_combine to conform to the kernel-doc specification. > > Signed-off-by: Yang Li Thanks for the patch. Srini already fixed this last week. Alex > --- >

Re: [PATCH] drm/amdgpu/atomfirmware: add intergrated info v2.3 table

2024-05-20 Thread Alex Deucher
Acked-by: Alex Deucher On Mon, May 20, 2024 at 7:07 AM Li Ma wrote: > > [Why] > The vram width value is 0. > Because the integratedsysteminfo table in VBIOS has updated to 2.3. > > [Solution] > Driver needs a new intergrated info v2.3 table too. > Then the vram wid

[PATCH] drm/amd/pm: update driver-if interface

2024-05-17 Thread Alex Deucher
From: Kenneth Feng update driver-if interface for smu 14.0.2/3 Signed-off-by: Kenneth Feng Reviewed-by: Yang Wang Signed-off-by: Alex Deucher --- .../swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h | 21 +-- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h | 2 +- 2 files changed

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 1:27 PM Tim Van Patten wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all

Re: [PATCH] drm/amdkfd: Correct the GFX12 memory type setting

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 11:51 AM Alex Deucher wrote: > > On Fri, May 17, 2024 at 3:07 AM Shane Xiao wrote: > > > > This patch fixes the GFX12 memory type to NC. Since > > the Memory type can be overwritten by the previous > > operations, the GFX12 MTYPE bits need

Re: [PATCH] drm/amdkfd: Correct the GFX12 memory type setting

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:07 AM Shane Xiao wrote: > > This patch fixes the GFX12 memory type to NC. Since > the Memory type can be overwritten by the previous > operations, the GFX12 MTYPE bits need to be clear > before setting to NC. > > Signed-off-by: longlyao > Signed-off-by: Shane Xiao >

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 2:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:41 AM Tvrtko Ursulin wrote: > > > On 16/05/2024 20:21, Alex Deucher wrote: > > On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Reduced re-spin of my previous series

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 16, 2024 at 3:46 PM Tim Van Patten wrote: > > From: Tim Van Patten > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > 9.3.0: > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > > This causes the device to hang when

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-16 Thread Alex Deucher
On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Reduced re-spin of my previous series after Christian corrected a few > misconceptions that I had. So lets see if what remains makes sense or is still > misguided. > > To summarise, the series address the

Re: [PATCH] drm/amdgpu/vcn: update vcn5 enc/dec capabilities

2024-05-16 Thread Alex Deucher
On Wed, May 15, 2024 at 3:57 PM Ruijing Dong wrote: > > Update the capabilities for supporting 8k encoding/decoding. > > Signed-off-by: Ruijing Dong Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc24.c | 10 +- > 1 file changed, 5 insertions(+), 5

[PATCH] drm/amd/pm: support mode1 reset on smu v14.0.3

2024-05-16 Thread Alex Deucher
From: Kenneth Feng Align with new port same as smu 13.x. Signed-off-by: Kenneth Feng Reviewed-by: Jack Gui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm

[PATCH] drm/amdgpu: Adjust logic in amdgpu_device_partner_bandwidth()

2024-05-16 Thread Alex Deucher
Use current speed/width on devices which don't support dynamic PCIe switching. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3289 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff

Re: [PATCH] drm/amdgpu: Remove duplicate amdgpu_umsch_mm.h header

2024-05-16 Thread Alex Deucher
Applied. Thanks! On Thu, May 16, 2024 at 4:47 AM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/amdgpu/amdgpu.h: amdgpu_umsch_mm.h is included more > than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9063 > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH] drm/radeon: initialize atom DIG backlight for iMac12, 1 and iMac12, 2 with Radeon 6750M

2024-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Wed, May 15, 2024 at 5:47 PM Kendall Smith wrote: > > If a Radeon 6750M GPU from an iMac12,1 is installed into an iMac 12,2, there > is no backlight device initialized during boot. Everything else is > functional, but the display brightness cannot be controlled.

[PATCH] drm/amdgpu: silence UBSAN warning

2024-05-16 Thread Alex Deucher
Convert a variable sized array from [1] to []. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmware.h index

Re: [PATCH] drm/amd/pm: disable gpo temporarily

2024-05-15 Thread Alex Deucher
On Wed, May 15, 2024 at 7:12 AM Gao, Likun wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Kenneth Feng > > disable gpo temprarily since it is not ready in fw > > Signed-off-by: Kenneth Feng > Reviewed-by: Jack Gui Acked-by: Alex Deu

Re: [PATCH] drm/amdgpu: fix Kconfig for ISP

2024-05-14 Thread Alex Deucher
Ignore this. Better, functional patch sent out. Alex On Tue, May 14, 2024 at 5:12 PM Alex Deucher wrote: > > Add new config option and set proper dependencies for ISP. > > Signed-off-by: Alex Deucher > Cc: Pratap Nirujogi > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 1

[PATCH] drm/amdgpu: fix Kconfig for ISP v2

2024-05-14 Thread Alex Deucher
Add new config option and set proper dependencies for ISP. v2: add missed guards, drop separate Kconfig Signed-off-by: Alex Deucher Cc: Pratap Nirujogi --- drivers/gpu/drm/amd/amdgpu/Kconfig| 11 +++ drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++ drivers/gpu/drm

[PATCH] drm/amdgpu: fix Kconfig for ISP

2024-05-14 Thread Alex Deucher
Add new config option and set proper dependencies for ISP. Signed-off-by: Alex Deucher Cc: Pratap Nirujogi --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++ drivers/gpu/drm/amd/isp/Kconfig | 17 + 3 files changed, 20 insertions

[PATCH 2/2] drm/amdgpu: fix documentation errors in gmc v12.0

2024-05-14 Thread Alex Deucher
Fix up parameter descriptions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c index 34e751b9b7003..c12c96f5bbaae 100644 --- a/drivers

[PATCH 1/2] drm/amdgpu: fix documentation errors in sdma v7.0

2024-05-14 Thread Alex Deucher
Fix up parameter descriptions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c index 7db53a96cff0a

[PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP

2024-05-14 Thread Alex Deucher
Add missing documentation for the IP block. Fixes: a83048bfa402 ("drm/amd/amdgpu: Add ISP support to amdgpu_discovery") Reported-by: Stephen Rothwell Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/g

Re: [PATCH] drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit

2024-05-14 Thread Alex Deucher
passed through, this leads to a NULL pointer dereference on startup. > > > > Signed-off-by: Friedrich Vock > > Acked-by: Christian König > > > > > Fixes: 1bece222eab ("drm/amdgpu: Clear doorbell interrupt status for Sienna > > Cichlid") > > C

Re: [PATCH] drm/amdgpu/mes: use mc address for wptr in add queue packet

2024-05-14 Thread Alex Deucher
Acked-by: Alex Deucher On Tue, May 14, 2024 at 5:07 AM Min, Frank wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Frank Min > > use mc address for wptr in add queue packet > > Signed-off-by: Frank Min > --- > drivers/gpu/

[PATCH 2/2] drm/amdgpu: apply state adjust rules to some additional HAINAN vairants

2024-05-13 Thread Alex Deucher
They need a similar workaround. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1839 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c b/drivers/gpu

[PATCH 1/2] drm/radeon: apply state adjust rules to some additional HAINAN vairants

2024-05-13 Thread Alex Deucher
They need a similar workaround. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1839 Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/si_dpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c

Re: [PATCH] drm/amdgpu/pm: update documentation on memory clock

2024-05-13 Thread Alex Deucher
Ping? On Thu, May 2, 2024 at 5:07 PM Alex Deucher wrote: > > Update documentation for RDNA3 dGPUs. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/amdgp

[PATCH 3/3] drm/amdgpu/gfx11: enable gfx pipe1 hardware support

2024-05-13 Thread Alex Deucher
Enable gfx pipe1 hardware support. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index d750ab86e4b27..96f441917b719

[PATCH 1/3] drm/amdgpu/gfx11: select HDP ref/mask according to gfx ring pipe

2024-05-13 Thread Alex Deucher
Use correct ref/mask for differnent gfx ring pipe. Ported from ZhenGuo's patch for gfx10. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd

[PATCH 2/3] drm/amdgpu/gfx11: handle priority setup for gfx pipe1

2024-05-13 Thread Alex Deucher
Set up pipe1 as a high priority queue. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 36 ++ 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index

Re: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

2024-05-13 Thread Alex Deucher
Ping. On Wed, May 8, 2024 at 3:42 PM Alex Deucher wrote: > > This fixes HDP flushes on systems with non-4K pages. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a

Re: [PATCH v2] drm/amd/display: fix documentation warnings for mpc.h

2024-05-13 Thread Alex Deucher
On Sat, May 11, 2024 at 12:22 AM Stephen Rothwell wrote: > > Hi Marcelo, > > On Sat, 11 May 2024 13:37:17 +1000 Stephen Rothwell > wrote: > > > > Thanks for doing this. > > > > I haven't tested it, but just a couple of little things: > > > > On Fri, 10 May 2024 21:02:02 -0300 Marcelo Mendes

Re: [PATCH] drm/amdgpu: fix getting vram info for gfx12

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 11:32 AM Min, Frank wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Frank Min > > gfx12 query video mem channel/type/width from umc_info of atom list, so fix > it accordingly. > > Signed-off-by: Frank M

Re: [PATCH] drm/amdgpu: add initial value for gfx12 AGP aperture

2024-05-13 Thread Alex Deucher
Reviewed-by: Alex Deucher On Mon, May 13, 2024 at 5:37 AM Gao, Likun wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > This patch was > Reviewed-by: Likun Gao . > > Regards, > Likun > > -Original Message- > From: Min, Frank >

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: > > On Fri, 10 May 2024, Alex Deucher wrote: > > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: > >> > >> I've sent this some moths ago, let's try again... > >> > >> BR, > >> Jan

Re: [PATCH 1/3] drm/amdgpu/gfx11: select HDP ref/mask according to gfx ring pipe

2024-05-10 Thread Alex Deucher
Ping again. This series enables a high priority gfx queue on gfx11, similar to gfx10. Alex On Tue, May 7, 2024 at 9:26 AM Alex Deucher wrote: > > Ping on this series? > > On Thu, May 2, 2024 at 6:02 PM Alex Deucher wrote: > > > > Use correct ref/mask for differnent gf

[PATCH] drm/amdgpu: drop MES 10.1 support v2

2024-05-10 Thread Alex Deucher
It was an enablement vehicle for MES 11 and was never productized. Remove it. v2: drop additional checks in the GFX10 code. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |1 - drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 20 - drivers/gpu/drm/amd

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
: MST DSC check for older devices Alex Deucher (1): drm/amdkfd: don't allow mapping the MMIO HDP page with large pages Lijo Lazar (1): Revert "drm/amdkfd: Add partition id field to location_id" Mario Limonciello (1): dm/amd/pm: Fix problems with reboot/shutdown for some

Re: [pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
Never mind. I'll send a new PR now. Alex On Fri, May 10, 2024 at 10:01 AM Alex Deucher wrote: > > On Thu, May 9, 2024 at 11:22 PM Dave Airlie wrote: > > > > On Thu, 9 May 2024 at 09:00, Alex Deucher wrote: > > > > > > Hi Dave, Sima, > > > &

Re: [PATCH] drm/amdkfd: Add GFX1201 to svm_range_get_pte_flags function

2024-05-10 Thread Alex Deucher
Reviewed-by: Alex Deucher On Fri, May 10, 2024 at 11:12 AM Sreekant Somasekharan wrote: > > GFX1201 was missed in the commit below. Adding it in. > > 'Fixes: 7c06cc729edc ("drm/amdkfd: mark GFX12 system and peer > GPU memory mappings as MTYPE_NC")' > Signed-o

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-10 Thread Alex Deucher
o from display info > drm/radeon: remove radeon_connector_edid() and stop using > edid_blob_ptr > drm/amdgpu: remove amdgpu_connector_edid() and stop using > edid_blob_ptr > drm/edid: add a helper for EDID sysfs property show > drm/connector: update edid_blob

Re: [pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
On Thu, May 9, 2024 at 11:22 PM Dave Airlie wrote: > > On Thu, 9 May 2024 at 09:00, Alex Deucher wrote: > > > > Hi Dave, Sima, > > > > Fixes for 6.9. > > > > The following changes since commit dd5a440a31fae6e459c0d627162825505361: > >

Re: [PATCH] drm/amd/amdgpu: update jpeg 5 capability

2024-05-09 Thread Alex Deucher
On Thu, May 9, 2024 at 6:02 PM David (Ming Qiang) Wu wrote: > > Based on the documentation the maximum resolustion should > be 16384x16384. > > Signed-off-by: David (Ming Qiang) Wu Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc24.c | 2 +- > 1 file ch

Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

2024-05-09 Thread Alex Deucher
> > We can just change the macro of DRM_INFO. > Do we agree on using DRM_INFO? Doesn't matter to me as long as we have a way to differentiate between multiple devices on a system. Alex > > Regards, > > David > > On 2024-05-09 17:36, Alex Deucher wrote: > > On Thu, May

Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

2024-05-09 Thread Alex Deucher
jpeg_v4_0.c: DRM_DEV_INFO(adev->dev, "JPEG decode initialized > successfully.\n"); > amdgpu/jpeg_v4_0.c: DRM_DEV_INFO(adev->dev, "JPEG decode is enabled in VM > mode\n"); > > If the rest of code in amdgpu uses DRM_INFO why should we make VCN and JPEG

Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

2024-05-09 Thread Alex Deucher
On Thu, May 9, 2024 at 4:57 PM David (Ming Qiang) Wu wrote: > > amdgpu jpeg kernel message is different than others such as vcn: > [drm:jpeg_v5_0_0_hw_init [amdgpu]] JPEG decode initialized successfully. > > This patch is to make them consistent. > > The message after the change is: > [drm]

  1   2   3   4   5   6   7   8   9   10   >