Re: [PATCH] Revert "drm/amd/display: avoid large on-stack structures"

2024-06-05 Thread Pillai, Aurabindo
[AMD Official Use Only - AMD Internal Distribution Only] Thanks for the heads up! -- Regards, Jay From: Mahfooz, Hamza Sent: Tuesday, June 4, 2024 1:50 PM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: a...@arndb.de ; Deucher, Alexander ; Wentland

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

2024-06-05 Thread Pillai, Aurabindo
[AMD Official Use Only - AMD Internal Distribution Only] Hi Alex, I'll a hunk for fixing DCN401 as well to this and resend it later today. -- Regards, Jay From: amd-gfx on behalf of Zhang, George Sent: Tuesday, June 4, 2024 12:49 PM To: Deucher, Alexander ;

Re: [PATCH v2] drm/amd/display: Remove redundant NULL check in dcn10_set_input_transfer_func

2024-04-30 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: SHANMUGAM, SRINIVASAN Sent: Tuesday, April 23, 2024 9:34 PM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: amd-gfx@lists.freedesktop.org ; SHANMUGAM, SRINIVASAN ; Liu

Re: [PATCH] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thanks for the review! Just sent a v2 From: Wentland, Harry Sent: Tuesday, April 30, 2024 9:36 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Deucher, Alexander Subject: Re: [PATCH] drm/amd

Re: [PATCH 2/2] drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o

2024-04-24 Thread Pillai, Aurabindo
, Christian ; Pan, Xinhui Cc: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org ; dri-de...@lists.freedesktop.org ; l...@lists.linux.dev ; patc...@lists.linux.dev ; Nathan Chancellor Subject: [PATCH 2/2] drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o -Wframe-larger-than=2048 is a part

Re: [PATCH 33/43] drm/amd/display: Prevent crash on bring-up

2024-03-13 Thread Pillai, Aurabindo
; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Park, Chris ; Limonciello, Mario ; Deucher, Alexander ; sta...@vger.kernel.org ; Liu, Charlene Subject: [PATCH 33/43] drm/amd/display: Prevent crash on bring-up From: Chris Park

Re: [PATCH v2] drm/amdgpu/display: Initialize gamma correction mode variable in dcn30_get_gamcor_current()

2024-02-12 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: SHANMUGAM, SRINIVASAN Sent: Monday, February 12, 2024 10:33 AM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: amd-gfx@lists.freedesktop.org ; SHANMUGAM, SRINIVASAN ; Lakha

Re: [PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail()'

2024-01-30 Thread Pillai, Aurabindo
Sent: Tuesday, January 30, 2024 4:45 AM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: amd-gfx@lists.freedesktop.org ; Julia Lawall ; Hung, Alex ; Deucher, Alexander ; Chung, ChiaHsuan (Tom) Subject: Re: [PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail

Re: [PATCH] drm/amd/include: Add missing registers/mask for DCN316 and 350

2024-01-25 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: Siqueira, Rodrigo Sent: Thursday, January 25, 2024 1:37 PM To: amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Lei, Jun ; Pillai, Aurabindo ; Mahfooz, Hamza

Re: [PATCH] drm/amd/display: fix ABM disablement

2023-11-22 Thread Pillai, Aurabindo
, 2023 5:24 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Koenig, Christian ; Hung, Alex ; Pillai, Aurabindo ; Wu, Hersen ; Lin, Wayne ; Mahfooz, Hamza Subject: [PATCH] drm/amd/display: fix ABM disablement On recent versions of DMUB firmware

Re: [PATCH 13/15] drm/amd/display: Remove freesync video mode amdgpu parameter

2023-08-09 Thread Pillai, Aurabindo
To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Pillai, Aurabindo

Re: [PATCH v2] drm/amd/display: Use root connector's colorspace property for MST

2023-07-13 Thread Pillai, Aurabindo
[Public] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: amd-gfx on behalf of Harry Wentland Sent: Thursday, July 13, 2023 3:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Subject: [PATCH v2] drm/amd/display: Use root connector's

Re: [PATCH] Revert "drm/amd/display: Program OTG vtotal min/max selectors unconditionally for DCN1+"

2023-07-12 Thread Pillai, Aurabindo
effect as reverting the aforementioned patches, but it makes the reverted sequence available only for Steam deck hardware. -- Regards, Jay From: Guilherme G. Piccoli Sent: Tuesday, July 11, 2023 7:15 PM To: Pillai, Aurabindo ; Deucher, Alexander Cc: amd-gfx

Re: [PATCH 1/2] drm/amd/display: Do not set drr on pipe commit

2023-07-06 Thread Pillai, Aurabindo
[Public] >From the log you provided, I extracted the panel id so I expect FAMS to get >disabled on your monitor. If it doesn't work, let me know. -- Regards, Jay From: Michel Dänzer Sent: Thursday, July 6, 2023 10:11 AM To: Pillai, Aurabindo ; a

Re: [PATCH 1/2] drm/amd/display: Do not set drr on pipe commit

2023-07-06 Thread Pillai, Aurabindo
into stable trees after applying the monitor specific quirk. -- Regards, Jay From: Michel Dänzer Sent: Thursday, July 6, 2023 6:05 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Chalmers, Wesley ; Siqueira, Rodrigo ; Wheeler, Daniel ; Mahfooz

Re: [PATCH] drm/amdgpu: Add dcdebugmask option to enable DPIA trace

2023-07-06 Thread Pillai, Aurabindo
[Public] Reviewed-by: Aurabindo Pillai -- Regards, Jay From: Wang, Chao-kai (Stylon) Sent: Thursday, July 6, 2023 3:00 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-12 Thread Pillai, Aurabindo
To: Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Chalmers, Wesley Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Li, Roman ; amd-gfx@lists.freedesktop.org ; Chiu, Solomon ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Pillai, Aurabindo
reverted causes hangs with 3 monitor setups. So I will push that monitor specific quirk and bring back the reverted patches. -- Regards, Jay From: Michel Dänzer Sent: Thursday, June 8, 2023 10:20 AM To: Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Chalmers

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-07 Thread Pillai, Aurabindo
: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit On 6/6/23 20:01, Pillai, Aurabindo wrote: > > I'm attaching another DMCUB firmware which has the bug fix for the hang we > saw at our end and some added tracing enabled. Still runs into the newer hang when starting a KDE Plasm

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-02 Thread Pillai, Aurabindo
load Piglit ./scripts/run-tests.sh -d Run tests ./scripts/run-tests.sh -s -T /path/to/navi21_postsubmission.testlist -- Regards, Jay From: Michel Dänzer Sent: Thursday, June 1, 2023 11:53 AM To: Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; amd

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-01 Thread Pillai, Aurabindo
: sudo amdgpu-install --use-case=graphics --no-dkms -- Regards, Jay From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, June 1, 2023 10:59 AM To: Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; amd-gfx@lists.freedesktop.org ; Chalmers, Wesley Cc: Wang, Chao

Re: [PATCH 2/2] Revert "drm/amd/display: Do not set drr on pipe commit"

2023-05-23 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Yep, we shall, thanks Alex. -- Regards, Jay From: Alex Deucher Sent: Tuesday, May 23, 2023 11:47 AM To: Pillai, Aurabindo ; Mahfooz, Hamza Cc: Michel Dänzer ; Deucher, Alexander ; Chalmers, Wesley ; Li, Sun peng (Leo

Re: [PATCH] Revert "drm/amd/display: enable DPG when disabling plane for phantom pipe"

2023-02-15 Thread Pillai, Aurabindo
; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin Subject: [PATCH] Revert "drm/amd/display: enable DPG when disabling plane for phantom pipe" This reve

Re: [PATCH] drm/amd/display: Properly handle additional cases where DCN is not supported

2023-01-27 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai -- Regards, Aurabindo From: Deucher, Alexander Sent: Friday, January 27, 2023 1:05 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Pillai, Aurabindo Subject: [PATCH] drm/amd

Re: [PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()

2022-09-27 Thread Pillai, Aurabindo
; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Lee, Alvin ; Hung, Alex ; Kotarac, Pavle ; Wang, Chao-kai (Stylon) ; Pillai, Aurabindo ; Ma, Leo ; Wu, Hersen ; Po-Yu Hsieh Paul ; Jimmy Kizito ; amd-gfx@lists.freedesktop.org ; dri-de

Re: [PATCH 23/31] Add debug option for exiting idle optimizations on cursor updates

2022-09-22 Thread Pillai, Aurabindo
) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Syu, Brandon ; Cyr, Aric ; Dhillon, Jasdeep Subject: [PATCH 23/31] Add debug option for exiting idle

Re: [PATCH 21/31] Add ABM control to panel_config struct.

2022-09-22 Thread Pillai, Aurabindo
) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Chen, Ian ; Pavic, Josip ; Dhillon, Jasdeep Subject: [PATCH 21/31] Add ABM control to panel_config

Re: [PATCH] drm/amd/display: Fix register definitions for DCN32/321

2022-09-06 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thank you Siqueira. -- Regards, Jay From: Siqueira, Rodrigo Sent: Tuesday, September 6, 2022 11:56 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Deucher, Alexander Subject: Re: [PATCH] drm

Re: [PATCH] drm/amd/display: remove stale debug setting

2022-07-06 Thread Pillai, Aurabindo
[Public] Thanks, will merge with Cc and fixes tag -- Regards, Jay From: Deucher, Alexander Sent: Wednesday, July 6, 2022 11:33 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Siqueira, Rodrigo ; Wentland, Harry Subject: Re: [PATCH] drm/amd

Re: [PATCH] drm/amd/display: ignore modifiers when checking for format support

2022-06-10 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thanks for noticing, will fix it in a separate patch since I already merged this. -- Regards, Jay From: Chen, Guchun Sent: Thursday, June 9, 2022 9:28 PM To: Pillai, Aurabindo ; Olsak, Marek ; amd-gfx@lists.freedesktop.org

Re: [PATCH] drm/amd/display: Use pre-allocated temp struct for bounding box update

2022-06-08 Thread Pillai, Aurabindo
) Sent: Wednesday, June 8, 2022 12:48 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Pillai, Aurabindo ; Siqueira, Rodrigo ; Li, Sun peng (Leo) Subject: [PATCH] drm/amd/display: Use pre-allocated temp struct for bounding box update From: Leo Li [Why] There is a theoretical problem

Re: [PATCH] drm/amd/display: fix a missing prototype warning in DCN303

2021-12-08 Thread Pillai, Aurabindo
[AMD Official Use Only] Hi Siqueira, Thanks for the heads up, lets apply Isabella's patch instead. -- Regards, Jay From: Siqueira, Rodrigo Sent: Wednesday, December 8, 2021 10:17 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org ; Isabella Basso Cc

Re: [PATCH 14/19] drm/amd/display: fix HDCP drm prop update for MST

2021-04-19 Thread Pillai, Aurabindo
-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Brol, Eryk ; R, Bindu ; Jacob, Anson ; Zhang, Dingchen (David) ; Zhang, Dingchen (David) Subject: [PATCH 14/19] drm/amd/display: fix HDCP drm

Re: [PATCH 13/19] drm/amd/display: force CP to DESIRED when removing display.

2021-04-19 Thread Pillai, Aurabindo
-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Brol, Eryk ; R, Bindu ; Jacob, Anson ; Zhang, Dingchen (David) ; Zhang, Dingchen (David) Subject: [PATCH 13/19] drm/amd/display: force CP to DESIRED

Re: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency

2021-04-08 Thread Pillai, Aurabindo
llai From: R, Bindu Sent: Thursday, April 8, 2021 11:55 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: Aberback, Joshua Subject: Re: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency [AMD Official Use Only - Internal Distribution Only] ​Hi Jay, Could you please add

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2021-01-19 Thread Pillai, Aurabindo
anen Cc: Pillai, Aurabindo ; amd-gfx list ; dri-devel ; Kazlauskas, Nicholas ; Wang, Chao-kai (Stylon) ; Thai, Thong ; Sharma, Shashank ; Lin, Wayne ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode On Tue, Ja

Re: [PATCH v3] drm/amd/display: turn DPMS off on mst connector unplug

2020-11-27 Thread Pillai, Aurabindo
[AMD Official Use Only - Internal Distribution Only] Thank you very much for the review! -- Thanks & Regards, Aurabindo Pillai From: Kazlauskas, Nicholas Sent: Friday, November 27, 2020 10:44 AM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org