Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-20 Thread Ed Cashin
Good idea, thanks! On May 20, 2014, at 4:24 PM, Christoph Biedl sourceforge.b...@manchmal.in-ulm.de wrote: Ed Cashin wrote... I was thinking of something like this: https://github.com/ecashin/vblade/commit/ca2dbda0a35ba686c0ed64e109748129c510fa90 Please let me know if that looks OK

Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-19 Thread Ed Cashin
On May 19, 2014, at 6:46 PM, Christoph Biedl sourceforge.b...@manchmal.in-ulm.de wrote: Ed Cashin wrote... ... but noticed along the way that you're using atoi. Because you're supporting 64-bit numbers, would you mind sending a patch that uses strtoll or doing it in git and sending a pull

Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-12 Thread Ed Cashin
I merged that to a new git repo: https://github.com/ecashin/vblade/ ... but noticed along the way that you're using atoi. Because you're supporting 64-bit numbers, would you mind sending a patch that uses strtoll or doing it in git and sending a pull request? On May 11, 2014, at 2:10 PM,

Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-11 Thread Christoph Biedl
Ed Cashin wrote... That sounds like a natural complement to your first patch, yes. If you've got the momentum to whip together the second patch, I could merge them both at once. Here you are. The patch below is to replace the original one, so uses vlong for the offset, and implements a

Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-10 Thread Christoph Biedl
Ed Cashin wrote... Thanks. This looks interesting. I like the way you provided a detailed explanation of the motivation for the patch. You're welcome. Do you agree that the offset should be a vlong so that it can support the same large values that the size can support? An unsigned int

Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-09 Thread Ed Cashin
Thanks. This looks interesting. I like the way you provided a detailed explanation of the motivation for the patch. Do you agree that the offset should be a vlong so that it can support the same large values that the size can support? An unsigned int sometimes isn't going to be 64 bits. On

[Aoetools-discuss] [PATCH] Implement an offset option for vbladed

2014-05-08 Thread Christoph Biedl
Hello, the patch below implements a new option -o for vbladed, denoting the number of sectors that should be skipped at the beginning of the exported file. Default is 0 (no offset, export from beginning, current behaviour). Rationale: If the exported files are actually raw block devices on the