Hi. I've been sitting on some changes for vblade for some time now and I
remembered to clean them up and contribute them back, so here's one.
diff --git a/vblade/freebsd.c b/vblade/freebsd.c
--- a/vblade/freebsd.c
+++ b/vblade/freebsd.c
@@ -261,7 +261,24 @@
int
getmtu(int fd, char *name)
{
The BPF filter program currently included in vblade requires that the
major and minor fields in a packet header either
- match server's major and minor addresses or
- be both all ones (0x and 0xff respectively)
This is against the AoE specification that requires that the two fields
be tested
in the original code.
I'll admit that I'm not entirely certain under what circumstances one
would use this behaviour (maybe an environment where multiple hosts
serve the same image?) or if there are Coraid appliances or HBAs that
actually support this.
On 19/05/2014 11:06 PM, Catalin Salgau
be good to hear about how the fix was tested
if you don't want to take a stab at adding such a test.
On May 19, 2014, at 3:11 PM, Catalin Salgau csal...@users.sourceforge.net
wrote:
The BPF filter program currently included in vblade requires that the
major and minor fields in a packet
You beat me by a few days on this. I was looking at something similar
some time ago, but I was thinking a bit in another direction.
I'm a bit verbose today, if you missed that from the previous mails, but
please bare with me.
tl;dr
- 'negotiation' should be 'discovery' by initiator queries only
Hi,
I'm sorry to say it was not clear to me that you went ahead with a fork
from your previous mail. (but given the time I took to answer it, I
should have assumed that)
I'm not exactly working in a resource constrained environment and I
already have most of the data cached in RAM. As I
On 15/06/2014 2:48 PM, Killer{R} wrote:
Hello Catalin,
Sunday, June 15, 2014, 6:59:54 AM, you wrote:
I would like to request two changes before release.
- An option to restrict the size of packets over automatic detection of
MTU.
You mean like if the MTU is 9000, you want the ability to
Hi again!
I like my long emails, don't I?
On 15/06/2014 4:22 PM, Killer{R} wrote:
Hello Catalin,
Sunday, June 15, 2014, 4:08:15 PM, you wrote:
I would like to request two changes before release.
- An option to restrict the size of packets over automatic detection of
MTU.
You mean like if
On 15/06/2014 6:40 PM, Killer{R} wrote:
Hello Catalin,
Sunday, June 15, 2014, 6:30:09 PM, you wrote:
CS Hi again!
CS I like my long emails, don't I?
Yep :)
About drop rate - its not my pure-theoretical assumption that drop
rate must be minimized. I played with WinAOE variable named as
:
Great! After merging, I made a pre-release:
https://github.com/ecashin/vblade/releases/tag/v23-rc1
On 02/25/2015 07:50 AM, Catalin Salgau wrote:
As requested, I've opened a pull request for this.
I have not included the full explanation in the man page as I believe
that is for initiators
10 matches
Mail list logo
