Hi Dossy,
Is it possible to remove the one which you just added on github because it's
not the clean version which I wanted to add at the time when I ported for
aolserver and also I have fixed a type casting bug in the code later on. So
I wanted to import a clean and a stable version of
On Fri, Sep 03, 2010 at 06:01:17PM +0400, Majid Khan wrote:
So I wanted to import a clean and a stable version of nsmemcache to
github.
Um, hopefully Dossy is importing the entire CVS history to github, not
a single snapshot of the code. (I know there are CVS-to-git
conversion tools, so I
Is it necessary to remove what's there (and lose the change history) or just
commit your changes? Send me what you have and I can commit it, or you can fork
and send a pull request through GitHub.
Are your changes documented? How can they be tested? Will they conflict with
Sep's BUFSIZE patch?
Yes just remove what's there because there are multiple/redundant copies of
the same file so its very confusing which file is the correct version of
memcache and about the history, ever since I have imported no one added any
patch so there is nothing that we will lose. The code I have sent you is
Majid,
I will be more than happy to do it. I just probably need to figure
how and where to git pull. I don't think I have an account however.
Regards.
On Sep 4, 5:03 am, Majid Khan majidkha...@gmail.com wrote:
Yes just remove what's there because there are multiple/redundant copies of
the
I think the best way to do this is to fork the project, then replace it with
his code, then commit his diff, and then do a pull request to Dossy.
That preserves the history, and allows us to see what Majid's changes are.
Jade
*Jade Rubick* | Director of Development | TRUiST
2201 Wisconsin Ave
I have committed Majid's code to GitHub that he has sent to me and have
tagged it version 1.1. You can download the tarball for it using this URL:
http://github.com/aolserver/nsmemcache/tarball/1.1
On 9/3/10 5:03 PM, Majid Khan wrote:
Yes just remove what's there because there are
After you test the latest code from Majid, determine if your patch is
still relevant. If it is, I'll merge it in.
On 8/31/10 7:17 PM, Sep Ng wrote:
Okay, I guess I'll simply post the diff patch here for anyone who
needs it.
--
Dossy Shiobara | do...@panoptic.com |
Yes sir! As soon as possible, I will look at it and determine whether
it's still relevant. I'll post a new diff if needed.
On Sep 4, 10:55 am, Dossy Shiobara do...@panoptic.com wrote:
After you test the latest code from Majid, determine if your patch is
still relevant. If it is, I'll merge