Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-05-12 Thread Joel Granados
> > So, have patches 1-10 go via their respective subsystems, and once all > > of those are in Linus's tree, send patch 11 as a stand-alone PR. > > Ack, I'll do that with the cover letter information requested by Joel. > > > (From patch 11, it looks like the seccomp read/write function changes > > could be split out? I'll do that now...) > > Thanks! > > Thomas -- Joel Granados signature.asc Description: PGP signature

Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-05-12 Thread Joel Granados
s ("[PATCH v3 10/11] sysctl: constify ctl_table arguments of utility function"), while you push the others to their respective subsystems (If you have not already) > > (From patch 11, it looks like the seccomp read/write function changes > could be split out? I'll do that

Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-05-08 Thread Joel Granados
ide_alternative=4a383503b1ea650d4e12c1f5838974e879f5aa6f > > [2] > > https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/commit/?h=jag/constfy_treewide_alternative=a3be65973d27ec2933b9e81e1bec60be3a9b460d > > [3] proc_dostring, proc_dobool, proc_dointvec > > > Thomas Best -- Joel Granados signature.asc Description: PGP signature

Re: [apparmor] [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-05-08 Thread Joel Granados
nly *allows* the actual table to be constified > themselves. > Then each table definition will have to be touched and "const" added. That is what I thought. thx for clarifying. > > See patches 17 and 18 in [7] for two examples. > > Some tables in net/ are already "const" as the static definitions are > never registered themselves but only their copies are. > ... best -- Joel Granados signature.asc Description: PGP signature

Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-05-03 Thread Joel Granados
rags_ctl_table section: .data obj_name : ipv6_table_template section: .data obj_name : ipv6_rotable section: .data obj_name : sctp_net_table section: .data obj_name : sctp_table section: .data obj_name : smc_table section: .data

Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

2024-04-25 Thread Joel Granados
pub/scm/linux/kernel/git/joel.granados/linux.git/commit/?h=jag/constfy_treewide_alternative=4a383503b1ea650d4e12c1f5838974e879f5aa6f [2] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/commit/?h=jag/constfy_treewide_alternative=a3be65973d27ec2933b9e81e1bec60be3a9b460d [3] proc_dostring, pro

Re: [apparmor] [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

2024-04-16 Thread Joel Granados
On Mon, Apr 15, 2024 at 03:02:43PM -0400, Paul Moore wrote: > On Mon, Apr 15, 2024 at 10:17 AM Paul Moore wrote: > > On Mon, Apr 15, 2024 at 9:44 AM Joel Granados > > wrote: > > > > > > Hey > > > > > > This is the only patch that I h

Re: [apparmor] [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

2024-04-15 Thread Joel Granados
28, 2024 at 04:57:49PM +0100, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kern

Re: [apparmor] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
On Wed, Jun 21, 2023 at 04:15:46PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > >> On Wed, 21 Jun 2023, Joel Granados wrote: > >> > Remove the empty end element from

Re: [apparmor] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > Remove the empty end element from all the arrays that are passed to the > > register sysctl calls. In some files this means reducing the explicit > > array size b

[apparmor] [PATCH 07/11] sysctl: Add size to register_sysctl

2023-06-21 Thread Joel Granados
In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to register_sysctl and change all the callers to pass the ARRAY_SIZE of their table arg. Signed-off-by: Joel Granados --- arch/arm/kernel/isa.c

[apparmor] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
Remove the empty end element from all the arrays that are passed to the register sysctl calls. In some files this means reducing the explicit array size by one. Also make sure that we are using the size in ctl_table_header instead of evaluating the .procname element. Signed-off-by: Joel Granados