Re: [asterisk-dev] [Code Review] 3084: testsuite: Insure core waitfullybooted command has completed succesfully

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3084/#review10473 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 3 p.m.,

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-20 Thread rnewton
On Dec. 20, 2013, 1:56 a.m., Matt Jordan wrote: branches/12/configs/pjsip.conf.sample, line 435 https://reviewboard.asterisk.org/r/3086/diff/1/?file=49880#file49880line435 May as well align the comment with the others Everything in that section is generated by my script, I adjusted

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/#review10475 --- Ship it! Ship It! - Matt Jordan On Dec. 20, 2013, 9:28

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-20 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/ --- (Updated Dec. 20, 2013, 3:28 p.m.) Review request for Asterisk

Re: [asterisk-dev] confbridge DTMF

2013-12-20 Thread Jason Ostrom
Chandrakant, It's my understanding that DTMF should be automatically detected on the conference if the SIP UA has correct DTMF mode, such as the following in sip.conf for peer: dtmfmode=rfc2833 In ingress through SIP trunk your provider would have to properly relay through rfc2833 or SIP

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-20 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/ --- (Updated Dec. 20, 2013, 7:19 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3087: Mini-audit of the ao2_iterator loops in the new code files.

2013-12-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3087/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10476 --- For pjsip show channels The output looks like: *CLI pjsip

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread opticron
On Dec. 20, 2013, 1:27 p.m., rnewton wrote: For pjsip show channels The output looks like: *CLI pjsip show channels Channel: ChannelId State. Time(sec) Codec: Codec Exten: DialedExten. CLCID:

Re: [asterisk-dev] [Code Review] 3087: Mini-audit of the ao2_iterator loops in the new code files.

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3087/#review10478 --- Ship it! /branches/12/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10479 --- For pjsip show endpoints, a formatting issue:

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
On Dec. 20, 2013, 7:35 p.m., rnewton wrote: For pjsip show endpoints, a formatting issue: Endpoint/CID State. Channels. I/OAuth: AuthId/UserName... Aor:

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
On Dec. 20, 2013, 7:35 p.m., rnewton wrote: For pjsip show endpoints, a formatting issue: Endpoint/CID State. Channels. I/OAuth: AuthId/UserName... Aor:

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043/#review10482 --- The state reflected in the command outputs remains Invalid and

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread rnewton
On Dec. 20, 2013, 7:35 p.m., rnewton wrote: For pjsip show endpoints, a formatting issue: Endpoint/CID State. Channels. I/OAuth: AuthId/UserName... Aor:

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread George Joseph
On Dec. 20, 2013, 12:46 p.m., rnewton wrote: The state reflected in the command outputs remains Invalid and does not update until the endpoint has made at least one call. Then it will change to Not in use *CLI pjsip show endpoints snip 6001

[asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3088/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3088/#review10487 --- Ship it! Ship It! - Matt Jordan On Dec. 20, 2013, 3:50

Re: [asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread David Lee
On Dec. 20, 2013, 3:51 p.m., Matt Jordan wrote: /branches/12/res/ari/resource_applications.h, line 91 https://reviewboard.asterisk.org/r/3088/diff/1/?file=49930#file49930line91 Undo this - the comment is now correct in the code (deviceState) Actually, that's in the generated code.

Re: [asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3088/ --- (Updated Dec. 20, 2013, 4 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3088/ --- (Updated Dec. 20, 2013, 4:07 p.m.) Status -- This change has been

[asterisk-dev] Asterisk 12.0.0 Now Available!

2013-12-20 Thread Asterisk Development Team
The Asterisk Development Team is pleased to announce the release of Asterisk 12.0.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk/releases Asterisk 12 is the next major release series of Asterisk. It is a Standard release, similar to

[asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2013-12-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3089/ --- Review request for Asterisk Developers. Repository: Asterisk