Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

2014-02-20 Thread Scott Griepentrog
On Feb. 19, 2014, 5:23 p.m., Matt Jordan wrote: /branches/12/include/asterisk/channel.h, lines 178-187 https://reviewboard.asterisk.org/r/3191/diff/5/?file=54211#file54211line178 This struct should be opaque, in the same way that all other channel internals are also opaque.

[asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Mark Michelson
Hi folks, Yesterday afternoon, I put up https://reviewboard.asterisk.org/r/3237/ for review, and now I'm starting to question if it's a good idea or not. I suggest reading the full description of the proposed change, but I'll briefly summarize here. res_pjsip_mwi, the module that allows for

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Brad Watkins
On Thu, 2014-02-20 at 09:29 -0600, Mark Michelson wrote: What do you folks think? Should the code in the referenced review be the proper way to handle things or is the idea proposed in this message a better idea? Mark Michelson I absolutely think the idea proposed here is better. My

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Matthew Jordan
On Thu, Feb 20, 2014 at 9:41 AM, Brad Watkins bwatk...@thinkingphones.com wrote: On Thu, 2014-02-20 at 09:29 -0600, Mark Michelson wrote: What do you folks think? Should the code in the referenced review be the proper way to handle things or is the idea proposed in this message a better idea?

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread George Joseph
On Thu, Feb 20, 2014 at 8:29 AM, Mark Michelson mmichel...@digium.comwrote: Hi folks, Yesterday afternoon, I put up https://reviewboard.asterisk.org/r/3237/for review, and now I'm starting to question if it's a good idea or not. I suggest reading the full description of the proposed change,

[asterisk-dev] Asterisk WebRTC one way audio issue

2014-02-20 Thread Nitesh Bansal
Hello All, I am using Asterisk 11.4 to make WebRTC calls. I am having one way audio issues in certain scenarios. Analysis Failure case: INVITE sent from browser: v=0^M o=- 546074467646554532 2 IN IP4 127.0.0.1^M s=-^M t=0 0^M a=group:BUNDLE audio^M

[asterisk-dev] [Code Review] 3241: Remove extra defines of AST_PBX_MAX_STACK

2014-02-20 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3241/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23141

[asterisk-dev] New Asterisk Developer - George Joseph

2014-02-20 Thread Matthew Jordan
Hey everyone! George Joseph has been doing a lot of great work on the new PJSIP stack for Asterisk 12. This includes adding the PJSIP_HEADER function, allowing users to add, modify, and remove headers from SIP messages; adding just about all of the CLI commands for the PJSIP modules; updating the

Re: [asterisk-dev] [Code Review] 3191: channel uniqueid phase 1: convert string uniqueid values to structure with time

2014-02-20 Thread Matt Jordan
On Feb. 19, 2014, 5:23 p.m., Matt Jordan wrote: /branches/12/main/cel.c, lines 833-842 https://reviewboard.asterisk.org/r/3191/diff/5/?file=54215#file54215line833 There shouldn't be any reason to memset these, as the structure is calloc'd. rmudgett wrote: channelid is a

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Mark Michelson
George Joseph Thursday, February 20, 2014 9:47 AM snipWith my "user" hat on, I think this is fair.  What would the subscription rejection look like? Since the issue doesn't lie with the SUBSCRIBE itself but rather with server configuration, a 500 response seems

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Brad Watkins
On Thu, 2014-02-20 at 13:35 -0600, Mark Michelson wrote: George Joseph Thursday, February 20, 2014 9:47 AM snip With my user hat on, I think this is fair. What would the subscription rejection look like? Since the issue doesn't lie with the SUBSCRIBE itself but rather with

Re: [asterisk-dev] [Code Review] 3210: PJSIP_CLI: Add 'pjsip show registrations' and 'pjsip show contacts'

2014-02-20 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3210/ --- (Updated Feb. 20, 2014, 2:14 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

2014-02-20 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3200/ --- (Updated Feb. 20, 2014, 2:14 p.m.) Status -- This change has been

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread Mark Michelson
Brad Watkins Thursday, February 20, 2014 1:44 PM For clarity I'd like to see the error message be more explicit about*why* the endpoint is already receiving notifications.- Brad Sounds reasonable enough to me! --

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-20 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184/ --- (Updated Feb. 20, 2014, 2:15 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3244: res_pjsip_sdp_rtp: Apply packetization rules on inbound SDP handling

2014-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3244/ --- Review request for Asterisk Developers, Joshua Colp and Mark Michelson.

[asterisk-dev] [Code Review] 3246: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

2014-02-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3246/ --- Review request for Asterisk Developers. Repository: testsuite

[asterisk-dev] [Code Review] 3245: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

2014-02-20 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3245/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3239: res_pjsip_exten_state: Presence for digium phones

2014-02-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3239/#review10914 --- Ship it! Ship It! - Mark Michelson On Feb. 19, 2014, 10:38

Re: [asterisk-dev] [Code Review] 3240: res_pjsip_exten_state: Presence for digium phones

2014-02-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3240/#review10915 ---

Re: [asterisk-dev] [Code Review] 3241: Remove extra defines of AST_PBX_MAX_STACK

2014-02-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3241/#review10916 --- Ship it! Ship It! - Mark Michelson On Feb. 20, 2014, 5:33

Re: [asterisk-dev] [Code Review] 3225: Asterisk doesn't support the dynamic payload change in rtp mapping in the 200 OK response

2014-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3225/#review10917 --- Ship it! Ship It! - Matt Jordan On Feb. 14, 2014, 3:45

Re: [asterisk-dev] [Code Review] 3221: testsuite: Test for Marked/Normal(Unmarked) user Conference Interaction

2014-02-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3221/ --- (Updated Feb. 20, 2014, 9:44 p.m.) Status -- This change has been

[asterisk-dev] Asterisk platform

2014-02-20 Thread Frank W. Miller
Greetings, I'm thinking of porting Asterisk to a new ARM based platform. I was wondering if there are any gotchas I need to be aware of as I try it. Thanks, FM -- _ -- Bandwidth and Colocation Provided by