---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3548/
---
(Updated June 23, 2014, 2:44 a.m.)
Status
--
This change has been
On 23 Jun 2014, at 04:01, Matt Jordan reviewbo...@asterisk.org wrote:
Move eid functions from netsock.c to utils.c. These functions were already
published by utils.h. Flag netsock.h as deprecated and switch
res_pjsip_session.h to use netsock2.h. The only code that still uses
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3607/
---
(Updated June 23, 2014, 9:36 a.m.)
Review request for Asterisk
On June 17, 2014, 9:25 p.m., Mark Michelson wrote:
trunk/apps/app_queue.c, line 8490
https://reviewboard.asterisk.org/r/3607/diff/1/?file=59533#file59533line8490
atoi() does not detect errors (such as the input not being an integer)
and will just return 0 on bad values. You can
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3607/
---
(Updated June 23, 2014, 9:41 a.m.)
Review request for Asterisk
On 23 Jun 2014, at 13:59, SVN commits to the Digium repositories
svn-comm...@lists.digium.com wrote:
+ /* If ICE negotiation is enabled the DTLS Handshake will be performed
upon completion of it */
+#ifdef USE_PJPROJECT
+ if (!rtp-ssl || rtp-ice) {
+#else
if (!rtp-ssl) {
Olle E. Johansson wrote:
On 23 Jun 2014, at 13:59, SVN commits to the Digium
repositoriessvn-comm...@lists.digium.com wrote:
+ /* If ICE negotiation is enabled the DTLS Handshake will be performed
upon completion of it */
+#ifdef USE_PJPROJECT
+ if (!rtp-ssl || rtp-ice) {
+#else
On 23 Jun 2014, at 14:24, Joshua Colp jc...@digium.com wrote:
Olle E. Johansson wrote:
On 23 Jun 2014, at 13:59, SVN commits to the Digium
repositoriessvn-comm...@lists.digium.com wrote:
+ /* If ICE negotiation is enabled the DTLS Handshake will be performed
upon completion of it */
On June 23, 2014, 12:10 a.m., Corey Farrell wrote:
Sorry to hit so many issues, I did tell you I was not so confident with the
changes I made to the last 3 files. Looking at it a second time has helped
find stuff. Feel free to BUGBUG things where possible. I've clicked open
an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/
---
(Updated June 23, 2014, 9:34 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3622/
---
(Updated June 23, 2014, 9:35 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/
---
(Updated June 23, 2014, 9:51 a.m.)
Review request for Asterisk
On Sun, Jun 22, 2014 at 12:22 PM, Corey Farrell g...@cfware.com wrote:
For a few functions you are recommending we create a new function, and keep
the old function. I think we should delete the old function, at most
provide a macro so the new function can be called with the old name. The
On June 17, 2014, 4:25 p.m., Mark Michelson wrote:
trunk/apps/app_queue.c, line 8490
https://reviewboard.asterisk.org/r/3607/diff/1/?file=59533#file59533line8490
atoi() does not detect errors (such as the input not being an integer)
and will just return 0 on bad values. You can
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3657/#review12273
---
trunk/main/udptl.c
On June 23, 2014, 12:10 a.m., Corey Farrell wrote:
/team/group/media_formats-reviewed/main/rtp_engine.c, line 669
https://reviewboard.asterisk.org/r/3665/diff/3/?file=60243#file60243line669
type-format could be leaking a reference here.
Matt Jordan wrote:
If this pattern
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/#review12275
---
/team/group/media_formats-reviewed/main/format_cache.c
On June 23, 2014, 12:41 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed/main/rtp_engine.c, line 234
https://reviewboard.asterisk.org/r/3665/diff/3-4/?file=60243#file60243line234
For a static procedure shouldn't we omit the ast_ namespace?
I didn't here simply because
On June 23, 2014, 12:10 a.m., Corey Farrell wrote:
/team/group/media_formats-reviewed/main/codec.c, line 87
https://reviewboard.asterisk.org/r/3665/diff/3/?file=60235#file60235line87
Why?
Matt Jordan wrote:
Because there are times when a user wants to look up a codec by name
On June 23, 2014, 4:48 p.m., Matt Jordan wrote:
trunk/main/udptl.c, lines 538-543
https://reviewboard.asterisk.org/r/3657/diff/1/?file=59974#file59974line538
I'm not very familiar with the UDPTL code here, so this is more a dump
of me trying to figure out what the error in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3666/
---
Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/
---
(Updated June 23, 2014, 3:34 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3601/
---
(Updated June 23, 2014, 3:56 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3657/#review12282
---
Ship it!
Ship It!
- Matt Jordan
On June 20, 2014, 3:47
On June 23, 2014, 11:48 a.m., Matt Jordan wrote:
trunk/main/udptl.c, lines 538-543
https://reviewboard.asterisk.org/r/3657/diff/1/?file=59974#file59974line538
I'm not very familiar with the UDPTL code here, so this is more a dump
of me trying to figure out what the error in the
On June 23, 2014, 3:45 p.m., Corey Farrell wrote:
/team/group/media_formats-reviewed/main/rtp_engine.c, line 1730
https://reviewboard.asterisk.org/r/3665/diff/4-5/?file=60343#file60343line1730
I think we need to zero out the records starting with
ast_rtp_mime_types[y + 1] and
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/#review12285
---
Ship it!
Ship It!
- Corey Farrell
On June 23, 2014, 4:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/
---
(Updated June 23, 2014, 4:42 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/#review12286
---
/team/group/media_formats-reviewed/main/rtp_engine.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/
---
(Updated June 23, 2014, 5:10 p.m.)
Status
--
This change has been
On June 23, 2014, 4:36 p.m., Matt Jordan wrote:
/trunk/res/res_fax.c, lines 318-325
https://reviewboard.asterisk.org/r/3666/diff/1/?file=60383#file60383line318
For duplicate fields, use an xi:include to pull in the documentation.
Don't reproduce documentation that you don't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3667/
---
Review request for Asterisk Developers, Joshua Colp and Matt Jordan.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3661/
---
(Updated June 23, 2014, 9:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3668/
---
Review request for Asterisk Developers and Matt Jordan.
Bugs:
On June 17, 2014, 9:25 p.m., Mark Michelson wrote:
trunk/apps/app_queue.c, line 8490
https://reviewboard.asterisk.org/r/3607/diff/1/?file=59533#file59533line8490
atoi() does not detect errors (such as the input not being an integer)
and will just return 0 on bad values. You can
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3669/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23790
36 matches
Mail list logo
