[asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

2014-06-24 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3670/ --- Review request for Asterisk Developers, George Joseph, Matt Jordan, and

Re: [asterisk-dev] [Code Review] 3463: RFC: astobj2 cached objects (alternative to weak containers)

2014-06-24 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3463/ --- (Updated June 24, 2014, 2:29 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option

2014-06-24 Thread Pavel Troller
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 24, 2014, 6:53 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option

2014-06-24 Thread Pavel Troller
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 24, 2014, 6:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3667: Media Formats fixes for trunk branch

2014-06-24 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3667/ --- (Updated June 24, 2014, 3:39 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option

2014-06-24 Thread Pavel Troller
On June 19, 2014, 11:05 p.m., rmudgett wrote: /branches/11/channels/chan_dahdi.c, line 12921 https://reviewboard.asterisk.org/r/3633/diff/1/?file=59792#file59792line12921 Rename alwayssendprogress to always_send_progress. It is a whole lot easier to read that way and you might

Re: [asterisk-dev] [Code Review] 3667: Media Formats fixes for trunk branch

2014-06-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3667/#review12289 --- Ship it!

Re: [asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

2014-06-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3670/#review12290 --- Ship it! Ship It! - Matt Jordan On June 24, 2014, 1:28

Re: [asterisk-dev] [svn-commits] file: branch file/sha256-a-harsh-reality r417185 - /team/file/sha256-a-harsh-...

2014-06-24 Thread Olle E. Johansson
On 24 Jun 2014, at 15:37, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: Handle receiving SSL traffic before ICE negotiation completes. Mind your language, young man :-) You are working with DTLS, which is TLS and not SSL. We should stop using SSL and start using

Re: [asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

2014-06-24 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3670/#review12291 --- Ship it! Ship It! - George Joseph On June 24, 2014, 12:28

Re: [asterisk-dev] [Code Review] 3669: chan_sip: Fix handling of From headers longer than 256 characters

2014-06-24 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3669/#review12292 --- chan_sip :( /branches/1.8/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3667: Media Formats fixes for trunk branch

2014-06-24 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3667/ --- (Updated June 24, 2014, 12:37 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3667: Media Formats fixes for trunk branch

2014-06-24 Thread Corey Farrell
On June 24, 2014, 9:16 a.m., Matt Jordan wrote: /team/group/media_formats-reviewed-trunk/main/codec_builtin.c, lines 706-710 https://reviewboard.asterisk.org/r/3667/diff/2/?file=60526#file60526line706 Good catch on this. I missed that ast_codec_register creates the codec object

Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option

2014-06-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12294 --- Ship it! I'll commit the patch. - rmudgett On June 24,

Re: [asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

2014-06-24 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3649/ --- (Updated June 24, 2014, 1:06 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

2014-06-24 Thread Jonathan Rose
On June 23, 2014, 4:36 p.m., Matt Jordan wrote: /trunk/res/res_fax.c, line 4084 https://reviewboard.asterisk.org/r/3666/diff/1/?file=60383#file60383line4084 This call can fail. If it does, emit an error and bail appropriately. Jonathan Rose wrote: Problem is, there is

Re: [asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

2014-06-24 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3666/ --- (Updated June 24, 2014, 1:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

2014-06-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3649/#review12297 --- trunk/include/asterisk/bridge_channel.h

Re: [asterisk-dev] [Code Review] 3659: res_http_websocket: Dispose of websocket correctly when writes fail; use ast_careful_write to control disconnects (Asterisk 12+)

2014-06-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3659/#review12300 --- /branches/12/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

2014-06-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3649/#review12301 --- trunk/tests/test_channel_datastore_features.c

Re: [asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

2014-06-24 Thread rmudgett
On June 24, 2014, 3:41 p.m., Mark Michelson wrote: trunk/include/asterisk/bridge_features.h, line 730 https://reviewboard.asterisk.org/r/3649/diff/2/?file=60541#file60541line730 No need for this. A function with a void return obviously returns nothing :) This is a doxygenism and

Re: [asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

2014-06-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3670/#review12303 --- Ship it! Minor nit that you could ignore. :)

[asterisk-dev] [Code Review] 3671: media_formats: res_rtp_asterisk and other fixes

2014-06-24 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3671/ --- Review request for Asterisk Developers, Joshua Colp and Matt Jordan.