Re: [asterisk-dev] [Code Review] 3560: Testsuite: Add PJSIP nominal attended transfer tests

2014-06-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3560/ --- (Updated June 27, 2014, 7:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/#review12369 --- I'm not sure why this feature is necessary. Using pre-dial,

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread opticron
On June 27, 2014, 8 a.m., Matt Jordan wrote: I'm not sure why this feature is necessary. Using pre-dial, feature codes (via FEATUREMAP) can be set on either an inbound or an outbound channel prior to dialling. The fact that this channel data store is not always inherited means we

Re: [asterisk-dev] [Code Review] 3684: Bridging: Allow on-channel features to be inheritable

2014-06-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/ --- (Updated June 27, 2014, 8:06 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3675: res_pjsip: Add ActionID to events created as a result of PJSIP Actions

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3675/ --- (Updated June 27, 2014, 8:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3676: testsuite: Update PJSIP AMI tests to provide/check for the ActionID

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3676/ --- (Updated June 27, 2014, 8:51 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3682: testsuite: Add dialplan tests for While/ContinueWhile/ExitWhile and Exec/TryExec

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3682/ --- (Updated June 27, 2014, 8:59 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3653: chan_sip: (Optionally) poll even on first part of TLS message

2014-06-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3653/#review12371 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3653: chan_sip: (Optionally) poll even on first part of TLS message

2014-06-27 Thread wdoekes
On June 27, 2014, 2:42 p.m., Matt Jordan wrote: trunk/channels/chan_sip.c, line 2755 https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755 So, I had to go back and do some research to see if this solution was correct - and I think it is a step in the right

Re: [asterisk-dev] Missing Symbol export in 11.10.2 ???

2014-06-27 Thread Joshua Colp
Steve Davies wrote: Hi, Kia ora, I do run a heavily patched version, but is the export of the symbol: ast_websocket_set_timeout as a global symbol (used by chan_sip.so) missing in this version? I've checked 11.10.2 and this function doesn't exist there, which is why the export isn't

Re: [asterisk-dev] Missing Symbol export in 11.10.2 ???

2014-06-27 Thread Steve Davies
Thanks. I had cherry-picked the patch from Reviewboard # 3624 and probably missed the symbols bit somehow. Steve On 27 June 2014 17:00, Joshua Colp jc...@digium.com wrote: Steve Davies wrote: Hi, Kia ora, I do run a heavily patched version, but is the export of the symbol:

Re: [asterisk-dev] [Code Review] 3653: chan_sip: (Optionally) poll even on first part of TLS message

2014-06-27 Thread rmudgett
On June 27, 2014, 9:42 a.m., Matt Jordan wrote: trunk/channels/chan_sip.c, line 2755 https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755 So, I had to go back and do some research to see if this solution was correct - and I think it is a step in the right

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-06-27 Thread Jonathan Rose
On June 26, 2014, 6:18 p.m., Mark Michelson wrote: /trunk/pbx/pbx_config.c, lines 525-526 https://reviewboard.asterisk.org/r/3650/diff/3/?file=61090#file61090line525 I don't understand the comment about not substituting S_OR here. I would suspect that S_OR(cidmatch,

Re: [asterisk-dev] Missing Symbol export in 11.10.2 ???

2014-06-27 Thread Matthew Jordan
On Fri, Jun 27, 2014 at 11:40 AM, Steve Davies davies...@gmail.com wrote: Thanks. I had cherry-picked the patch from Reviewboard # 3624 and probably missed the symbols bit somehow. You didn't miss it; it wasn't there :-) Sean Bright caught that on the commit message, and I fixed it in

Re: [asterisk-dev] [Code Review] 3668: refcounter.py uses excessive RAM when processing large refs file

2014-06-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3668/ --- (Updated June 27, 2014, 2:14 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3668: refcounter.py uses excessive RAM when processing large refs file

2014-06-27 Thread Corey Farrell
On June 26, 2014, 11:57 a.m., wdoekes wrote: Some micro-optimization below: Thanks for teaching me this about Python! - Corey --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3677: REF_DEBUG: record an entry to refs log when we run ao2_ref against an invalid (likely already freed) ao2 pointer

2014-06-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3677/ --- (Updated June 27, 2014, 2:24 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3683: testsuite: Add a test for CELGenUserEvent

2014-06-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3683/#review12376 --- /asterisk/trunk/tests/cel/cel_gen_user_event/test-config.yaml

Re: [asterisk-dev] [Code Review] 3650: pbx_config: Add manager command equivalents to 'dialplan add extension' and 'dialplan remove extension' CLI commands

2014-06-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3650/ --- (Updated June 27, 2014, 3 p.m.) Review request for Asterisk Developers,

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.9.2-rc1 Now Available

2014-06-27 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.2-rc1 DAHDI-Tools-v2.9.2-rc1 dahdi-linux-complete-2.9.2-rc1+2.9.2-rc1 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-27 Thread rmudgett
On June 25, 2014, 6:16 p.m., Matt Jordan wrote: /branches/12/main/event.c, lines 146-167 https://reviewboard.asterisk.org/r/3601/diff/2/?file=60432#file60432line146 For the tweaks in this section that are unrelated to the accountcode changes, please commit them on a separate