Re: [asterisk-dev] [Code Review] 3679: WebRTC: Add SHA-256 support, change DTLS-SRTP negotiation, add finer grain control of things.

2014-06-30 Thread one47
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3679/#review12388 --- I do not feel qualified to add a ship-it flag, but can confirm

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12389 --- /branches/12/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

2014-06-30 Thread Michael K.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/ --- (Updated June 30, 2014, 1:26 p.m.) Review request for Asterisk

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-06-30 Thread Tilghman Lesher
On Sat, Jun 28, 2014 at 5:50 PM, Matthew Jordan mjor...@digium.com wrote: The following modules are currently deprecated in trunk. This e-mail is a proposal to remove them from trunk in preparation for Asterisk 13. All of these modules have been deprecated for at least two release cycles (the

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-06-30 Thread Walter Doekes
On 29-06-14 00:50, Matthew Jordan wrote: * app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl - deprecated in Asterisk 1.8. While less important than the other previously listed modules, having been deprecated for 2 LTS's, it is probably time for these module to go. May I also suggest

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
On June 30, 2014, 1:12 p.m., Matt Jordan wrote: /branches/12/res/res_pjsip_sdp_rtp.c, lines 541-545 https://reviewboard.asterisk.org/r/3686/diff/1/?file=61142#file61142line541 That seems like an odd setting return here. Why wouldn't this return

Re: [asterisk-dev] Proposed removal of deprecated modules in Asterisk 13 (cdr_sqlite, chan_gtalk, chan_jingle, res_jabber, chan_h323, app_readfile, app_dahdibarge, app_setcallerid, app_saycountpl)

2014-06-30 Thread Matthew Jordan
On Mon, Jun 30, 2014 at 9:24 AM, Walter Doekes walter+asterisk-...@osso.nl wrote: On 29-06-14 00:50, Matthew Jordan wrote: * app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl - deprecated in Asterisk 1.8. While less important than the other previously listed modules, having been

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 2:31 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12391 ---

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 3:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12392 --- Ship it! Ship It! - Matt Jordan On June 30, 2014, 10:20

[asterisk-dev] Regarding packet2packet bridging

2014-06-30 Thread Sameer Rathod
Dear concern, I want to configure packet2packet bridging in asterisk. How could I do this any of the tutorial or instructions will help ? I found the setting the canreinvite=yes will do the stuff but it is not working I am using asterisk 12.3 version I am very new to asterisk please help me

Re: [asterisk-dev] Regarding packet2packet bridging

2014-06-30 Thread Matthew Jordan
On Mon, Jun 30, 2014 at 12:29 PM, Sameer Rathod sam...@hostnsoft.com wrote: Dear concern, I want to configure packet2packet bridging in asterisk. How could I do this any of the tutorial or instructions will help ? I found the setting the canreinvite=yes will do the stuff but it is not

[asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/#review12393 --- I have not yet reviewed rtp_engine.c - that one will take a

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 7:47 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3679: WebRTC: Add SHA-256 support, change DTLS-SRTP negotiation, add finer grain control of things.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3679/ --- (Updated June 30, 2014, 2:42 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/ --- (Updated June 30, 2014, 2:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/ --- (Updated June 30, 2014, 3:04 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Matt Jordan
On June 30, 2014, 2:27 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/channels/chan_sip.c, lines 10088-10090 https://reviewboard.asterisk.org/r/3687/diff/1/?file=61242#file61242line10088 Why switch these to be undefined values? Compilation issue. Both the

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Corey Farrell
On June 30, 2014, 3:27 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/channels/chan_sip.c, lines 10088-10090 https://reviewboard.asterisk.org/r/3687/diff/1/?file=61242#file61242line10088 Why switch these to be undefined values? Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Matt Jordan
On June 30, 2014, 2:27 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/channels/chan_sip.c, lines 10088-10090 https://reviewboard.asterisk.org/r/3687/diff/1/?file=61242#file61242line10088 Why switch these to be undefined values? Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/ --- (Updated June 30, 2014, 5:14 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/#review12397 --- branches/12/main/causes.c

Re: [asterisk-dev] [Code Review] 3601: accountcode: Slightly change accountcode propagation.

2014-06-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3601/ --- (Updated June 30, 2014, 6:24 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/#review12398 --- branches/12/include/asterisk/causes.h

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/ --- (Updated June 30, 2014, 7:02 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3687: media format improvements: Update packetization handling; improve rtp_engine's ast_rtp_codecs handling

2014-06-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3687/#review12399 ---

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread opticron
On June 30, 2014, 5:54 p.m., Matt Jordan wrote: branches/12/main/causes.c, lines 19-24 https://reviewboard.asterisk.org/r/3690/diff/3/?file=61383#file61383line19 Since this is specific to sip, I'd place it in something that calls that out. Maybe sip_causes? I figured I'd pull

Re: [asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

2014-06-30 Thread opticron
On June 30, 2014, 6:38 p.m., Corey Farrell wrote: branches/12/res/res_pjsip_session.c, lines 1808-1810 https://reviewboard.asterisk.org/r/3690/diff/3/?file=61385#file61385line1808 What about space for the NULL terminator? The space for the null terminator is allocated in the

[asterisk-dev] [Code Review] 3691: HTTP: Add persistent connection support.

2014-06-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3691/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23552