Re: [asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3761/ --- (Updated July 13, 2014, 10:49 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3761/#review12602 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 11:49

Re: [asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3761/ --- (Updated July 13, 2014, 11:36 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3757: Fix TEST_FRAMEWORK leak in manager.c and another leak in app_skel.c

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3757/ --- (Updated July 13, 2014, 11:43 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3749: chan_dahdi.c: Restore some sanity checks on frames that dahdi_write() cannot handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3749/#review12603 --- Ship it! Ship It! - opticron On July 11, 2014, 3:22 p.m.,

Re: [asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

On July 12, 2014, 10:32 p.m., Matt Jordan wrote: I'm not sure I understand the problem for your issue description: When ast_format_cap_append was replaced with ast_format_cap_append_from_cap, the behavior of the original function was not preserved. This change introduces

Re: [asterisk-dev] [Code Review] 3760: ARI: Fix endpoint/channel subscription issues; allow for subscriptions to endpoint technologies

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3760/#review12605 --- /branches/12/res/res_xmpp.c

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12606 --- /trunk/res/res_smdi.c

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 13, 2014, 3:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3764: astobj2: fix define for ao2_t_cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3764/ --- (Updated July 13, 2014, 3:08 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12607 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 4:05

Re: [asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

On July 12, 2014, 10:32 p.m., Matt Jordan wrote: I'm not sure I understand the problem for your issue description: When ast_format_cap_append was replaced with ast_format_cap_append_from_cap, the behavior of the original function was not preserved. This change introduces

[asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24036

[asterisk-dev] [Code Review] 3769: testsuite: Add tests for copying a stored recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3769/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24036

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() We could consolidate these two functions easily;

[asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/ --- Review request for Asterisk Developers and Samuel Galarneau. Bugs:

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12612 --- /trunk/channels/dahdi/bridge_native_dahdi.c

[asterisk-dev] [Code Review] 3771: device state: Update core to report ONHOLD if channel is on hold

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3771/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24038

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

[asterisk-dev] [Code Review] 3772: media formats: Fix ref leak when copying ast_rtp_codecs

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3772/ --- Review request for Asterisk Developers, Corey Farrell and Matt Jordan.

Re: [asterisk-dev] [Code Review] 3753: media_formats: Prevent crash during masquerade

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3753/#review12614 --- Ship it!

[asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3753: media_formats: Prevent crash during masquerade

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3753/ --- (Updated July 13, 2014, 9:04 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3774: translate.c: Reduce the number of codec refs in the log when the translation matrix is rebuilt.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3774/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3774: translate.c: Reduce the number of codec refs in the log when the translation matrix is rebuilt.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3774/#review12615 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 10:13

Re: [asterisk-dev] [Code Review] 3775: translate.c: Remove dead struct ast_trans_pvt member explicit_dst.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3775/#review12616 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 10:32