---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---
(Updated July 21, 2014, 4:40 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---
(Updated July 21, 2014, 3:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/
---
(Updated July 21, 2014, 4:54 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3811/
---
(Updated July 21, 2014, 4:56 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3818/
---
(Updated July 21, 2014, 4:59 a.m.)
Review request for Asterisk
On July 16, 2014, 4:54 p.m., Kevin Harwell wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 203-212
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line203
Should be able to remove the RAII_VAR here and just return the value
from sorcery (no reason for
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 21, 2014, 12:14 p.m.)
Review request for Asterisk
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 530-568
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line530
None of this is necessary. pjsip_publishc_init() parses URIs and will
return PJSIP_EINVALIDURI if
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3831/#review12771
---
Ship it!
Ship It!
- opticron
On July 18, 2014, 7:29 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3781/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24040
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12772
---
/trunk/channels/chan_sip.c
On July 18, 2014, 3:40 p.m., Mark Michelson wrote:
/trunk/include/asterisk/res_pjsip.h, lines 1195-1203
https://reviewboard.asterisk.org/r/3817/diff/2/?file=64713#file64713line1195
This function isn't necessary. When PJSIP is passed a URI string, PJSIP
will perform URI validation
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3819/#review12774
---
Ship it!
/trunk/main/bridge_channel.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3830/#review12775
---
Ship it!
Ship It!
- Matt Jordan
On July 18, 2014, 2:15
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3760/
---
(Updated July 21, 2014, 9:48 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3830/
---
(Updated July 21, 2014, 9:49 a.m.)
Status
--
This change has been
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3760/#review12782
---
Ship it!
Ship It!
- opticron
On July 21, 2014, 9:48 a.m.,
On July 17, 2014, 9:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 71-75
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63302#file63302line71
This seems like an odd default behavior. I would suspect that by
default we would actually magic up a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3829/#review12783
---
Two points:
1) This was technically ready for review prior to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/#review12785
---
trunk/main/stasis.c
On July 16, 2014, 7:52 p.m., Corey Farrell wrote:
/trunk/main/loader.c, lines 606-607
https://reviewboard.asterisk.org/r/3777/diff/1/?file=63328#file63328line606
Not sure we want this, but if we do I think it should be ast_debug.
It will be useful when debugging ref leaks in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3777/
---
(Updated July 21, 2014, 11:58 a.m.)
Review request for Asterisk
On July 18, 2014, 10:40 a.m., Mark Michelson wrote:
/trunk/include/asterisk/res_pjsip.h, lines 1195-1203
https://reviewboard.asterisk.org/r/3817/diff/2/?file=64713#file64713line1195
This function isn't necessary. When PJSIP is passed a URI string, PJSIP
will perform URI
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12784
---
/trunk/channels/chan_sip.c
On July 18, 2014, 5:18 p.m., opticron wrote:
I gave this review a look and only found the same findings as opticron.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/
---
(Updated July 21, 2014, 12:37 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3777/#review12789
---
/trunk/main/loader.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3810/#review12790
---
/branches/12/res/res_rtp_asterisk.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3781/#review12791
---
Ship it!
/trunk/channels/sip/dialplan_functions.c
On July 17, 2014, 4:49 p.m., Mark Michelson wrote:
/trunk/res/res_pjsip_publish_asterisk.c, lines 428-430
https://reviewboard.asterisk.org/r/3780/diff/1/?file=63304#file63304line428
Is there some sort of stasis cache removal you could perform here?
Joshua Colp wrote:
So the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/#review12793
---
trunk/main/stasis_message.c
On July 21, 2014, 2:25 p.m., Mark Michelson wrote:
trunk/main/stasis_message.c, lines 84-91
https://reviewboard.asterisk.org/r/3823/diff/7/?file=64893#file64893line84
Can you describe the reason this function was made NULL-safe? Did you
encounter a situation in testing where a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/
---
(Updated July 21, 2014, 2:58 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729/#review12795
---
branches/12/res/stasis/control.c
On July 21, 2014, 12:49 p.m., Mark Michelson wrote:
/trunk/main/loader.c, lines 1001-1005
https://reviewboard.asterisk.org/r/3777/diff/2/?file=64886#file64886line1001
Feel free to cringe at this suggestion, but since you've created both
an AST_DLLIST_ENTRY and an AST_LIST_ENTRY
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3733/
---
(Updated July 21, 2014, 9:38 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/
---
(Updated July 21, 2014, 4:39 p.m.)
Review request for Asterisk Developers
The Asterisk Development Team has announced the releases of:
DAHDI-Linux-v2.9.2
DAHDI-Tools-v2.9.2
dahdi-linux-complete-2.9.2+2.9.2
This release is available for immediate download at:
http://downloads.asterisk.org/pub/telephony/dahdi-linux
http://downloads.asterisk.org/pub/telephony/dahdi-tools
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3832/
---
Review request for Asterisk Developers.
Bugs: AFS-65
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3833/
---
Review request for Asterisk Developers and Jacob Barber.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729/
---
(Updated July 21, 2014, 4:55 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3673/#review12797
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3833/#review12798
---
trunk/apps/app_voicemail.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3601/
---
(Updated July 21, 2014, 5:19 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3673/#review12799
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3813/#review12800
---
Ping for attention.
- rmudgett
On July 16, 2014, 4:37 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3813/#review12801
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 9:37
On July 21, 2014, 1:14 p.m., Mark Michelson wrote:
/trunk/channels/chan_sip.c, lines 3522-3534
https://reviewboard.asterisk.org/r/3759/diff/3/?file=64859#file64859line3522
Heh, it's a bit late for this now, but it would have probably saved you
a bunch of searching and replacing
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3834/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24087
54 matches
Mail list logo
