Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- (Updated July 22, 2014, 11:44 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

On July 21, 2014, 6:31 p.m., Mark Michelson wrote: /trunk/channels/sip/dialplan_functions.c, line 80 https://reviewboard.asterisk.org/r/3781/diff/1/?file=63311#file63311line80 There's an inline function in include/asterisk/netsock2.h called ast_sockaddr_stringify_port() that you

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3780/ --- (Updated July 22, 2014, 12:11 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/#review12804 --- /team/group/rls/res/res_pjsip_exten_state.c

[asterisk-dev] [Code Review] 3835: chan_iax2: Restore previous iax2_best_codec behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3835/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3835: chan_iax2: Restore previous iax2_best_codec behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3835/#review12805 --- Ship it! Ship It! - opticron On July 22, 2014, 8:18 a.m.,

Re: [asterisk-dev] [Code Review] 3835: chan_iax2: Restore previous iax2_best_codec behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3835/ --- (Updated July 22, 2014, 9:36 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12806 --- Ship it! Other than the two nitpicks below, this looks ready

[asterisk-dev] [Code Review] 3836: app_bridgewait: Remove race condition where bridge may be dissolved when trying to join

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3836/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23987

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/ --- (Updated July 22, 2014, 10:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3760: ARI: Fix endpoint/channel subscription issues; allow for subscriptions to endpoint technologies

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3760/ --- (Updated July 22, 2014, 11:12 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12807 --- /trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3762: testsuite: Tests for endpoint subscription (nominal + basic off-nominal)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3762/ --- (Updated July 22, 2014, 11:26 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3726: ari: Add message technology agnostic out of call text messaging

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3726/ --- (Updated July 22, 2014, 11:42 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3813: codec_speex: Fix trashing normal static frame for AST_FRAME_CNG.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3813/ --- (Updated July 22, 2014, 12:10 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3728: ARI: Add missing transfer information

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3728/#review12808 --- Ship it! Ship It! - rmudgett On July 18, 2014, 12:42 p.m.,

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/#review12809 --- team/rmudgett/stasis_linkedids/res/stasis/app.c

Re: [asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/#review12811 --- Ship it! branches/12/res/stasis/control.c

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

On July 22, 2014, 11:24 a.m., rmudgett wrote: /trunk/channels/chan_sip.c, lines 15568-15571 https://reviewboard.asterisk.org/r/3759/diff/4/?file=64989#file64989line15568 Something seems off here. The ao2_t_ref() calls return ints and are parameters to AST_SCHED_REPLACE_UNREF().

[asterisk-dev] [Code Review] 3837: app_voicemail: use consistent generator string when updating voicemail.conf

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3837/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/ --- (Updated July 22, 2014, 1:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/ --- (Updated July 22, 2014, 1:08 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/#review12813 --- Ship it! Ship It! - rmudgett On July 22, 2014, 1:08 p.m.,

Re: [asterisk-dev] [Code Review] 3832: testsuite: Accountcode propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3832/#review12810 --- /asterisk/trunk/tests/cdr/sqlite3/test-config.yaml

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/ --- (Updated July 22, 2014, 6:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/ --- (Updated July 22, 2014, 1:25 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3815/ --- (Updated July 22, 2014, 1:56 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12814 ---

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 22, 2014, 3:01 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 22, 2014, 3:02 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12815 ---

Re: [asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3820/ --- (Updated July 22, 2014, 3:01 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/#review12817 --- Ship it! Ship It! - Samuel Galarneau On July 22, 2014,

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

On July 22, 2014, 8:17 p.m., Samuel Galarneau wrote: Ship It! Tested latest patch locally successfully. - Samuel --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/#review12817

Re: [asterisk-dev] [Code Review] 3836: app_bridgewait: Remove race condition where bridge may be dissolved when trying to join

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3836/#review12816 --- /branches/12/apps/app_bridgewait.c

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 22, 2014, 3:22 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3832: testsuite: Accountcode propagation.

On July 22, 2014, 12:41 p.m., Matt Jordan wrote: /asterisk/trunk/tests/pbx/accountcode/dial_none/configs/ast1/extensions.conf, lines 7-10 https://reviewboard.asterisk.org/r/3832/diff/1/?file=64930#file64930line7 Having to wait 5 seconds for this test to end when it has

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/#review12819 ---

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/ --- (Updated July 22, 2014, 8:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/ --- (Updated July 22, 2014, 8:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/ --- (Updated July 22, 2014, 6:01 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12822 ---

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

On July 22, 2014, 5:29 p.m., Corey Farrell wrote: trunk/main/xmldoc.c, lines 2182-2188 https://reviewboard.asterisk.org/r/3812/diff/3/?file=64854#file64854line2182 This seems to break the guideline of not doing adhoc list code. If this can be fixed without much trouble please do

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/ --- (Updated July 22, 2014, 6:01 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12826 --- /trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/ --- (Updated July 22, 2014, 8:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/ --- (Updated July 22, 2014, 8:54 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3831/ --- (Updated July 22, 2014, 8:29 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/#review12828 --- Ship it! Please see that the xml_doc_item list code be fixed

Re: [asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3834/#review12829 --- Ship it! Ship It! - opticron On July 21, 2014, 10:57 p.m.,