[asterisk-dev] [Code Review] 3840: bridge: Move bridge destroy CLI command to devmode and add all to bridge kick CLI command

2014-07-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/#review12832 ---

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-23 Thread Matt Jordan
On July 17, 2014, 3:31 p.m., Matt Jordan wrote: /asterisk/trunk/lib/python/asterisk/pluggable_modules.py, lines 443-466 https://reviewboard.asterisk.org/r/3733/diff/2/?file=62566#file62566line443 I'd structure this differently: (1) First, try to get rid of your indexes.

Re: [asterisk-dev] [Code Review] 3837: app_voicemail: use consistent generator string when updating voicemail.conf

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3837/#review12834 --- Ship it! Ship It! - Matt Jordan On July 22, 2014, 1 p.m.,

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

2014-07-23 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/ --- (Updated July 23, 2014, 8:01 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3837: app_voicemail: use consistent generator string when updating voicemail.conf

2014-07-23 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3837/ --- (Updated July 23, 2014, 8:21 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3728: ARI: Add missing transfer information

2014-07-23 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3728/ --- (Updated July 23, 2014, 10:56 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

2014-07-23 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/ --- (Updated July 23, 2014, 10:57 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

2014-07-23 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/ --- (Updated July 23, 2014, 10:59 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/ --- (Updated July 23, 2014, 11:19 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-07-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3741/#review12835 --- I was checking this work against the full state test (with

[asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

2014-07-23 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/ --- Review request for Asterisk Developers and Joshua Colp. Bugs:

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-23 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/ --- (Updated July 23, 2014, 5:26 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12836 ---

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-23 Thread Jonathan Rose
On July 17, 2014, 10:48 a.m., opticron wrote: /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/rls_integrity.py, lines 57-58 https://reviewboard.asterisk.org/r/3673/diff/3/?file=62344#file62344line57 I don't think this is what you intended when attempting to

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-23 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/ --- (Updated July 23, 2014, 6:23 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

2014-07-23 Thread Tilghman Lesher
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/#review12839 --- As long as you're doing multiple statements, might it be

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12838 ---

[asterisk-dev] AstriDevCon on Oct 21st, 2014 in Las Vegas - Asterisk Developers invited!

2014-07-23 Thread Digium's Asterisk Development Team
Digium invites developers who are interested in the future of Asterisk to join us at AstriDevCon on Tuesday, October 21st, 2014. AstriDevCon is an annual event, held alongside AstriCon - it includes an in-depth review of progress made in the past year plus an open discussion about the future

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12840 ---

[asterisk-dev] [Code Review] 3843: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3843/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3799/ --- (Updated July 23, 2014, 3:10 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-23 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12841 --- http://pastebin.com/4617yxRq This has an updated diff that

Re: [asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

2014-07-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3799/ --- (Updated July 23, 2014, 3:16 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3810: res_hep_rtcp: Add module that sends RTCP information to a Homer Server

2014-07-23 Thread Matt Jordan
On July 21, 2014, 1:27 p.m., Mark Michelson wrote: /branches/12/res/res_rtp_asterisk.c, lines 2749-2751 https://reviewboard.asterisk.org/r/3810/diff/1/?file=64596#file64596line2749 ast_sockaddr_stringify uses a thread-local buffer to store the stringified address. If you call it

[asterisk-dev] [Code Review] 3844: features.c: Allow appliationmap to use Gosub.

2014-07-23 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3844/ --- Review request for Asterisk Developers. Bugs: AST-1391