Re: [asterisk-dev] [Code Review] 3844: features.c: Allow appliationmap to use Gosub.

2014-07-25 Thread Guenther Kelleter
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3844/#review12868 --- Ship it! Tested with Asterisk 11: Gosub is now working as

Re: [asterisk-dev] [Code Review] 3840: bridge: Move bridge destroy CLI command to devmode and add all to bridge kick CLI command

2014-07-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3840/ --- (Updated July 25, 2014, 5:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3836: app_bridgewait: Remove race condition where bridge may be dissolved when trying to join

2014-07-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3836/ --- (Updated July 25, 2014, 5:53 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3850: res_pjsip_session: Ensure session supplements are invoked before redirection occurs

2014-07-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3850/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3844: features.c: Allow appliationmap to use Gosub.

2014-07-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3844/#review12869 --- Ship it! /branches/1.8/apps/app_stack.c

[asterisk-dev] [Code Review] 3851: res_pjsip_pidf_body_generator / res_pjsip_xpidf_body_generator: Ensure entity is unquoted.

2014-07-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3851/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3852: Stasis App: Handle outbound masquerades

2014-07-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/ --- Review request for Asterisk Developers, Mark Michelson and rmudgett.

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-25 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated July 25, 2014, 2:19 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-25 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- Review request for Asterisk Developers. Bugs: ASTERISK-21178

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-25 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated July 25, 2014, 2:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- (Updated July 25, 2014, 9:27 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

2014-07-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/ --- (Updated July 25, 2014, 9:41 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

2014-07-25 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3856/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23767

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3802: Add module support level to module info; print module support level in CLI module show command.

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3802/ --- (Updated July 25, 2014, 11:47 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/#review12874 --- Ship it! Ship It! - Matt Jordan On July 24, 2014, 12:08

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-25 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/ --- (Updated July 25, 2014, 5:41 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-25 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3839/ --- (Updated July 25, 2014, 5:44 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread George Joseph
On July 24, 2014, 3:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3716: Weak Reference Containers

2014-07-25 Thread rmudgett
On July 24, 2014, 4:01 p.m., rmudgett wrote: You are affecting the lifetime of the continer node object without protecting it. It can now potentially be used outside the lifetime of its container as part of the held object. The container node and the continer ponter in the

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-25 Thread Tyler Austin Cambron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 25, 2014, 2:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-25 Thread Tyler Austin Cambron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 25, 2014, 2:51 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3857: Ensure that channels that move from a stasis bridge to a non-stasis bridge have a StasisEnd sent at an appropriate time.

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3857/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3857: Ensure that channels that move from a stasis bridge to a non-stasis bridge have a StasisEnd sent at an appropriate time.

2014-07-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3857/#review12879 ---

[asterisk-dev] [Code Review] 3858: Tests for verifying StopMixMonitor/MuteMixMonitor AMI action

2014-07-25 Thread Tyler Austin Cambron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3858/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24028

Re: [asterisk-dev] [Code Review] 3852: Stasis App: Handle outbound masquerades

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/#review12878 --- team/group/ari-greedy-atxfer/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 3699: RLS: Inbound SUBSCRIBE handling

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3699/ --- (Updated July 25, 2014, 8:46 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/ --- (Updated July 25, 2014, 8:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3852: Stasis App: Handle outbound masquerades

2014-07-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/ --- (Updated July 25, 2014, 4:30 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3852: Stasis App: Handle outbound masquerades

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/#review12880 --- Ship it! Minor nit.

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3741/ --- (Updated July 25, 2014, 10 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3852: Stasis App: Handle outbound masquerades

2014-07-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/ --- (Updated July 25, 2014, 5:15 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3859: datastores: Audit v1.8 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3859/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] Planned maintenance for community services on Monday, July 28, 2014

2014-07-25 Thread Digium's Asterisk Development Team
Monday, July 28, 2014, Asterisk community services will have intermittent availability due to maintenance. This maintenance will begin at approximately 9:00 PM CST[1] and should last no longer than one hour. The affected services are: * svn.digium.com * svn.asterisk.org * svncommunity.digium.com

Re: [asterisk-dev] [Code Review] 3859: datastores: Audit v1.8 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3859/ --- (Updated July 25, 2014, 5:23 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-07-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated July 25, 2014, 10:54 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3844: features.c: Allow appliationmap to use Gosub.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3844/ --- (Updated July 25, 2014, 6:04 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3860: datastores: Audit v11 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3860/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3861: datastores: Audit v12 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3861/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3860: datastores: Audit v11 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3860/ --- (Updated July 25, 2014, 9:03 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3859: datastores: Audit v1.8 ast_channel_datastore_remove usage.

2014-07-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3859/ --- (Updated July 25, 2014, 9:04 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

2014-07-25 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3862/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24126