Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-05 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/#review12979 ---

Re: [asterisk-dev] [Code Review] 3870: alembic: Adjust sippeers, queue_members, and voicemail_messages tables.

2014-08-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3870/#review12980 --- Ship it! Ship It! - Joshua Colp On Aug. 4, 2014, 9:39

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-08-05 Thread Jeremy Lainé
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3867/#review12981 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3889/#review12982 --- Can you elaborate on what actually happens here between 11-12

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-08-05 Thread Michael K.
On Aug. 5, 2014, 12:37 p.m., Jeremy Lainé wrote: trunk/channels/chan_sip.c, line 31270 https://reviewboard.asterisk.org/r/3867/diff/2/?file=66137#file66137line31270 This looks like a typo, did you mean default_dtls_cfg? yeap, gonna apply the fix - Michael

Re: [asterisk-dev] [Code Review] 3885: chan_iax2: Fix a crash caused by trying to allow all codecs on a chan_iax2 peer

2014-08-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3885/ --- (Updated Aug. 5, 2014, 8:44 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3885: chan_iax2: Fix a crash caused by trying to allow all codecs on a chan_iax2 peer

2014-08-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3885/ --- (Updated Aug. 5, 2014, 9 a.m.) Status -- This change has been marked

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12984 --- trunk/main/stasis_message.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated Aug. 5, 2014, 9:46 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12988 --- Ship it! Ship It! - Matt Jordan On Aug. 5, 2014, 9:46

[asterisk-dev] Regarding CLI Command Result

2014-08-05 Thread bala murugan
Hi , I installed asterisk 12 and when I run command connecting to CLI core show taskprocessors I see below results , not sure the processor name with Hex char what it means has anyone got the same result and if possible can explain how to interpret this results . core show taskprocessors

Re: [asterisk-dev] Regarding CLI Command Result

2014-08-05 Thread Mark Michelson
On 08/05/2014 09:56 AM, bala murugan wrote: Hi , I installed asterisk 12 and when I run command connecting to CLI core show taskprocessors I see below results , not sure the processor name with Hex char what it means has anyone got the same result and if possible can explain how to

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/#review12986 --- /team/group/rls/res/res_pjsip_exten_state.c

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/#review12990 --- /asterisk/trunk/lib/python/asterisk/ami.py

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3741/#review12991 --- /team/mmichelson/rls-notify/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread rmudgett
On Aug. 5, 2014, 8:03 a.m., Joshua Colp wrote: Can you elaborate on what actually happens here between 11-12 and 12-12 that makes it so we need to remove the newly added ones? The format compatibility bits need to remain frozen to new codecs because chan_iax2 leaks internal

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread Joshua Colp
On Aug. 5, 2014, 1:03 p.m., Joshua Colp wrote: Can you elaborate on what actually happens here between 11-12 and 12-12 that makes it so we need to remove the newly added ones? rmudgett wrote: The format compatibility bits need to remain frozen to new codecs because chan_iax2

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/#review12996 ---

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/#review12993 --- /team/group/rls/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Mark Michelson
On Aug. 5, 2014, 3:57 p.m., Matt Jordan wrote: /team/group/rls/res/res_pjsip_pubsub.c, lines 1091-1105 https://reviewboard.asterisk.org/r/3723/diff/3/?file=65309#file65309line1091 This is really more of a general question then a specific finding, however: What is the

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Joshua Colp
On Aug. 5, 2014, 5:17 p.m., Matt Jordan wrote: /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf, line 9 https://reviewboard.asterisk.org/r/3869/diff/2/?file=66140#file66140line9 This looks a little odd. Just to double check... should

Re: [asterisk-dev] [Code Review] 3889: format: Remove incorrectly assigned format compatibility bits for Opus and VP8.

2014-08-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3889/ --- (Updated Aug. 5, 2014, 12:36 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/ --- (Updated Aug. 5, 2014, 5:37 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3780/ --- (Updated Aug. 5, 2014, 5:37 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

2014-08-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3863/#review12999 --- /asterisk/trunk/tests/hep/rtcp-receiver/test-config.yaml

Re: [asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

2014-08-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3863/#review13000 --- Ship it! Other than Scott's comment about the regexes and the

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Mark Michelson
On Aug. 5, 2014, 5:21 p.m., opticron wrote: /team/group/rls/res/res_pjsip_pubsub.c, line 1427 https://reviewboard.asterisk.org/r/3723/diff/3/?file=65309#file65309line1427 It looks like it is being called recursively. Can the XXX comment be dropped or reworded? It's not being

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/ --- (Updated Aug. 5, 2014, 6:30 p.m.) Review request for Asterisk Developers.

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.10.0-rc1 Now Available

2014-08-05 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.10.0-rc1 DAHDI-Tools-v2.10.0-rc1 dahdi-linux-complete-2.10.0-rc1+2.10.0-rc1 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux

Re: [asterisk-dev] [Code Review] 3890: chan_iax2: Several media format fixes.

2014-08-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3890/ --- (Updated Aug. 5, 2014, 2:39 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/#review13005 --- /team/group/rls/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-08-05 Thread Mark Michelson
On Aug. 5, 2014, 4:14 p.m., Matt Jordan wrote: /team/mmichelson/rls-notify/res/res_pjsip_pubsub.c, lines 1548-1568 https://reviewboard.asterisk.org/r/3741/diff/2/?file=65312#file65312line1548 There's a lot of off nominal allocation failures that could occur in here. We typically

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-08-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3741/ --- (Updated Aug. 5, 2014, 8:10 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3726: ari: Add message technology agnostic out of call text messaging

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3726/ --- (Updated Aug. 5, 2014, 3:10 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Mark Michelson
On Aug. 5, 2014, 7:55 p.m., Kevin Harwell wrote: /team/group/rls/res/res_pjsip_pubsub.c, lines 1614-1625 https://reviewboard.asterisk.org/r/3723/diff/4/?file=66225#file66225line1614 I'm curious as to why the sub_tree needs a ref inc/dec here. Does it get decremented within the

Re: [asterisk-dev] [Code Review] 3723: RLS: NOTIFY generation + structural refactor

2014-08-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3723/ --- (Updated Aug. 5, 2014, 8:21 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-08-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/#review13007 --- Ship it! I like the action: stop feature. That will come in

Re: [asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

2014-08-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3863/#review13009 --- I'm getting a random number (4-6) of packets that didn't

Re: [asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

2014-08-05 Thread Scott Griepentrog
On Aug. 5, 2014, 4:11 p.m., Scott Griepentrog wrote: I'm getting a random number (4-6) of packets that didn't match. Tested with a fresh install of trunk with res_hep* enabled, and fresh patched testsuite, on a Centos 6 x86_64. Further details: Centos 6, 32 64 bit, tests rtcp-sender

Re: [asterisk-dev] [Code Review] 3884: testsuite: fail sipp test if sipp not installed

2014-08-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3884/ --- (Updated Aug. 5, 2014, 4:53 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

2014-08-05 Thread Matt Jordan
On Aug. 5, 2014, 4:11 p.m., Scott Griepentrog wrote: I'm getting a random number (4-6) of packets that didn't match. Tested with a fresh install of trunk with res_hep* enabled, and fresh patched testsuite, on a Centos 6 x86_64. Scott Griepentrog wrote: Further details: Centos

Re: [asterisk-dev] [Code Review] 3890: chan_iax2: Several media format fixes.

2014-08-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3890/ --- (Updated Aug. 5, 2014, 5:51 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3741: RLS: Add body generation + some bug fixes

2014-08-05 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3741/#review13014 --- Ship it! Minor findings for me, so going to go ahead and ship

[asterisk-dev] [Code Review] 3891: Fix Lua regression caused by me fixing ASTERISK-23818 incorrectly.

2014-08-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3891/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] Regarding CLI Command Result

2014-08-05 Thread bala murugan
thank you mark On Tue, Aug 5, 2014 at 11:56 AM, Mark Michelson mmichel...@digium.com wrote: On 08/05/2014 09:56 AM, bala murugan wrote: Hi , I installed asterisk 12 and when I run command connecting to CLI core show taskprocessors I see below results , not sure the processor name

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-05 Thread ebroad
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/ --- (Updated Aug. 5, 2014, 10:21 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3882: Replace sip_tls_read() and resolve the large SDP poll issue

2014-08-05 Thread ebroad
On Aug. 4, 2014, 1:17 p.m., Alexander Traud wrote: trunk/channels/chan_sip.c, line 3041 https://reviewboard.asterisk.org/r/3882/diff/1/?file=65918#file65918line3041 Thank you for adding me to the list of reviewers. That way, I got E-mail notifications. No no-go from my