---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/#review13016
---
trunk/channels/chan_sip.c
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote:
trunk/channels/chan_sip.c, line 3042
https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042
Because the rest of the Asterisk code does it this way:
instead of bitwiseOr |
please, a logicalOr ||
On Aug. 5, 2014, 10:58 a.m., wdoekes wrote:
http://lists.digium.com/pipermail/asterisk-commits/2014-August/069629.html
It'd be nice if the documentation got updated too...
I know it's in an illogical place, in funcs/func_channel.c, but it should
be updated nevertheless.
/w
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3781/
---
(Updated Aug. 6, 2014, 10:01 a.m.)
Review request for Asterisk
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote:
trunk/channels/chan_sip.c, line 3042
https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042
Because the rest of the Asterisk code does it this way:
instead of bitwiseOr |
please, a logicalOr ||
On Aug. 22, 2012, 8:43 a.m., nixon wrote:
I try to compile and result are...
chan_sip.c: In function ‘register_realtime_peers_with_callbackextens’:
chan_sip.c:4996: warning: implicit declaration of function ‘sip_unref_peer’
asterisk-1.8.16.0-rc1
wdoekes wrote:
nixon: This was
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/
---
(Updated Aug. 6, 2014, 7:55 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3891/#review13022
---
This isn't entirely germane to your patch, but I figured I'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3891/#review13023
---
Ship it!
Ship It!
- Matt Jordan
On Aug. 5, 2014, 7:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3883/#review13021
---
As a side note, all these IntegrityCheck classes are nearly
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3890/#review13024
---
There are numerous formatting changes that were made in this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3781/
---
(Updated Aug. 6, 2014, 10:32 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/
---
(Updated Aug. 6, 2014, 3:44 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3891/
---
(Updated Aug. 6, 2014, 11:05 a.m.)
Status
--
This change has been
On Aug. 6, 2014, 1:58 a.m., Alexander Traud wrote:
trunk/channels/chan_sip.c, line 3042
https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042
Because the rest of the Asterisk code does it this way:
instead of bitwiseOr |
please, a logicalOr ||
On Aug. 1, 2014, 5:29 p.m., Corey Farrell wrote:
/trunk/main/logger.c, line 839
https://reviewboard.asterisk.org/r/3811/diff/2/?file=66020#file66020line839
Is it appropriate / acceptable to document LogChannel in two places?
Or do the two documentation sections need to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3862/#review13028
---
Ship it!
Ship It!
- Matt Jordan
On July 31, 2014, 2:25
On Fri, Aug 1, 2014 at 5:47 PM, Corey Farrell g...@cfware.com wrote:
Hello everyone,
As part of r3811 I'm fixing build_tools/get_documentation so it picks
up every /*** DOCUMENTATION ***/ block, instead of just the first from
each file. As a side-effect this picked up some validation
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3870/
---
(Updated Aug. 6, 2014, 11:51 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13027
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13013
---
/trunk/res/res_pjsip_outbound_publish.c
On Aug. 6, 2014, 2:58 a.m., Alexander Traud wrote:
trunk/channels/chan_sip.c, line 3042
https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042
Because the rest of the Asterisk code does it this way:
instead of bitwiseOr |
please, a logicalOr ||
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/
---
(Updated Aug. 6, 2014, 2:04 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13030
---
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/
---
(Updated Aug. 6, 2014, 2:03 p.m.)
Review request for Asterisk Developers
On Aug. 6, 2014, 5:39 p.m., opticron wrote:
/trunk/res/res_pjsip_outbound_publish.c, lines 524-528
https://reviewboard.asterisk.org/r/3780/diff/7/?file=66217#file66217line524
This feels like another implementation of string fields where the
allocation is embedded in the struct.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated Aug. 6, 2014, 6:23 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13032
---
Ship it!
/trunk/res/res_pjsip_outbound_publish.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3856/
---
(Updated Aug. 6, 2014, 2:38 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/#review13035
---
Ship it!
Ship It!
- Alexander Traud
On Aug. 6, 2014, 6:04
On Aug. 6, 2014, 6:58 a.m., Alexander Traud wrote:
trunk/channels/chan_sip.c, line 3042
https://reviewboard.asterisk.org/r/3882/diff/2/?file=66262#file66262line3042
Because the rest of the Asterisk code does it this way:
instead of bitwiseOr |
please, a logicalOr ||
On Aug. 6, 2014, 6:56 p.m., Alexander Traud wrote:
Ship It!
Not sure, if I am allowed to set that flag. Anyway, because I was invited, I
think I have to.
Everything fine from my side.
(One part of the) community says thanks you for your contribution!
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/#review13037
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 6, 2014, 6:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/#review13038
---
Ship it!
Ship It!
- rmudgett
On Aug. 6, 2014, 1:04 p.m.,
On Aug. 6, 2014, 2:22 p.m., rmudgett wrote:
Ship It!
I'll commit this tomorrow if you don't have commit access.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
On Aug. 6, 2014, 3:22 p.m., rmudgett wrote:
Ship It!
rmudgett wrote:
I'll commit this tomorrow if you don't have commit access.
Thanks! I don't have commit access.
- ebroad
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3864/#review13041
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/#review13033
---
/team/group/rls/res/res_pjsip_exten_state.c
I'm not getting validation error's after the changes I've made. I was
getting validation error's from the many managerEventInstance which
were missing the class attributes. Many of those same sections that
were missing class were also not contained within a managerEvent tag.
One thing I'm
On Aug. 1, 2014, 6:29 p.m., Corey Farrell wrote:
/trunk/res/res_manager_channels.c, lines 253-261
https://reviewboard.asterisk.org/r/3811/diff/2/?file=66030#file66030line253
channel_state_change has a comment stating that Newchannel, Newstate
and Hangup events are mutually
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3890/#review13043
---
Ship it!
Ship It!
- Mark Michelson
On Aug. 5, 2014, 10:51
Tonight the Asterisk issue tracker will have intermittent availability
due to maintenance. This maintenance will begin at approximately 9:00
PM CST[1] and should last no longer than one hour.
The affected services are:
* issues.asterisk.org
Thank you for your support!
[1]:
On Aug. 6, 2014, 9 p.m., rmudgett wrote:
/team/group/rls/res/res_pjsip_pubsub.c, line 1119
https://reviewboard.asterisk.org/r/3723/diff/6/?file=66266#file66266line1119
AST_VECTOR_APPEND() can fail. child subscription leaked.
This call to AST_VECTOR_APPEND() cannot fail. The vector
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/
---
(Updated Aug. 6, 2014, 10 p.m.)
Review request for Asterisk Developers.
On Aug. 6, 2014, 9 p.m., rmudgett wrote:
/team/group/rls/res/res_pjsip_pubsub.c, line 1137
https://reviewboard.asterisk.org/r/3723/diff/6/?file=66266#file66266line1137
It might be better to remove_subscription() first before destroying the
sub_tree contents.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3723/
---
(Updated Aug. 6, 2014, 10:26 p.m.)
Review request for Asterisk
46 matches
Mail list logo
