Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13178 --- I think the addition of participants is getting to be

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-26 Thread Tzafrir Cohen
On Aug. 25, 2014, 5:53 p.m., Matt Jordan wrote: How is this different than the -l option? George Joseph wrote: Just to chip in... The -l option lists everything even though the test might not actually get run because of some constraint. I use something like the proposed dry-run

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-26 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/ --- (Updated Aug. 26, 2014, 4:50 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3949: a separate output-dir option

2014-08-26 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3949/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13179 --- Ship it! branches/1.8/main/callerid.c

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- (Updated Aug. 26, 2014, 11:35 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13181 --- branches/12/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 3932: runtests.py: -H (--hide-skipped)

2014-08-26 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3932/#review13182 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13180 --- branches/12/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread rmudgett
On Aug. 26, 2014, 3:01 p.m., opticron wrote: branches/12/apps/app_confbridge.c, line 230 https://reviewboard.asterisk.org/r/3944/diff/3/?file=66808#file66808line230 Why is this being removed? Because it doesn't do it. - rmudgett

Re: [asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/#review13184 --- Ship it! Ship It! - rmudgett On Aug. 25, 2014, 8:59 p.m.,

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- (Updated Aug. 26, 2014, 3:26 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13185 --- branches/12/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 3927: Resolve race condition in scheduler when attempting to delete a running task

2014-08-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3927/ --- (Updated Aug. 26, 2014, 5:08 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- (Updated Aug. 26, 2014, 4:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13186 --- Ship it! Ship It! - rmudgett On Aug. 26, 2014, 5:43 p.m.,

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-26 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- (Updated Aug. 26, 2014, 6:18 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3950: confbridge: Add 'Admin' parameter to join, leave, mute, unmute and talking events

2014-08-26 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk