Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/#review13229 --- Short version: not needed, IMO. The path was hard-coded in

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Shaun Ruffell
On Sept. 4, 2014, 10:49 a.m., Tzafrir Cohen wrote: Short version: not needed, IMO. The path was hard-coded in the first place because the DAHDI udev hooks directory is explicitly hard-coded. Placing it elsewhere does nothing. If the prefix is anything other than '/usr'. this hook

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-04 Thread rmudgett
On Sept. 3, 2014, 6:04 p.m., Mark Michelson wrote: /branches/13/res/res_pjsip/pjsip_options.c, lines 401-404 https://reviewboard.asterisk.org/r/3954/diff/2/?file=67194#file67194line401 I don't understand the race condition you're referring to here since the scheduler has been

[asterisk-dev] [Code Review] 3975: Menuselect: Fix incorrect enabling on failed deps

2014-09-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3975/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 3961: Testsuite: Off-nominal resource list subscription tests (Lists only, no lists of lists)

2014-09-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3961/#review13232 ---

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread David M. Lee
On Sep 3, 2014, at 7:15 PM, Oron Peled oron.pe...@xorcom.com wrote: So I don't see a way which would achieve what you want -- i.e: install as a regular user *and* with DAHDI support. OTOH, build+install of asterisk *without* DAHDI support should not have this problem (otherwise it's a bug

Re: [asterisk-dev] [Code Review] 3962: CDRs: preserve context/extension when executing a Macro or GoSub

2014-09-04 Thread Matt Jordan
On Sept. 3, 2014, 12:01 p.m., rmudgett wrote: /branches/12/main/cdr.c, lines 1352-1354 https://reviewboard.asterisk.org/r/3962/diff/1/?file=66995#file66995line1352 The comment seems wrong. Actually, I think it is still correct. If a channel has been hung up on - indicated by the

Re: [asterisk-dev] [Code Review] 3962: CDRs: preserve context/extension when executing a Macro or GoSub

2014-09-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3962/ --- (Updated Sept. 4, 2014, 11:25 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3962: CDRs: preserve context/extension when executing a Macro or GoSub

2014-09-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3962/#review13235 --- /branches/12/apps/app_stack.c

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/ --- (Updated Sept. 4, 2014, 1:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3972: Only install dahdi_span_config_hook if DAHDI is enabled

2014-09-04 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/ --- (Updated Sept. 4, 2014, 1:35 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3976/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3962: CDRs: preserve context/extension when executing a Macro or GoSub

2014-09-04 Thread Matt Jordan
On Sept. 4, 2014, 11:39 a.m., rmudgett wrote: /branches/12/apps/app_stack.c, line 255 https://reviewboard.asterisk.org/r/3962/diff/1-2/?file=66993#file66993line255 unsigned int for single bit bitfields Doh! - Matt --- This

Re: [asterisk-dev] [Code Review] 3975: Menuselect: Fix incorrect enabling on failed deps

2014-09-04 Thread opticron
On Sept. 4, 2014, 10:59 a.m., Matt Jordan wrote: trunk/menuselect.c, lines 632-642 https://reviewboard.asterisk.org/r/3975/diff/1/?file=67200#file67200line632 I'm not sure I understand why this was broken. was_defaulted simply tracks whether or not there is a

Re: [asterisk-dev] [Code Review] 3975: Menuselect: Fix incorrect enabling on failed deps

2014-09-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3975/ --- (Updated Sept. 4, 2014, 2:30 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3975: Menuselect: Fix incorrect enabling on failed deps

2014-09-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3975/ --- (Updated Sept. 4, 2014, 2:32 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3969: Manager: FullyBooted events are sent to AMI users that log in even if they don't have system level read permission.

2014-09-04 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3969/ --- (Updated Sept. 4, 2014, 2:51 p.m.) Status -- This change has been

[asterisk-dev] AstriCon Hackathon

2014-09-04 Thread Matthew Jordan
Join a worldwide community of designers, developers, and communications technologists to to create, code, and design apps built on Asterisk and other communications APIs at the inaugural AstriCon Hackathon! Obligatory yet useful information: *When*: Wednesday, October 22nd at 8AM. A reception is

Re: [asterisk-dev] [Code Review] 3962: CDRs: preserve context/extension when executing a Macro or GoSub

2014-09-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3962/ --- (Updated Sept. 4, 2014, 3:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3951: Testsuite: Nominal test for Inter-Asterisk MWI SIP publication

2014-09-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3951/#review13240 --- Ship it! I agree that we should have some docstrings, but I

[asterisk-dev] [Code Review] 3977: RLS: Pre-allocate transmission data buffer to allow for sending of large NOTIFY requests.

2014-09-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3977/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24181

Re: [asterisk-dev] AstriCon Hackathon

2014-09-04 Thread Paul Belanger
On Thu, Sep 4, 2014 at 3:54 PM, Matthew Jordan mjor...@digium.com wrote: Join a worldwide community of designers, developers, and communications technologists to to create, code, and design apps built on Asterisk and other communications APIs at the inaugural AstriCon Hackathon! Obligatory

Re: [asterisk-dev] AstriCon Hackathon

2014-09-04 Thread Paul Belanger
On Thu, Sep 4, 2014 at 4:14 PM, Paul Belanger paul.belan...@polybeacon.com wrote: On Thu, Sep 4, 2014 at 3:54 PM, Matthew Jordan mjor...@digium.com wrote: Join a worldwide community of designers, developers, and communications technologists to to create, code, and design apps built on Asterisk

Re: [asterisk-dev] [Code Review] 3977: RLS: Pre-allocate transmission data buffer to allow for sending of large NOTIFY requests.

2014-09-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3977/#review13241 --- This is a loaded question but... how much does 64k buy us?

Re: [asterisk-dev] [Code Review] 3977: RLS: Pre-allocate transmission data buffer to allow for sending of large NOTIFY requests.

2014-09-04 Thread Mark Michelson
On Sept. 4, 2014, 8:49 p.m., Matt Jordan wrote: This is a loaded question but... how much does 64k buy us? That is, how many different list elements can we typically embed in a 64k body? The list used in the test on /r/3978/ has 20 presence resources. The full state NOTIFY takes up

Re: [asterisk-dev] [Code Review] 3977: RLS: Pre-allocate transmission data buffer to allow for sending of large NOTIFY requests.

2014-09-04 Thread Mark Michelson
On Sept. 4, 2014, 8:49 p.m., Matt Jordan wrote: This is a loaded question but... how much does 64k buy us? That is, how many different list elements can we typically embed in a 64k body? Mark Michelson wrote: The list used in the test on /r/3978/ has 20 presence resources. The full

[asterisk-dev] [Code Review] 3979: Call IDs: channel Call ID appears as gibberish when shown via CLI command core show channel for a channel that doesn't have call ID set

2014-09-04 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3979/ --- Review request for Asterisk Developers. Bugs:

Re: [asterisk-dev] [Code Review] 3979: Call IDs: channel Call ID appears as gibberish when shown via CLI command core show channel for a channel that doesn't have call ID set

2014-09-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3979/#review13246 --- Ship it! Ship It! - rmudgett On Sept. 4, 2014, 6:04 p.m.,

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 4, 2014, 6:41 p.m.) Review request for Asterisk