Re: [asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

2014-10-01 Thread Kristian Høgh
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4035/ --- (Updated Oct. 1, 2014, 7 a.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4037/ --- Review request for Asterisk Developers and opticron. Bugs: ASTERISK-24378

[asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24379

Re: [asterisk-dev] [Code Review] 4031: Realtime peers are never unref: memory leaks

2014-10-01 Thread ibercom
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4031/ --- (Updated Oct. 1, 2014, 4:50 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

2014-10-01 Thread Kristian Høgh
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4035/ --- (Updated Oct. 1, 2014, 11:04 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

2014-10-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/ --- (Updated Oct. 1, 2014, 7:13 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4019: PJSIP: Handle defaults properly

2014-10-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4019/ --- (Updated Oct. 1, 2014, 7:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

2014-10-01 Thread Kristian Høgh
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4035/ --- (Updated Oct. 1, 2014, 12:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4035/#review13429 --- /trunk/apps/app_queue.c

[asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

2014-10-01 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/ --- Review request for Asterisk Developers and Joshua Colp. Bugs:

[asterisk-dev] Opinions needed: Should PJSIP support enhancements still be allowed in 12-13?

2014-10-01 Thread George Joseph
Even though I've been using pjsip on my dev and test machines for a year, it's only in the last few weeks I've tried to implement pjsip in a prod environment and that's brought up some issues. Unfortunately now that we're close to a 13 release there's some trepidation about addressing these

Re: [asterisk-dev] Opinions needed: Should PJSIP support enhancements still be allowed in 12-13?

2014-10-01 Thread Eric Wieling
From: asterisk-dev-boun...@lists.digium.com [mailto:asterisk-dev-boun...@lists.digium.com] On Behalf Of George Joseph Sent: Wednesday, October 01, 2014 1:16 PM To: asterisk-dev@lists.digium.com Subject: [asterisk-dev] Opinions needed: Should PJSIP support enhancements still be allowed in 12-13?

Re: [asterisk-dev] [Code Review] 4033: manager/config: Enhancements to support templates and non-unique category names via AMI

2014-10-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4033/#review13428 --- Ship it! My Ship it! is a cautious one. Basically, the unit

Re: [asterisk-dev] [Code Review] 4018: res_pjsip: Make transport cipher option accept a comma separated list of cipher names.

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4018/ --- (Updated Oct. 1, 2014, 1:05 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4018: res_pjsip: Make transport cipher option accept a comma separated list of cipher names.

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4018/ --- (Updated Oct. 1, 2014, 1:19 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4040: Manager: Add missing fields and documentation for CoreShowChannels

2014-10-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4040/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24262

Re: [asterisk-dev] [Code Review] 4018: res_pjsip: Make transport cipher option accept a comma separated list of cipher names.

2014-10-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4018/#review13430 --- Ship it! Ship It! - Mark Michelson On Oct. 1, 2014, 6:19

Re: [asterisk-dev] [Code Review] 4034: chan_pjsip: Fix deadlock when masquerading PJSIP channels.

2014-10-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4034/#review13431 --- Ship it! Ship It! - Mark Michelson On Sept. 30, 2014, 7:24

Re: [asterisk-dev] [Code Review] 4026: res_hep leaks reference to configuration

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4026/ --- (Updated Oct. 1, 2014, 3:30 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4041: features.c: Fix lingering channel ref while Bridge() application is active.

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4041/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24224

[asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042/ --- Review request for Asterisk Developers. Repository: Repotools

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042/#review13432 --- /Makefile.in

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
On Oct. 1, 2014, 5:04 p.m., rmudgett wrote: /Makefile.in, line 55 https://reviewboard.asterisk.org/r/4042/diff/1/?file=67816#file67816line55 It shouldn't be necessary to run configure to uninstall. Guess I hadn't really thought this one out. If you update the repository and

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042/ --- (Updated Oct. 1, 2014, 5:14 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

2014-10-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4042/#review13434 --- Ship it! Ship It! - rmudgett On Oct. 1, 2014, 4:14 p.m.,

[asterisk-dev] [Code Review] 4043: chan_motif: Release format capabilities on module load error

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4043/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24384

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 1, 2014, 6:29 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4044: sorcery: Prevent segfault in sorcery_wizard_create when there's no create virtual function

2014-10-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4044/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4017: chan_pjsip: Don't attempt to apply formats if there aren't any capabilities defined when creating a new channel

2014-10-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4017/ --- (Updated Oct. 1, 2014, 5:52 p.m.) Status -- This change has been

[asterisk-dev] PJSIP Configuration Wizard (Was: Opinions Needed: PJSIP Outboud Registration with multiple server_uris)

2014-10-01 Thread George Joseph
This is a followup to the discussion we had in this thread... Opinions Needed: PJSIP Outboud Registration with multiple server_uris http://lists.digium.com/pipermail/asterisk-dev/2014-September/070426.html I started with wanting to allow multiple server_uris in a single registration object but

[asterisk-dev] [Code Review] 4045: chan_sip: process_sdp leaks on an error path

2014-10-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4045/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24385