Re: [asterisk-dev] [Code Review] 4126: app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-30 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4126/ --- (Updated Oct. 30, 2014, 4:11 a.m.) Status -- This change has been

[asterisk-dev] Looking for Asterisk developer(s)

2014-10-30 Thread Jim Griffin
Keenly interested in locating excellent Asterisk developers/coders looking for an interesting project(s). Employee, consultant, freelance, job -- whatever works best for you. Geographic location, gender, age, race, creed, color, etc., all irrelevant. Contact: grif...@onehouse.com Thanks,

Re: [asterisk-dev] Looking for Asterisk developer(s)

2014-10-30 Thread Steven Howes
Keenly interested in locating excellent Asterisk developers/coders looking for an interesting project(s). Then try the commercial list. Steve -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com --

Re: [asterisk-dev] Looking for Asterisk developer(s)

2014-10-30 Thread Jim Griffin
All apologies! Had not intended to break a protocol, did not know, now I do. Thanks for the help ... Jim -Original Message- From: asterisk-dev-boun...@lists.digium.com [mailto:asterisk-dev-boun...@lists.digium.com] On Behalf Of Steven Howes Sent: Thursday, October 30, 2014 10:03 AM To:

[asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4118/#review13630 --- Ship it! I'd say this should go into all affected branches.

Re: [asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-30 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4118/ --- (Updated Oct. 30, 2014, 4:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

2014-10-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/ --- (Updated Oct. 30, 2014, 11:35 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- Review request for Asterisk Developers and Birger Harzenetter. Bugs:

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 11:09 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact

2014-10-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/ --- (Updated Oct. 30, 2014, 12:16 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/#review13631 --- Ship it! The test originally needed the 50 iterations to be

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13632 --- This new function could use some unit tests for nominal and

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-30 Thread Scott Griepentrog
On Oct. 29, 2014, 4:57 a.m., wdoekes wrote: /asterisk/trunk/runtests.py, line 150 https://reviewboard.asterisk.org/r/4038/diff/6/?file=68606#file68606line150 lstrip() does not do what it looks like. I thought someone fixed this everywhere already? Just checked it in... - Scott

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread opticron
On Oct. 30, 2014, 1:25 p.m., opticron wrote: branches/13/main/utils.c, line 494 https://reviewboard.asterisk.org/r/4132/diff/3/?file=68631#file68631line494 This should be instead of = due to the need to write out a null terminator along with the escaped semicolon.

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-30 Thread Paul Albrecht
On Oct 29, 2014, at 2:45 PM, Ben Klang bkl...@mojolingo.com wrote: On 10/28/2014 06:03 PM, Ben Langfeld wrote: On 28 October 2014 19:47, Derek Andrew derek.and...@usask.ca wrote: What is the alternative to the dial plan? Is everyone talking about getting rid of the statements like: exten

Re: [asterisk-dev] [asterisk-users] AstriDevCon 2014: Agenda item Deprecate AMI/AGI(Ben Klang)

2014-10-30 Thread Paul Albrecht
On Oct 29, 2014, at 4:26 PM, Matthew Jordan mjor...@digium.com wrote: On Wed, Oct 29, 2014 at 2:31 PM, Paul Albrecht palbre...@glccom.com wrote: On Oct 28, 2014, at 5:03 PM, Ben Langfeld b...@langfeld.me wrote: On 28 October 2014 19:47, Derek Andrew derek.and...@usask.ca wrote: What is

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-30 Thread Ben Klang
Il giorno Oct 30, 2014, alle ore 4:57 PM, Paul Albrecht palbre...@glccom.com ha scritto: On Oct 29, 2014, at 2:45 PM, Ben Klang bkl...@mojolingo.com mailto:bkl...@mojolingo.com wrote: On 10/28/2014 06:03 PM, Ben Langfeld wrote: On 28 October 2014 19:47, Derek Andrew

Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/#review13635 --- Add similar text to the conf.sample file as well. - Kevin

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-30 Thread Brad Watkins
On Thu, Oct 30, 2014 at 4:57 PM, Paul Albrecht palbre...@glccom.com wrote: On Oct 29, 2014, at 2:45 PM, Ben Klang bkl...@mojolingo.com wrote: On 10/28/2014 06:03 PM, Ben Langfeld wrote: On 28 October 2014 19:47, Derek Andrew derek.and...@usask.ca wrote: What is the alternative to the

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 3:35 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4129/ --- (Updated Oct. 30, 2014, 4:42 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4103: chan_pjsip: Add 'moh_passthrough' option for passing through musiconhold requests.

2014-10-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4103/#review13636 --- Ship it! Ship It! - Kevin Harwell On Oct. 22, 2014, 11:06

[asterisk-dev] [Code Review] 4134: testsute: Add 'add-relative-to-search-path' handler to TestModuleLoader

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4134/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13637 --- branches/13/main/config.c

[asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13638 --- /branches/12/main/bridge.c

[asterisk-dev] Fwd: [asterisk-commits] mjordan: testsuite/asterisk/trunk r5811 - in /asterisk/trunk/tests/fax/pjsip:...

2014-10-30 Thread Corey Farrell
I'm confused about how this can be? Unless I'm missing something a module dependency doesn't effect how the test runs, just if it runs. If chan_sip is not required then shouldn't we remove sip.conf from each of these tests config dirs? -- Forwarded message -- From: SVN commits to

[asterisk-dev] [Code Review] 4136: testsuite: Add escaped semicolons tests for UpdateConfig and dialplan save

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4136/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4124: audiohooks: Clean references to formats

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4124/ --- (Updated Oct. 30, 2014, 6:44 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4121/ --- (Updated Oct. 30, 2014, 6:49 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4125/ --- (Updated Oct. 30, 2014, 6:53 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 6:02 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22409

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/ --- (Updated Oct. 30, 2014, 8:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/#review13639 --- /branches/11/funcs/func_jitterbuffer.c

Re: [asterisk-dev] Fwd: [asterisk-commits] mjordan: testsuite/asterisk/trunk r5811 - in /asterisk/trunk/tests/fax/pjsip:...

2014-10-30 Thread Matthew Jordan
On Thu, Oct 30, 2014 at 6:36 PM, Corey Farrell g...@cfware.com wrote: I'm confused about how this can be? Unless I'm missing something a module dependency doesn't effect how the test runs, just if it runs. If chan_sip is not required then shouldn't we remove sip.conf from each of these tests

[asterisk-dev] [Code Review] 4137: res_pjsip: Add disable_tcp_switch option.

2014-10-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4137/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] func_jitterbuffer handling of masquerades

2014-10-30 Thread Corey Farrell
Hello everyone, Review 3063 [1] is posted to address audio quality failure experienced when certain masquerades occur on a channel with func_jitterbuffer active. The goal of this change is to address situations where a masquerade occurs due to Local channel optimization, and one or both of the

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
On Oct. 30, 2014, 8:32 p.m., rmudgett wrote: /branches/11/funcs/func_jitterbuffer.c, lines 309-310 https://reviewboard.asterisk.org/r/4128/diff/1/?file=68612#file68612line309 ast_frfree(frame) before dup replaces frame. This caused a segmentation fault in

[asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

2014-10-30 Thread Frankie Chin
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4093/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24274

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/ --- (Updated Oct. 30, 2014, 9:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/ --- (Updated Oct. 30, 2014, 10:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4094: Install refcounter.py to /var/lib/asterisk/scripts

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4094/ --- (Updated Oct. 30, 2014, 10:03 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4038: Testsuite: Process REF_DEBUG logs, fail any test that leaks

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/ --- (Updated Oct. 30, 2014, 10:20 p.m.) Status -- This change has been

Re: [asterisk-dev] Fwd: [asterisk-commits] mjordan: testsuite/asterisk/trunk r5811 - in /asterisk/trunk/tests/fax/pjsip:...

2014-10-30 Thread Corey Farrell
Since making the module depend on chan_pjsip, it should stop chan_sip from being loaded (since it's not a dependency anymore). Doesn't that mean we can remove sip.conf from these tests that way nobody else mistakenly thinks chan_sip is required for these tests? On Thu, Oct 30, 2014 at 8:41 PM,

[asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4138/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24476