[asterisk-dev] [Code Review] 4325: PJSIP: Prevent slow graceful shutdown when outbound publications have not started

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4325/ --- Review request for Asterisk Developers and Kevin Harwell. Bugs:

Re: [asterisk-dev] [Code Review] 4321: Testsuite: Test T.38 negotiation timeout

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4321/#review14130 --- Ship it! Ship It! - Mark Michelson On Jan. 7, 2015, 9:21

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14131 --- Ship it! Since I only have a minor issue, I'll go ahead and

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

2015-01-08 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4315/#review14134 --- Ship it! Minor finding, so going to go ahead a ship.

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- (Updated Jan. 8, 2015, 3:38 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

2015-01-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4318/ --- (Updated Jan. 8, 2015, 3:40 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 8, 2015, 3:50 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14132 --- Ship it! Ship It! - Mark Michelson On Dec. 31, 2014, 6:13

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Kevin Harwell
On Jan. 8, 2015, 3:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? pjsip_options uses sorcery_memory with regards to

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

2015-01-08 Thread Mark Michelson
On Jan. 8, 2015, 10:01 p.m., Kevin Harwell wrote: /branches/13/CHANGES, line 64 https://reviewboard.asterisk.org/r/4315/diff/2/?file=70251#file70251line64 I think you meant 1.7.0? Actually, I think it's supposed to be AMI, not ARI, and 2.7.0 is correct. - Mark

Re: [asterisk-dev] [Code Review] 4315: AMI: Make AMI actions that generate event lists consistent.

2015-01-08 Thread Kevin Harwell
On Jan. 8, 2015, 4:01 p.m., Kevin Harwell wrote: /branches/13/CHANGES, line 64 https://reviewboard.asterisk.org/r/4315/diff/2/?file=70251#file70251line64 I think you meant 1.7.0? Mark Michelson wrote: Actually, I think it's supposed to be AMI, not ARI, and 2.7.0 is correct.

Re: [asterisk-dev] [Code Review] 4272: Testsuite: Verify that bridged channels originated into Stasis and AMI Redirect interoperate properly

2015-01-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4272/ --- (Updated Jan. 8, 2015, 7:57 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4320: res_fax: Make T.38 negotiation timeout configurable and handle T.38 switch failure

2015-01-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4320/#review14122 --- Ship it! Ship It! - rmudgett On Jan. 7, 2015, 7:25 p.m.,

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2015-01-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/ --- (Updated Jan. 8, 2015, 11:49 a.m.) Status -- This change has been

Re: [asterisk-dev] CDR: log? lib?

2015-01-08 Thread Matthew Jordan
Hey Tzafrir - Sorry I didn't reply sooner. Response inline below. On Wed, Dec 31, 2014 at 3:10 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Following a bug report asking to rotate Master.csv in the asterisk package: https://bugs.debian.org/761985 Someone noted there that while those

Re: [asterisk-dev] [Code Review] 4322: app_bridge: return to next dialplan priority

2015-01-08 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4322/#review14124 --- Ship it! Ship It! - rmudgett On Jan. 7, 2015, 5:10 p.m.,

Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.

2015-01-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/#review14123 --- Ship it! Fix up the missing docstrings before you commit, but

Re: [asterisk-dev] [Code Review] 4304: res_pjsip_outbound_registration: Fix several reload issues.

2015-01-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/#review14121 --- Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 3:52

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14126 --- branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 4318: res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4318/#review14127 --- Ship it! After IRC discussions yesterday, I relented that the

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/#review14129 --- Ship it! Ship It! - Mark Michelson On Jan. 5, 2015, 11:33

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14125 --- branches/13/res/res_pjsip.c