---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4512/#review14789
---
Ship it!
I'm shipping Mark's tests, not my own.
- Joshua
On March 23, 2015, 9:45 p.m., Matt Jordan wrote:
./branches/13/apps/app_stasis.c, lines 75-79
https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line75
You'll want to document this new channel variable in the XML
documentation at the top of the file. Something
On March 23, 2015, 7:52 p.m., Matt Jordan wrote:
trunk/channels/chan_iax2.c, lines 345-347
https://reviewboard.asterisk.org/r/4483/diff/2/?file=72090#file72090line345
This lock concerns me a lot.
Because you are looking to toggle the QOS setting on the socket, you
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/#review14792
---
./branches/13/res/res_stasis.c
Dmitriy Serov wrote:
snip
The proposed decision confuses me two things:
1. There is one section of the ACL and one endpoint, which pointed to
ACL section by name. Now I remove the line with the name of ACL in the
endpoint section.
And... ACL becoming global, preventing the registration of all
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4476/
---
(Updated March 24, 2015, 12:23 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14790
---
Hi,
I've been looking into the migration path between chan_sip and chan_pjsip and
have noticed that its not possible to lookup the server a device is resisted to
within the PJSIP realtime database.
Would it be able to add this column into the 'ps_contacts' table as with the
'sippeers' in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4476/#review14782
---
/trunk/res/res_pjsip_endpoint_identifier_request_user.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4477/#review14786
---
Ship it!
Ship It!
- Joshua Colp
On March 19, 2015, 9:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4496/#review14784
---
Ship it!
Ship It!
- Joshua Colp
On March 14, 2015, 3:21
24.03.2015 3:44, Joshua Colp пишет:
Dmitriy Serov wrote:
Hello.
And Sorry for my english :)
https://issues.asterisk.org/jira/browse/ASTERISK-24890
I continue to migrate from asterisk 11 to 13.2 and continues to face
problems of compatibility.
chan_sip has a very good ability to limit
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/4
Change subject: Add a .gitignore
..
Add a .gitignore
This patch adds a .gitignore file for the testsuite, mimicking the svn:ignore
property that
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/
---
(Updated March 24, 2015, 9:53 p.m.)
Review request for Asterisk
On March 24, 2015, 5:08 p.m., rmudgett wrote:
/branches/13/main/logger.c, lines 1331-1332
https://reviewboard.asterisk.org/r/4502/diff/2/?file=72787#file72787line1331
I don't think this thread needs to be treated differently than any
other thread. The recursion check is thread
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4504/#review14822
---
/branches/13/configs/basic-pbx/extensions.conf
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4504/#review14821
---
Tested with 4488. Pretty much worked fine.
You will need to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4501/
---
(Updated March 24, 2015, 6:18 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14823
---
/trunk/configs/basic-pbx/extensions.conf
On March 24, 2015, 10:39 p.m., rnewton wrote:
/trunk/configs/basic-pbx/extensions.conf, lines 16-30
https://reviewboard.asterisk.org/r/4503/diff/1/?file=72533#file72533line16
These should move to the External-Features context and get their
extensions changed to the full DID.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 24, 2015, 6:05 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4501/#review14820
---
/branches/13/main/bridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/#review14818
---
Forgot to add that I fixed a few issues found during testing,
I noticed that recently there were some dev emails that were not handled
correctly by my mail filtering rules. They are emails in a new format from
gerrit that don't have a To: address. This looks a new setup, so is this
likely to be changed soon, or should I just change my rule to include
On March 24, 2015, 10:41 p.m., rnewton wrote:
Tested with 4488, only a few modifications made. Emailed you a diff with
the changes and external extensions.
When testing this patch with 4488 I ran through the following tests:
*patch1 - internal stuff*
internal user to internal user
On March 24, 2015, 10:32 p.m., rnewton wrote:
Tested with 4488. Pretty much worked fine.
You will need to add a timing interface to modules.conf.
res_timing_timerfd.so is probably fine.
When testing with 4488 I ran through the following tests:
*patch1 - internal stuff*
internal user
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/5
Change subject: Add a .gitreview file
..
Add a .gitreview file
This allows 'git review' to find our gerrit server and post changes for us,
along
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14825
---
Tested with 4488, only a few modifications made. Emailed you a
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/run-test, lines
18-20
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72748#file72748line18
Since the StasisStatusTestCase is located in the local test_case
Corey Farrell has posted comments on this change.
Change subject: Add a .gitignore
..
Patch Set 1: Code-Review-1
Missing all the ignores from subdirs:
addons/starpy
asttest/asttest
asttest/tools/mkstring
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4501/
---
(Updated March 24, 2015, 6:35 p.m.)
Review request for Asterisk
Russell Bryant has posted comments on this change.
Change subject: Add a .gitreview file
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/5
To unsubscribe, visit https://gerrit.asterisk.org/settings
On March 24, 2015, 8:25 a.m., Joshua Colp wrote:
/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf,
line 25
https://reviewboard.asterisk.org/r/4518/diff/3/?file=72766#file72766line25
Same for contacts when udp is wanted. The transport= isn't needed.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4476/#review14793
---
I'm not a big fan of this module for a couple of reasons:
1)
Matt Jordan has abandoned this change.
Change subject: Add a .gitreview file
..
Abandoned
--
To view, visit https://gerrit.asterisk.org/5
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: abandon
Matt Jordan has abandoned this change.
Change subject: Add a .gitignore
..
Abandoned
--
To view, visit https://gerrit.asterisk.org/4
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: abandon
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/6
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output format.
* Produce new syntax for linking to JIRA tickets.
*
On Mon, Mar 23, 2015 at 7:09 PM, Matthew Jordan mjor...@digium.com wrote:
On Mon, Mar 23, 2015 at 6:40 PM, Russell Bryant
russ...@russellbryant.net wrote:
On Mon, Mar 23, 2015 at 6:20 PM, Matthew Jordan mjor...@digium.com wrote:
[2] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
Matt Jordan has posted comments on this change.
Change subject: Add a .gitignore
..
Patch Set 1:
Unfortunately, there were some issues when the repo got made (see the -dev list
post about the authors). As such, I'm going to
On Tue, Mar 24, 2015 at 8:09 PM, Matthew Jordan mjor...@digium.com wrote:
On Mon, Mar 23, 2015 at 7:09 PM, Matthew Jordan mjor...@digium.com wrote:
On Mon, Mar 23, 2015 at 6:40 PM, Russell Bryant
russ...@russellbryant.net wrote:
On Mon, Mar 23, 2015 at 6:20 PM, Matthew Jordan
On March 25, 2015, 9:24 a.m., Corey Farrell wrote:
/trunk/main/manager.c, lines 4908-4911
https://reviewboard.asterisk.org/r/4391/diff/2/?file=72690#file72690line4908
astman_start_ack(s, m) seems to be the standard way to begin success
responses. We would send Response: Success
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/#review14801
---
branches/13/apps/app_confbridge.c
On March 24, 2015, 12:01 p.m., rmudgett wrote:
branches/13/main/bridge_channel.c, line 1575
https://reviewboard.asterisk.org/r/4510/diff/2/?file=72687#file72687line1575
Just
if (digit)
is sufficient.
If anything, you should assert:
ast_assert(0 =
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/#review14798
---
branches/13/apps/app_confbridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14795
---
Ship it!
Ship It!
- Matt Jordan
On March 24, 2015, 11:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4477/#review14797
---
Ship it!
- rmudgett
On March 19, 2015, 4:59 p.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4473/
---
(Updated March 24, 2015, 2:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/
---
(Updated March 24, 2015, 2:45 p.m.)
Status
--
This change has been
On March 24, 2015, 1:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to know
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to
On March 24, 2015, 1:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to know
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/#review14781
---
I like this change mostly as is. Since we are talking about
On March 24, 2015, 4:13 p.m., rmudgett wrote:
/branches/13/include/asterisk/utils.h, line 28
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72471#file72471line28
This can be removed as it was added for the backtrace
_ast_mem_backtrace_buffer[].
Ooops, it actually needs to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/
---
(Updated March 24, 2015, 3:30 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4498/#review14807
---
/branches/13/res/res_pjsip_outbound_registration.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14808
---
/branches/13/include/asterisk/utils.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 24, 2015, 4:31 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/#review14800
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/#review14803
---
./branches/13/apps/app_stasis.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14802
---
/branches/13/main/logger.c
One of the ways in which IAX calculates peer ping time is using
POKE/PONG/ACK sequence as follows:
- Peer1 sends POKE (frame timestamp is time of sending)
- Peer2 sends PONG with same time stamp received from POKE.
- Peer1 calculates ping time by doing: pong_reception_time - poke_send_time.
On March 24, 2015, 4:11 p.m., Kevin Harwell wrote:
/branches/13/res/res_pjsip_outbound_registration.c, line 424
https://reviewboard.asterisk.org/r/4498/diff/2/?file=72709#file72709line424
I ran the res_pjsip_outbound_registration testsuite test locally and
never received any
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4498/
---
(Updated March 24, 2015, 5:06 p.m.)
Review request for Asterisk
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users to
On March 24, 2015, 3:11 p.m., Corey Farrell wrote:
While testing res_pjsip_outbound_registration I wanted to see if a frack
would occur while unloading during registration attempts, but instead
Asterisk crashed after unloading. I believe this is due to the module
unloading, yet pjsip
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/#review14816
---
Ship it!
Ship It!
- rmudgett
On March 24, 2015, 3:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4498/#review14817
---
Ship it!
Ship It!
- Kevin Harwell
On March 24, 2015, 4:06
67 matches
Mail list logo
