On April 7, 2015, 9:55 p.m., Olle E Johansson wrote:
global is used for global variabels. Other CLI commands have show
settings - can't we reuse the same with some extra options for system?
rmudgett wrote:
Where are you getting global variables from the command?
pjsip
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4563/
---
(Updated April 8, 2015, 6:53 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4599/
---
(Updated April 8, 2015, 6:59 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/
---
(Updated April 8, 2015, 6:36 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
(Updated April 8, 2015, 6:42 a.m.)
Status
--
This change has been
On April 7, 2015, 8:15 a.m., Corey Farrell wrote:
branches/13/res/res_pjsip_config_wizard.c, lines 1189-1191
https://reviewboard.asterisk.org/r/4596/diff/1/?file=73638#file73638line1189
I'm concerned that this is needed due to the load order change. My
worry is that there might
On April 7, 2015, 6:15 a.m., Corey Farrell wrote:
branches/13/res/res_pjsip_config_wizard.c, lines 1189-1191
https://reviewboard.asterisk.org/r/4596/diff/1/?file=73638#file73638line1189
I'm concerned that this is needed due to the load order change. My
worry is that there might
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4594/#review15129
---
I have a few problems with this review:
* I don't see in this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4592/
---
(Updated April 8, 2015, 12:07 p.m.)
Status
--
This change has been
Hey all -
Since there hasn't been much feedback on the TEST-Asterisk repo that
is currently in gerrit [1] [2], I'm going to take that as a sign that
all is well and start the migration of Asterisk to Git next week.
We've already summarized some of the steps that will need to happen
for this to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15130
---
Ship it!
branches/13/CHANGES
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4600/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24841
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4598/#review15131
---
Ship it!
Ship It!
- Joshua Colp
On April 7, 2015, 5:49
Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe,
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: -Verified
Removing the Verified since there are still outstanding findings.
--
This fix is also needed for 13.
On Wed, Apr 8, 2015 at 8:02 AM, SVN commits to the Asterisk project
asterisk-comm...@lists.digium.com wrote:
Author: mjordan
Date: Wed Apr 8 07:02:37 2015
New Revision: 434294
URL: http://svnview.digium.com/svn/asterisk?view=revrev=434294
Log:
chan_iax2:
On April 7, 2015, 8:15 a.m., Corey Farrell wrote:
branches/13/res/res_pjsip_config_wizard.c, lines 1189-1191
https://reviewboard.asterisk.org/r/4596/diff/1/?file=73638#file73638line1189
I'm concerned that this is needed due to the load order change. My
worry is that there might
On Wed, Apr 8, 2015 at 7:31 AM, Corey Farrell g...@cfware.com wrote:
This fix is also needed for 13.
Yikes. Thanks for catching that.
On Wed, Apr 8, 2015 at 8:02 AM, SVN commits to the Asterisk project
asterisk-comm...@lists.digium.com wrote:
Author: mjordan
Date: Wed Apr 8 07:02:37 2015
On April 7, 2015, 8:15 a.m., Corey Farrell wrote:
branches/13/res/res_pjsip_config_wizard.c, lines 1189-1191
https://reviewboard.asterisk.org/r/4596/diff/1/?file=73638#file73638line1189
I'm concerned that this is needed due to the load order change. My
worry is that there might
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4596/#review15136
---
So this change does fix the leak I was originally concerned
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#6).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(6 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Gerrit ate this response in my previous draft. :/
Joshua Colp has uploaded a new change for review.
https://gerrit.asterisk.org/31
Change subject: pjsip: Add basic resolver tests covering A/, SRV, and NAPTR.
..
pjsip: Add basic resolver tests covering A/, SRV, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4601/
---
Review request for Asterisk Developers.
Repository: Asterisk
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Just one more finding.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#7).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Done =)
On April 8, 2015, 5:05 p.m., Mark Michelson wrote:
I have a few problems with this review:
* I don't see in this review or in the patch you uploaded to the linked
issue where ast_escape_c() or astman_escape_output() are defined.
* This patch performs a lot of heap allocations and
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+1
(2 comments)
It's looking good by me!
Greetings,
A few months ago an issue [1] was reported that when the progressinband
option found in chan_sip was set to never it was not working correctly in
some scenarios. A fix for the issue was committed [2]. However, the fix had
a side effect of changing the scope of never somewhat and since
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---
(Updated April 8, 2015, 12:52 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4590/#review15134
---
/trunk/include/asterisk/optional_api.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4490/#review15135
---
The only things I can think of that are issues here are based
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4594/
---
(Updated April 8, 2015, 5:51 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15133
---
Ship it!
Ship It!
- Joshua Colp
On April 8, 2015, 5:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4600/#review15132
---
Ship it!
Ship It!
- Joshua Colp
On April 8, 2015, 5:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4596/
---
(Updated April 8, 2015, 12:09 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4600/
---
(Updated April 8, 2015, 1:14 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 8, 2015, 1:15 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4590/
---
(Updated April 8, 2015, 2:21 p.m.)
Review request for Asterisk
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(3 comments)
Found more draft comments that gerrit obscured from me earlier =)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Ooops. I forgot to remove the chan_sip dependency from the
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#8).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: Enable support for directory containing custom tests.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/27
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4603/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24947
Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 8:
(3 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 8:
(2 comments)
Addressed both of Matt Jordan's review feedback comments.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#10).
Change subject: stasis: set a channel variable on websocket disconnect error
Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe,
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 9:
(1 comment)
Found one more tiny issue with the docstrings.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#9).
Change subject: stasis: set a channel variable on websocket disconnect error
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4604/
---
Review request for Asterisk Developers and Corey Farrell.
Repository:
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 10: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/18
To
Hello Anonymous Coward #119,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/35
to look at the new patch set (#2).
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
On April 3, 2015, 11:37 p.m., Corey Farrell wrote:
/trunk/main/manager.c, line 4873
https://reviewboard.asterisk.org/r/4391/diff/3/?file=72904#file72904line4873
If we successfully ran the command, it seems unsafe to claim failure.
We have to assume the the caller doesn't
Mark Michelson has submitted this change and it was merged.
Change subject: stasis: set a channel variable on websocket disconnect error
..
stasis: set a channel variable on websocket disconnect error
This test is to ensure
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/
---
(Updated April 9, 2015, 5:05 p.m.)
Review request for Asterisk
The Asterisk Development Team has announced security releases for Certified
Asterisk 1.8.28, 11.6, and 13.1 and Asterisk 1.8, 11, 12, and 13. The available
security releases are released as versions 1.8.28.cert-5, 1.8.32.3, 11.6-cert11,
11.17.1, 12.8.2, 13.1-cert2, and 13.3.2.
These releases are
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4522/
---
(Updated April 8, 2015, 9:04 p.m.)
Status
--
This change has been
Jared K. Smith has posted comments on this change.
Change subject: pjsip: Add basic resolver tests covering A/, SRV, and NAPTR.
..
Patch Set 1:
(10 comments)
Lots of red blobs, plus one typo
Asterisk Project Security Advisory - AST-2015-003
ProductAsterisk
SummaryTLS Certificate Common name NULL byte exploit
Nature of Advisory Man in the Middle Attack
Anonymous Coward #119 has posted comments on this change.
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
..
Patch Set 1: Verified-1
Merge Failed.
This change was unable to be automatically
On April 8, 2015, 9:40 p.m., Corey Farrell wrote:
branches/13/main/loader.c, lines 1382-1386
https://reviewboard.asterisk.org/r/4604/diff/1/?file=73808#file73808line1382
Please remove this, it's simpler to just do it in
ast_process_pending_reloads. There are a couple
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4605/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-21777 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4601/#review15139
---
Ship it!
Ship It!
- Corey Farrell
On April 8, 2015, 2:59
Anonymous Coward #119 has posted comments on this change.
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
..
Patch Set 2: Verified-1
Build failed :-( (check pipeline)
-
Matt Jordan has posted comments on this change.
Change subject: Enable support for directory containing custom tests.
..
Patch Set 1: Code-Review+2 Verified+1
In the absence of any additional comments (and it's been a little
Matt Jordan has submitted this change and it was merged.
Change subject: Enable support for directory containing custom tests.
..
Enable support for directory containing custom tests.
This change enables use of 'tests/custom/'
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4604/#review15138
---
branches/13/main/loader.c
Jared K. Smith has posted comments on this change.
Change subject: tests/rest_api/channels: Add a channel hold intercept test
..
Patch Set 4: Code-Review+1
Looks straightforward to me
--
To view, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4604/
---
(Updated April 8, 2015, 11:51 p.m.)
Review request for Asterisk
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/35
Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
..
res_phoneprov_pjsip: Disconnect HTTP before stopping
76 matches
Mail list logo
