---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3595/#review12126
---
Ship it!
- Mark Michelson
On June 11, 2014, 2:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3599/#review12128
---
Ship it!
Ship It!
- Mark Michelson
On June 9, 2014, 7:21
Hi!
It has been brought to my attention that chan_pjsip does not have an
equivalent to chan_sip's usereqphone option. However, nobody here seems
to know how useful such an option actually would be. The result is, we
have no idea if an equivalent should be made in chan_pjsip or if we
should
Hey folks,
I have just completed writing wiki pages that detail a plan for
implementing SIP resource list subscriptions in Asterisk trunk. Here are
the relevant pages:
Parent page:
https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscriptions
API Abstraction plan:
/res_pjsip.c
https://reviewboard.asterisk.org/r/3598/#comment22133
Remove this comment since it doesn't add anything and the persisted
information part of it may end up being overly narrow.
- Mark Michelson
On June 10, 2014, 2:12 p.m., Joshua Colp wrote
Developers, Matt Jordan and Mark Michelson.
Repository: testsuite
Description
---
Tests for the following behavior in PJSIPNotify action:
*PJSIPNotify sends notify messages with specified custom headers
*PJSIPNotify does not override reserved headers
*PJSIPNotify sends notify message
) both report the
member as ringing, it's a safe bet that the member actually is ringing and we
should move on.
- Mark Michelson
On June 10, 2014, 2:43 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3587/#review12100
---
Ship it!
Ship It!
- Mark Michelson
On June 6, 2014, 9:56
own function allows
both users to call the common function.
/branches/12/res/res_pjsip_pubsub.c
https://reviewboard.asterisk.org/r/3598/#comment22123
Red
- Mark Michelson
On June 6, 2014, 6:14 p.m., Joshua Colp wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3578/#review12081
---
Ship it!
Ship It!
- Mark Michelson
On June 1, 2014, 9:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3568/#review12085
---
Ship it!
Ship It!
- Mark Michelson
On June 6, 2014, 12:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3588/#review12091
---
Ship it!
Ship It!
- Mark Michelson
On June 6, 2014, 9:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3575/#review12052
---
Ship it!
Ship It!
- Mark Michelson
On May 30, 2014, 5:39
a third flag needs
to be considered.
- Mark Michelson
On June 4, 2014, 4:43 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3585
On June 5, 2014, 5:45 p.m., Mark Michelson wrote:
/branches/12/main/channel.c, lines 10156-10161
https://reviewboard.asterisk.org/r/3585/diff/1/?file=59219#file59219line10156
I reccomend re-writing this to be:
hangup_flags = ast_channel_softhangup_internal_flag(chan
On June 5, 2014, 5:45 p.m., Mark Michelson wrote:
/branches/12/include/asterisk/channel.h, line 4300
https://reviewboard.asterisk.org/r/3585/diff/1/?file=59216#file59216line4300
It's a tough thing to do, but I'd like to see this function's name
imply that channels that are being
idem.
- Mark Michelson
On June 4, 2014, 4:43 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3586
afterwards.
4) Pass vars as the second argument to push_notify()
5) Call ast_variables_destroy(vars) in the INVALID_ENDPOINT and ALLOC_ERROR
cases in the switch statement.
- Mark Michelson
On June 5, 2014, 6:19 p.m., Jonathan Rose wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3572/#review12036
---
Ship it!
Ship It!
- Mark Michelson
On May 28, 2014, 8:14
On May 28, 2014, 11:57 p.m., Paul Belanger wrote:
I'm all for adding the pjsip reload, but the context changes in the
template seem unnecessary and potentially break systems that depend on the
default config files.
Matt Jordan wrote:
Do you have an alternative to propose for
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3512/#review12002
---
Ship it!
Ship It!
- Mark Michelson
On May 8, 2014, 8:37
/talk_detect.py
https://reviewboard.asterisk.org/r/3564/#comment21941
This isn't necessary since you are not modifying FINAL_PLAYBACK
- Mark Michelson
On May 25, 2014, 4:47 a.m., Matt Jordan wrote:
---
This is an automatically generated e
On May 22, 2014, 2:12 p.m., Matt Jordan wrote:
/branches/12/channels/chan_sip.c, lines 25146-25151
https://reviewboard.asterisk.org/r/3537/diff/1/?file=58434#file58434line25146
Not a finding, just a thought for your testing.
Under the hood, ast_do_pickup will eventually
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3570/#review11980
---
Ship it!
Ship It!
- Mark Michelson
On May 27, 2014, 9:04
code.
- Mark Michelson
On May 8, 2014, 5:16 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3512
/r/3489/#comment21738
Assert that run_num 0
- Mark Michelson
On April 28, 2014, 8:18 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3489
/tones/bridges_play.py
https://reviewboard.asterisk.org/r/3428/#comment21740
Does this instance variable get used anywhere?
- Mark Michelson
On May 7, 2014, 6:58 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail
://reviewboard.asterisk.org/r/3490/diff/
Testing
---
Prior to the diff mentioned in the description, devstate_repeat and
presencestate_repeat would pass, but presencestate_repeat_okay would not. With
the diff above applied, all three tests pass.
Thanks,
Mark Michelson
to be reusable and to plug some memory leaks and
stasis subscription leaks.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3505/#review11801
---
Ship it!
Ship It!
- Mark Michelson
On April 29, 2014, 10
/#comment21640
Just remove the code instead of commenting it out.
- Mark Michelson
On April 30, 2014, 10:49 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3515
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3514/#review11807
---
Ship it!
Ship It!
- Mark Michelson
On April 30, 2014, 11
These are the exact same calls twice in a row. I assume one was supposed to
use AST_MEDIA_TYPE_VIDEO?
- Mark Michelson
On April 30, 2014, 9:22 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
Testing
---
Prior to the diff mentioned in the description, devstate_repeat and
presencestate_repeat would pass, but presencestate_repeat_okay would not. With
the diff above applied, all three tests pass.
Thanks,
Mark Michelson
I did a Google search and a common result of cannot find -lresolv is the
use of FreeBSD. Are you compiling on a FreeBSD system? My understanding of
FreeBSD is that this linker flag simply is not needed, so you may be safe
to just remove the flag from the Makefile. If that does not work for you,
/res_manager_devicestate.c PRE-CREATION
/trunk/main/presencestate.c 412583
/trunk/main/devicestate.c 412583
Diff: https://reviewboard.asterisk.org/r/3417/diff/
Testing
---
See /r/3418
Thanks,
Mark Michelson
/manager/device_state_changed/ami_device_state.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3418/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api
remove these from the sample.
./asterisk/trunk/sample-yaml/memorytestcondition-config.yaml.sample
https://reviewboard.asterisk.org/r/3476/#comment21566
The units need to be specified here (bytes? kilobytes?)
- Mark Michelson
On April 25, 2014, 8:42 p.m., Benjamin Keith Ford wrote
April 25, 2014, 10:48 p.m.)
Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
Repository: Asterisk
Description
---
If a PJSIP endpoint attempts to blind transfer to a parking extension, there
is an override to the normal transfer logic that can make
I had originally suggested.
- Mark Michelson
On April 28, 2014, 7:10 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3476/#review11775
---
Ship it!
Ship It!
- Mark Michelson
On April 28, 2014, 3:46
, but presencestate_repeat_okay would not. With
the diff above applied, all three tests pass.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
this behaves as expected. In doing so, I
realized it was nearly identical to the previous test_presence_state_change
test, so I refactored the code to be reusable and to plug some memory leaks and
stasis subscription leaks.
Thanks,
Mark Michelson
://reviewboard.asterisk.org/r/3474/#comment21501
To address a potential corner case, I would suggest expanding this to
cur-srtp ? SRTP : cur-rtp ? RTP : None
- Mark Michelson
On April 23, 2014, 7:52 p.m., Patrick Laimbock wrote
/blind_transfer/callee_hold/configs/ast1/pjsip.conf
https://reviewboard.asterisk.org/r/3444/#comment21510
The same applies to this bob_two setup.
- Mark Michelson
On April 24, 2014, 8:01 p.m., Scott Emidy wrote
/asterisk/test_conditions.py
https://reviewboard.asterisk.org/r/3476/#comment21530
Any particular reason you switched this away from raising an exception?
- Mark Michelson
On April 24, 2014, 7:02 p.m., Benjamin Keith Ford wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3444/#review11737
---
Ship it!
Ship It!
- Mark Michelson
On April 24, 2014, 10
On April 24, 2014, 10:46 p.m., Mark Michelson wrote:
./asterisk/trunk/lib/python/asterisk/memory_test_condition.py, lines 151-153
https://reviewboard.asterisk.org/r/3476/diff/1/?file=57812#file57812line151
This seems like it's not going to work properly
in milliseconds as well.
- Mark Michelson
On April 11, 2014, 8:41 a.m., Olle E Johansson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3438
://reviewboard.asterisk.org/r/3417/diff/
Testing
---
See /r/3418
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3449/#review11711
---
Ship it!
Ship It!
- Mark Michelson
On April 21, 2014, 8:21
/3466/#comment21454
s/peices/pieces/
branches/1.8/main/http.c
https://reviewboard.asterisk.org/r/3466/#comment21456
I recommend a different set of warning messages here, just so someone
trying to debug can more accurately determine what is going wrong.
- Mark Michelson
On April 18
and that the TotalContacts: header showed 2 contacts.
I could make this testsuite change permanent if desired, but since the change
was minute, I didn't feel it necessary to post a review with the change.
Thanks,
Mark Michelson
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3459/#review11695
---
Ship it!
Ship It!
- Mark Michelson
On April 17, 2014, 7:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3457/#review11696
---
Ship it!
Ship It!
- Mark Michelson
On April 17, 2014, 7:51
is much simpler and concentrates more on the functionality that is
under test. In your ami_connect method, start the options.xml scenario and then
run the AMI action.
- Mark Michelson
On April 15, 2014, 8:09 p.m., Scott Emidy wrote
it necessary to post a review with the change.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3379/#review11678
---
Ship it!
Ship It!
- Mark Michelson
On April 10, 2014, 9:59
before commit. Ship it!
/branches/1.8/channels/chan_sip.c
https://reviewboard.asterisk.org/r/3447/#comment21433
Using AST_CLI_YESNO won't work here since this has the potential to be yes,
no, or legacy.
- Mark Michelson
On April 17, 2014, 8:25 p.m., Jonathan Rose wrote
.
- Mark Michelson
On April 15, 2014, 4:52 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3447
pointed out, so I've gone
ahead and marked it with a ship it! since otherwise this is ready to go.
/trunk/include/asterisk/rtp_engine.h
https://reviewboard.asterisk.org/r/3439/#comment21376
This will need to be updated to whatever version of Asterisk this actually
gets added to.
- Mark
On April 15, 2014, 5:15 p.m., Mark Michelson wrote:
First off, I agree that anonymizing P-Asserted-Identity is not the correct
way to be going here. The concept of trust is something that is not
well-defined in chan_sip. The closest thing we currently have is the
trustrpid option
()
here.
- Mark Michelson
On March 28, 2014, 8:14 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3379
wise, I notice that the swap optimizations are the
only kind you attempt to do. Any particular reason you do not handle merge
optimizations?
- Mark Michelson
On April 9, 2014, 7:49 p.m., Joshua Colp wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3357/#review11555
---
Ship it!
Ship It!
- Mark Michelson
On March 27, 2014, 8:43
://reviewboard.asterisk.org/r/3377/#comment21319
s/menueselect/menuselect/
- Mark Michelson
On April 9, 2014, 9:08 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
the mixmonitor is destroyed.
- Mark Michelson
On April 8, 2014, 11:49 p.m., Russell Bryant wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3424
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3403/#review11563
---
Ship it!
Ship It!
- Mark Michelson
On April 9, 2014, 2:55
/include/asterisk/presencestate.h 411714
/trunk/include/asterisk/devicestate.h 411714
Diff: https://reviewboard.asterisk.org/r/3417/diff/
Testing
---
See /r/3418
Thanks,
Mark Michelson
--
_
-- Bandwidth
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3407/#review11565
---
Ship it!
Ship It!
- Mark Michelson
On April 4, 2014, 10:44
-CREATION
/asterisk/trunk/tests/rest_api/playback/tests.yaml 4836
Diff: https://reviewboard.asterisk.org/r/3339/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api
On April 5, 2014, 7:02 a.m., Olle E Johansson wrote:
I would like to see a configuration option for this, as it will generate a
massive amount of events in busy servers.
Mark Michelson wrote:
That's fair. I can think of two ways to do this:
1) The DeviceStateChange
. To reply, visit:
https://reviewboard.asterisk.org/r/3417/#review11505
---
On April 4, 2014, 7:38 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit
: https://reviewboard.asterisk.org/r/3417/diff/
Testing
---
See /r/3418
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3412/#review11501
---
Ship it!
Ship It!
- Mark Michelson
On April 3, 2014, 8:45
/3414/#comment21204
Any reason you killed the debug message that used to announce this?
- Mark Michelson
On April 3, 2014, 4:52 p.m., rmudgett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3411/#review11481
---
Ship it!
Ship It!
- Mark Michelson
On April 1, 2014, 11:41
:
Good: obj.foo(param=eggs)
Bad: obj.foo(param = eggs)
This applies to all of the originations you've modified in this file.
/asterisk/trunk/tests/masquerade/run-test
https://reviewboard.asterisk.org/r/3412/#comment21206
Just use
logger.info(cli_command.output)
- Mark
https://reviewboard.asterisk.org/r/3413/#comment21207
Since you're poking in this area, I suggest placing curly braces on these
if statements.
- Mark Michelson
On April 2, 2014, 10:02 p.m., Kevin Harwell wrote
://reviewboard.asterisk.org/r/3407/#comment21212
Same comment here as for the earlier SIPp test: The comments above the
scenarios contradict what the description states.
- Mark Michelson
On March 29, 2014, 5:59 a.m., jbigelow wrote
-config.yaml
https://reviewboard.asterisk.org/r/3403/#comment21213
Since you're using a pre-dial handler in this test, you'll need to set the
minversion to 11.0.0
Asterisk 1.8 did not have predial handlers.
- Mark Michelson
On April 1, 2014, 8 p.m., Benjamin Keith Ford wrote
/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
:
https://reviewboard.asterisk.org/r/3363/#review11365
---
On March 15, 2014, 6:34 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3414/#review11489
---
Ship it!
Ship It!
- Mark Michelson
On April 3, 2014, 4:52
though.
- Mark Michelson
On March 27, 2014, 6:06 p.m., Scott Emidy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3313
/main/sorcery.c 411188
Diff: https://reviewboard.asterisk.org/r/3401/diff/
Testing
---
This change makes the PJSIP qualify test go from crashing 1 in 5 runs to
running 120+ times with no crashes.
Thanks,
Mark Michelson
version of the
no_accept_header test.
- Mark Michelson
On March 26, 2014, 8:04 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3357
/chan_dahdi.c
https://reviewboard.asterisk.org/r/3387/#comment21043
You could use:
dahdi_tech.capabilities = ao2_cleanup(dahdi_tech.capabilities);
here instead if you wished.
- Mark Michelson
On March 25, 2014, 11:11 a.m., Joshua Colp wrote
On March 27, 2014, 7:02 p.m., Mark Michelson wrote:
/team/group/media_formats-reviewed/channels/chan_dahdi.c, lines 16557-16558
https://reviewboard.asterisk.org/r/3387/diff/1/?file=56446#file56446line16557
You could use:
dahdi_tech.capabilities = ao2_cleanup
-reviewed/channels/chan_mgcp.c
https://reviewboard.asterisk.org/r/3388/#comment21048
Hm, but on this one, you've left in the ast_format_cap_iscompatible_format
call. I'm a bit confused on why you've removed it in some places but not others.
- Mark Michelson
On March 25, 2014, 11:11 a.m., Joshua
is that the comments and the reasons for the code changes are bothering
me more than the actual code changes themselves :)
- Mark Michelson
On March 27, 2014, 6:52 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply
it!
- Mark Michelson
On March 25, 2014, 11:11 a.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3389
On March 27, 2014, 10:14 p.m., Mark Michelson wrote:
/branches/12/res/ari/resource_bridges.c, lines 323-329
https://reviewboard.asterisk.org/r/3379/diff/4/?file=56650#file56650line323
ari_bridges_play_found() calls this with the control locked, but
ari_bridges_play_new() calls
and chan_gtalk are
compiling that's good enough.
- Mark Michelson
On March 25, 2014, 11:11 a.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3390
crashing 1 in 5 runs to
running 120+ times with no crashes.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3374/#review11367
---
Ship it!
Ship It!
- Mark Michelson
On March 24, 2014, 10
411020
/branches/12/include/asterisk/res_pjsip.h 411020
Diff: https://reviewboard.asterisk.org/r/3384/diff/
Testing
---
See /r/3385
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api
/asterisk/trunk/tests/channels/pjsip/message/message_context/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3385/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation
have any automated tests to post yet because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
601 - 700 of 927 matches
Mail list logo
