Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-20 Thread Matt Jordan
be found here: https://wiki.asterisk.org/wiki/display/AST/Git+Usage While it's a bit of a pain to move the patch over, in the long run, this should make managing the clang fixup patches much easier. - Matt Jordan On April 20, 2015, 5:38 a.m., Diederik de Groot wrote

[asterisk-dev] Change in testsuite[master]: pjsip: Add basic resolver tests covering A/AAAA, SRV, and NA...

2015-04-15 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: pjsip: Add basic resolver tests covering A/, SRV, and NAPTR. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/31 To unsubscribe

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: python/asterisk/version: Update version handling for Git migration .. python/asterisk/version: Update version handling for Git migration This patch

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: python/asterisk/version: Update version handling for Git migration .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/91

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/91 Change subject: python/asterisk/version: Update version handling for Git migration .. python/asterisk/version: Update version handling for Git

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: PEP8 fixes .. PEP8 fixes * Add tox.ini for pep8 to set max-line-length=90 * Resolve most PEP8 findings in runtests.py and lib. Change-Id

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: python/asterisk/version: Update version handling for Git migration .. python/asterisk/version: Update version handling for Git migration This patch updates

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: python/asterisk/version: Update version handling for Git migration .. python/asterisk/version: Update version handling for Git migration This patch updates

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/40 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in testsuite[master]: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' var...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/41

[asterisk-dev] Change in testsuite[master]: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' var...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable .. tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

2015-04-13 Thread Matt Jordan
On April 13, 2015, 2:41 a.m., Corey Farrell wrote: So I think this looks pretty good. Next steps: * We've migrated to git. Take a look at [1] for information on how to use gerrit to post a git review. Don't worry you won't be facing the full review again, we've already dealt with

Re: [asterisk-dev] [Code Review] 4612: Command cdr show pgsql status dont work

2015-04-13 Thread Matt Jordan
Board should be moved to Gerrit: https://gerrit.asterisk.org Please see the instructions on using Gerrit here: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage - Matt Jordan On April 13, 2015, 4:23 p.m., Rodrigo Ramirez Norambuena wrote

[asterisk-dev] Change in asterisk[1.8]: Add .gitignore and .gitreview files

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/82 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[12]: Add .gitignore and .gitreview files

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/81 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[12]: main/editline: Add .gitignore.

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/83 To unsubscribe, visit https://gerrit.asterisk.org

[asterisk-dev] Change in asterisk[12]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/85 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[1.8]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/86 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[1.8]: main/editline: Add .gitignore.

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/84 To unsubscribe, visit https://gerrit.asterisk.org

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/60/2/main/asterisk.c File main/asterisk.c: Line 539

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

2015-04-13 Thread Matt Jordan (Code Review)
: newpatchset Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28 Gerrit-PatchSet: 3 Gerrit-Project: asterisk Gerrit-Branch: 13 Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in asterisk[master]: Optional API: Fix handling of sources that are both provider...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Optional API: Fix handling of sources that are both provider and user. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/73

[asterisk-dev] Change in asterisk[13]: res_monitor: Add dependency on func_periodic_hook.

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: res_monitor: Add dependency on func_periodic_hook. .. Patch Set 1: Code-Review+1 Unfortunate, but apparently necessary. -- To view, visit https

[asterisk-dev] Change in asterisk[master]: AMI: Fix improper handling of lines that are exactly 1025 by...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: AMI: Fix improper handling of lines that are exactly 1025 bytes long. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/74

[asterisk-dev] Change in asterisk[11]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git migration External

[asterisk-dev] Change in asterisk[11]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/77

[asterisk-dev] Change in asterisk[1.8]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git migration External

[asterisk-dev] Change in asterisk[13]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/79

[asterisk-dev] Change in asterisk[12]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/78

[asterisk-dev] Change in asterisk[12]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git migration External

[asterisk-dev] Change in asterisk[master]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.asterisk.org/80

[asterisk-dev] Change in asterisk[1.8]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/76

[asterisk-dev] Change in asterisk[13]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git migration External

[asterisk-dev] Change in asterisk[master]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git migration External

[asterisk-dev] Change in asterisk[1.8]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/76 Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git

[asterisk-dev] Change in asterisk[13]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/79 Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git

[asterisk-dev] Change in asterisk[12]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/78 Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git

[asterisk-dev] Change in asterisk[11]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/77 Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git

[asterisk-dev] Change in asterisk[master]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/80 Change subject: build_tools/make_version: Update version parsing for Git migration .. build_tools/make_version: Update version parsing for Git

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line 390

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c File cel/cel_radius.c

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 3 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
: newpatchset Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28 Gerrit-PatchSet: 2 Gerrit-Project: asterisk Gerrit-Branch: 13 Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the ability to replace a token

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 2 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support the ability to replace a token

[asterisk-dev] Change in repotools[master]: mapmantis: Remove dependency on digium_jira

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: mapmantis: Remove dependency on digium_jira .. mapmantis: Remove dependency on digium_jira This patch removes the dependency of mapmantis from the digium_jira

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Gerrit-PatchSet: 5 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com -- _ -- Bandwidth

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/59 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has abandoned this change. Change subject: git migration: Remove support for file versions .. Abandoned -- To view, visit https://gerrit.asterisk.org/59 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/55 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz extension

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Gerrit-PatchSet: 4 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com -- _ -- Bandwidth

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: (3 comments) https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h File include

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has abandoned this change. Change subject: git migration: Remove support for file versions .. Abandoned Blech. This patch kind of got messed up in the process of trying to put up the Asterisk 13 version. I'm going

[asterisk-dev] Change in asterisk[13]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/60 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support

[asterisk-dev] Change in asterisk[master]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/67 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
: I2b7513fc9acf5d432cf9587c25faa9786af14abf Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: 11 Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/57 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/66 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/40 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/63 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz extension

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/62 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/66 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/65 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit https://gerrit.asterisk.org

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/64 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit https://gerrit.asterisk.org

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz extension

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/61 Change subject: git migration: Remove support for file versions .. git migration: Remove support for file versions Git does not support

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/63 Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-12 Thread Matt Jordan (Code Review)
: I4c8af3b8e3739957db545f7368ac53f38e99f696 Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: 13 Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] Change in repotools[master]: mapmantis: Remove dependency on digium_jira

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/68 Change subject: mapmantis: Remove dependency on digium_jira .. mapmantis: Remove dependency on digium_jira This patch removes the dependency

[asterisk-dev] Change in repotools[master]: digium_jira: Refactor module to wrap the Atlassian JIRA REST...

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/69 Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST client .. digium_jira: Refactor module to wrap the Atlassian JIRA

[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

2015-04-12 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Remove support for file versions .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line 390

[asterisk-dev] Change in asterisk[master]: sounds: Add a .gitignore file for downloaded sound tarballs

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/55 Change subject: sounds: Add a .gitignore file for downloaded sound tarballs .. sounds: Add a .gitignore file for downloaded sound tarballs

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

2015-04-11 Thread Matt Jordan (Code Review)
-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit https

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Note for reviewers: This patch will break ABI, and can't be backported as-is. Once

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (2 comments) https://gerrit.asterisk.org/#/c/42/2/.gitignore File .gitignore: Line 21: addons/mp3 I

Re: [asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

2015-04-10 Thread Matt Jordan
On April 10, 2015, 9:50 a.m., Matt Jordan wrote: I'm going to go ahead and post this for review on Gerrit (gerrit.asterisk.org) - particularly since the 'findings' were very minor. That will allow us to go ahead and commit the patch for the auto-dtmf mode ahead of the move to Git

Re: [asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

2015-04-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4609/#review15183 --- Reviewed: I didn't have any findings. - Matt Jordan

Re: [asterisk-dev] [Code Review] 4588: IAX make calltoken expiration time configurable

2015-04-09 Thread Matt Jordan
file, this looks good to go. Since that's relatively minor, I'll Ship It. - Matt Jordan On April 9, 2015, 9:21 a.m., Y Ateya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

[asterisk-dev] Change in testsuite[master]: Testsuite: Caller callee initiated local attended transfer...

2015-04-09 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Testsuite: Caller callee initiated local attended transfers to application. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/34

[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

2015-04-09 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/35 To unsubscribe

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

2015-04-09 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/36 Change subject: rest_api/applications/stasisstatus: Make run-test executable .. rest_api/applications/stasisstatus: Make run-test executable

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

2015-04-09 Thread Matt Jordan
On April 3, 2015, 5:37 a.m., Corey Farrell wrote: /trunk/main/manager.c, line 4873 https://reviewboard.asterisk.org/r/4391/diff/3/?file=72904#file72904line4873 If we successfully ran the command, it seems unsafe to claim failure. We have to assume the the caller doesn't actually

Re: [asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

2015-04-09 Thread Matt Jordan
/4604/#comment25803 Nitpick #1: Since this is static, there's no real reason to assign 0 to it. Nitpick #2: Even though this one is clear, doxygen comments for globals is always nice. - Matt Jordan On April 9, 2015, 12:51 a.m., George Joseph wrote

[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

2015-04-09 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk. .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/35/2/tests/phoneprov

[asterisk-dev] Change in testsuite[master]: Testsuite: Caller callee initiated local attended transfer...

2015-04-09 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Testsuite: Caller callee initiated local attended transfers to application. .. Patch Set 1: (7 comments) https://gerrit.asterisk.org/#/c/34/1//COMMIT_MSG

  1   2   3   4   5   6   7   8   9   10   >