Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Russell Bryant
On Mon, Jun 8, 2015 at 9:57 AM, Leif Madsen leif.mad...@avoxi.com wrote: On Mon, Jun 8, 2015 at 9:35 AM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Jun 2, 2015 at 8:05 PM, Matthew Jordan mjor...@digium.com wrote: Personally, I'd like some way to present any user of Asterisk

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Russell Bryant
absolute numbers measure. A survey could still produce useful relative numbers and help identify some trends over time. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Russell Bryant
, you'll get fewer servers reporting data but it's the much friendlier thing to with respect to privacy. +1. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] Team branches and gerrit

2015-04-27 Thread Russell Bryant
On Mon, Apr 27, 2015 at 8:20 AM, Olle E. Johansson o...@edvina.net wrote: On 24 Apr 2015, at 15:42, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's wiki page

Re: [asterisk-dev] Team branches and gerrit

2015-04-24 Thread Russell Bryant
warrants further changes they also need to be squashed back into a single commit with the original changes. The single commit you post for review is what is reviewed and merged into the branch. Gerrit can also work on a patch series, and tracks dependencies between those patches. -- Russell

Re: [asterisk-dev] Team branches and gerrit

2015-04-24 Thread Russell Bryant
On Fri, Apr 24, 2015 at 12:17 PM, Matthew Jordan mjor...@digium.com wrote: On Fri, Apr 24, 2015 at 8:42 AM, Russell Bryant russ...@russellbryant.net wrote: On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: Playing around following Matt's

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-16 Thread Russell Bryant
. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Asterisk 1.8/12 build system changes

2015-04-14 Thread Russell Bryant
very different from a source management perspective, the actual release deliverable shouldn't look any different. menuselect is in the tarball just like it was before. Or am I missing something? -- Russell Bryant

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Russell Bryant
reviews, when patches are updated, when patches merge, or when people make comments (all optionally on a per repository basis). So, another option would be to drop sending to the list completely and let people configure their own notifications that suit their needs and interests. -- Russell

Re: [asterisk-dev] Git Migration update

2015-04-14 Thread Russell Bryant
-- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Russell Bryant
On Tue, Apr 14, 2015 at 10:55 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 9:43 AM, Dan Jenkins dan.jenkin...@gmail.com wrote: On Tue, Apr 14, 2015 at 3:18 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Apr 14, 2015 at 8:47 AM, Matthew Jordan

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/42/2/.gitignore File .gitignore: Line 21: addons/mp3 I

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/42/2//COMMIT_MSG Commit Message: Line 15: Tested-by: George

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit https

Re: [asterisk-dev] Asterisk to Git Migration Update

2015-03-31 Thread Russell Bryant
removing it is another option. Anyway, the goal is to kick off the move of Asterisk to Git immediately after we get the next batch of releases out. I'll send out an e-mail once we know exactly when that is. \o/ -- Russell Bryant

[asterisk-dev] Change in testsuite[master]: Add .gitignore files

2015-03-25 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore files .. Patch Set 1: Code-Review+1 looks sane -- To view, visit https://gerrit.asterisk.org/8 To unsubscribe, visit https

[asterisk-dev] Change in testsuite[master]: Add a .gitreview file for the testsuite

2015-03-25 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add a .gitreview file for the testsuite .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.asterisk.org/#/c/7/1/.gitreview File .gitreview: Line 5

[asterisk-dev] Change in testsuite[master]: Add a .gitreview file

2015-03-24 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add a .gitreview file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/5 To unsubscribe, visit https://gerrit.asterisk.org/settings

Re: [asterisk-dev] Asterisk Testsuite: Moving to Git

2015-03-23 Thread Russell Bryant
a .gitreview file added [1]. [1] https://gerrit.asterisk.org/#/c/3 -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] Change in repotools[master]: Add .gitreview file

2015-03-22 Thread Russell Bryant (Code Review)
Russell Bryant has uploaded a new change for review. https://gerrit.asterisk.org/3 Change subject: Add .gitreview file .. Add .gitreview file This file tells 'git review' how to contact the gerrit server. Change-Id

[asterisk-dev] Change in repotools[master]: .gitignore: Add a .gitignore file that mirrors the previous ...

2015-03-21 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: .gitignore: Add a .gitignore file that mirrors the previous svn:ignore .. Patch Set 2: You can create .gitignore files in subdirectories instead of listing

Re: [asterisk-dev] How to catch the source of a deadlock?

2015-01-27 Thread Russell Bryant
compile time option and the core show locks CLI command? https://wiki.asterisk.org/wiki/display/AST/CLI+commands+useful+for+debugging -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] git migration update

2014-12-24 Thread Russell Bryant
a different model. I don't see why anyone would use them for day-to-day work like team branches have been used in the past. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] git migration update

2014-12-22 Thread Russell Bryant
. Let users make their own arrangements be it GitHub or in my case, my own GIT infrastructure. +1. I don't think it makes sense with git. github or whatever should work just fine for that purpose. -- Russell Bryant

Re: [asterisk-dev] AstriDevCon 2014: Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-28 Thread Russell Bryant
be architected in my view. Well done, dev community. Keep kicking ass. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] Asterisk 11.9.0 Segmentation fault.

2014-10-21 Thread Russell Bryant
) and not in Asterisk itself. 2) Based on this backtrace, it shows chan_sip calling into this client library, which doesn't exist in Asterisk code, so it could be a problem specific to modifications made in your version. -- Russell Bryant -- Russell Bryant

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Russell Bryant
was designed in such a way that people could run it against their own deployment to do some validation, but quite far from how it actually works. So, what use cases are you aiming to allow exactly? -- Russell Bryant -- _ -- Bandwidth

Re: [asterisk-dev] License issue

2014-10-13 Thread Russell Bryant
scratch or if I can use this code and still submit it at some point... Trying to get hold of the original author, but no reply so far. It should be fine. Users have never been able to use reviewboard without an active contributor license agreement. (AFAIK) -- Russell Bryant

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Russell Bryant
On Mon, Oct 13, 2014 at 9:44 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Hi I finally got the asterisk-testsuite accpted

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Russell Bryant
On Thu, Sep 18, 2014 at 12:29 PM, Russell Bryant russ...@russellbryant.net wrote: On Thu, Sep 18, 2014 at 11:31 AM, Samuel Galarneau sgalarn...@digium.com wrote: On Tue, Sep 16, 2014 at 5:01 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 3:48 PM, Matthew

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Russell Bryant
this is going to be MUCH better no matter what specific infrastructure you go with. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] Git Migration

2014-09-17 Thread Russell Bryant
On Tue, Sep 16, 2014 at 10:52 PM, Matthew Jordan mjor...@digium.com wrote: On Tue, Sep 16, 2014 at 5:01 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 3:48 PM, Matthew Jordan mjor...@digium.com wrote: So, to set what I hope are a few guidelines: (1) I know

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
page (http://status.openstack.org/zuul/), it has been launching about 500-600 jobs per hour today. -- Process Recommendation I discussed this a good bit above, but I'm happy to answer questions. -- Russell Bryant

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: From a high level, all patches go to a code review system. *Every* patch must be peer reviewed (usually by 2 people, but that's a policy decision). *Every* patch must also pass tests. Once a patch passes both

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
On Tue, Sep 16, 2014 at 6:12 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: From a high level, all patches go to a code review system. *Every* patch must be peer reviewed (usually by 2 people, but that's

Re: [asterisk-dev] Asterisk Beginner learning about Channels

2014-08-28 Thread Russell Bryant
used. chan_iax2 has to do it that way as all data for *every* call is arriving on the same UDP socket, so it can't put that one socket fd on every channel. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3952: Add 'rtpbindaddr' setting for chan_sip

2014-08-27 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3952/#review13195 --- Ship it! looks sane to me - Russell Bryant On Aug. 27

Re: [asterisk-dev] Does asterisk video frame contains video data only or there is RTP headers too ?

2014-08-25 Thread Russell Bryant
to another buffer for every frame you're sending. Good luck with your work! -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] loader.c in asterisk 1.8.15-cert5

2014-08-13 Thread Russell Bryant
on the problem you're having? Without more detail, nobody will be able to help you. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Bounty] Stasis bug/finishing implementation - $1, 000

2014-07-17 Thread Russell Bryant
Heh, but you just posted your own patch. Are you still interested in help here? -- Russell Bryant On Wed, Jul 16, 2014 at 11:23 PM, Krandon krandon.br...@gmail.com wrote: Up'ing bounty to $1,000 -- KB On Wednesday, July 16, 2014 at 5:56 AM, Krandon wrote: ARI /continue fails

Re: [asterisk-dev] [Code Review] 3424: (mix)monitor: Add options to enable a periodic beep

2014-04-14 Thread Russell Bryant
)) same = n,StartMusicOnHold() same = n,Wait(15) same = n,StopMusicOnHold() same = n,StopMixMonitor() same = n,Wait(5) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-11 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3424/#review11562 --- On April 8, 2014, 7:49 p.m., Russell Bryant wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-11 Thread Russell Bryant
= n,StopMixMonitor() same = n,Wait(5) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-11 Thread Russell Bryant
to bump the module refcount for func_periodic_hook.so so that the module cannot be unloaded while there is an active mixmonitor. You can decrement the module refcount when the mixmonitor is destroyed. Russell Bryant wrote: I started looking at this, but I'm not sure the alternative is better

Re: [asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-10 Thread Russell Bryant
an argument, and that's a pain to do when not using this helper, so start by doing this conversion. Diffs - /trunk/res/res_monitor.c 412023 Diff: https://reviewboard.asterisk.org/r/3429/diff/ Testing --- Thanks, Russell Bryant

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-10 Thread Russell Bryant
--- On April 8, 2014, 7:49 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3424

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-09 Thread Russell Bryant
--- On April 8, 2014, 7:49 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3424

Re: [asterisk-dev] [Code Review] 3423: Internal timing: Add notice message about the -I and internal_timing option no longer needed.

2014-04-08 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3423/#review11511 --- Ship it! lgtm - Russell Bryant On April 8, 2014, 12:03 a.m

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-08 Thread Russell Bryant
module. - Russell --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3424/#review11515 --- On April 8, 2014, 1:28 a.m., Russell Bryant

Re: [asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-08 Thread Russell Bryant
= n,Wait(5) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-04-08 Thread Russell Bryant
--- Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2684: Fix exposure of template-only config sections

2014-04-08 Thread Russell Bryant
ast_category_delete() if (cat-name == category) { from ast_variable_browse() if (config-last_browse (config-last_browse-name == category)) { etc. Diffs - /trunk/main/config.c 394685 Diff: https://reviewboard.asterisk.org/r/2684/diff/ Testing --- Thanks, Russell

Re: [asterisk-dev] [Code Review] 2684: Fix exposure of template-only config sections

2014-04-08 Thread Russell Bryant
for now - Russell --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2684/#review9325 --- On July 18, 2013, 9:44 a.m., Russell Bryant wrote

Re: [asterisk-dev] [Code Review] 3426: Fix build failure on SmartOS / Illumos / SunOS

2014-04-08 Thread Russell Bryant
On April 8, 2014, 6:31 p.m., Tzafrir Cohen wrote: I know I really shouldn't be writing this, as I added one of the defined() in that line, but: shouldn't this test be done in autoconf? Ideally, yes, but seems like a reasonable improvement that could be made later, beyond the scope of

Re: [asterisk-dev] [Code Review] 3426: Fix build failure on SmartOS / Illumos / SunOS

2014-04-08 Thread Russell Bryant
platforms - Russell Bryant On April 8, 2014, 3:31 p.m., Sebastian Wiedenroth wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3426

[asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-08 Thread Russell Bryant
412023 Diff: https://reviewboard.asterisk.org/r/3429/diff/ Testing --- Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

2014-04-07 Thread Russell Bryant
() exten = 105,1,Answer() same = n,MixMonitor(test.gsm,B(3)) same = n,StartMusicOnHold() same = n,Wait(15) same = n,StopMusicOnHold() same = n,StopMixMonitor() same = n,Wait(5) same = n,Hangup() Thanks, Russell Bryant

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-05 Thread Russell Bryant
) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=off) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [svn-commits] rmudgett: branch 1.8 r411715 - in /branches/1.8: ./ channels/ configs/ includ...

2014-04-05 Thread Russell Bryant
it off. The change to make it the only way it works is really the right thing to do. It was equivalent to an option called make_things_work_properly=yes. -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-04 Thread Russell Bryant
) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-03 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11476 --- On April 1, 2014, 4:43 p.m., Russell Bryant wrote

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-03 Thread Russell Bryant
,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] Asterisk Test Suite Git Migration

2014-04-02 Thread Russell Bryant
welcome and more information to come once we begin the actual migration. +1! :-) -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-04-01 Thread Russell Bryant
= n,Set(PERIODIC_HOOK(${BEEP_ID})=off) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
/#review11441 --- On March 29, 2014, 8:27 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
being created or re-enabled. Unless this behaviour is documented I would expect the first run after create or resume to be delayed state-interval seconds. Russell Bryant wrote: Fair. I had originally intended for it to run immediately, but I think it makes more sense to delay

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=off) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3362/#review11455 --- On March 31, 2014, 4:11 p.m., Russell Bryant wrote

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
)}) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=off) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-31 Thread Russell Bryant
On March 31, 2014, 5:58 p.m., Corey Farrell wrote: /trunk/funcs/func_periodic_hook.c, lines 141-143 https://reviewboard.asterisk.org/r/3362/diff/6/?file=56951#file56951line141 Macro is deprecated, why not use Gosub? Russell Bryant wrote: I tried that. GoSub() doesn't

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-29 Thread Russell Bryant
() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-29 Thread Russell Bryant
] exten = 100,1,Answer() same = n,Set(BEEP_ID=${PERIODIC_HOOK(hooks,beep,5)}) same = n,Wait(20) same = n,Set(PERIODIC_HOOK(${BEEP_ID})=off) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant

Re: [asterisk-dev] [Code Review] 3362: func_periodic_hook: New function for periodic hooks.

2014-03-29 Thread Russell Bryant
(PERIODIC_HOOK(${BEEP_ID})=on) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] g722 package for extras sounds went missing

2014-03-25 Thread Russell Bryant
/ -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Alembic in 12 SVN

2014-03-18 Thread Russell Bryant
something like the existing validate-docs Makefile target that only runs if dev mode is on. Add a validate-linear-migrations target that runs in dev mode or something like that. -- Russell Bryant -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] Alembic in 12 SVN

2014-03-18 Thread Russell Bryant
On Tue, Mar 18, 2014 at 10:07 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Mar 18, 2014 at 8:31 AM, Russell Bryant russ...@russellbryant.net wrote: On Mon, Mar 17, 2014 at 1:01 PM, Joshua Colp jc...@digium.com wrote: Matthew Jordan wrote: snip Technically, it's

[asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Russell Bryant
,Answer() same = n,Set(BEEP(5)=on) same = n,Wait(20) same = n,Set(BEEP()=off) same = n,Wait(20) same = n,Hangup() Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3362: func_beep: New function for periodic beeps.

2014-03-15 Thread Russell Bryant
every 30 seconds exten = foo,1,Set(PERIODIC_HOOK(30,beep@dialplan_hooks) Does that sound better than the current BEEP()? - Russell Bryant On March 15, 2014, 6:15 p.m., Russell Bryant wrote: --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-06 Thread Russell Bryant
. Diffs - /branches/11/res/res_musiconhold.c 409286 Diff: https://reviewboard.asterisk.org/r/3282/diff/ Testing --- Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-05 Thread Russell Bryant
no bridged instance, but this seems like a pretty safe function input sanity check. Diffs - /tags/1.8.18.1/res/res_rtp_asterisk.c 405155 Diff: https://reviewboard.asterisk.org/r/3300/diff/ Testing --- Thanks, Russell Bryant

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-03 Thread Russell Bryant
://reviewboard.asterisk.org/r/3282/#review11024 --- On March 2, 2014, 8:45 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-03 Thread Russell Bryant
- Russell --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3282/#review11020 --- On March 2, 2014, 8:45 p.m., Russell Bryant wrote

[asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

2014-03-02 Thread Russell Bryant
/r/3282/diff/ Testing --- Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3279: Iterate through logger.conf [general] section

2014-02-28 Thread Russell Bryant
On Feb. 28, 2014, 12:51 p.m., Matt Jordan wrote: I'm not sure I understand the need for this patch. Setting a configuration option twice - when that option doesn't support being set multiple times - would generally have undefined behaviour. Your patch changes it so that Asterisk

[asterisk-dev] [Code Review] 3159: Allow nested #includes in extconfig.conf

2014-01-27 Thread Russell Bryant
/ Testing --- Created some nested includes in extconfig.conf. Confirmed error before the patch and loading fine afterwards. Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

2014-01-26 Thread Russell Bryant
that. It at least doesn't blow up immediately ... I wanted to get the patch and analysis up to get some more eyes on it. Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3148: res_pjsip: Config option to enable PJSIP logger at load time

2014-01-21 Thread Russell Bryant
On Jan. 22, 2014, 1:14 a.m., Paul Belanger wrote: branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py, line 1 https://reviewboard.asterisk.org/r/3148/diff/1/?file=53005#file53005line1 You should be creating new alembic scripts not

[asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

2014-01-17 Thread Russell Bryant
to get some more eyes on it. Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

2014-01-17 Thread Russell Bryant
-mail. To reply, visit: https://reviewboard.asterisk.org/r/3135/#review10631 --- On Jan. 17, 2014, 10:18 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 3135: Protect ast_filestream object when on a channel

2014-01-17 Thread Russell Bryant
in production or anything like that. It at least doesn't blow up immediately ... I wanted to get the patch and analysis up to get some more eyes on it. Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread Russell Bryant
. In any case, Fedora has had a systemd unit for Asterisk for quite some time. For reference, you can view it here: http://pkgs.fedoraproject.org/cgit/asterisk.git/tree/asterisk.service - Russell Bryant On Dec. 24, 2013, 4:49 p.m., Tzafrir Cohen wrote

[asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Russell Bryant
) executed *CLI sip reload 4) Repeat step 1, observe outboundproxy no longer set when the patch is applied I also verified that step 4 fails without the patch Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Russell Bryant
with outboundproxy set, observed with 'sip show peer foo' 2) removed outboundproxy from the config 3) executed *CLI sip reload 4) Repeat step 1, observe outboundproxy no longer set when the patch is applied I also verified that step 4 fails without the patch Thanks, Russell Bryant

Re: [asterisk-dev] [svn-commits] murf: branch murf/bug11210 r103686 - /team/murf/bug11210/doc/

2008-02-15 Thread Russell Bryant
think all of this stuff is really great to have. I would also encourage anyone else that comes up with anything more extensive like this for testing to help get it into the tree somewhere. As it starts to pile up, we will start to have a nice set of tests available ... -- Russell Bryant Senior

  1   2   3   >