branches/11/configs/res_fax.conf.sample 430372
Diff: https://reviewboard.asterisk.org/r/4320/diff/
Testing
---
Manual testing and the test in review 4321.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided
,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
-config.yaml
6148
Diff: https://reviewboard.asterisk.org/r/4272/diff/
Testing
---
Verified that the test operated properly when 4271 was applied and failed when
it was not applied.
Thanks,
opticron
--
_
-- Bandwidth
, but otherwise this looks good
to go.
- opticron
On Dec. 30, 2014, 6:15 p.m., jbigelow wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4267
/r/4311/#comment24620
The curly brace should remain on its own line.
- opticron
On Jan. 6, 2015, 3:30 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
Diff: https://reviewboard.asterisk.org/r/4320/diff/
Testing
---
Manual testing and the test in review 4321.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4321/diff/
Testing
---
Verified that the test performed as expected.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api
and the test in review 4321.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
-CREATION
asterisk/trunk/tests/fax/sip/t38_negotiation_timeout/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4321/diff/
Testing
---
Verified that the test performed as expected.
Thanks,
opticron
in question.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Diff: https://reviewboard.asterisk.org/r/4320/diff/
Testing
---
Manual testing and the test in review 4321.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
verification passed and
that the new documentation was visible on the CLI.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
/stasis_bridge/test-config.yaml
6148
Diff: https://reviewboard.asterisk.org/r/4272/diff/
Testing
---
Verified that the test operated properly when 4271 was applied and failed when
it was not applied.
Thanks,
opticron
in question.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
operation.
Diffs (updated)
-
branches/13/res/res_stasis.c 429611
Diff: https://reviewboard.asterisk.org/r/4271/diff/
Testing
---
Ran the test that found this bug and verified that it passed with the expected
events. See review 4272 for the test in question.
Thanks,
opticron
(updated)
-
branches/13/res/res_stasis.c 429611
Diff: https://reviewboard.asterisk.org/r/4271/diff/
Testing
---
Ran the test that found this bug and verified that it passed with the expected
events. See review 4272 for the test in question.
Thanks,
opticron
the remainder of the test.
- opticron
On Dec. 15, 2014, 11:55 p.m., jbigelow wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4267
/
Testing
---
Verified that this allowed the call to operate normally despite the original
reliable connection being torn down where this situation was experienced.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided
of the line.
- opticron
On Dec. 15, 2014, 4:56 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4266
://reviewboard.asterisk.org/r/4265/#comment24486
Might as well drop this since it's duplicated just below your addition.
- opticron
On Dec. 15, 2014, 11:59 a.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply
/stasis_bridge_direct_originate/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4272/diff/
Testing
---
Verified that the test operated properly when 4271 was applied and failed when
it was not applied.
Thanks,
opticron
429611
Diff: https://reviewboard.asterisk.org/r/4271/diff/
Testing
---
Ran the test that found this bug and verified that it passed with the expected
events.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided
/resource_channels.c 429611
branches/13/main/pbx.c 429611
Diff: https://reviewboard.asterisk.org/r/4271/diff/
Testing (updated)
---
Ran the test that found this bug and verified that it passed with the expected
events. See review 4272 for the test in question.
Thanks,
opticron
.
- opticron
On Dec. 15, 2014, 8:09 a.m., wdoekes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4263/
---
(Updated
/res/res_pjsip.c 429431
Diff: https://reviewboard.asterisk.org/r/4264/diff/
Testing
---
Ensured that Asterisk compiled and that the XML schema verification passed and
that the new documentation was visible on the CLI.
Thanks,
opticron
/
Testing
---
Made sure that the message was printed upon reload with a bad object config.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
of the 'inactive' stream direction.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
://reviewboard.asterisk.org/r/4253/diff/
Testing
---
Ensured that the tests functioned as expected.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
://reviewboard.asterisk.org/r/4252/diff/
Testing
---
Ran existing pjsip tests in the testsuite and created new tests for checking
functionality of the 'inactive' stream direction.
Thanks,
opticron
--
_
-- Bandwidth
/pjsip.conf
PRE-CREATION
asterisk/trunk/tests/channels/pjsip/hold_inactive/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4253/diff/
Testing
---
Ensured that the tests functioned as expected.
Thanks,
opticron
good to go.
/branches/12/res/res_pjsip_session.c
https://reviewboard.asterisk.org/r/4254/#comment24472
This comment needs tweaking.
- opticron
On Dec. 11, 2014, 11:01 a.m., Joshua Colp wrote:
---
This is an automatically generated
/sdp_offer_answer/incoming/off-nominal/multiple-media-stream/audio-video/hold-declined/test-config.yaml
https://reviewboard.asterisk.org/r/4255/#comment24473
Will this feature go in before 12.8.0 is released?
- opticron
On Dec. 11, 2014, 11:01 a.m., Joshua Colp wrote
that the tests functioned as expected.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
is significantly different from the
new config.
Diffs
-
branches/12/res/res_sorcery_config.c 429244
Diff: https://reviewboard.asterisk.org/r/4250/diff/
Testing
---
Made sure that the message was printed upon reload with a bad object config.
Thanks,
opticron
test and used wireshark
to verify that the OPTIONS messages were being sent at staggered intervals with
the patch and all at once without the patch.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/#review13932
---
Ship it!
Ship It!
- opticron
On Nov. 14, 2014, 5:03 p.m
that are in-progress along with the
scenarios that originally found these issues.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
/attended_transfer/attended_transfer.py
6018
asterisk/trunk/lib/python/asterisk/ari.py 6018
Diff: https://reviewboard.asterisk.org/r/4226/diff/
Testing
---
Ran the tests and verified they passed with the expected events when the fix in
4213 is applied.
Thanks,
opticron
the patch.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4232/#review13925
---
Ship it!
Ship It!
- opticron
On Dec. 8, 2014, 9:38 a.m
change that disables qualification on the given contact would
remove the scheduler entry and then not start a new one since qualify_frequency
would be 0 (see qualify_and_schedule()).
- opticron
---
This is an automatically generated e-mail
.
/asterisk/trunk/tests/rest_api/channels/connected_line_update/test-config.yaml
https://reviewboard.asterisk.org/r/4232/#comment24411
This minversion seems a bit low.
- opticron
On Dec. 4, 2014, 3:59 p.m., Mark Michelson wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4230/#review13882
---
The alembic scripts should get an update for this.
- opticron
/ari.py 6018
Diff: https://reviewboard.asterisk.org/r/4226/diff/
Testing
---
Ran the tests and verified they passed with the expected events when the fix in
4213 is applied.
Thanks,
opticron
--
_
-- Bandwidth
asterisk/trunk/lib/python/asterisk/ari.py 6018
Diff: https://reviewboard.asterisk.org/r/4226/diff/
Testing
---
Ran the tests and verified they passed with the expected events when the fix in
4213 is applied.
Thanks,
opticron
with:
requests:
method: 'post'
uri: 'channels/{channel.id}/variable'
params:
variable: 'CONNECTEDLINE(all)'
value: 'TEST 1234'
- opticron
On Dec. 4, 2014, 11:07 a.m., Mark Michelson wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4231/#review13888
---
Ship it!
Ship It!
- opticron
On Dec. 4, 2014, 11:07 a.m
in
4213 is applied.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
/attended_transfer.py
6018
asterisk/trunk/lib/python/asterisk/ari.py 6018
Diff: https://reviewboard.asterisk.org/r/4226/diff/
Testing
---
Ran the tests and verified they passed with the expected events when the fix in
4213 is applied.
Thanks,
opticron
://reviewboard.asterisk.org/r/4141/#comment24344
These could use a bit of documentation.
/branches/11/main/loader.c
https://reviewboard.asterisk.org/r/4141/#comment24345
Bump the indentation here.
- opticron
On Nov. 2, 2014, 1:13 a.m., Corey Farrell wrote
sending routines. I'll finish that integration in the
next patch.
- opticron
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4213/#review13859
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4197/#review13864
---
Ship it!
Ship It!
- opticron
On Nov. 19, 2014, 12:15 p.m
ones that are in-progress along with the
scenarios that originally found these issues.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
428504
Diff: https://reviewboard.asterisk.org/r/4213/diff/
Testing
---
Ran existing ARI tests and a few new ones that are in-progress along with the
scenarios that originally found these issues.
Thanks,
opticron
://reviewboard.asterisk.org/r/3603/#comment24287
These should use ast_strdup and should be checked for failure.
- opticron
On Oct. 30, 2014, 7:06 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/res_pjsip_nat.c 428116
Diff: https://reviewboard.asterisk.org/r/4155/diff/
Testing
---
Verified that this allowed the call to operate normally despite the original
reliable connection being torn down where this situation was experienced.
Thanks,
opticron
://reviewboard.asterisk.org/r/4163/diff/
Testing
---
Ran all the REST API tests to verify that they passed.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
://reviewboard.asterisk.org/r/4155/diff/
Testing
---
Verified that this allowed the call to operate normally despite the original
reliable connection being torn down where this situation was experienced.
Thanks,
opticron
branches/12/res/res_stasis.c 427539
branches/12/include/asterisk/stasis_app.h 427539
branches/12/include/asterisk/stasis.h 427539
Diff: https://reviewboard.asterisk.org/r/4163/diff/
Testing
---
Ran all the REST API tests to verify that they passed.
Thanks,
opticron
steal it like a thief.
The uri is allocated on the rdata and not on the dialog, so the clone is
necessary.
- opticron
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4155/#review13717
/4163/diff/
Testing
---
Ran all the REST API tests to verify that they passed.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
the original
reliable connection being torn down where this situation was experienced.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
/stasis_bridges.c
https://reviewboard.asterisk.org/r/4135/#comment24201
Using RAII_VAR here would be appropriate since the 5 applicable return
paths require its cleanup.
- opticron
On Nov. 4, 2014, 3:44 p.m., Mark Michelson wrote
On Oct. 29, 2014, 1:26 p.m., opticron wrote:
/asterisk/trunk/tests/channels/pjsip/optimistic_srtp/optimistic_with_optimistic_offer/sipp/offer.xml,
line 45
https://reviewboard.asterisk.org/r/4099/diff/2/?file=68484#file68484line45
The other three new tests should have this type
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4132/#review13670
---
Ship it!
Ship It!
- opticron
On Oct. 30, 2014, 7:02 p.m
the declarations block.
branches/13/pbx/pbx_config.c
https://reviewboard.asterisk.org/r/4132/#comment24142
escaped_len can be declared in the if block.
- opticron
On Oct. 30, 2014, 12:09 p.m., George Joseph wrote
On Oct. 30, 2014, 1:25 p.m., opticron wrote:
branches/13/main/utils.c, line 494
https://reviewboard.asterisk.org/r/4132/diff/3/?file=68631#file68631line494
This should be instead of = due to the need to write out a null
terminator along with the escaped semicolon
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2964/#review13620
---
Ship it!
Ship It!
- opticron
On Oct. 10, 2014, 8:18 a.m
/optimistic_with_optimistic_offer/sipp/offer.xml
https://reviewboard.asterisk.org/r/4099/#comment24131
The other three new tests should have this type of check in the 200
response as well.
- opticron
On Oct. 21, 2014, 8:49 a.m., Joshua Colp wrote
statements here.
- opticron
On Oct. 21, 2014, 12:50 p.m., greenfieldtech wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4101
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4116/#review13625
---
Ship it!
Ship It!
- opticron
On Oct. 27, 2014, 4:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4120/#review13626
---
Ship it!
Ship It!
- opticron
On Oct. 28, 2014, 2:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4085/#review13592
---
Ship it!
Ship It!
- opticron
On Oct. 16, 2014, 2:06 p.m
On Oct. 15, 2014, 5:38 p.m., George Joseph wrote:
Can you make the change in res_pjsip_phoneprov_provider while you're there?
It was just committed. It'd need CHECK_PJSIP_MODULE_LOADED().
I can take care of that.
- opticron
/4062/diff/
Testing
---
Verified that this fixed the bug presented in ASTERISK-24312.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
://reviewboard.asterisk.org/r/4053/#comment24036
Shouldn't be = instead?
- opticron
On Oct. 8, 2014, 8:55 a.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4053
---
Verified that the patch fixed the reporter's reproduction and verified that the
new unit test passes with the patch and fails without it.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api
/res_pjsip_pubsub.h 424849
branches/12/include/asterisk/res_pjsip.h 424849
branches/12/channels/chan_pjsip.c 424849
Diff: https://reviewboard.asterisk.org/r/4062/diff/
Testing
---
Verified that this fixed the bug presented in ASTERISK-24312.
Thanks,
opticron
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4049/#review13482
---
Ship it!
Ship It!
- opticron
On Oct. 7, 2014, 2:04 p.m
it.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
reproduction and verified that the
new unit test passes with the patch and fails without it.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
os.path.join.
- opticron
On Oct. 1, 2014, 5:29 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4038
://reviewboard.asterisk.org/r/4054/diff/
Testing
---
Verified that the media indexer could be disabled without error messages
showing up incorrectly.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
branches/13/include/asterisk/stasis.h 424425
Diff: https://reviewboard.asterisk.org/r/4054/diff/
Testing
---
Verified that the media indexer could be disabled without error messages
showing up incorrectly.
Thanks,
opticron
/r/4049/#comment23986
I can't seem to find where the reserved session is actually linked into the
faxregistry container. Have you verified that everything is properly balanced
in the ref logs with this patch?
- opticron
On Oct. 5, 2014, 10:10 p.m., Corey Farrell wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4033/#review13460
---
Ship it!
Ship It!
- opticron
On Oct. 2, 2014, 3:33 p.m
Diff: https://reviewboard.asterisk.org/r/4040/diff/
Testing
---
Verified that the missing functionality was restored.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
below.
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists_of_lists/off_nominal/presence/shared_name_wo_list_support/test-config.yaml
https://reviewboard.asterisk.org/r/4020/#comment23968
This is unnecessary for this test.
- opticron
On Sept. 30, 2014, 3:54 p.m., Jonathan Rose
://reviewboard.asterisk.org/r/4033/#comment23976
This appears to be debugging and should go away.
- opticron
On Sept. 30, 2014, 4:24 p.m., George Joseph wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/diff/
Testing
---
Ensured that this patch allowed the BYE to be sent properly.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
options were accepted.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
allowed the BYE to be sent properly.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
/#comment23893
This is unnecessary since there are no symbols that match it.
- opticron
On Sept. 18, 2014, 7:01 p.m., George Joseph wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/shared_name_w_list_support/sipp/list_subscribe.xml
https://reviewboard.asterisk.org/r/4020/#comment23900
Idem.
- opticron
On Sept. 24, 2014, 5:28 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviewboard.asterisk.org/r/2964/#comment23942
pj_create_random_string() does not NULL-terminate the buffer when
generating the string. This should be taken care of manually and space allotted
for the NULL terminator.
- opticron
On Sept. 13, 2014, 5:44 a.m., Joshua Colp wrote
it was sent to the remote
party's TCP port over UDP.
Diffs
-
branches/12/res/res_pjsip_nat.c 424094
Diff: https://reviewboard.asterisk.org/r/4032/diff/
Testing
---
Ensured that this patch allowed the BYE to be sent properly.
Thanks,
opticron
with tls, ws, and others. Is there a
benefit to leaving it blank if the transport is UDP?
- opticron
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4032/#review13400
allowed the BYE to be sent properly.
Thanks,
opticron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
branches/12/configs/pjsip.conf.sample 423656
Diff: https://reviewboard.asterisk.org/r/4019/diff/
Testing
---
Ensured that default values for config options were accepted.
Thanks,
opticron
--
_
-- Bandwidth
1 - 100 of 551 matches
Mail list logo
