works.
* The system can still restart and shutdown.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3135/#review10638
---
Ship it!
Looks good to me.
- rmudgett
On Jan. 17, 2014, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3134/#review10639
---
Ship it!
Ship It!
- rmudgett
On Jan. 20, 2014, 9:47 a.m
---
Since I was not able to reprocuce the INTERNAL_OBJ error reported, I just
tested to see that things still worked.
* The CLI manager show connected still works.
* The system can still restart and shutdown.
Thanks,
rmudgett
timingdata to NULL here is unnecessary since it is set with a new
value right after. It is the purpose of the function.
- rmudgett
On Jan. 17, 2014, 4:18 p.m., Russell Bryant wrote:
---
This is an automatically generated e-mail. To reply
is not complete and is
supurfluous.
- rmudgett
On Jan. 17, 2014, 12:51 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3134
it took 25 seconds.
Tested the core set verbose CLI command tab completion.
Tested that different verbose levels on multiple rasterisk connections got the
expected verbose messages.
Thanks,
rmudgett
--
_
-- Bandwidth
was as expected.
* Checked CEL logs for APP_START/APP_END/LINKEDID_END events after a call.
* Shutdown asterisk with core stop now and core stop gracefully without any
crashes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
was as expected.
* Checked CEL logs for APP_START/APP_END/LINKEDID_END events after a call.
* Shutdown asterisk with core stop now and core stop gracefully without any
crashes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided
,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
the call to
ast_park_call_exten(). That call can take awhile to return because it plays
parking messages.
- rmudgett
On Jan. 8, 2014, 5:41 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviewboard.asterisk.org/r/3107/#comment20052
The transferee channel would get orphaned here since it has already been
masqueraded.
- rmudgett
On Jan. 13, 2014, 3:41 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply
is in the wrong place per guidelines.
Also I know some static checkers can complain of an always true while loop
where they won't if you use for (;;)
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
));
pbx_builtin_serialize_variables(chan, vars);
by dumpchan_exec() should only be made when the sys verbose level is at
least dumpchan's argument, i.e. last hunk of revision 397961 for
app_dumpchan.c should be reverted appropriately.
Fixed.
- rmudgett
25 seconds.
Tested the core set verbose CLI command tab completion.
Tested that different verbose levels on multiple rasterisk connections got the
expected verbose messages.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Just remove the note as the count returned could change due to other thread
activity on the iterated container.
branches/12/include/asterisk/astobj2.h
https://reviewboard.asterisk.org/r/3111/#comment19973
The number of objects in the iterated container.
- rmudgett
On Jan. 8, 2014, 1:31
://reviewboard.asterisk.org/r/3061/diff/
Testing
---
Used the CLI database show along with the new CLI commands and AMI actions to
test adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
--
_
-- Bandwidth
should be renamed to AST_TEST_VALIDATE() to emphasize that it is a macro and
that it does not behave like a real function because it has a return in it.)
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
: https://reviewboard.asterisk.org/r/3089/diff/
Testing
---
No memory leaks from running test execute category /stasis/core/ name
cache_dump.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3098/#review10507
---
Ship it!
Ship It!
- rmudgett
On Jan. 2, 2014, 6:51 p.m
/branches/12/res/ari/resource_bridges.c 404420
Diff: https://reviewboard.asterisk.org/r/3087/diff/
Testing
---
Compiler only.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
/branches/12/include/asterisk/astobj2.h 404437
Diff: https://reviewboard.asterisk.org/r/3089/diff/
Testing
---
No memory leaks from running test execute category /stasis/core/ name
cache_dump.
Thanks,
rmudgett
that the mailbox option works.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
: https://reviewboard.asterisk.org/r/3061/diff/
Testing
---
Used the CLI database show along with the new CLI commands and AMI actions to
test adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
working on the
regex code. The change *only* affects the use of the '^' anchor character.
The anchor character is not a big loss anyway.
I just left it in the second diff because I didn't want to get rid of it right
away.
- rmudgett
MWI, and so this is inaccurate.
The urgent mentions are from copying the API typedef doxygen comments. Those
comments describe what the instantiated API call needs to do.
- rmudgett
---
This is an automatically generated e-mail. To reply
://reviewboard.asterisk.org/r/3061/diff/
Testing
---
Used the CLI database show along with the new CLI commands and AMI actions to
test adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
Diff: https://reviewboard.asterisk.org/r/3061/diff/
Testing
---
Used the CLI database show along with the new CLI commands and AMI actions to
test adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
if chan's alocation fails.
- rmudgett
On Dec. 17, 2013, 11:20 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3067
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3067/#review10451
---
Ship it!
Ship It!
- rmudgett
On Dec. 18, 2013, 5:31 p.m
for an app_voicemail mailbox it will still be added by app_voicemail.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3072/#review10445
that the mailbox option works.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
.
/branches/12/main/channel.c
https://reviewboard.asterisk.org/r/3069/#comment19923
Lock both channels and clear masq/masqr here.
- rmudgett
On Dec. 18, 2013, 8:20 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail
that the mailbox option works.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3069/#review10460
---
Ship it!
Ship It!
- rmudgett
On Dec. 18, 2013, 11:10 p.m
://reviewboard.asterisk.org/r/3079/diff/
Testing
---
It still compiles because nothing used what was deleted. :)
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
/udptl.h 404291
/branches/12/channels/chan_sip.c 404291
/branches/12/addons/chan_ooh323.c 404291
Diff: https://reviewboard.asterisk.org/r/3079/diff/
Testing
---
It still compiles because nothing used what was deleted. :)
Thanks,
rmudgett
On Dec. 16, 2013, 8:26 p.m., rmudgett wrote:
/branches/12/main/channel.c, lines 2687-2704
https://reviewboard.asterisk.org/r/3069/diff/1/?file=49555#file49555line2687
It is probably simpler now to just make ast_hangup() wait for any
masquerade in progress to complete
://reviewboard.asterisk.org/r/3067/#comment19906
Existing bug: chan needs to be locked when adding a datastore.
- rmudgett
On Dec. 17, 2013, 11:20 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3076/#review10443
---
Ship it!
Ship It!
- rmudgett
On Dec. 18, 2013, 12:10 a.m
place.
Maybe do_channel_masquerade() needs to poke both channels to wake up their
respective caretaker threads instead. Those threads could be in the
ast_read/ast_write functions.
- rmudgett
On Dec. 12, 2013, 9:59 p.m., Mark Michelson wrote
://reviewboard.asterisk.org/r/3070/#comment19882
The dummy bridge does not have these allocated.
- rmudgett
On Dec. 16, 2013, 8:47 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/3070/#comment19883
Delete this as it is already set by the struct initializer.
/branches/12/main/bridge.c
https://reviewboard.asterisk.org/r/3070/#comment19884
Stray blank line.
- rmudgett
On Dec. 16, 2013, 8:47 p.m., Jonathan Rose wrote
as the struct
definition to improve memory caching usage.
- rmudgett
On Dec. 16, 2013, 10:39 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3070
to be sure that the new mwi_vm_boxes option parses correctly
and sets up mailboxes.
Tested chan_sip to be sure that the mailbox option works.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api
to the bridges it creates. This could aleviate
some creation identification issues being discussed.
- rmudgett
On Dec. 13, 2013, 9:40 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Dec. 10, 2013, 5:14 p.m., rmudgett wrote:
I don't think changing this default is a good idea. Enabling it is only
useful if you are using the relative channel format. I have yet to see
anyone on the Asterisk users list actually use this format.
Tzafrir Cohen wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3040/#review10389
---
Ship it!
Ship It!
- rmudgett
On Dec. 11, 2013, 10:58 p.m
think v-value could ever be NULL here.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3052/#review10346
---
On Dec. 10
it is only useful
if you are using the relative channel format. I have yet to see anyone on the
Asterisk users list actually use this format.
- rmudgett
On Dec. 10, 2013, 4:25 p.m., Tzafrir Cohen wrote:
---
This is an automatically
messages all assume this format.
Trying to ignore this fact in the external MWI core and external MWI AMI
interface is more limiting.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org
in the UPGRADE.txt file.
- rmudgett
On Dec. 10, 2013, 4:25 p.m., Tzafrir Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3063
commands and AMI actions to
test adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
here.
- rmudgett
On Dec. 4, 2013, 6:11 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3040
/3040/#comment19671
This function may need to clear the other transfer variable if it exists on
the channel since there are two now.
- rmudgett
On Dec. 2, 2013, 9:22 p.m., Jonathan Rose wrote:
---
This is an automatically
(target);
if (!target_snapshot) {
goto pickup_failed;
}
- rmudgett
On Nov. 19, 2013, 11:17 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org
On Sept. 19, 2013, 10:06 p.m., rmudgett wrote:
/branches/1.8/main/lock.c, lines 73-90
https://reviewboard.asterisk.org/r/2826/diff/3/?file=45654#file45654line73
You could reduce the pain of the global lock here by:
if *plt
return *plt
lock global reentrancy lock
On Nov. 25, 2013, 6:54 p.m., rmudgett wrote:
/branches/12/main/core_local.c, lines 682-685
https://reviewboard.asterisk.org/r/2961/diff/4/?file=48509#file48509line682
Revert all the changes you've made to local_call() and reacquire the
locks in publish_local_bridge_message
string.
In this case you could pass a struct pointer that contains two string pointers.
struct device_container_key {
const char *app_name;
const char *device_name;
}
- rmudgett
---
This is an automatically generated e-mail. To reply
801 - 861 of 861 matches
Mail list logo
