Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-03-28 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/ --- (Updated March 28, 2014, 8:44 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/#review11126 --- Ship it! Ship It! - Mark Michelson On Feb. 23, 2014, 6:04

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-22 Thread Matt Jordan
On Feb. 11, 2014, 10:54 a.m., Mark Michelson wrote: /asterisk/trunk/tests/hep/hep_capture_node.py, lines 260-261 https://reviewboard.asterisk.org/r/3206/diff/2/?file=53829#file53829line260 Another place for an enum-style class to be used. Actually, this one isn't an enum. The HEPv3

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/ --- (Updated Feb. 23, 2014, 12:04 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-13 Thread Matt Jordan
On Feb. 11, 2014, 10:54 a.m., Mark Michelson wrote: I think it's worth it to create an IPv6 test in addition to the IPv4 test you've created here. In retrospect, I should have something that sends an authkey as well. I'll add both. - Matt

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/#review10852 --- I think it's worth it to create an IPv6 test in addition to

[asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/ --- Review request for Asterisk Developers and Lorenzo Miniero. Repository:

Re: [asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

2014-02-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3206/ --- (Updated Feb. 10, 2014, 10:15 p.m.) Review request for Asterisk