Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/ --- (Updated March 12, 2014, 1:35 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/#review11147 --- Ship it! Ship It! - Matt Jordan On March 6, 2014, 5:59

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-06 Thread Matt Jordan
On March 5, 2014, 7:34 p.m., Matt Jordan wrote: So this completely solves the problem in the report, and we may decide this is sufficient. In general, however, this problem happens a lot - someone starts MoH on a channel, hangs it up, does something else with it... and we don't

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/ --- (Updated March 6, 2014, 5:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/#review11127 --- I have already taken care of the two red blobs next to lines I

[asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23311

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3306/#review11081 --- So this completely solves the problem in the report, and we

Re: [asterisk-dev] [Code Review] 3306: app_confbridge: Make explicitly stop MOH if a user is kicked or hangs up while MOH is playing.

2014-03-05 Thread rmudgett
On March 5, 2014, 7:34 p.m., Matt Jordan wrote: So this completely solves the problem in the report, and we may decide this is sufficient. In general, however, this problem happens a lot - someone starts MoH on a channel, hangs it up, does something else with it... and we don't