Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/ --- (Updated May 16, 2014, 7:24 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-13 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/#review11885 --- Ship it! One minor issue, so going to go ahead and ship.

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-10 Thread Joshua Colp
On May 8, 2014, 5:37 p.m., Matt Jordan wrote: /team/group/media_formats-reviewed/channels/chan_mgcp.c, line 2600 https://reviewboard.asterisk.org/r/3388/diff/2/?file=58249#file58249line2600 I'd declare these on separate lines. Just a thought. Done. On May 8, 2014, 5:37 p.m.,

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/ --- (Updated May 10, 2014, 7:27 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/#review11853 --- /team/group/media_formats-reviewed/channels/chan_mgcp.c

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-08 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/#review11855 --- /team/group/media_formats-reviewed/channels/chan_mgcp.c

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-08 Thread Kevin Harwell
On May 8, 2014, 1:22 p.m., Kevin Harwell wrote: /team/group/media_formats-reviewed/channels/chan_skinny.c, lines 4846-4847 https://reviewboard.asterisk.org/r/3388/diff/2/?file=58250#file58250line4846 bugbug. oops, looks like Matt already mentioned this one. Just drop. - Kevin

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/ --- (Updated May 5, 2014, 11:11 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-03-27 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/#review11400 --- /team/group/media_formats-reviewed/channels/chan_mgcp.c

[asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-03-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/ --- Review request for Asterisk Developers. Repository: Asterisk