---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
(Updated April 17, 2014, 9:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11632
---
Ship it!
The tests that have been written should also include
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11606
---
/branches/12/main/app.c
On April 15, 2014, 10:21 a.m., Joshua Colp wrote:
/branches/12/main/app.c, line 1128
https://reviewboard.asterisk.org/r/3427/diff/3/?file=57210#file57210line1128
This doesn't allow the tone zone to be specified by the user,
restricting us to US only. This needs to be made
On April 15, 2014, 10:21 a.m., Joshua Colp wrote:
/branches/12/main/app.c, line 1128
https://reviewboard.asterisk.org/r/3427/diff/3/?file=57210#file57210line1128
This doesn't allow the tone zone to be specified by the user,
restricting us to US only. This needs to be made
On April 15, 2014, 10:21 a.m., Joshua Colp wrote:
/branches/12/main/app.c, line 1128
https://reviewboard.asterisk.org/r/3427/diff/3/?file=57210#file57210line1128
This doesn't allow the tone zone to be specified by the user,
restricting us to US only. This needs to be made
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
(Updated April 15, 2014, 4:14 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
(Updated April 15, 2014, 5:25 p.m.)
Review request for Asterisk
On April 9, 2014, 4:31 p.m., David Lee wrote:
/trunk/CHANGES, line 125
https://reviewboard.asterisk.org/r/3427/diff/2/?file=57139#file57139line125
How hard would it be to add something like ?timeMillis= to the URI for
tones? Or are tones usually something like busy, where you
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11545
---
Hrm - I'm not sure I like it being tones. When talking about
On April 9, 2014, 11:31 a.m., David Lee wrote:
/trunk/CHANGES, line 125
https://reviewboard.asterisk.org/r/3427/diff/2/?file=57139#file57139line125
How hard would it be to add something like ?timeMillis= to the URI for
tones? Or are tones usually something like busy, where you
On April 10, 2014, 9:19 a.m., Joshua Colp wrote:
Hrm - I'm not sure I like it being tones. When talking about these you
don't refer to them as plural. Busy tone for an example. Thoughts?
tone works for me.
- Matt
---
This is an
On April 9, 2014, 11:31 a.m., David Lee wrote:
/trunk/CHANGES, line 125
https://reviewboard.asterisk.org/r/3427/diff/2/?file=57139#file57139line125
How hard would it be to add something like ?timeMillis= to the URI for
tones? Or are tones usually something like busy, where you
On April 10, 2014, 9:19 a.m., Joshua Colp wrote:
Hrm - I'm not sure I like it being tones. When talking about these you
don't refer to them as plural. Busy tone for an example. Thoughts?
Matt Jordan wrote:
tone works for me.
tone will be fine. I just went by the description on the
On April 9, 2014, 4:20 p.m., Matt Jordan wrote:
/trunk/main/app.c, lines 1056-1060
https://reviewboard.asterisk.org/r/3427/diff/2/?file=57141#file57141line1056
This would be an appropriate place for a ternary operator:
ast_playtones_start(chan, 0, ts ? ts-data : tone,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
(Updated April 10, 2014, 3:55 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11529
---
/trunk/CHANGES
On April 9, 2014, 11:31 a.m., David Lee wrote:
/trunk/CHANGES, line 125
https://reviewboard.asterisk.org/r/3427/diff/2/?file=57139#file57139line125
How hard would it be to add something like ?timeMillis= to the URI for
tones? Or are tones usually something like busy, where you
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11534
---
/trunk/CHANGES
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
Review request for Asterisk Developers, David Lee, Joshua Colp, and Matt
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/
---
(Updated April 8, 2014, 5:46 p.m.)
Review request for Asterisk
21 matches
Mail list logo
