Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-28 Thread Vitezslav Novy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/ --- (Updated April 28, 2014, 3:26 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/#review11750 --- While I appreciate the contribution to Asterisk and the

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-23 Thread Vitezslav Novy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/ --- (Updated April 23, 2014, 2:02 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-22 Thread Vitezslav Novy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23636

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-22 Thread Olle E. Johansson
Please explain what the benefit of this over the existing methods are. I would prefer using musiconhold.conf and have a mode that you list files in by just adding them to a [section]. That way, you could just include the playlists in musiconhold.conf without changing or ignoring. The different

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-22 Thread Olle E. Johansson
On 22 Apr 2014, at 16:41, Vitezslav Novy vn...@vnovy.net wrote: On 04/22/14 16:07, Olle E. Johansson wrote: Please explain what the benefit of this over the existing methods are. 1/ It allows create/delete/modify MoH classes on fly without module reload and without realtime feature. Why

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-22 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/#review11720 --- /trunk/CHANGES