Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3519/ --- (Updated May 7, 2014, 5:22 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-06 Thread Kevin Harwell
On May 1, 2014, 1:51 p.m., Kevin Harwell wrote: /team/group/media_formats-reviewed/main/format_compatibility.c, lines 308-317 https://reviewboard.asterisk.org/r/3519/diff/1/?file=58205#file58205line308 It looks possible that this could return NULL. Looking through some of the

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3519/#review11829 --- Ship it! Ship It! - Kevin Harwell On May 5, 2014, 8:33

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3519/ --- (Updated May 5, 2014, 1:33 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-05 Thread Joshua Colp
On May 1, 2014, 6:51 p.m., Kevin Harwell wrote: /team/group/media_formats-reviewed/channels/chan_h323.c, lines 1049-1050 https://reviewboard.asterisk.org/r/3519/diff/1/?file=58191#file58191line1049 If no longer needed then delete, or did you mean to come back to this? BUGBUGs