Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated June 6, 2014, 9:08 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/#review12067 --- Also the utils directory svn:ignore property needs to be

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated June 5, 2014, 4:38 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread George Joseph
On June 5, 2014, 4:02 p.m., rmudgett wrote: Also the utils directory svn:ignore property needs to be updated to include the new astobj2 files. Done. - George --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/#review12070 --- branches/12/main/astobj2_container.c

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated June 5, 2014, 5:43 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-05 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/#review12072 --- branches/12/main/astobj2.c

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-04 Thread rmudgett
On June 4, 2014, 4:47 p.m., rmudgett wrote: This split is what I had in mind except for the unnecessary pushing of ao2 primitive private declarations into astobj2_private.h. - rmudgett --- This is an automatically generated e-mail.

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated June 4, 2014, 7:33 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-06-04 Thread George Joseph
On June 4, 2014, 3:47 p.m., rmudgett wrote: branches/12/tests/test_astobj2.c, lines 2002-2003 https://reviewboard.asterisk.org/r/3576/diff/2/?file=59061#file59061line2002 Compiler error: ast_tvdiff_ms(ast_tvnow(), start) does not match the format string. ast_tvdiff_ms() returns

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/#review12014 --- branches/12/main/astobj2_private.h

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-30 Thread George Joseph
On May 30, 2014, 2:38 p.m., rmudgett wrote: branches/12/main/astobj2_private.h, lines 156-159 https://reviewboard.asterisk.org/r/3576/diff/1/?file=59035#file59035line156 There is too much in this file that should not be here. 1) Almost everything from this enum

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-30 Thread rmudgett
On May 30, 2014, 3:38 p.m., rmudgett wrote: branches/12/main/astobj2_private.h, lines 156-159 https://reviewboard.asterisk.org/r/3576/diff/1/?file=59035#file59035line156 There is too much in this file that should not be here. 1) Almost everything from this enum

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated May 30, 2014, 11:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- (Updated May 30, 2014, 11:54 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

2014-05-29 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk